You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by knusbaum <gi...@git.apache.org> on 2016/01/05 19:23:52 UTC
[GitHub] storm pull request: STORM-1432: Spurious failure in storm-kafka te...
GitHub user knusbaum opened a pull request:
https://github.com/apache/storm/pull/990
STORM-1432: Spurious failure in storm-kafka test
ExponentialBackoffMsgRetryManagerTest.testMaxBackoff() fails sometimes, I think due to too small times. It can miss the mark on slow machines.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/knusbaum/incubator-storm STORM-1432
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/990.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #990
----
commit 6712e8d7e4cf48e045eb0d46187291296d99a1f2
Author: Kyle Nusbaum <ky...@gmail.com>
Date: 2016-01-05T18:22:23Z
Fixing STORM-1432
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-1432: Spurious failure in storm-kafka te...
Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/990#issuecomment-169091553
I'm not sure that this fixed it.
```Tests run: 11, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 1.696 sec <<< FAILURE! - in storm.kafka.ExponentialBackoffMsgRetryManagerTest
testSingleDelay(storm.kafka.ExponentialBackoffMsgRetryManagerTest) Time elapsed: 0.001 sec <<< FAILURE!
java.lang.AssertionError: expect no message ready for retry yet expected null, but was:<101>
at org.junit.Assert.fail(Assert.java:88)
at org.junit.Assert.failNotNull(Assert.java:664)
at org.junit.Assert.assertNull(Assert.java:646)
at storm.kafka.ExponentialBackoffMsgRetryManagerTest.testSingleDelay(ExponentialBackoffMsgRetryManagerTest.java:57)
```
From the travis CI JDK8 build.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-1432: Spurious failure in storm-kafka te...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/990
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-1432: Spurious failure in storm-kafka te...
Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/990#issuecomment-170585765
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-1432: Spurious failure in storm-kafka te...
Posted by knusbaum <gi...@git.apache.org>.
Github user knusbaum commented on the pull request:
https://github.com/apache/storm/pull/990#issuecomment-169098913
That looks like a different test entirely that has the same problem. I'll try to fix that one as well.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-1432: Spurious failure in storm-kafka te...
Posted by knusbaum <gi...@git.apache.org>.
Github user knusbaum commented on the pull request:
https://github.com/apache/storm/pull/990#issuecomment-169098388
@revans2 I'll keep testing.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---