You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by vgmartinez <gi...@git.apache.org> on 2015/10/23 14:58:24 UTC
[GitHub] incubator-zeppelin pull request: JDBC generic interpreter
GitHub user vgmartinez opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/361
JDBC generic interpreter
Only you need to add to the classpath the jdbc connector jar and the interpreter add the particular properties for each db.
In the file zeppelin-daemon.sh add:
ZEPPELIN_CLASSPATH+=":${ZEPPELIN_HOME}/jdbc/jdbc/connector jar"
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/vgmartinez/incubator-zeppelin jdbc_interpreter
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-zeppelin/pull/361.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #361
----
commit 53d0a81389a4d917b2c790e66718a689bb2e8bc8
Author: Victor <vi...@gmail.com>
Date: 2015-10-23T12:37:48Z
generic interpreter for jdbc
commit 4f28f5a9f4fe2840d824f47d42f6bc07bbc17026
Author: Victor <vi...@gmail.com>
Date: 2015-10-23T12:40:52Z
change psql to jdbc
commit 710699cf04c7fac916dbda98d2babe62a8ffa919
Author: Victor <vi...@gmail.com>
Date: 2015-10-23T12:41:53Z
deleted cassandra/.cache-main from commit
commit a66a5b798d3948db7b456b7693e8002c3be2a636
Author: Victor <vi...@gmail.com>
Date: 2015-10-23T12:46:28Z
add descriptions
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: JDBC generic interpreter
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/361#issuecomment-160284341
@jiekechoo This interpreter is based on jdbc connecttion, and this PR makes PostgreSqlInterpreter change JdbcInterpreter only. Thus you can use PostgrsSqlInterpreter to use Jdbc. @vgmartinez Could you please add docs for this interpreter? If you don't, I'll merge it first add docs later.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: JDBC generic interpreter
Posted by vgmartinez <gi...@git.apache.org>.
GitHub user vgmartinez reopened a pull request:
https://github.com/apache/incubator-zeppelin/pull/361
JDBC generic interpreter
Only you need to add to the classpath the jdbc connector jar and the interpreter add the particular properties for each db.
In the file zeppelin-daemon.sh add:
ZEPPELIN_CLASSPATH+=":${ZEPPELIN_HOME}/jdbc/jdbc/connector jar"
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/vgmartinez/incubator-zeppelin jdbc_interpreter
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-zeppelin/pull/361.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #361
----
commit 53d0a81389a4d917b2c790e66718a689bb2e8bc8
Author: Victor <vi...@gmail.com>
Date: 2015-10-23T12:37:48Z
generic interpreter for jdbc
commit 4f28f5a9f4fe2840d824f47d42f6bc07bbc17026
Author: Victor <vi...@gmail.com>
Date: 2015-10-23T12:40:52Z
change psql to jdbc
commit 710699cf04c7fac916dbda98d2babe62a8ffa919
Author: Victor <vi...@gmail.com>
Date: 2015-10-23T12:41:53Z
deleted cassandra/.cache-main from commit
commit a66a5b798d3948db7b456b7693e8002c3be2a636
Author: Victor <vi...@gmail.com>
Date: 2015-10-23T12:46:28Z
add descriptions
commit 462c3b1a55e285e8058de0a6e2ef42c4f647897c
Author: Victor <vi...@gmail.com>
Date: 2015-10-23T20:05:47Z
Merge branch 'master' of https://github.com/apache/incubator-zeppelin into jdbc_interpreter
commit 09006f1a5f34744a2a08d8edeced2628371c3b98
Author: Victor <vi...@gmail.com>
Date: 2015-10-23T23:21:36Z
fix test
commit 52cdbacf207bceb5d66b18c1e5452608881906cf
Author: Ryu Ah young <fb...@hanmail.net>
Date: 2015-10-24T11:46:31Z
ZEPPELIN-334 Add documentation for Apache Lens Interpreter
[ZEPPELIN-334](https://issues.apache.org/jira/browse/ZEPPELIN-334?jql=project%20%3D%20ZEPPELIN%20AND%20text%20~%20%22lens%22) Add documentation for Apache Lens Interpreter
Since the last PR that I opened few days ago has some problems, so I create new one.
I read all comments in the last one and edited below files.
Author: Ryu Ah young <fb...@hanmail.net>
Closes #360 from AhyoungRyu/ZEPPELIN-334-Add-documentation-for-Apache-Lens-Interpreter and squashes the following commits:
9099e6d [Ryu Ah young] modify the typo and add description
11feb1d [Ryu Ah young] ZEPPELIN-334 Add documentation for Apache Lens Interpreter
commit 28a42ff68c42526f156194f3367729eac7ff4519
Author: Lee moon soo <mo...@apache.org>
Date: 2015-10-25T05:46:57Z
ZEPPELIN-359 add NOTICE and DISCLAIMER in the binary package
NOTICE and DISCLAIMER is missing in the binary package.
https://issues.apache.org/jira/browse/ZEPPELIN-359
Author: Lee moon soo <mo...@apache.org>
Closes #363 from Leemoonsoo/ZEPPELIN-359 and squashes the following commits:
ce8aa70 [Lee moon soo] ZEPPELIN-359 add NOTICE and DISCLAIMER in the binary package
commit 11233168fc08322baf8e1032153f370ed272431c
Author: Lee moon soo <mo...@apache.org>
Date: 2015-10-25T05:59:17Z
ZEPPELIN-360 Remove "Copyright 2014, NFLabs inc." from LICENSE
This PR addresses https://issues.apache.org/jira/browse/ZEPPELIN-360
Removing "Copyright 2014, NFLabs inc." from LICENSE.
Author: Lee moon soo <mo...@apache.org>
Closes #364 from Leemoonsoo/ZEPPELIN-360 and squashes the following commits:
cfb814b [Lee moon soo] Remove "Copyright (c) 2010-2015 NFLabs Inc." from NOTICE
fb75e86 [Lee moon soo] ZEPPELIN-360 Remove "Copyright 2014, NFLabs inc." from LICENSE
commit 0b132133ab946b202634a08f484b4689380e8beb
Author: Lee moon soo <mo...@apache.org>
Date: 2015-10-25T06:38:17Z
ZEPPELIN-362 Add maven-remote-resources-plugin plugin
https://issues.apache.org/jira/browse/ZEPPELIN-362
Add maven-remote-resources-plugin to add LICENSE, NOTICE and DISCLAIMER to jar and war artifacts.
Author: Lee moon soo <mo...@apache.org>
Closes #366 from Leemoonsoo/ZEPPELIN-362 and squashes the following commits:
17076fa [Lee moon soo] Add maven-remote-resources-plugin plugin
commit f140c0955be4f0d2978ebb0a93b322ccb99adb4d
Author: Lee moon soo <mo...@apache.org>
Date: 2015-10-25T06:04:52Z
ZEPPELIN-361 Move licese of subcomponents from NOTICE to LICENSE
Move license of subcomponents from NOTICE to LICENSE
https://issues.apache.org/jira/browse/ZEPPELIN-361
Author: Lee moon soo <mo...@apache.org>
This patch had conflicts when merged, resolved by
Committer: Lee moon soo <mo...@apache.org>
Closes #365 from Leemoonsoo/ZEPPELIN-361 and squashes the following commits:
f8ebe84 [Lee moon soo] ZEPPELIN-361 Move licese of subcompoenents from NOTICE to LICENSE
commit fff175f92559afc58280eaeaa94c225e82830f90
Author: Lee moon soo <mo...@apache.org>
Date: 2015-10-27T12:22:48Z
ZEPPELIN-366 Create a single binary package with default build flags.
This PR addresses https://issues.apache.org/jira/browse/ZEPPELIN-366
This patch creates single binary package instead of multiple binary package with different version of Spark / Hadoop combinations.
Also it's removing redundant directory structure from it's tar archive.
Author: Lee moon soo <mo...@apache.org>
Closes #373 from Leemoonsoo/ZEPPELIN-366 and squashes the following commits:
366bbf4 [Lee moon soo] Create a single binary package with default build flags. Remove redundant directory structure in binary package.
commit 86a1a199453b3c347e2b4e731463fea1bc5940bd
Author: Felix Cheung <fe...@hotmail.com>
Date: 2015-10-26T00:01:18Z
[ZEPPELIN-357] Add support for a configurable list of repo for dependencies
Make it configurable via `zeppelin.dep.additionalRemoteRepository`, with spark-packages default. This enables notebook to load dependencies with having to add spark-packages each time.
There is a fair bit of overlap between `DependencyResolver` and `DependencyContext`, but it appears in order for any custom repo available it needs to be in both components. We should discuss how best to address overlaps between the two components.
corneadoug
Leemoonsoo
Author: Felix Cheung <fe...@hotmail.com>
Closes #368 from felixcheung/sparkpackage and squashes the following commits:
207ffb8 [Felix Cheung] Update test - spark-csv is actually on maven central.
dfdb07b [Felix Cheung] add test
eab697b [Felix Cheung] Make custom remote repo configurable
commit ac5ff10b677f757afd0aa0272246ed1cf1de8e2c
Author: Lee moon soo <mo...@apache.org>
Date: 2015-10-30T08:27:31Z
ZEPPELIN-375 HOTFIX move geode from default build to profile
Hot fix for https://issues.apache.org/jira/browse/ZEPPELIN-375, until we get better resolution.
This patch moves geode from default build to profile.
Author: Lee moon soo <mo...@apache.org>
Closes #379 from Leemoonsoo/ZEPPELIN-375-hotfix and squashes the following commits:
7740296 [Lee moon soo] Hotfix for ZEPPELIN-375
commit 0a82a93ce495cf537b28104a024a8c0361fd80ac
Author: Lee moon soo <mo...@apache.org>
Date: 2015-11-02T04:46:02Z
ZEPPELIN-377 CI hanging on ./testing/startSparkCluster.sh 1.4.0 2.3
Address https://issues.apache.org/jira/browse/ZEPPELIN-377.
This patch change spark package download location from apache archive to mirror, to download in 10min.
Also add missing test for 1.5.1 and change test version from 1.4.0 to 1.4.1
Author: Lee moon soo <mo...@apache.org>
Closes #380 from Leemoonsoo/fix_spark_test and squashes the following commits:
142583a [Lee moon soo] Add test for 1.5.1
b8323e6 [Lee moon soo] Use mirror for 1.3.x and later version of spark
commit b7c76f80d4d716f751820947b2271e2b8b5e8e08
Author: Ryu Ah young <fb...@hanmail.net>
Date: 2015-10-30T07:09:12Z
ZEPPELIN-376 http://zeppelin.incubator.apache.org/docs/dynamicform.html points to null link
I found the right place of dynamicform.html : )
Author: Ryu Ah young <fb...@hanmail.net>
Closes #378 from AhyoungRyu/ZEPPELIN-376-dynamicform.html-points-to-null-link and squashes the following commits:
f44d46a [Ryu Ah young] fix http://zeppelin.incubator.apache.org/docs/display.html link
0b79294 [Ryu Ah young] ZEPPELIN-376 http://zeppelin.incubator.apache.org/docs/dynamicform.html points to null link
commit 600f728d26b91632701740bdb98bbc53377bc971
Author: Tomas <xh...@gmail.com>
Date: 2015-10-31T12:26:27Z
added autocompletion
auto-completion shortcut was missing
Author: Tomas <xh...@gmail.com>
Closes #382 from xhudik/patch-3 and squashes the following commits:
ed3ee01 [Tomas] added autocompletion
commit fb5d21719297e27fc8f033534259c016b4217210
Author: Michael Chen <mi...@gmail.com>
Date: 2015-11-03T19:51:06Z
ZEPPELIN-389: Longer Paragraph Title will wrap to new line and interfere with code below
This PR relates to: https://issues.apache.org/jira/browse/ZEPPELIN-389 fixing a bug with paragraph titles longer than 1 line.
Current long paragraph title:
<img width="1258" alt="screen shot 2015-11-03 at 12 16 26 pm" src="https://cloud.githubusercontent.com/assets/6380209/10919812/6e5b919a-8232-11e5-9963-8e7847b8bd67.png">
After the pull request:
<img width="1247" alt="screen shot 2015-11-03 at 1 15 35 pm" src="https://cloud.githubusercontent.com/assets/6380209/10919819/7a4053f6-8232-11e5-878a-0a423c042520.png">
Author: Michael Chen <mi...@gmail.com>
Closes #388 from MikeTYChen/ZEPPELIN-389 and squashes the following commits:
d4daad0 [Michael Chen] ZEPPELIN-389: longer paragraph title
commit 2d893abafad4ab6309e532b1134435c1991b0659
Author: Lee moon soo <mo...@apache.org>
Date: 2015-11-03T18:21:16Z
ZEPPELIN-386 provide links to individual bin/src artifact as well as signatures and KEYS
This PR addresses https://issues.apache.org/jira/browse/ZEPPELIN-386, by provide links to individual bin/src artifact as well as signatures and KEYS
Current download page
After applying this PR
Author: Lee moon soo <mo...@apache.org>
Closes #387 from Leemoonsoo/ZEPPELIN-386 and squashes the following commits:
8dc6581 [Lee moon soo] ZEPPELIN-386 provide link to individual bin/src package as well as signatures and KEYS
commit dfbc0e690c1dfdb6533207a98ef814ec79bff01e
Author: Lee moon soo <mo...@apache.org>
Date: 2015-11-06T04:16:51Z
ZEPPELIN-396 Add -Pypspark profile for release binary
https://issues.apache.org/jira/browse/ZEPPELIN-396
Add -Ppyspark to enable pyspark in default configuration (without SPARK_HOME specified).
Author: Lee moon soo <mo...@apache.org>
Closes #396 from Leemoonsoo/ZEPPELIN-396 and squashes the following commits:
4e599af [Lee moon soo] Add -Pypspark profile for release binary
commit a4db1688c9ce0a172722e289171e82099a43b55d
Author: Lee moon soo <mo...@apache.org>
Date: 2015-11-06T04:57:13Z
ZEPPELIN-397 Activate spark-1.5 and hadoop-2.4 by default in release script
https://issues.apache.org/jira/browse/ZEPPELIN-397
Activate spark-1.5 and hadoop-2.4 by default
That'll enable use sc.textFile("s3...") with default configuration without specify SPARK_HOME.
Author: Lee moon soo <mo...@apache.org>
This patch had conflicts when merged, resolved by
Committer: Lee moon soo <mo...@apache.org>
Closes #397 from Leemoonsoo/ZEPPELIN-397 and squashes the following commits:
9855dde [Lee moon soo] Activate spark-1.5 and hadoop-2.4 by default
commit e3e61832bcaa3fcce5b1096a20180631c2a8d6e8
Author: Ryu Ah young <fb...@hanmail.net>
Date: 2015-10-26T01:31:32Z
ZEPPELIN-338 Add documentation for Ignite Interpreter
[ZEPPELIN-338](https://issues.apache.org/jira/browse/ZEPPELIN-338?jql=project%20%3D%20ZEPPELIN%20AND%20text%20~%20%22ignite%22) Add documentation for Ignite Interpreter
Since the last PR that I opened few days ago has some problems, so I create new one.
I read all comments in the last one and edited below files.
Author: Ryu Ah young <fb...@hanmail.net>
This patch had conflicts when merged, resolved by
Committer: Lee moon soo <mo...@apache.org>
Closes #359 from AhyoungRyu/ZEPPELIN-338-Add-documentation-for-Ignite-Interpreter and squashes the following commits:
6ae854d [Ryu Ah young] edit 'next' to 'binary'
3e0509d [Ryu Ah young] edit next to future
1acf2ee [Ryu Ah young] add explanation about Zeppelin binary release to check ignite version
814d8fa [Ryu Ah young] add explanation about Zeppelin binary release to check ignite version
8689915 [Ryu Ah young] ZEPPELIN-338 Add documentation for Ignite Interpreter
commit 27b7ad52b6bf8f18643e8b58d16fcab3d709eb1c
Author: eranwitkon <go...@gmail.com>
Date: 2015-11-04T13:09:06Z
[Zeppelin-354] - List notebooks REST API
replacing PR #367
This is the implementation, test and documentation of List notebooks REST API.
The documentation include sample JSON with different looknfeel option and coron options.
This is ready for review.
Author: eranwitkon <go...@gmail.com>
Closes #369 from eranwitkon/354 and squashes the following commits:
5472620 [eranwitkon] update getNotebook list documentation
b2dad81 [eranwitkon] revert to original implementation as getNotebookList does not need the exclusionStrategy anymore
0eff22e [eranwitkon] update getList test
c2f1c5f [eranwitkon] update getNotebookList to use NotebookServer.generateNotebookInfo function
d0b6744 [eranwitkon] refactor broadcastNoteList to use a new public generateNotebookList function which will be used in both socket implementation and REST implementation.
1e3d98c [eranwitkon] List Notebook REST API implementation, Test & documentation
ee53446 [eranwitkon] List Notebook REST API implementation, Test & documentation
commit 618bcd8785cdde83d5212569be6e54aabb2d6f14
Author: Prabhjyot Singh <pr...@gmail.com>
Date: 2015-11-03T09:01:39Z
ZEPPELIN-372 : Exporting a notebook
Exporting a notebook in a JSON format, which can later be used/imported in a different environment.
<img width="203" alt="screen shot 2015-10-29 at 12 29 41 pm" src="https://cloud.githubusercontent.com/assets/674497/10812117/d6611b82-7e38-11e5-9074-d14eebf19e72.png">
Author: Prabhjyot Singh <pr...@gmail.com>
Closes #376 from prabhjyotsingh/ZEPPELIN-372 and squashes the following commits:
462e733 [Prabhjyot Singh] ZEPPELIN-372 : Exporting a notebook in a JSON format, which can later be used/imported in a different environment.
commit e45cf399596be7e30d8bb42a45e700c6898a3f1b
Author: Luciano Resende <lr...@apache.org>
Date: 2015-11-05T19:52:58Z
Correct contact e-mail in documentation config.yml
Author: Luciano Resende <lr...@apache.org>
Closes #393 from lresende/website and squashes the following commits:
c167239 [Luciano Resende] Correct contact e-mail in documentation config.yml
commit fd2a28853ec83da975fdffba6f2a5ca198126d4d
Author: Patrick Ethier <nu...@gmail.com>
Date: 2015-11-04T19:15:33Z
ZEPPELIN-365: Add credentials for dependency loader
Allow to authenticate to Artifactory or any other private maven repository using user/pass via the dependency loader
Author: Patrick Ethier <nu...@gmail.com>
Author: Patrick Ethier <pa...@secureops.com>
Author: nuttybrewer <nu...@gmail.com>
Closes #377 from nuttybrewer/master and squashes the following commits:
9745f24 [Patrick Ethier] Update Repository.java
8599240 [Patrick Ethier] Update Repository.java
70de3ec [Patrick Ethier] Update Repository.java
3e395bf [Patrick Ethier] Move to fluent API
6c858e8 [Patrick Ethier] Merge branch 'master' of github.com:apache/incubator-zeppelin
3dcfc1f [Patrick Ethier] Update Repository.java
361291a [Patrick Ethier] Update Repository.java
656266a [Patrick Ethier] Update Repository.java
1169f80 [Patrick Ethier] Update spark.md
5b8f357 [Patrick Ethier] Update Repository.java
10c342b [Patrick Ethier] Update DependencyContext.java
57ab930 [Patrick Ethier] Update Repository.java
2b98165 [Patrick Ethier] Update DependencyContext.java
b93057d [nuttybrewer] remove return statement for coding style
0c9395c [Patrick Ethier] Merge branch 'master' of github.com:nuttybrewer/incubator-zeppelin
e7ece92 [Patrick Ethier] Added addCredential() function to allow for authenticated repositories via dependency loader
0936e89 [Patrick Ethier] Added documentation for new addCredential() function
commit ae08e713e43ce9ebfb11f0f9cf7a7ea42885d677
Author: Khalid Huseynov <kh...@nflabs.com>
Date: 2015-10-28T11:40:16Z
ZEPPELIN-367 Sync with secondary storage when listing notebooks
This PR resolves https://issues.apache.org/jira/browse/ZEPPELIN-367 by synchronizing with secondary storage when reloading all notebooks into memory. Currently, existing `ZEPPELIN_NOTEBOOK_RELOAD_FROM_STORAGE` from https://github.com/apache/incubator-zeppelin/pull/331 is used as a flag since these functionalities are correlated, however it can be separated into distinct flag as well.
Author: Khalid Huseynov <kh...@nflabs.com>
Closes #375 from khalidhuseynov/sync-on-list and squashes the following commits:
e2cf5d9 [Khalid Huseynov] minor fix
878a23e [Khalid Huseynov] initial working commit
commit cd0010d69be4e58ca5c92d984e61729ebde63174
Author: Tomas <xh...@gmail.com>
Date: 2015-11-05T11:56:32Z
added hint to errror message
%dep interpreter gives meaningless(for newbies) error message if it is not executed as the first snippet. Whit this hint it should be clear what to do to get rid of the problem
Author: Tomas <xh...@gmail.com>
Closes #383 from xhudik/patch-4 and squashes the following commits:
8ce0f8f [Tomas] paragraph instead of cell
aa16656 [Tomas] added Interpreter restart option
674cb66 [Tomas] cell instead of snippet
9c3af9f [Tomas] formatting
c8c5649 [Tomas] added hint to errror message
commit 8b7556df11c732029d694bbd492b0d30865d3b0c
Author: DuyHai DOAN <do...@gmail.com>
Date: 2015-11-02T11:57:29Z
[ZEPPELIN-382] Add Documentation for Cassandra interpreter in the doc…
Linked **[JIRA]**
[JIRA]: https://issues.apache.org/jira/browse/ZEPPELIN-382?jql=project%20%3D%20ZEPPELIN
Author: DuyHai DOAN <do...@gmail.com>
Closes #384 from doanduyhai/CassandraInterpreterDocumentation and squashes the following commits:
b0bf36a [DuyHai DOAN] [ZEPPELIN-382] Add Documentation for Cassandra interpreter in the doc pages
commit 785ee3c8b46225da75698458acc5b730e8ead542
Author: Lee moon soo <mo...@apache.org>
Date: 2015-11-08T01:03:34Z
ZEPPELIN-404 Certain project dependencies are pulled from 3rd parties repos instead of ASF or public Maven
https://issues.apache.org/jira/browse/ZEPPELIN-404
This PR removes / move 3rd party repository into profile.
cloudera repo is disabled by default and can be activated by -Pvendor-repo
Author: Lee moon soo <mo...@apache.org>
Closes #404 from Leemoonsoo/ZEPPELIN-404 and squashes the following commits:
fe403a9 [Lee moon soo] Fix typo. vender-repo -> vendor-repo
5b55ac0 [Lee moon soo] move cloudera repository into profile
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: JDBC generic interpreter
Posted by beeva-victorgarcia <gi...@git.apache.org>.
Github user beeva-victorgarcia commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/361#issuecomment-172542965
In the next PR I add docs and auto-completion function...sorry for this confusion
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: JDBC generic interpreter
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/361#issuecomment-172522382
@tzolov Hi, your opinion makes sense. @Leemoonsoo also worried about changing Postgresql to Jdbc, but I don't think it's a big problem because I will add auto-completion feature before we release Zeppelin 0.6.0. But I agree that we should also consider those who use Zeppelin from master. I propose the way to support Postgresql and it's completer is to make another PR asap. But we should make sure that this is temporary until we completed JDBC interpreter. I'll restore Postgresql interpreter soon. And personally, sorry for confusing you.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: JDBC generic interpreter
Posted by vgmartinez <gi...@git.apache.org>.
Github user vgmartinez commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/361#issuecomment-163870545
Hi @jongyoul,
Sorry for my delay ...;) as we move forward with the discussion about the interpreter jdbc ...? I can improve this withdrawal request with previous recommendations, but I still see a problem with one of the points commented by @felixcheung , for example, to have multiple instances of the same artist ... How can we do ...?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: JDBC generic interpreter
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/361#issuecomment-168941295
@vgmartinez Thanks for quick response. And first of all, could you rebase this PR? this PR won't be merged into current master until you rebase it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: JDBC generic interpreter
Posted by vgmartinez <gi...@git.apache.org>.
Github user vgmartinez commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/361#issuecomment-172103321
Hi @jongyoul @Leemoonsoo,
There is something more to fix or to make the merge...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: JDBC generic interpreter
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/361#issuecomment-172523822
@vgmartinez Our goal is to move to the generic jdbc interpreter, finally. Could you please contribute a document?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: JDBC generic interpreter
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/361#issuecomment-168008003
@vrajat And I also think JDBC interpreter supports all kind of JDBC drivers.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: JDBC generic interpreter
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/361#issuecomment-164620557
And could you please check https://www.mail-archive.com/dev@zeppelin.incubator.apache.org/msg05504.html at dev@. I, strongly, think every contribution should be tracked.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: JDBC generic interpreter
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/361#issuecomment-151024130
@felixcheung There are several implementations for jdbc. We should talk about it for focusing one issue. Do you have any idea?
+ @Leemoonsoo
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: JDBC generic interpreter
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/361#issuecomment-152012132
If I recall there were 3 areas of discussions around JDBC:
1. JDBC url, authentication etc would need to be extensible since they vary greatly between platforms
2. Autocomplete hint etc would also need to be extensible since reserve words etc are different
3. More importantly - multi-instances - if we are to have one JDBC interpreter we need to have a way of supporting multiple instances of the interpreter? Otherwise we are limiting to work with one JDBC host at a time and can't talk to Hive, PostgresQL, Phoenix etc at the same time.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: JDBC generic interpreter
Posted by vgmartinez <gi...@git.apache.org>.
Github user vgmartinez closed the pull request at:
https://github.com/apache/incubator-zeppelin/pull/361
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: JDBC generic interpreter
Posted by beeva-victorgarcia <gi...@git.apache.org>.
Github user beeva-victorgarcia commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/361#issuecomment-163870346
Hi @jongyoul,
Sorry for my delay ...;) as we move forward with the discussion about the interpreter jdbc ...? I can improve this withdrawal request with previous recommendations, but I still see a problem with one of the points commented by felixcheung, for example, to have multiple instances of the same artist ... How can we do ...?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: JDBC generic interpreter
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/361#issuecomment-172354008
@Leemoonsoo Thanks for the reply. I'll merge this PR after resolving conflict.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: JDBC generic interpreter
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/361#issuecomment-172348402
@vgmartinez Sorry for late reply. @Leemoonsoo Do you introduce or use the postgresql interpreter from master branch on the upcoming meetup at 21st Jan? If you do, I'll merge this PR after that. Unless you do, I'll merge it right now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: JDBC generic interpreter
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/361#issuecomment-172539838
I fixed my mistakes. Feel free to talk to me if there's some problems. Thanks everyone for taking care of it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: JDBC generic interpreter
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/361#issuecomment-150918917
@vgmartinez Thanks for contribution on this issue which @Leemoonsoo and I talk about a few days ago. It will covers several Interpreters using JDBC.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: JDBC generic interpreter
Posted by tzolov <gi...@git.apache.org>.
Github user tzolov commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/361#issuecomment-172528525
@jongyoul,
Imo the safest and cleanest solution is be to revert the last (jdbc) commit and to do the changes right before committing the again.
Then it might be better to create the jdbc interpreter in parallel, and gradually replace the other jdbc-based interpreters once you can prove you don't break existing functionality.
What do you think?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: JDBC generic interpreter
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/361#issuecomment-169863487
And... Could you please rebase your changes only and ``push --force`` ? That makes commits clear
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: JDBC generic interpreter
Posted by vgmartinez <gi...@git.apache.org>.
Github user vgmartinez closed the pull request at:
https://github.com/apache/incubator-zeppelin/pull/361
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: JDBC generic interpreter
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/361#issuecomment-172526791
@tzolov Oops. I've found what's the problem. We just delete sqlCompleter only. It's my mistake. I'll fix asap.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: JDBC generic interpreter
Posted by tzolov <gi...@git.apache.org>.
Github user tzolov commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/361#issuecomment-172529513
Same principles that apply for extending/evolving APIs (or Interfaces) should apply here. One shouldn't drop a new incomplete and undocumented API while removing the existing one.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: JDBC generic interpreter
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-zeppelin/pull/361
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: JDBC generic interpreter
Posted by tzolov <gi...@git.apache.org>.
Github user tzolov commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/361#issuecomment-172505545
Thanks for the quick response @vgmartinez ,
The SqlCompleter (removed by the last commit) is meant to be 100% JDBC API compliant and hopefully easy to reuse in a generic jdbc interpreter.
IMO though it is unacceptable to remove a working interpreters until the JDBC interpreter is completed. Some Zeppelin users (like me) use the master to build Zeppelin and now suddenly some essential (for us) functionality is gone.
I think that as a percussion it has to be confirmed that the new JDBC driver can support an existing (jdbc based) interpreter before the later is removed.
I suggest returning the PSQL interpreter code ASAP. Let me know if you need help.
In the meantime we can continue working on the generic JDBC. I will help porting the Completer functionality and missing tests.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: JDBC generic interpreter
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/361#issuecomment-156319520
@felixcheung
1. http://docs.oracle.com/javase/7/docs/api/java/sql/DriverManager.html#getConnection(java.lang.String,%20java.util.Properties) would be a good candidate
2. We need to talk about it. Can Zeppelin show the hint from reading a specific setting from Interpreter tab?
3. I'm agree for supporting multiple instances of same Interpreters. Do you have any idea about it? Basically, generic JDBC driver will replace all JDBC drivers if we can use multiple instance.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: JDBC generic interpreter
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/361#issuecomment-150918846
@vgmartinez https://github.com/vgmartinez/incubator-zeppelin/blob/jdbc_interpreter/jdbc/src/main/java/org/apache/zeppelin/jdbc/JDBCInterpreter.java#L146 How about connecting without user or password? It's better use `getConnection(String url, Properties info)`
https://docs.oracle.com/javase/8/docs/api/java/sql/DriverManager.html#getConnection-java.lang.String-java.util.Properties- ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: JDBC generic interpreter
Posted by vrajat <gi...@git.apache.org>.
Github user vrajat commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/361#issuecomment-167984726
FWIW - I vote for this implementation of JDBC Interpreter. I understand that your focus is on well-known databases - mysql, postgres etc.
I am working with a relatively unknown JDBC driver: https://github.com/qubole/quark. This design allows me to use zeppelin with unknown or custom drivers too. I just have to put the jar in the classpath (which is a bit confusing). I have picked up this pull request and updated it to work with master of zeppelin in this branch: https://github.com/vrajat/incubator-zeppelin/tree/JDBCInterpreter.
Please feel free to use my branch if you choose this implementation and give credit to @vgmartinez . He did all the hard work.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: JDBC generic interpreter
Posted by beeva-victorgarcia <gi...@git.apache.org>.
Github user beeva-victorgarcia commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/361#issuecomment-168940927
Hi @jongyoul,
Yes, this week I can complete the PR...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: JDBC generic interpreter
Posted by vgmartinez <gi...@git.apache.org>.
GitHub user vgmartinez reopened a pull request:
https://github.com/apache/incubator-zeppelin/pull/361
JDBC generic interpreter
Only you need to add to the classpath the jdbc connector jar and the interpreter add the particular properties for each db.
In the file zeppelin-daemon.sh add:
ZEPPELIN_CLASSPATH+=":${ZEPPELIN_HOME}/jdbc/jdbc/connector jar"
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/vgmartinez/incubator-zeppelin jdbc_interpreter
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-zeppelin/pull/361.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #361
----
commit 53d0a81389a4d917b2c790e66718a689bb2e8bc8
Author: Victor <vi...@gmail.com>
Date: 2015-10-23T12:37:48Z
generic interpreter for jdbc
commit 4f28f5a9f4fe2840d824f47d42f6bc07bbc17026
Author: Victor <vi...@gmail.com>
Date: 2015-10-23T12:40:52Z
change psql to jdbc
commit 710699cf04c7fac916dbda98d2babe62a8ffa919
Author: Victor <vi...@gmail.com>
Date: 2015-10-23T12:41:53Z
deleted cassandra/.cache-main from commit
commit a66a5b798d3948db7b456b7693e8002c3be2a636
Author: Victor <vi...@gmail.com>
Date: 2015-10-23T12:46:28Z
add descriptions
commit 462c3b1a55e285e8058de0a6e2ef42c4f647897c
Author: Victor <vi...@gmail.com>
Date: 2015-10-23T20:05:47Z
Merge branch 'master' of https://github.com/apache/incubator-zeppelin into jdbc_interpreter
commit 09006f1a5f34744a2a08d8edeced2628371c3b98
Author: Victor <vi...@gmail.com>
Date: 2015-10-23T23:21:36Z
fix test
commit 52cdbacf207bceb5d66b18c1e5452608881906cf
Author: Ryu Ah young <fb...@hanmail.net>
Date: 2015-10-24T11:46:31Z
ZEPPELIN-334 Add documentation for Apache Lens Interpreter
[ZEPPELIN-334](https://issues.apache.org/jira/browse/ZEPPELIN-334?jql=project%20%3D%20ZEPPELIN%20AND%20text%20~%20%22lens%22) Add documentation for Apache Lens Interpreter
Since the last PR that I opened few days ago has some problems, so I create new one.
I read all comments in the last one and edited below files.
Author: Ryu Ah young <fb...@hanmail.net>
Closes #360 from AhyoungRyu/ZEPPELIN-334-Add-documentation-for-Apache-Lens-Interpreter and squashes the following commits:
9099e6d [Ryu Ah young] modify the typo and add description
11feb1d [Ryu Ah young] ZEPPELIN-334 Add documentation for Apache Lens Interpreter
commit 28a42ff68c42526f156194f3367729eac7ff4519
Author: Lee moon soo <mo...@apache.org>
Date: 2015-10-25T05:46:57Z
ZEPPELIN-359 add NOTICE and DISCLAIMER in the binary package
NOTICE and DISCLAIMER is missing in the binary package.
https://issues.apache.org/jira/browse/ZEPPELIN-359
Author: Lee moon soo <mo...@apache.org>
Closes #363 from Leemoonsoo/ZEPPELIN-359 and squashes the following commits:
ce8aa70 [Lee moon soo] ZEPPELIN-359 add NOTICE and DISCLAIMER in the binary package
commit 11233168fc08322baf8e1032153f370ed272431c
Author: Lee moon soo <mo...@apache.org>
Date: 2015-10-25T05:59:17Z
ZEPPELIN-360 Remove "Copyright 2014, NFLabs inc." from LICENSE
This PR addresses https://issues.apache.org/jira/browse/ZEPPELIN-360
Removing "Copyright 2014, NFLabs inc." from LICENSE.
Author: Lee moon soo <mo...@apache.org>
Closes #364 from Leemoonsoo/ZEPPELIN-360 and squashes the following commits:
cfb814b [Lee moon soo] Remove "Copyright (c) 2010-2015 NFLabs Inc." from NOTICE
fb75e86 [Lee moon soo] ZEPPELIN-360 Remove "Copyright 2014, NFLabs inc." from LICENSE
commit 0b132133ab946b202634a08f484b4689380e8beb
Author: Lee moon soo <mo...@apache.org>
Date: 2015-10-25T06:38:17Z
ZEPPELIN-362 Add maven-remote-resources-plugin plugin
https://issues.apache.org/jira/browse/ZEPPELIN-362
Add maven-remote-resources-plugin to add LICENSE, NOTICE and DISCLAIMER to jar and war artifacts.
Author: Lee moon soo <mo...@apache.org>
Closes #366 from Leemoonsoo/ZEPPELIN-362 and squashes the following commits:
17076fa [Lee moon soo] Add maven-remote-resources-plugin plugin
commit f140c0955be4f0d2978ebb0a93b322ccb99adb4d
Author: Lee moon soo <mo...@apache.org>
Date: 2015-10-25T06:04:52Z
ZEPPELIN-361 Move licese of subcomponents from NOTICE to LICENSE
Move license of subcomponents from NOTICE to LICENSE
https://issues.apache.org/jira/browse/ZEPPELIN-361
Author: Lee moon soo <mo...@apache.org>
This patch had conflicts when merged, resolved by
Committer: Lee moon soo <mo...@apache.org>
Closes #365 from Leemoonsoo/ZEPPELIN-361 and squashes the following commits:
f8ebe84 [Lee moon soo] ZEPPELIN-361 Move licese of subcompoenents from NOTICE to LICENSE
commit fff175f92559afc58280eaeaa94c225e82830f90
Author: Lee moon soo <mo...@apache.org>
Date: 2015-10-27T12:22:48Z
ZEPPELIN-366 Create a single binary package with default build flags.
This PR addresses https://issues.apache.org/jira/browse/ZEPPELIN-366
This patch creates single binary package instead of multiple binary package with different version of Spark / Hadoop combinations.
Also it's removing redundant directory structure from it's tar archive.
Author: Lee moon soo <mo...@apache.org>
Closes #373 from Leemoonsoo/ZEPPELIN-366 and squashes the following commits:
366bbf4 [Lee moon soo] Create a single binary package with default build flags. Remove redundant directory structure in binary package.
commit 86a1a199453b3c347e2b4e731463fea1bc5940bd
Author: Felix Cheung <fe...@hotmail.com>
Date: 2015-10-26T00:01:18Z
[ZEPPELIN-357] Add support for a configurable list of repo for dependencies
Make it configurable via `zeppelin.dep.additionalRemoteRepository`, with spark-packages default. This enables notebook to load dependencies with having to add spark-packages each time.
There is a fair bit of overlap between `DependencyResolver` and `DependencyContext`, but it appears in order for any custom repo available it needs to be in both components. We should discuss how best to address overlaps between the two components.
corneadoug
Leemoonsoo
Author: Felix Cheung <fe...@hotmail.com>
Closes #368 from felixcheung/sparkpackage and squashes the following commits:
207ffb8 [Felix Cheung] Update test - spark-csv is actually on maven central.
dfdb07b [Felix Cheung] add test
eab697b [Felix Cheung] Make custom remote repo configurable
commit ac5ff10b677f757afd0aa0272246ed1cf1de8e2c
Author: Lee moon soo <mo...@apache.org>
Date: 2015-10-30T08:27:31Z
ZEPPELIN-375 HOTFIX move geode from default build to profile
Hot fix for https://issues.apache.org/jira/browse/ZEPPELIN-375, until we get better resolution.
This patch moves geode from default build to profile.
Author: Lee moon soo <mo...@apache.org>
Closes #379 from Leemoonsoo/ZEPPELIN-375-hotfix and squashes the following commits:
7740296 [Lee moon soo] Hotfix for ZEPPELIN-375
commit 0a82a93ce495cf537b28104a024a8c0361fd80ac
Author: Lee moon soo <mo...@apache.org>
Date: 2015-11-02T04:46:02Z
ZEPPELIN-377 CI hanging on ./testing/startSparkCluster.sh 1.4.0 2.3
Address https://issues.apache.org/jira/browse/ZEPPELIN-377.
This patch change spark package download location from apache archive to mirror, to download in 10min.
Also add missing test for 1.5.1 and change test version from 1.4.0 to 1.4.1
Author: Lee moon soo <mo...@apache.org>
Closes #380 from Leemoonsoo/fix_spark_test and squashes the following commits:
142583a [Lee moon soo] Add test for 1.5.1
b8323e6 [Lee moon soo] Use mirror for 1.3.x and later version of spark
commit b7c76f80d4d716f751820947b2271e2b8b5e8e08
Author: Ryu Ah young <fb...@hanmail.net>
Date: 2015-10-30T07:09:12Z
ZEPPELIN-376 http://zeppelin.incubator.apache.org/docs/dynamicform.html points to null link
I found the right place of dynamicform.html : )
Author: Ryu Ah young <fb...@hanmail.net>
Closes #378 from AhyoungRyu/ZEPPELIN-376-dynamicform.html-points-to-null-link and squashes the following commits:
f44d46a [Ryu Ah young] fix http://zeppelin.incubator.apache.org/docs/display.html link
0b79294 [Ryu Ah young] ZEPPELIN-376 http://zeppelin.incubator.apache.org/docs/dynamicform.html points to null link
commit 600f728d26b91632701740bdb98bbc53377bc971
Author: Tomas <xh...@gmail.com>
Date: 2015-10-31T12:26:27Z
added autocompletion
auto-completion shortcut was missing
Author: Tomas <xh...@gmail.com>
Closes #382 from xhudik/patch-3 and squashes the following commits:
ed3ee01 [Tomas] added autocompletion
commit fb5d21719297e27fc8f033534259c016b4217210
Author: Michael Chen <mi...@gmail.com>
Date: 2015-11-03T19:51:06Z
ZEPPELIN-389: Longer Paragraph Title will wrap to new line and interfere with code below
This PR relates to: https://issues.apache.org/jira/browse/ZEPPELIN-389 fixing a bug with paragraph titles longer than 1 line.
Current long paragraph title:
<img width="1258" alt="screen shot 2015-11-03 at 12 16 26 pm" src="https://cloud.githubusercontent.com/assets/6380209/10919812/6e5b919a-8232-11e5-9963-8e7847b8bd67.png">
After the pull request:
<img width="1247" alt="screen shot 2015-11-03 at 1 15 35 pm" src="https://cloud.githubusercontent.com/assets/6380209/10919819/7a4053f6-8232-11e5-878a-0a423c042520.png">
Author: Michael Chen <mi...@gmail.com>
Closes #388 from MikeTYChen/ZEPPELIN-389 and squashes the following commits:
d4daad0 [Michael Chen] ZEPPELIN-389: longer paragraph title
commit 2d893abafad4ab6309e532b1134435c1991b0659
Author: Lee moon soo <mo...@apache.org>
Date: 2015-11-03T18:21:16Z
ZEPPELIN-386 provide links to individual bin/src artifact as well as signatures and KEYS
This PR addresses https://issues.apache.org/jira/browse/ZEPPELIN-386, by provide links to individual bin/src artifact as well as signatures and KEYS
Current download page
After applying this PR
Author: Lee moon soo <mo...@apache.org>
Closes #387 from Leemoonsoo/ZEPPELIN-386 and squashes the following commits:
8dc6581 [Lee moon soo] ZEPPELIN-386 provide link to individual bin/src package as well as signatures and KEYS
commit dfbc0e690c1dfdb6533207a98ef814ec79bff01e
Author: Lee moon soo <mo...@apache.org>
Date: 2015-11-06T04:16:51Z
ZEPPELIN-396 Add -Pypspark profile for release binary
https://issues.apache.org/jira/browse/ZEPPELIN-396
Add -Ppyspark to enable pyspark in default configuration (without SPARK_HOME specified).
Author: Lee moon soo <mo...@apache.org>
Closes #396 from Leemoonsoo/ZEPPELIN-396 and squashes the following commits:
4e599af [Lee moon soo] Add -Pypspark profile for release binary
commit a4db1688c9ce0a172722e289171e82099a43b55d
Author: Lee moon soo <mo...@apache.org>
Date: 2015-11-06T04:57:13Z
ZEPPELIN-397 Activate spark-1.5 and hadoop-2.4 by default in release script
https://issues.apache.org/jira/browse/ZEPPELIN-397
Activate spark-1.5 and hadoop-2.4 by default
That'll enable use sc.textFile("s3...") with default configuration without specify SPARK_HOME.
Author: Lee moon soo <mo...@apache.org>
This patch had conflicts when merged, resolved by
Committer: Lee moon soo <mo...@apache.org>
Closes #397 from Leemoonsoo/ZEPPELIN-397 and squashes the following commits:
9855dde [Lee moon soo] Activate spark-1.5 and hadoop-2.4 by default
commit e3e61832bcaa3fcce5b1096a20180631c2a8d6e8
Author: Ryu Ah young <fb...@hanmail.net>
Date: 2015-10-26T01:31:32Z
ZEPPELIN-338 Add documentation for Ignite Interpreter
[ZEPPELIN-338](https://issues.apache.org/jira/browse/ZEPPELIN-338?jql=project%20%3D%20ZEPPELIN%20AND%20text%20~%20%22ignite%22) Add documentation for Ignite Interpreter
Since the last PR that I opened few days ago has some problems, so I create new one.
I read all comments in the last one and edited below files.
Author: Ryu Ah young <fb...@hanmail.net>
This patch had conflicts when merged, resolved by
Committer: Lee moon soo <mo...@apache.org>
Closes #359 from AhyoungRyu/ZEPPELIN-338-Add-documentation-for-Ignite-Interpreter and squashes the following commits:
6ae854d [Ryu Ah young] edit 'next' to 'binary'
3e0509d [Ryu Ah young] edit next to future
1acf2ee [Ryu Ah young] add explanation about Zeppelin binary release to check ignite version
814d8fa [Ryu Ah young] add explanation about Zeppelin binary release to check ignite version
8689915 [Ryu Ah young] ZEPPELIN-338 Add documentation for Ignite Interpreter
commit 27b7ad52b6bf8f18643e8b58d16fcab3d709eb1c
Author: eranwitkon <go...@gmail.com>
Date: 2015-11-04T13:09:06Z
[Zeppelin-354] - List notebooks REST API
replacing PR #367
This is the implementation, test and documentation of List notebooks REST API.
The documentation include sample JSON with different looknfeel option and coron options.
This is ready for review.
Author: eranwitkon <go...@gmail.com>
Closes #369 from eranwitkon/354 and squashes the following commits:
5472620 [eranwitkon] update getNotebook list documentation
b2dad81 [eranwitkon] revert to original implementation as getNotebookList does not need the exclusionStrategy anymore
0eff22e [eranwitkon] update getList test
c2f1c5f [eranwitkon] update getNotebookList to use NotebookServer.generateNotebookInfo function
d0b6744 [eranwitkon] refactor broadcastNoteList to use a new public generateNotebookList function which will be used in both socket implementation and REST implementation.
1e3d98c [eranwitkon] List Notebook REST API implementation, Test & documentation
ee53446 [eranwitkon] List Notebook REST API implementation, Test & documentation
commit 618bcd8785cdde83d5212569be6e54aabb2d6f14
Author: Prabhjyot Singh <pr...@gmail.com>
Date: 2015-11-03T09:01:39Z
ZEPPELIN-372 : Exporting a notebook
Exporting a notebook in a JSON format, which can later be used/imported in a different environment.
<img width="203" alt="screen shot 2015-10-29 at 12 29 41 pm" src="https://cloud.githubusercontent.com/assets/674497/10812117/d6611b82-7e38-11e5-9074-d14eebf19e72.png">
Author: Prabhjyot Singh <pr...@gmail.com>
Closes #376 from prabhjyotsingh/ZEPPELIN-372 and squashes the following commits:
462e733 [Prabhjyot Singh] ZEPPELIN-372 : Exporting a notebook in a JSON format, which can later be used/imported in a different environment.
commit e45cf399596be7e30d8bb42a45e700c6898a3f1b
Author: Luciano Resende <lr...@apache.org>
Date: 2015-11-05T19:52:58Z
Correct contact e-mail in documentation config.yml
Author: Luciano Resende <lr...@apache.org>
Closes #393 from lresende/website and squashes the following commits:
c167239 [Luciano Resende] Correct contact e-mail in documentation config.yml
commit fd2a28853ec83da975fdffba6f2a5ca198126d4d
Author: Patrick Ethier <nu...@gmail.com>
Date: 2015-11-04T19:15:33Z
ZEPPELIN-365: Add credentials for dependency loader
Allow to authenticate to Artifactory or any other private maven repository using user/pass via the dependency loader
Author: Patrick Ethier <nu...@gmail.com>
Author: Patrick Ethier <pa...@secureops.com>
Author: nuttybrewer <nu...@gmail.com>
Closes #377 from nuttybrewer/master and squashes the following commits:
9745f24 [Patrick Ethier] Update Repository.java
8599240 [Patrick Ethier] Update Repository.java
70de3ec [Patrick Ethier] Update Repository.java
3e395bf [Patrick Ethier] Move to fluent API
6c858e8 [Patrick Ethier] Merge branch 'master' of github.com:apache/incubator-zeppelin
3dcfc1f [Patrick Ethier] Update Repository.java
361291a [Patrick Ethier] Update Repository.java
656266a [Patrick Ethier] Update Repository.java
1169f80 [Patrick Ethier] Update spark.md
5b8f357 [Patrick Ethier] Update Repository.java
10c342b [Patrick Ethier] Update DependencyContext.java
57ab930 [Patrick Ethier] Update Repository.java
2b98165 [Patrick Ethier] Update DependencyContext.java
b93057d [nuttybrewer] remove return statement for coding style
0c9395c [Patrick Ethier] Merge branch 'master' of github.com:nuttybrewer/incubator-zeppelin
e7ece92 [Patrick Ethier] Added addCredential() function to allow for authenticated repositories via dependency loader
0936e89 [Patrick Ethier] Added documentation for new addCredential() function
commit ae08e713e43ce9ebfb11f0f9cf7a7ea42885d677
Author: Khalid Huseynov <kh...@nflabs.com>
Date: 2015-10-28T11:40:16Z
ZEPPELIN-367 Sync with secondary storage when listing notebooks
This PR resolves https://issues.apache.org/jira/browse/ZEPPELIN-367 by synchronizing with secondary storage when reloading all notebooks into memory. Currently, existing `ZEPPELIN_NOTEBOOK_RELOAD_FROM_STORAGE` from https://github.com/apache/incubator-zeppelin/pull/331 is used as a flag since these functionalities are correlated, however it can be separated into distinct flag as well.
Author: Khalid Huseynov <kh...@nflabs.com>
Closes #375 from khalidhuseynov/sync-on-list and squashes the following commits:
e2cf5d9 [Khalid Huseynov] minor fix
878a23e [Khalid Huseynov] initial working commit
commit cd0010d69be4e58ca5c92d984e61729ebde63174
Author: Tomas <xh...@gmail.com>
Date: 2015-11-05T11:56:32Z
added hint to errror message
%dep interpreter gives meaningless(for newbies) error message if it is not executed as the first snippet. Whit this hint it should be clear what to do to get rid of the problem
Author: Tomas <xh...@gmail.com>
Closes #383 from xhudik/patch-4 and squashes the following commits:
8ce0f8f [Tomas] paragraph instead of cell
aa16656 [Tomas] added Interpreter restart option
674cb66 [Tomas] cell instead of snippet
9c3af9f [Tomas] formatting
c8c5649 [Tomas] added hint to errror message
commit 8b7556df11c732029d694bbd492b0d30865d3b0c
Author: DuyHai DOAN <do...@gmail.com>
Date: 2015-11-02T11:57:29Z
[ZEPPELIN-382] Add Documentation for Cassandra interpreter in the doc…
Linked **[JIRA]**
[JIRA]: https://issues.apache.org/jira/browse/ZEPPELIN-382?jql=project%20%3D%20ZEPPELIN
Author: DuyHai DOAN <do...@gmail.com>
Closes #384 from doanduyhai/CassandraInterpreterDocumentation and squashes the following commits:
b0bf36a [DuyHai DOAN] [ZEPPELIN-382] Add Documentation for Cassandra interpreter in the doc pages
commit 785ee3c8b46225da75698458acc5b730e8ead542
Author: Lee moon soo <mo...@apache.org>
Date: 2015-11-08T01:03:34Z
ZEPPELIN-404 Certain project dependencies are pulled from 3rd parties repos instead of ASF or public Maven
https://issues.apache.org/jira/browse/ZEPPELIN-404
This PR removes / move 3rd party repository into profile.
cloudera repo is disabled by default and can be activated by -Pvendor-repo
Author: Lee moon soo <mo...@apache.org>
Closes #404 from Leemoonsoo/ZEPPELIN-404 and squashes the following commits:
fe403a9 [Lee moon soo] Fix typo. vender-repo -> vendor-repo
5b55ac0 [Lee moon soo] move cloudera repository into profile
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: JDBC generic interpreter
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/361#issuecomment-151794561
As @felixcheung mentioned, there were couple of attempt.
This patch renames existing postgresql to jdbc. So if renaming does not bring big problem, I think it can be a basement and starting point to do all the things discussed in previous attempt.
What do you think? will rename postgresql to jdbc make some problem?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: JDBC generic interpreter
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/361#issuecomment-170033129
@vgmartinez Thanks for making it clear. You look like that you want to includes some jdbc connectors but it's not appropriate because we don't decide which connectors are supported. Which connector do you think it's suitable for a default? I think postgresql is a good candidate because there is no license and this is based on that. @Leemoonsoo Do you have any recommendation on a default jdbc connector? I propose we decide nothing for now, and describe how to add specific jdbc interpreter on a document. Except that, It looks good to me. Thanks again, @vgmartinez.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: JDBC generic interpreter
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/361#issuecomment-169863282
@vgmartinez Yes, HiveInterpreter is based on this interpreter, but I thought it's a natural way of you to commit this PR, then I fix to support to multiple connections. It's a way to conserve your contribution and authority. After that, I'll deprecate HiveInterpreter and any other JDBC-like interpreters, and guide your interpreter by using JDBC connections. As you think this is redundant or don't need to conserve authority, I'll change HiveInterpreter to JdbcInterpreter and deprecate any other interpreters. What about your opinion?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: JDBC generic interpreter
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/361#issuecomment-172415835
@vgmartinez Thanks, I'll merge it. Did you make a PR for docs? or will you make it?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: JDBC generic interpreter
Posted by beeva-victorgarcia <gi...@git.apache.org>.
Github user beeva-victorgarcia commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/361#issuecomment-172526244
ok...make sense
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: JDBC generic interpreter
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/361#issuecomment-172525954
@beeva-victorgarcia I keep this PR merged and add Postgresql interpreter again. I think this is more easier way to add Postgresql interpreter.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: JDBC generic interpreter
Posted by vgmartinez <gi...@git.apache.org>.
Github user vgmartinez commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/361#issuecomment-172359934
hi @jongyoul,
It ready...in other PR add docs for the interpreter....
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: JDBC generic interpreter
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/361#issuecomment-172355131
@vgmartinez Hi, Could you please rebase this PR one more? Some logging codes are added by another PR. After that rebase, I'll merge it immediately.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: JDBC generic interpreter
Posted by vgmartinez <gi...@git.apache.org>.
GitHub user vgmartinez reopened a pull request:
https://github.com/apache/incubator-zeppelin/pull/361
JDBC generic interpreter
Only you need to add to the classpath the jdbc connector jar and the interpreter add the particular properties for each db.
In the file zeppelin-daemon.sh add:
ZEPPELIN_CLASSPATH+=":${ZEPPELIN_HOME}/jdbc/jdbc/connector jar"
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/vgmartinez/incubator-zeppelin jdbc_interpreter
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-zeppelin/pull/361.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #361
----
commit 53d0a81389a4d917b2c790e66718a689bb2e8bc8
Author: Victor <vi...@gmail.com>
Date: 2015-10-23T12:37:48Z
generic interpreter for jdbc
commit 4f28f5a9f4fe2840d824f47d42f6bc07bbc17026
Author: Victor <vi...@gmail.com>
Date: 2015-10-23T12:40:52Z
change psql to jdbc
commit 710699cf04c7fac916dbda98d2babe62a8ffa919
Author: Victor <vi...@gmail.com>
Date: 2015-10-23T12:41:53Z
deleted cassandra/.cache-main from commit
commit a66a5b798d3948db7b456b7693e8002c3be2a636
Author: Victor <vi...@gmail.com>
Date: 2015-10-23T12:46:28Z
add descriptions
commit 462c3b1a55e285e8058de0a6e2ef42c4f647897c
Author: Victor <vi...@gmail.com>
Date: 2015-10-23T20:05:47Z
Merge branch 'master' of https://github.com/apache/incubator-zeppelin into jdbc_interpreter
commit 09006f1a5f34744a2a08d8edeced2628371c3b98
Author: Victor <vi...@gmail.com>
Date: 2015-10-23T23:21:36Z
fix test
commit 52cdbacf207bceb5d66b18c1e5452608881906cf
Author: Ryu Ah young <fb...@hanmail.net>
Date: 2015-10-24T11:46:31Z
ZEPPELIN-334 Add documentation for Apache Lens Interpreter
[ZEPPELIN-334](https://issues.apache.org/jira/browse/ZEPPELIN-334?jql=project%20%3D%20ZEPPELIN%20AND%20text%20~%20%22lens%22) Add documentation for Apache Lens Interpreter
Since the last PR that I opened few days ago has some problems, so I create new one.
I read all comments in the last one and edited below files.
Author: Ryu Ah young <fb...@hanmail.net>
Closes #360 from AhyoungRyu/ZEPPELIN-334-Add-documentation-for-Apache-Lens-Interpreter and squashes the following commits:
9099e6d [Ryu Ah young] modify the typo and add description
11feb1d [Ryu Ah young] ZEPPELIN-334 Add documentation for Apache Lens Interpreter
commit 28a42ff68c42526f156194f3367729eac7ff4519
Author: Lee moon soo <mo...@apache.org>
Date: 2015-10-25T05:46:57Z
ZEPPELIN-359 add NOTICE and DISCLAIMER in the binary package
NOTICE and DISCLAIMER is missing in the binary package.
https://issues.apache.org/jira/browse/ZEPPELIN-359
Author: Lee moon soo <mo...@apache.org>
Closes #363 from Leemoonsoo/ZEPPELIN-359 and squashes the following commits:
ce8aa70 [Lee moon soo] ZEPPELIN-359 add NOTICE and DISCLAIMER in the binary package
commit 11233168fc08322baf8e1032153f370ed272431c
Author: Lee moon soo <mo...@apache.org>
Date: 2015-10-25T05:59:17Z
ZEPPELIN-360 Remove "Copyright 2014, NFLabs inc." from LICENSE
This PR addresses https://issues.apache.org/jira/browse/ZEPPELIN-360
Removing "Copyright 2014, NFLabs inc." from LICENSE.
Author: Lee moon soo <mo...@apache.org>
Closes #364 from Leemoonsoo/ZEPPELIN-360 and squashes the following commits:
cfb814b [Lee moon soo] Remove "Copyright (c) 2010-2015 NFLabs Inc." from NOTICE
fb75e86 [Lee moon soo] ZEPPELIN-360 Remove "Copyright 2014, NFLabs inc." from LICENSE
commit 0b132133ab946b202634a08f484b4689380e8beb
Author: Lee moon soo <mo...@apache.org>
Date: 2015-10-25T06:38:17Z
ZEPPELIN-362 Add maven-remote-resources-plugin plugin
https://issues.apache.org/jira/browse/ZEPPELIN-362
Add maven-remote-resources-plugin to add LICENSE, NOTICE and DISCLAIMER to jar and war artifacts.
Author: Lee moon soo <mo...@apache.org>
Closes #366 from Leemoonsoo/ZEPPELIN-362 and squashes the following commits:
17076fa [Lee moon soo] Add maven-remote-resources-plugin plugin
commit f140c0955be4f0d2978ebb0a93b322ccb99adb4d
Author: Lee moon soo <mo...@apache.org>
Date: 2015-10-25T06:04:52Z
ZEPPELIN-361 Move licese of subcomponents from NOTICE to LICENSE
Move license of subcomponents from NOTICE to LICENSE
https://issues.apache.org/jira/browse/ZEPPELIN-361
Author: Lee moon soo <mo...@apache.org>
This patch had conflicts when merged, resolved by
Committer: Lee moon soo <mo...@apache.org>
Closes #365 from Leemoonsoo/ZEPPELIN-361 and squashes the following commits:
f8ebe84 [Lee moon soo] ZEPPELIN-361 Move licese of subcompoenents from NOTICE to LICENSE
commit fff175f92559afc58280eaeaa94c225e82830f90
Author: Lee moon soo <mo...@apache.org>
Date: 2015-10-27T12:22:48Z
ZEPPELIN-366 Create a single binary package with default build flags.
This PR addresses https://issues.apache.org/jira/browse/ZEPPELIN-366
This patch creates single binary package instead of multiple binary package with different version of Spark / Hadoop combinations.
Also it's removing redundant directory structure from it's tar archive.
Author: Lee moon soo <mo...@apache.org>
Closes #373 from Leemoonsoo/ZEPPELIN-366 and squashes the following commits:
366bbf4 [Lee moon soo] Create a single binary package with default build flags. Remove redundant directory structure in binary package.
commit 86a1a199453b3c347e2b4e731463fea1bc5940bd
Author: Felix Cheung <fe...@hotmail.com>
Date: 2015-10-26T00:01:18Z
[ZEPPELIN-357] Add support for a configurable list of repo for dependencies
Make it configurable via `zeppelin.dep.additionalRemoteRepository`, with spark-packages default. This enables notebook to load dependencies with having to add spark-packages each time.
There is a fair bit of overlap between `DependencyResolver` and `DependencyContext`, but it appears in order for any custom repo available it needs to be in both components. We should discuss how best to address overlaps between the two components.
corneadoug
Leemoonsoo
Author: Felix Cheung <fe...@hotmail.com>
Closes #368 from felixcheung/sparkpackage and squashes the following commits:
207ffb8 [Felix Cheung] Update test - spark-csv is actually on maven central.
dfdb07b [Felix Cheung] add test
eab697b [Felix Cheung] Make custom remote repo configurable
commit ac5ff10b677f757afd0aa0272246ed1cf1de8e2c
Author: Lee moon soo <mo...@apache.org>
Date: 2015-10-30T08:27:31Z
ZEPPELIN-375 HOTFIX move geode from default build to profile
Hot fix for https://issues.apache.org/jira/browse/ZEPPELIN-375, until we get better resolution.
This patch moves geode from default build to profile.
Author: Lee moon soo <mo...@apache.org>
Closes #379 from Leemoonsoo/ZEPPELIN-375-hotfix and squashes the following commits:
7740296 [Lee moon soo] Hotfix for ZEPPELIN-375
commit 0a82a93ce495cf537b28104a024a8c0361fd80ac
Author: Lee moon soo <mo...@apache.org>
Date: 2015-11-02T04:46:02Z
ZEPPELIN-377 CI hanging on ./testing/startSparkCluster.sh 1.4.0 2.3
Address https://issues.apache.org/jira/browse/ZEPPELIN-377.
This patch change spark package download location from apache archive to mirror, to download in 10min.
Also add missing test for 1.5.1 and change test version from 1.4.0 to 1.4.1
Author: Lee moon soo <mo...@apache.org>
Closes #380 from Leemoonsoo/fix_spark_test and squashes the following commits:
142583a [Lee moon soo] Add test for 1.5.1
b8323e6 [Lee moon soo] Use mirror for 1.3.x and later version of spark
commit b7c76f80d4d716f751820947b2271e2b8b5e8e08
Author: Ryu Ah young <fb...@hanmail.net>
Date: 2015-10-30T07:09:12Z
ZEPPELIN-376 http://zeppelin.incubator.apache.org/docs/dynamicform.html points to null link
I found the right place of dynamicform.html : )
Author: Ryu Ah young <fb...@hanmail.net>
Closes #378 from AhyoungRyu/ZEPPELIN-376-dynamicform.html-points-to-null-link and squashes the following commits:
f44d46a [Ryu Ah young] fix http://zeppelin.incubator.apache.org/docs/display.html link
0b79294 [Ryu Ah young] ZEPPELIN-376 http://zeppelin.incubator.apache.org/docs/dynamicform.html points to null link
commit 600f728d26b91632701740bdb98bbc53377bc971
Author: Tomas <xh...@gmail.com>
Date: 2015-10-31T12:26:27Z
added autocompletion
auto-completion shortcut was missing
Author: Tomas <xh...@gmail.com>
Closes #382 from xhudik/patch-3 and squashes the following commits:
ed3ee01 [Tomas] added autocompletion
commit fb5d21719297e27fc8f033534259c016b4217210
Author: Michael Chen <mi...@gmail.com>
Date: 2015-11-03T19:51:06Z
ZEPPELIN-389: Longer Paragraph Title will wrap to new line and interfere with code below
This PR relates to: https://issues.apache.org/jira/browse/ZEPPELIN-389 fixing a bug with paragraph titles longer than 1 line.
Current long paragraph title:
<img width="1258" alt="screen shot 2015-11-03 at 12 16 26 pm" src="https://cloud.githubusercontent.com/assets/6380209/10919812/6e5b919a-8232-11e5-9963-8e7847b8bd67.png">
After the pull request:
<img width="1247" alt="screen shot 2015-11-03 at 1 15 35 pm" src="https://cloud.githubusercontent.com/assets/6380209/10919819/7a4053f6-8232-11e5-878a-0a423c042520.png">
Author: Michael Chen <mi...@gmail.com>
Closes #388 from MikeTYChen/ZEPPELIN-389 and squashes the following commits:
d4daad0 [Michael Chen] ZEPPELIN-389: longer paragraph title
commit 2d893abafad4ab6309e532b1134435c1991b0659
Author: Lee moon soo <mo...@apache.org>
Date: 2015-11-03T18:21:16Z
ZEPPELIN-386 provide links to individual bin/src artifact as well as signatures and KEYS
This PR addresses https://issues.apache.org/jira/browse/ZEPPELIN-386, by provide links to individual bin/src artifact as well as signatures and KEYS
Current download page
After applying this PR
Author: Lee moon soo <mo...@apache.org>
Closes #387 from Leemoonsoo/ZEPPELIN-386 and squashes the following commits:
8dc6581 [Lee moon soo] ZEPPELIN-386 provide link to individual bin/src package as well as signatures and KEYS
commit dfbc0e690c1dfdb6533207a98ef814ec79bff01e
Author: Lee moon soo <mo...@apache.org>
Date: 2015-11-06T04:16:51Z
ZEPPELIN-396 Add -Pypspark profile for release binary
https://issues.apache.org/jira/browse/ZEPPELIN-396
Add -Ppyspark to enable pyspark in default configuration (without SPARK_HOME specified).
Author: Lee moon soo <mo...@apache.org>
Closes #396 from Leemoonsoo/ZEPPELIN-396 and squashes the following commits:
4e599af [Lee moon soo] Add -Pypspark profile for release binary
commit a4db1688c9ce0a172722e289171e82099a43b55d
Author: Lee moon soo <mo...@apache.org>
Date: 2015-11-06T04:57:13Z
ZEPPELIN-397 Activate spark-1.5 and hadoop-2.4 by default in release script
https://issues.apache.org/jira/browse/ZEPPELIN-397
Activate spark-1.5 and hadoop-2.4 by default
That'll enable use sc.textFile("s3...") with default configuration without specify SPARK_HOME.
Author: Lee moon soo <mo...@apache.org>
This patch had conflicts when merged, resolved by
Committer: Lee moon soo <mo...@apache.org>
Closes #397 from Leemoonsoo/ZEPPELIN-397 and squashes the following commits:
9855dde [Lee moon soo] Activate spark-1.5 and hadoop-2.4 by default
commit e3e61832bcaa3fcce5b1096a20180631c2a8d6e8
Author: Ryu Ah young <fb...@hanmail.net>
Date: 2015-10-26T01:31:32Z
ZEPPELIN-338 Add documentation for Ignite Interpreter
[ZEPPELIN-338](https://issues.apache.org/jira/browse/ZEPPELIN-338?jql=project%20%3D%20ZEPPELIN%20AND%20text%20~%20%22ignite%22) Add documentation for Ignite Interpreter
Since the last PR that I opened few days ago has some problems, so I create new one.
I read all comments in the last one and edited below files.
Author: Ryu Ah young <fb...@hanmail.net>
This patch had conflicts when merged, resolved by
Committer: Lee moon soo <mo...@apache.org>
Closes #359 from AhyoungRyu/ZEPPELIN-338-Add-documentation-for-Ignite-Interpreter and squashes the following commits:
6ae854d [Ryu Ah young] edit 'next' to 'binary'
3e0509d [Ryu Ah young] edit next to future
1acf2ee [Ryu Ah young] add explanation about Zeppelin binary release to check ignite version
814d8fa [Ryu Ah young] add explanation about Zeppelin binary release to check ignite version
8689915 [Ryu Ah young] ZEPPELIN-338 Add documentation for Ignite Interpreter
commit 27b7ad52b6bf8f18643e8b58d16fcab3d709eb1c
Author: eranwitkon <go...@gmail.com>
Date: 2015-11-04T13:09:06Z
[Zeppelin-354] - List notebooks REST API
replacing PR #367
This is the implementation, test and documentation of List notebooks REST API.
The documentation include sample JSON with different looknfeel option and coron options.
This is ready for review.
Author: eranwitkon <go...@gmail.com>
Closes #369 from eranwitkon/354 and squashes the following commits:
5472620 [eranwitkon] update getNotebook list documentation
b2dad81 [eranwitkon] revert to original implementation as getNotebookList does not need the exclusionStrategy anymore
0eff22e [eranwitkon] update getList test
c2f1c5f [eranwitkon] update getNotebookList to use NotebookServer.generateNotebookInfo function
d0b6744 [eranwitkon] refactor broadcastNoteList to use a new public generateNotebookList function which will be used in both socket implementation and REST implementation.
1e3d98c [eranwitkon] List Notebook REST API implementation, Test & documentation
ee53446 [eranwitkon] List Notebook REST API implementation, Test & documentation
commit 618bcd8785cdde83d5212569be6e54aabb2d6f14
Author: Prabhjyot Singh <pr...@gmail.com>
Date: 2015-11-03T09:01:39Z
ZEPPELIN-372 : Exporting a notebook
Exporting a notebook in a JSON format, which can later be used/imported in a different environment.
<img width="203" alt="screen shot 2015-10-29 at 12 29 41 pm" src="https://cloud.githubusercontent.com/assets/674497/10812117/d6611b82-7e38-11e5-9074-d14eebf19e72.png">
Author: Prabhjyot Singh <pr...@gmail.com>
Closes #376 from prabhjyotsingh/ZEPPELIN-372 and squashes the following commits:
462e733 [Prabhjyot Singh] ZEPPELIN-372 : Exporting a notebook in a JSON format, which can later be used/imported in a different environment.
commit e45cf399596be7e30d8bb42a45e700c6898a3f1b
Author: Luciano Resende <lr...@apache.org>
Date: 2015-11-05T19:52:58Z
Correct contact e-mail in documentation config.yml
Author: Luciano Resende <lr...@apache.org>
Closes #393 from lresende/website and squashes the following commits:
c167239 [Luciano Resende] Correct contact e-mail in documentation config.yml
commit fd2a28853ec83da975fdffba6f2a5ca198126d4d
Author: Patrick Ethier <nu...@gmail.com>
Date: 2015-11-04T19:15:33Z
ZEPPELIN-365: Add credentials for dependency loader
Allow to authenticate to Artifactory or any other private maven repository using user/pass via the dependency loader
Author: Patrick Ethier <nu...@gmail.com>
Author: Patrick Ethier <pa...@secureops.com>
Author: nuttybrewer <nu...@gmail.com>
Closes #377 from nuttybrewer/master and squashes the following commits:
9745f24 [Patrick Ethier] Update Repository.java
8599240 [Patrick Ethier] Update Repository.java
70de3ec [Patrick Ethier] Update Repository.java
3e395bf [Patrick Ethier] Move to fluent API
6c858e8 [Patrick Ethier] Merge branch 'master' of github.com:apache/incubator-zeppelin
3dcfc1f [Patrick Ethier] Update Repository.java
361291a [Patrick Ethier] Update Repository.java
656266a [Patrick Ethier] Update Repository.java
1169f80 [Patrick Ethier] Update spark.md
5b8f357 [Patrick Ethier] Update Repository.java
10c342b [Patrick Ethier] Update DependencyContext.java
57ab930 [Patrick Ethier] Update Repository.java
2b98165 [Patrick Ethier] Update DependencyContext.java
b93057d [nuttybrewer] remove return statement for coding style
0c9395c [Patrick Ethier] Merge branch 'master' of github.com:nuttybrewer/incubator-zeppelin
e7ece92 [Patrick Ethier] Added addCredential() function to allow for authenticated repositories via dependency loader
0936e89 [Patrick Ethier] Added documentation for new addCredential() function
commit ae08e713e43ce9ebfb11f0f9cf7a7ea42885d677
Author: Khalid Huseynov <kh...@nflabs.com>
Date: 2015-10-28T11:40:16Z
ZEPPELIN-367 Sync with secondary storage when listing notebooks
This PR resolves https://issues.apache.org/jira/browse/ZEPPELIN-367 by synchronizing with secondary storage when reloading all notebooks into memory. Currently, existing `ZEPPELIN_NOTEBOOK_RELOAD_FROM_STORAGE` from https://github.com/apache/incubator-zeppelin/pull/331 is used as a flag since these functionalities are correlated, however it can be separated into distinct flag as well.
Author: Khalid Huseynov <kh...@nflabs.com>
Closes #375 from khalidhuseynov/sync-on-list and squashes the following commits:
e2cf5d9 [Khalid Huseynov] minor fix
878a23e [Khalid Huseynov] initial working commit
commit cd0010d69be4e58ca5c92d984e61729ebde63174
Author: Tomas <xh...@gmail.com>
Date: 2015-11-05T11:56:32Z
added hint to errror message
%dep interpreter gives meaningless(for newbies) error message if it is not executed as the first snippet. Whit this hint it should be clear what to do to get rid of the problem
Author: Tomas <xh...@gmail.com>
Closes #383 from xhudik/patch-4 and squashes the following commits:
8ce0f8f [Tomas] paragraph instead of cell
aa16656 [Tomas] added Interpreter restart option
674cb66 [Tomas] cell instead of snippet
9c3af9f [Tomas] formatting
c8c5649 [Tomas] added hint to errror message
commit 8b7556df11c732029d694bbd492b0d30865d3b0c
Author: DuyHai DOAN <do...@gmail.com>
Date: 2015-11-02T11:57:29Z
[ZEPPELIN-382] Add Documentation for Cassandra interpreter in the doc…
Linked **[JIRA]**
[JIRA]: https://issues.apache.org/jira/browse/ZEPPELIN-382?jql=project%20%3D%20ZEPPELIN
Author: DuyHai DOAN <do...@gmail.com>
Closes #384 from doanduyhai/CassandraInterpreterDocumentation and squashes the following commits:
b0bf36a [DuyHai DOAN] [ZEPPELIN-382] Add Documentation for Cassandra interpreter in the doc pages
commit 785ee3c8b46225da75698458acc5b730e8ead542
Author: Lee moon soo <mo...@apache.org>
Date: 2015-11-08T01:03:34Z
ZEPPELIN-404 Certain project dependencies are pulled from 3rd parties repos instead of ASF or public Maven
https://issues.apache.org/jira/browse/ZEPPELIN-404
This PR removes / move 3rd party repository into profile.
cloudera repo is disabled by default and can be activated by -Pvendor-repo
Author: Lee moon soo <mo...@apache.org>
Closes #404 from Leemoonsoo/ZEPPELIN-404 and squashes the following commits:
fe403a9 [Lee moon soo] Fix typo. vender-repo -> vendor-repo
5b55ac0 [Lee moon soo] move cloudera repository into profile
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: JDBC generic interpreter
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/361#issuecomment-170316015
LGTM. Merging if there isn't no more discussion.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: JDBC generic interpreter
Posted by vgmartinez <gi...@git.apache.org>.
Github user vgmartinez commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/361#issuecomment-172495765
Hi @tzolov,
Yes, the interpreter is based on the PostgreSQL was mentioned https://github.com/apache/incubator-zeppelin/pull/608. I think is that we should work on this interpreter and add auto-completion functionality already available in Postgres and to all others that will be added. what do you think...?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: JDBC generic interpreter
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/361#issuecomment-164620107
@vgmartinez Sorry for delay. I've committed #455 #517 for supporting multiple instances - connections - Because that's based on this interpreter, it would be easy to fit those features in this interpreter. Could you please check those PRs? And I also hope you contribute the documentations.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: JDBC generic interpreter
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/361#issuecomment-150919985
@vgmartinez Finally, How about adding a `ZEPPELIN_INTP_CLASSPATH` to zeppelin-env.sh and making it added by interpreter.sh?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: JDBC generic interpreter
Posted by vgmartinez <gi...@git.apache.org>.
Github user vgmartinez commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/361#issuecomment-150933832
Hi @jongyoul,
Thanks for the feedback...I will implement the suggestion....
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: JDBC generic interpreter
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/361#issuecomment-160021026
@jiekechoo You can find a document on
http://zeppelin.incubator.apache.org/docs/0.5.5-incubating/interpreter/postgresql.html
1. Set the driver name as you want to `postgresql.driver.name`.
2. Set other properties
3. Save
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: JDBC generic interpreter
Posted by woonsan <gi...@git.apache.org>.
Github user woonsan commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/361#issuecomment-172528015
Big applause to you guys!
+1 on moving to jdbc interpreter which may also allow other db specific interpreter extensions in the future.
Cheers!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: JDBC generic interpreter
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/361#issuecomment-150661569
@tzolov
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: JDBC generic interpreter
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/361#issuecomment-150986836
There's another earlier attempt for this #211, #60
Other JDBC-like use cases perhaps you could also factor into your design? #73, #110
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: JDBC generic interpreter
Posted by jiekechoo <gi...@git.apache.org>.
Github user jiekechoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/361#issuecomment-160019122
How to get this function?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: JDBC generic interpreter
Posted by vgmartinez <gi...@git.apache.org>.
Github user vgmartinez closed the pull request at:
https://github.com/apache/incubator-zeppelin/pull/361
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: JDBC generic interpreter
Posted by vgmartinez <gi...@git.apache.org>.
Github user vgmartinez commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/361#issuecomment-169939310
Hi @jongyoul,
Is rebase now...let me know if you need help with testing or anything else.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: JDBC generic interpreter
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/361#issuecomment-168940465
@vgmartinez It took a long time to reach this PR. I hope you could share your time to complete this PR. Basically, this implementation looks good to me, but we need to update docs to describe how to use custom Jdbc drivers. Do you have a time to do this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: JDBC generic interpreter
Posted by tzolov <gi...@git.apache.org>.
Github user tzolov commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/361#issuecomment-172492176
@vgmartinez , @felixcheung , @asfgit, @Leemoonsoo
Hello guys, I am sorry to jump a bit late.
First let me say that I am glad that you have decided to base the generic JDBC interpreter on the work i've done on the PostgreSqlInterpter.
I believe though that the generic interpreter should extend rather than degradating the existing functionality! For example the new generic JDBC intr. hasn't included the SqlCompleter (not sure why since the later is based on JDBC metdata functionality?) and in the same time the last commit you has removed the original PostgreSql Interpreter? (Actually one single class is still left in. Looks like a slappy commit?)
IMHO This is unacceptable functionality degradation! I would propose to return the PostgreSQL interpreter until JDBC matures? I will try to prepare a hot-fix asap.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: JDBC generic interpreter
Posted by vgmartinez <gi...@git.apache.org>.
Github user vgmartinez commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/361#issuecomment-170147338
I removed the dependencies and add the postgres dependency to have it by default without having to add the jar to the classpath. What do you think?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: JDBC generic interpreter
Posted by vrajat <gi...@git.apache.org>.
Github user vrajat commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/361#issuecomment-168020790
I read your mail. I understand why you are following this process.
I am voting for a requirement that seems to be missing in others but is
satisfied in this one. Just want to make sure you hear all requests.
Thanks for shepherding the JDBC feature. Will wait for it in the main
branch. I'll help in anyway possible.
On Wed, 30 Dec 2015 at 19:47, Jongyoul Lee <no...@github.com> wrote:
> @vrajat <https://github.com/vrajat> And I also think JDBC interpreter
> supports all kind of JDBC drivers.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/apache/incubator-zeppelin/pull/361#issuecomment-168008003>
> .
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: JDBC generic interpreter
Posted by jiekechoo <gi...@git.apache.org>.
Github user jiekechoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/361#issuecomment-160135681
@jongyoul I mean how to use jdbc interpreter.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: JDBC generic interpreter
Posted by vgmartinez <gi...@git.apache.org>.
Github user vgmartinez commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/361#issuecomment-169696454
Hi @jongyoul,
I think it is not necessary to add another interpreter, I think you can improve the interpreter hive to add the jars to the classpath and use the hive interpreter for all jdbc. What do you think?
I tried your implementation in this [branch](https://github.com/vgmartinez/incubator-zeppelin/tree/jdbc_interpreter) and work for:
- postgres
- mysql
- mariadb
- redshift
I do not see useful to have another interpreter where the code is almost the same as the hive.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: JDBC generic interpreter
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/361#issuecomment-172530452
@tzolov Yes, It would be safe in general case, but in this case, because we drop postgresql interpreter only, I think it's ok that I just add postgresql interpreter. What do you think of it? And I agree what you told is a general rule.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: JDBC generic interpreter
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/361#issuecomment-172353917
@jongyoul Thanks for consideration. Please feel free to merge regardless of upcoming meetup. If i need, i can always use specific commit from git repository.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: JDBC generic interpreter
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/361#issuecomment-168004929
@vrajat Thanks for taking an interest in this issue and being willing to contribute your code. I have a plan to merge several jdbc-like interpreters until 0.6.0-incubating. For that, I'm trying to find PRs related JDBC and contacting contributors to track their contribution. Now, I'm trying to contact the contributor of #211 and this PR is next candidate if I'm not contacting that contributor. And I also think this implementation looks the best, but I think the former contribution should be tracked and accepted at first if that contributor is still willing to give his/her time to contribute. I hope you understand my thoughts and plans. Finally, I will merge additional features of #455 and #517 into jdbc implementation. Please wait a moment and Thank you again for concerning about this issue.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: JDBC generic interpreter
Posted by beeva-victorgarcia <gi...@git.apache.org>.
Github user beeva-victorgarcia commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/361#issuecomment-172525500
ok, no problem when I can add docs.
@jongyoul you move the generic jdbc and restore the PostgresQL Interprete?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: JDBC generic interpreter
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/361#issuecomment-170056833
I think postgresql is good candidate to be default, too. Leaving it undecided also good to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---