You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2022/10/26 13:45:39 UTC
[GitHub] [maven-plugin-tools] slawekjaranowski opened a new pull request, #161: [MPLUGIN-434] Improve dependency management
slawekjaranowski opened a new pull request, #161:
URL: https://github.com/apache/maven-plugin-tools/pull/161
- excludes in one place
- exclude plexus-container-default
- exclude plexus-component-api
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-plugin-tools] slawekjaranowski commented on a diff in pull request #161: [MPLUGIN-434] Improve dependency management
Posted by GitBox <gi...@apache.org>.
slawekjaranowski commented on code in PR #161:
URL: https://github.com/apache/maven-plugin-tools/pull/161#discussion_r1005767730
##########
maven-plugin-report-plugin/pom.xml:
##########
@@ -240,6 +237,7 @@
<maven.compiler.source>${maven.compiler.source}</maven.compiler.source>
<maven.compiler.target>${maven.compiler.target}</maven.compiler.target>
</properties>
+ <junitPackageName>maven.invoker.it.plugin.report</junitPackageName>
Review Comment:
Ok, not related.
It is used for package name of IT tests like
https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven-plugin-tools/job/master/lastCompletedBuild/testReport/maven.invoker.it/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-plugin-tools] slawekjaranowski commented on a diff in pull request #161: [MPLUGIN-434] Improve dependency management
Posted by GitBox <gi...@apache.org>.
slawekjaranowski commented on code in PR #161:
URL: https://github.com/apache/maven-plugin-tools/pull/161#discussion_r1005770250
##########
maven-plugin-report-plugin/pom.xml:
##########
@@ -240,6 +237,7 @@
<maven.compiler.source>${maven.compiler.source}</maven.compiler.source>
<maven.compiler.target>${maven.compiler.target}</maven.compiler.target>
</properties>
+ <junitPackageName>maven.invoker.it.plugin.report</junitPackageName>
Review Comment:
removed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-plugin-tools] slawekjaranowski merged pull request #161: [MPLUGIN-434] Improve dependency management
Posted by GitBox <gi...@apache.org>.
slawekjaranowski merged PR #161:
URL: https://github.com/apache/maven-plugin-tools/pull/161
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-plugin-tools] gnodet commented on a diff in pull request #161: [MPLUGIN-434] Improve dependency management
Posted by GitBox <gi...@apache.org>.
gnodet commented on code in PR #161:
URL: https://github.com/apache/maven-plugin-tools/pull/161#discussion_r1005755280
##########
maven-plugin-report-plugin/pom.xml:
##########
@@ -240,6 +237,7 @@
<maven.compiler.source>${maven.compiler.source}</maven.compiler.source>
<maven.compiler.target>${maven.compiler.target}</maven.compiler.target>
</properties>
+ <junitPackageName>maven.invoker.it.plugin.report</junitPackageName>
Review Comment:
That looks unrelated. What is is used for ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org