[jira] [Commented] (AIRFLOW-6356) make cli only print output relevant to dag argument passed in rather than from any random dag in bag

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AIRFLOW-6356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17004840#comment-17004840 ] 

ASF GitHub Bot commented on AIRFLOW-6356:
-----------------------------------------

tooptoop4 commented on pull request #6951: [AIRFLOW-6356] clear/dag_state should not show logs from other dags
URL: https://github.com/apache/airflow/pull/6951
 
 
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [ ] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
     - https://issues.apache.org/jira/browse/AIRFLOW-XXX
     - In case you are fixing a typo in the documentation you can prepend your commit with \[AIRFLOW-XXX\], code changes always need a Jira issue.
     - In case you are proposing a fundamental code change, you need to create an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)).
     - In case you are adding a dependency, check if the license complies with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   
   ### Description
   
   - [ ] Here are some details about my PR, including screenshots of any UI changes:
   
   ### Tests
   
   - [ ] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
   
   ### Commits
   
   - [ ] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [ ] In case of new functionality, my PR adds documentation that describes how to use it.
     - All the public functions and the classes in the PR contain docstrings that explain what it does
     - If you implement backwards incompatible changes, please leave a note in the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so we can assign it to a appropriate release
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> make cli only print output relevant to dag argument passed in rather than from any random dag in bag
> ----------------------------------------------------------------------------------------------------
>
>                 Key: AIRFLOW-6356
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-6356
>             Project: Apache Airflow
>          Issue Type: Improvement
>          Components: cli, DAG
>    Affects Versions: 1.10.6
>            Reporter: t oo
>            Assignee: t oo
>            Priority: Major
>
> I have 5 different .py that each generate dynamic dags. One of the .py had a bug where it was printing exceptions for dagxyz instead of properly generating the dag. the other 4 .py were correctly generating other dags
>  
> now when I run airflow cli of 'get_state' dagabc I was not just getting the result for dagabc but also seeing the exception log printed related to  dagxyz! I am sure many other cli commands are affected since the log messages from OTHER dags in dagbag are not suppressed
>  
> [https://github.com/apache/airflow/blob/1.10.7/airflow/bin/cli.py#L589-L598]
> The cli boasts only getting the state of a DagRun returned, not exception logs from other DAGs!
>  
> |Returns the state of a DagRun at the command line.|
> | |>>> airflow dag_state tutorial 2015-01-01T00:00:00.000000|
> | |running|
> dag_state and clear commands are definitely impacted (the log shows 'Filling up the DagBag from' at folder level)
> trigger_dag command is not impacted  (the log shows 'Filling up the DagBag from' at .py level)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)