[jira] [Commented] (HADOOP-10661) Ineffective user/passsword check in FTPFileSystem#initialize()

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HADOOP-10661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14018079#comment-14018079 ] 

Hadoop QA commented on HADOOP-10661:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12648373/HADOOP-10661.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:red}-1 core tests{color}.  The patch failed these unit tests in hadoop-common-project/hadoop-common:

                  org.apache.hadoop.net.TestNetUtils

    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/4008//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/4008//console

This message is automatically generated.

> Ineffective user/passsword check in FTPFileSystem#initialize()
> --------------------------------------------------------------
>
>                 Key: HADOOP-10661
>                 URL: https://issues.apache.org/jira/browse/HADOOP-10661
>             Project: Hadoop Common
>          Issue Type: Bug
>            Reporter: Ted Yu
>            Assignee: Chen He
>            Priority: Minor
>         Attachments: HADOOP-10661.patch
>
>
> Here is related code:
> {code}
>       userAndPassword = (conf.get("fs.ftp.user." + host, null) + ":" + conf
>           .get("fs.ftp.password." + host, null));
>       if (userAndPassword == null) {
>         throw new IOException("Invalid user/passsword specified");
>       }
> {code}
> The intention seems to be checking that username / password should not be null.
> But due to the presence of colon, the above check is not effective.



--
This message was sent by Atlassian JIRA
(v6.2#6252)