You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by José Guilherme Vanz <gu...@gmail.com> on 2015/08/09 06:57:55 UTC
Review Request 37268: Style checker checking for { on newline
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37268/
-----------------------------------------------------------
Review request for mesos.
Repository: mesos
Description
-------
As requested in the issue MESOS-2578 the style checker now
verifies "{" on newline for class and methods declarations.
This commit contains the files changed in the stout project
Diffs
-----
3rdparty/libprocess/3rdparty/stout/include/stout/mac.hpp 30baa65837621a277cf9d1042a751bfe18004b05
Diff: https://reviews.apache.org/r/37268/diff/
Testing
-------
Thanks,
José Guilherme Vanz
Re: Review Request 37268: Style checker checking for { on newline
Posted by Jose Guilherme Vanz <gu...@gmail.com>.
> On Aug. 24, 2015, 8:34 p.m., Jose Guilherme Vanz wrote:
> > Ship It!
>
> Jose Guilherme Vanz wrote:
> Ops... sorry.
My "Ship it" is not valid. I'm the author... sorry
- Jose Guilherme
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37268/#review96194
-----------------------------------------------------------
On Aug. 12, 2015, 1:15 a.m., Jose Guilherme Vanz wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37268/
> -----------------------------------------------------------
>
> (Updated Aug. 12, 2015, 1:15 a.m.)
>
>
> Review request for mesos.
>
>
> Bugs: MESOS-2578
> https://issues.apache.org/jira/browse/MESOS-2578
>
>
> Repository: mesos
>
>
> Description
> -------
>
> As requested in the issue MESOS-2578 the style checker now
> verifies { on newline for class and methods declarations.
>
> This commit contains the files changed in the stout project
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/mac.hpp 30baa65837621a277cf9d1042a751bfe18004b05
>
> Diff: https://reviews.apache.org/r/37268/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jose Guilherme Vanz
>
>
Re: Review Request 37268: Style checker checking for { on newline
Posted by Jose Guilherme Vanz <gu...@gmail.com>.
> On Aug. 24, 2015, 8:34 p.m., Jose Guilherme Vanz wrote:
> > Ship It!
Ops... sorry.
- Jose Guilherme
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37268/#review96194
-----------------------------------------------------------
On Aug. 12, 2015, 1:15 a.m., Jose Guilherme Vanz wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37268/
> -----------------------------------------------------------
>
> (Updated Aug. 12, 2015, 1:15 a.m.)
>
>
> Review request for mesos.
>
>
> Bugs: MESOS-2578
> https://issues.apache.org/jira/browse/MESOS-2578
>
>
> Repository: mesos
>
>
> Description
> -------
>
> As requested in the issue MESOS-2578 the style checker now
> verifies { on newline for class and methods declarations.
>
> This commit contains the files changed in the stout project
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/mac.hpp 30baa65837621a277cf9d1042a751bfe18004b05
>
> Diff: https://reviews.apache.org/r/37268/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jose Guilherme Vanz
>
>
Re: Review Request 37268: Style checker checking for { on newline
Posted by Jose Guilherme Vanz <gu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37268/#review96194
-----------------------------------------------------------
Ship it!
Ship It!
- Jose Guilherme Vanz
On Aug. 12, 2015, 1:15 a.m., Jose Guilherme Vanz wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37268/
> -----------------------------------------------------------
>
> (Updated Aug. 12, 2015, 1:15 a.m.)
>
>
> Review request for mesos.
>
>
> Bugs: MESOS-2578
> https://issues.apache.org/jira/browse/MESOS-2578
>
>
> Repository: mesos
>
>
> Description
> -------
>
> As requested in the issue MESOS-2578 the style checker now
> verifies { on newline for class and methods declarations.
>
> This commit contains the files changed in the stout project
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/mac.hpp 30baa65837621a277cf9d1042a751bfe18004b05
>
> Diff: https://reviews.apache.org/r/37268/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jose Guilherme Vanz
>
>
Re: Review Request 37268: Style checker checking for { on newline
Posted by Jose Guilherme Vanz <gu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37268/
-----------------------------------------------------------
(Updated Nov. 17, 2015, 10:34 a.m.)
Review request for mesos.
Bugs: MESOS-2578
https://issues.apache.org/jira/browse/MESOS-2578
Repository: mesos
Description
-------
As requested in the issue MESOS-2578 the style checker now
verifies { on newline for class and methods declarations.
This commit contains the files changed in the stout project
Diffs
-----
3rdparty/libprocess/3rdparty/stout/include/stout/mac.hpp 30baa65837621a277cf9d1042a751bfe18004b05
Diff: https://reviews.apache.org/r/37268/diff/
Testing
-------
Thanks,
Jose Guilherme Vanz
Re: Review Request 37268: Style checker checking for { on newline
Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37268/#review96138
-----------------------------------------------------------
Ship it!
Ship It!
- Guangya Liu
On 八月 12, 2015, 1:15 a.m., Jose Guilherme Vanz wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37268/
> -----------------------------------------------------------
>
> (Updated 八月 12, 2015, 1:15 a.m.)
>
>
> Review request for mesos.
>
>
> Bugs: MESOS-2578
> https://issues.apache.org/jira/browse/MESOS-2578
>
>
> Repository: mesos
>
>
> Description
> -------
>
> As requested in the issue MESOS-2578 the style checker now
> verifies { on newline for class and methods declarations.
>
> This commit contains the files changed in the stout project
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/mac.hpp 30baa65837621a277cf9d1042a751bfe18004b05
>
> Diff: https://reviews.apache.org/r/37268/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jose Guilherme Vanz
>
>
Re: Review Request 37268: Style checker checking for { on newline
Posted by José Guilherme Vanz <gu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37268/
-----------------------------------------------------------
(Updated Aug. 12, 2015, 1:15 a.m.)
Review request for mesos.
Bugs: MESOS-2578
https://issues.apache.org/jira/browse/MESOS-2578
Repository: mesos
Description (updated)
-------
As requested in the issue MESOS-2578 the style checker now
verifies { on newline for class and methods declarations.
This commit contains the files changed in the stout project
Diffs
-----
3rdparty/libprocess/3rdparty/stout/include/stout/mac.hpp 30baa65837621a277cf9d1042a751bfe18004b05
Diff: https://reviews.apache.org/r/37268/diff/
Testing
-------
Thanks,
José Guilherme Vanz
Re: Review Request 37268: Style checker checking for { on newline
Posted by José Guilherme Vanz <gu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37268/
-----------------------------------------------------------
(Updated Aug. 12, 2015, 1:10 a.m.)
Review request for mesos.
Bugs: MESOS-2578
https://issues.apache.org/jira/browse/MESOS-2578
Repository: mesos
Description (updated)
-------
As requested in the issue MESOS-2578 the style checker now
verifies { on newline for class and methods declarations.
This commit contains the files changed in the stout project
Diffs
-----
3rdparty/libprocess/3rdparty/stout/include/stout/mac.hpp 30baa65837621a277cf9d1042a751bfe18004b05
Diff: https://reviews.apache.org/r/37268/diff/
Testing
-------
Thanks,
José Guilherme Vanz
Re: Review Request 37268: Style checker checking for { on newline
Posted by José Guilherme Vanz <gu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37268/
-----------------------------------------------------------
(Updated Aug. 10, 2015, 1:46 a.m.)
Review request for mesos.
Bugs: MESOS-2578
https://issues.apache.org/jira/browse/MESOS-2578
Repository: mesos
Description
-------
As requested in the issue MESOS-2578 the style checker now
verifies "{" on newline for class and methods declarations.
This commit contains the files changed in the stout project
Diffs
-----
3rdparty/libprocess/3rdparty/stout/include/stout/mac.hpp 30baa65837621a277cf9d1042a751bfe18004b05
Diff: https://reviews.apache.org/r/37268/diff/
Testing
-------
Thanks,
José Guilherme Vanz
Re: Review Request 37268: Style checker checking for { on newline
Posted by Jose Guilherme Vanz <gu...@gmail.com>.
> On Aug. 9, 2015, 11:28 p.m., Mesos ReviewBot wrote:
> > Bad patch!
> >
> > Reviews applied: [37266]
> >
> > Failed command: ./support/apply-review.sh -n -r 37266
> >
> > Error:
> > 2015-08-09 23:28:17 URL:https://reviews.apache.org/r/37266/diff/raw/ [8119/8119] -> "37266.patch" [1]
> > Traceback (most recent call last):
> > File "./support/jsonurl.py", line 25, in <module>
> > print data
> > UnicodeEncodeError: 'ascii' codec can't encode character u'\xe9' in position 3: ordinal not in range(128)
> > Successfully applied: Style checker checking for { on newline
> >
> > As requested in the issue MESOS-2578 the style checker now
> > verifies "{" on newline for class and methods declarations.
> >
> > This commit contains the files changed in the mesos project
> >
> >
> > Review: https://reviews.apache.org/r/37266
> > fatal: empty ident name (for <gu...@gmail.com>) not allowed
> > Failed to commit patch
>
> Jose Guilherme Vanz wrote:
> Solved. There is a issue with description with "
Actually, I discovered the real issue. There is an issue in the apply-review.sh. The script crashes because my name has "é". After I changed my name in the review board the script runs fine
- Jose Guilherme
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37268/#review94684
-----------------------------------------------------------
On Aug. 12, 2015, 1:15 a.m., Jose Guilherme Vanz wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37268/
> -----------------------------------------------------------
>
> (Updated Aug. 12, 2015, 1:15 a.m.)
>
>
> Review request for mesos.
>
>
> Bugs: MESOS-2578
> https://issues.apache.org/jira/browse/MESOS-2578
>
>
> Repository: mesos
>
>
> Description
> -------
>
> As requested in the issue MESOS-2578 the style checker now
> verifies { on newline for class and methods declarations.
>
> This commit contains the files changed in the stout project
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/mac.hpp 30baa65837621a277cf9d1042a751bfe18004b05
>
> Diff: https://reviews.apache.org/r/37268/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jose Guilherme Vanz
>
>
Re: Review Request 37268: Style checker checking for { on newline
Posted by José Guilherme Vanz <gu...@gmail.com>.
> On Aug. 9, 2015, 11:28 p.m., Mesos ReviewBot wrote:
> > Bad patch!
> >
> > Reviews applied: [37266]
> >
> > Failed command: ./support/apply-review.sh -n -r 37266
> >
> > Error:
> > 2015-08-09 23:28:17 URL:https://reviews.apache.org/r/37266/diff/raw/ [8119/8119] -> "37266.patch" [1]
> > Traceback (most recent call last):
> > File "./support/jsonurl.py", line 25, in <module>
> > print data
> > UnicodeEncodeError: 'ascii' codec can't encode character u'\xe9' in position 3: ordinal not in range(128)
> > Successfully applied: Style checker checking for { on newline
> >
> > As requested in the issue MESOS-2578 the style checker now
> > verifies "{" on newline for class and methods declarations.
> >
> > This commit contains the files changed in the mesos project
> >
> >
> > Review: https://reviews.apache.org/r/37266
> > fatal: empty ident name (for <gu...@gmail.com>) not allowed
> > Failed to commit patch
Solved. There is a issue with description with "
- José Guilherme
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37268/#review94684
-----------------------------------------------------------
On Aug. 12, 2015, 1:15 a.m., José Guilherme Vanz wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37268/
> -----------------------------------------------------------
>
> (Updated Aug. 12, 2015, 1:15 a.m.)
>
>
> Review request for mesos.
>
>
> Bugs: MESOS-2578
> https://issues.apache.org/jira/browse/MESOS-2578
>
>
> Repository: mesos
>
>
> Description
> -------
>
> As requested in the issue MESOS-2578 the style checker now
> verifies { on newline for class and methods declarations.
>
> This commit contains the files changed in the stout project
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/mac.hpp 30baa65837621a277cf9d1042a751bfe18004b05
>
> Diff: https://reviews.apache.org/r/37268/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> José Guilherme Vanz
>
>
Re: Review Request 37268: Style checker checking for { on newline
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37268/#review94684
-----------------------------------------------------------
Bad patch!
Reviews applied: [37266]
Failed command: ./support/apply-review.sh -n -r 37266
Error:
2015-08-09 23:28:17 URL:https://reviews.apache.org/r/37266/diff/raw/ [8119/8119] -> "37266.patch" [1]
Traceback (most recent call last):
File "./support/jsonurl.py", line 25, in <module>
print data
UnicodeEncodeError: 'ascii' codec can't encode character u'\xe9' in position 3: ordinal not in range(128)
Successfully applied: Style checker checking for { on newline
As requested in the issue MESOS-2578 the style checker now
verifies "{" on newline for class and methods declarations.
This commit contains the files changed in the mesos project
Review: https://reviews.apache.org/r/37266
fatal: empty ident name (for <gu...@gmail.com>) not allowed
Failed to commit patch
- Mesos ReviewBot
On Aug. 9, 2015, 4:57 a.m., José Guilherme Vanz wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37268/
> -----------------------------------------------------------
>
> (Updated Aug. 9, 2015, 4:57 a.m.)
>
>
> Review request for mesos.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> As requested in the issue MESOS-2578 the style checker now
> verifies "{" on newline for class and methods declarations.
>
> This commit contains the files changed in the stout project
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/mac.hpp 30baa65837621a277cf9d1042a751bfe18004b05
>
> Diff: https://reviews.apache.org/r/37268/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> José Guilherme Vanz
>
>