You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/08/11 06:36:04 UTC
[GitHub] [dolphinscheduler] sketchmind opened a new pull request, #11419: [Improvement-11386][UI] Concise the logic available for task action buttons
sketchmind opened a new pull request, #11419:
URL: https://github.com/apache/dolphinscheduler/pull/11419
<!--Thanks very much for contributing to Apache DolphinScheduler. Please review https://dolphinscheduler.apache.org/en-us/community/development/pull-request.html before opening a pull request.-->
## Purpose of the pull request
<!--(For example: This pull request adds checkstyle plugin).-->
Concise the logic available for task action buttons
close #11386
## Brief change log
<!--*(for example:)*
- *Add maven-checkstyle-plugin to root pom.xml*
-->
* Remove button instead of disable button
* Correct the value of releaseState in the compare statement
## Verify this pull request
<!--*(Please pick either of the following options)*-->
This pull request is code cleanup without any test coverage.
*(or)*
This pull request is already covered by existing tests, such as *(please describe tests)*.
(or)
This change added tests and can be verified as follows:
<!--*(example:)*
- *Added dolphinscheduler-dao tests for end-to-end.*
- *Added CronUtilsTest to verify the change.*
- *Manually verified the change by testing locally.* -->
(or)
If your pull request contain incompatible change, you should also add it to `docs/docs/en/guide/upgrede/incompatible.md`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] sketchmind commented on a diff in pull request #11419: [Improvement-11386][UI] Concise the logic available for task action buttons
Posted by GitBox <gi...@apache.org>.
sketchmind commented on code in PR #11419:
URL: https://github.com/apache/dolphinscheduler/pull/11419#discussion_r944064639
##########
dolphinscheduler-ui/src/views/projects/workflow/components/dag/dag-context-menu.tsx:
##########
@@ -131,36 +127,37 @@ export default defineComponent({
class={styles['dag-context-menu']}
style={{ left: `${this.left}px`, top: `${this.top}px` }}
>
- {this.startButtonDisplay && (
+ {this.startDisplay && (
<NButton
class={`${styles['menu-item']}`}
- disabled={this.startReadonly}
onClick={this.startRunning}
>
{t('project.node.start')}
</NButton>)
}
- <NButton
- class={`${styles['menu-item']}`}
- disabled={this.menuReadonly}
- onClick={this.handleEdit}
- >
- {t('project.node.edit')}
- </NButton>
- <NButton
- class={`${styles['menu-item']}`}
- disabled={this.menuReadonly}
- onClick={this.handleCopy}
- >
- {t('project.node.copy')}
- </NButton>
- <NButton
- class={`${styles['menu-item']}`}
- disabled={this.menuReadonly}
- onClick={this.handleDelete}
- >
- {t('project.node.delete')}
- </NButton>
+ {this.menuDisplay && (
+ <div
+ >
+ <NButton
+ class={`${styles['menu-item']}`}
+ onClick={this.handleEdit}
+ >
+ {t('project.node.edit')}
+ </NButton>
+ <NButton
+ class={`${styles['menu-item']}`}
+ onClick={this.handleCopy}
+ >
+ {t('project.node.copy')}
+ </NButton>
+ <NButton
+ class={`${styles['menu-item']}`}
+ onClick={this.handleDelete}
+ >
+ {t('project.node.delete')}
+ </NButton>
+ </div>
+ )}
Review Comment:
> The fragment element is better than div here.
Is a '<></>' element ok?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] Amy0104 merged pull request #11419: [Improvement-11386][UI] Concise the logic available for task action buttons
Posted by GitBox <gi...@apache.org>.
Amy0104 merged PR #11419:
URL: https://github.com/apache/dolphinscheduler/pull/11419
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] sonarcloud[bot] commented on pull request #11419: [Improvement-11386][UI] Concise the logic available for task action buttons
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #11419:
URL: https://github.com/apache/dolphinscheduler/pull/11419#issuecomment-1211650250
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=11419)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11419&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11419&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11419&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11419&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11419&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11419&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=11419&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=11419&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=11419&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11419&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11419&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11419&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=11419&metric=coverage&view=list) No Coverage information
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=11419&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=11419&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] sonarcloud[bot] commented on pull request #11419: [Improvement-11386][UI] Concise the logic available for task action buttons
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #11419:
URL: https://github.com/apache/dolphinscheduler/pull/11419#issuecomment-1211648876
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=11419)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11419&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11419&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11419&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11419&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11419&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11419&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=11419&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=11419&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=11419&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11419&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11419&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11419&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=11419&metric=coverage&view=list) No Coverage information
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=11419&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=11419&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] sonarcloud[bot] commented on pull request #11419: [Improvement-11386][UI] Concise the logic available for task action buttons
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #11419:
URL: https://github.com/apache/dolphinscheduler/pull/11419#issuecomment-1212679974
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=11419)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11419&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11419&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11419&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11419&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11419&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11419&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=11419&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=11419&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=11419&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11419&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11419&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11419&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=11419&metric=coverage&view=list) No Coverage information
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=11419&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=11419&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] Amy0104 commented on a diff in pull request #11419: [Improvement-11386][UI] Concise the logic available for task action buttons
Posted by GitBox <gi...@apache.org>.
Amy0104 commented on code in PR #11419:
URL: https://github.com/apache/dolphinscheduler/pull/11419#discussion_r944063039
##########
dolphinscheduler-ui/src/views/projects/workflow/components/dag/index.tsx:
##########
@@ -119,29 +119,29 @@ export default defineComponent({
})
// start button in the dag node menu
- const startReadonly = computed(() => {
+ const startDisplay = computed(() => {
if (props.definition) {
return (
route.name === 'workflow-definition-detail' &&
- props.definition!.processDefinition.releaseState === 'NOT_RELEASE'
+ props.definition!.processDefinition.releaseState === 'ONLINE'
)
} else {
return false
}
})
// other button in the dag node menu
- const menuReadonly = computed(() => {
+ const menuDisplay = computed(() => {
if (props.instance) {
return (
- props.instance.state !== 'WAITING_THREAD' &&
- props.instance.state !== 'SUCCESS' &&
- props.instance.state !== 'PAUSE' &&
- props.instance.state !== 'FAILURE' &&
- props.instance.state !== 'STOP'
+ props.instance.state == 'WAITING_THREAD' ||
+ props.instance.state == 'SUCCESS' ||
+ props.instance.state == 'PAUSE' ||
+ props.instance.state == 'FAILURE' ||
+ props.instance.state == 'STOP'
Review Comment:
The strict equality is better here.
##########
dolphinscheduler-ui/src/views/projects/workflow/components/dag/dag-context-menu.tsx:
##########
@@ -131,36 +127,37 @@ export default defineComponent({
class={styles['dag-context-menu']}
style={{ left: `${this.left}px`, top: `${this.top}px` }}
>
- {this.startButtonDisplay && (
+ {this.startDisplay && (
<NButton
class={`${styles['menu-item']}`}
- disabled={this.startReadonly}
onClick={this.startRunning}
>
{t('project.node.start')}
</NButton>)
}
- <NButton
- class={`${styles['menu-item']}`}
- disabled={this.menuReadonly}
- onClick={this.handleEdit}
- >
- {t('project.node.edit')}
- </NButton>
- <NButton
- class={`${styles['menu-item']}`}
- disabled={this.menuReadonly}
- onClick={this.handleCopy}
- >
- {t('project.node.copy')}
- </NButton>
- <NButton
- class={`${styles['menu-item']}`}
- disabled={this.menuReadonly}
- onClick={this.handleDelete}
- >
- {t('project.node.delete')}
- </NButton>
+ {this.menuDisplay && (
+ <div
+ >
+ <NButton
+ class={`${styles['menu-item']}`}
+ onClick={this.handleEdit}
+ >
+ {t('project.node.edit')}
+ </NButton>
+ <NButton
+ class={`${styles['menu-item']}`}
+ onClick={this.handleCopy}
+ >
+ {t('project.node.copy')}
+ </NButton>
+ <NButton
+ class={`${styles['menu-item']}`}
+ onClick={this.handleDelete}
+ >
+ {t('project.node.delete')}
+ </NButton>
+ </div>
+ )}
Review Comment:
The fragment element is better than div here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] sonarcloud[bot] commented on pull request #11419: [Improvement-11386][UI] Concise the logic available for task action buttons
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #11419:
URL: https://github.com/apache/dolphinscheduler/pull/11419#issuecomment-1212680683
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=11419)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11419&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11419&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11419&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11419&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11419&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11419&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=11419&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=11419&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=11419&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11419&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11419&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11419&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=11419&metric=coverage&view=list) No Coverage information
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=11419&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=11419&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org