You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/09/29 19:57:36 UTC
[GitHub] [tvm] yelite commented on a diff in pull request #12895: [MetaSchedule] UX: Tuning API cleanup & developer ergonomics
yelite commented on code in PR #12895:
URL: https://github.com/apache/tvm/pull/12895#discussion_r983952886
##########
python/tvm/meta_schedule/utils.py:
##########
@@ -114,7 +113,10 @@ def __init__(self, *args, **kwargs):
def __getattr__(self, name: str):
"""Bridge the attribute function."""
- return self._inst.__getattribute__(name)
+ try:
+ return self._inst.__getattribute__(name)
+ except AttributeError:
+ return super(TVMDerivedObject, self).__getattr__(name)
Review Comment:
Not really related to the change here. But is it possible to make mypy treat DerivedObject as sub class of the real base class from `_tvm_metadata`? For example, right now `RPCRunner` is not a subclass of `Runner` from mypy's perspective.
##########
python/tvm/meta_schedule/logging.py:
##########
@@ -0,0 +1,262 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+"""Logging interface in MetaSchedule"""
+import logging
+import logging.config
+import os
+import os.path as osp
+from logging import Logger
+from typing import Any, Callable, Dict, List, Optional
+
+
+def get_logger(name: str) -> Logger:
+ """Create or get a logger by its name. This is essentially a wrapper of python's native logger.
+
+ Parameters
+ ----------
+ name : str
+ The name of the logger.
+
+ Returns
+ -------
+ logger : Logger
+ The logger instance.
+ """
+ return logging.getLogger(name)
+
+
+def make_logging_func(logger: Logger) -> Optional[Callable[[int, str], None]]:
+ """Get the logging function.
+
+ Parameters
+ ----------
+ logger : Logger
+ The logger instance.
+ Returns
+ -------
+ result : Optional[Callable]
+ The function to do the specified level of logging.
+ """
+ if logger is None:
+ return None
+
+ level2log = {
+ logging.DEBUG: logger.debug,
+ logging.INFO: logger.info,
+ logging.WARNING: logger.warning,
+ logging.ERROR: logger.error,
+ # logging.FATAL not included
+ }
+
+ def logging_func(level: int, msg: str):
+ def clear_notebook_output():
+ from IPython.display import ( # type: ignore # pylint: disable=import-outside-toplevel
+ clear_output,
+ )
+
+ clear_output(wait=True)
+
+ if level < 0:
+ clear_notebook_output()
Review Comment:
Will there be the case that `level < 0` while code isn't executed in notebook?
##########
python/tvm/meta_schedule/logging.py:
##########
@@ -0,0 +1,262 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+"""Logging interface in MetaSchedule"""
+import logging
+import logging.config
+import os
+import os.path as osp
+from logging import Logger
+from typing import Any, Callable, Dict, List, Optional
+
+
+def get_logger(name: str) -> Logger:
+ """Create or get a logger by its name. This is essentially a wrapper of python's native logger.
+
+ Parameters
+ ----------
+ name : str
+ The name of the logger.
+
+ Returns
+ -------
+ logger : Logger
+ The logger instance.
+ """
+ return logging.getLogger(name)
+
+
+def make_logging_func(logger: Logger) -> Optional[Callable[[int, str], None]]:
+ """Get the logging function.
+
+ Parameters
+ ----------
+ logger : Logger
+ The logger instance.
+ Returns
+ -------
+ result : Optional[Callable]
+ The function to do the specified level of logging.
+ """
+ if logger is None:
+ return None
+
+ level2log = {
+ logging.DEBUG: logger.debug,
+ logging.INFO: logger.info,
+ logging.WARNING: logger.warning,
+ logging.ERROR: logger.error,
+ # logging.FATAL not included
+ }
+
+ def logging_func(level: int, msg: str):
+ def clear_notebook_output():
+ from IPython.display import ( # type: ignore # pylint: disable=import-outside-toplevel
+ clear_output,
+ )
+
+ clear_output(wait=True)
+
+ if level < 0:
+ clear_notebook_output()
Review Comment:
Will this be better?
```suggestion
if level < 0:
from IPython.display import clear_output
clear_output(wait=True)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org