You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/10/27 09:04:44 UTC

[GitHub] [camel-kafka-connector] apupier opened a new issue #645: Include default and possible values in Catalog

apupier opened a new issue #645:
URL: https://github.com/apache/camel-kafka-connector/issues/645


   The Camel kafka Connector Catalog currently doesn't contain information on default values or possible values in case of enumeration.
   
   it would be nice to provide them so that tooling support can be improved by proposing them via completion.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel-kafka-connector] oscerd commented on issue #645: Include possible enum values in Catalog

Posted by GitBox <gi...@apache.org>.
oscerd commented on issue #645:
URL: https://github.com/apache/camel-kafka-connector/issues/645#issuecomment-742660775


   Should have been done.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel-kafka-connector] apupier edited a comment on issue #645: Include default and possible values in Catalog

Posted by GitBox <gi...@apache.org>.
apupier edited a comment on issue #645:
URL: https://github.com/apache/camel-kafka-connector/issues/645#issuecomment-741622671


   start looking at it.
   
   technical help provided by Andrea C.:
   
   > need to have a look at how the `defaultValue` are set in generic camel-catalog and modify the model we are using in ckc by including them into a default value field.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel-kafka-connector] apupier commented on issue #645: Include default and possible values in Catalog

Posted by GitBox <gi...@apache.org>.
apupier commented on issue #645:
URL: https://github.com/apache/camel-kafka-connector/issues/645#issuecomment-741654785


   in Core Camel Catalog, the values are provided in a field `enum`, for instance:
   
   https://github.com/apache/camel/blob/cffe3d077020cafee4ae39935c3e4c189a6976b8/catalog/camel-catalog/src/generated/resources/org/apache/camel/catalog/components/activemq.json#L30


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel-kafka-connector] apupier commented on issue #645: Include default and possible values in Catalog

Posted by GitBox <gi...@apache.org>.
apupier commented on issue #645:
URL: https://github.com/apache/camel-kafka-connector/issues/645#issuecomment-741651863


   default values are already provided:
   https://github.com/apache/camel-kafka-connector/blob/314eee947e6f9c979a9c1ddbcd5516c3f51b6539/camel-kafka-connector-catalog/src/main/java/org/apache/camel/kafkaconnector/catalog/CamelKafkaConnectorCatalog.java#L136
   https://github.com/apache/camel-kafka-connector/blob/314eee947e6f9c979a9c1ddbcd5516c3f51b6539/camel-kafka-connector-catalog/src/test/java/org/apache/camel/kafkaconnector/catalog/CamelKafkaConnectorCatalogTest.java#L81
   
   the missing part is the list of available enums


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel-kafka-connector] apupier edited a comment on issue #645: Include default and possible values in Catalog

Posted by GitBox <gi...@apache.org>.
apupier edited a comment on issue #645:
URL: https://github.com/apache/camel-kafka-connector/issues/645#issuecomment-741651863


   default values are already provided:
   https://github.com/apache/camel-kafka-connector/blob/314eee947e6f9c979a9c1ddbcd5516c3f51b6539/camel-kafka-connector-catalog/src/main/java/org/apache/camel/kafkaconnector/catalog/CamelKafkaConnectorCatalog.java#L136
   https://github.com/apache/camel-kafka-connector/blob/314eee947e6f9c979a9c1ddbcd5516c3f51b6539/camel-kafka-connector-catalog/src/test/java/org/apache/camel/kafkaconnector/catalog/CamelKafkaConnectorCatalogTest.java#L81
   
   and for instance:
   
   https://github.com/apache/camel-kafka-connector/blob/314eee947e6f9c979a9c1ddbcd5516c3f51b6539/camel-kafka-connector-catalog/src/generated/resources/connectors/camel-activemq-sink.json#L15
   
   the missing part is the list of available enums


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel-kafka-connector] oscerd closed issue #645: Include possible enum values in Catalog

Posted by GitBox <gi...@apache.org>.
oscerd closed issue #645:
URL: https://github.com/apache/camel-kafka-connector/issues/645


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel-kafka-connector] apupier commented on issue #645: Include default and possible values in Catalog

Posted by GitBox <gi...@apache.org>.
apupier commented on issue #645:
URL: https://github.com/apache/camel-kafka-connector/issues/645#issuecomment-741622671


   start looking at it.
   
   technical help provided by Andrea C.:
   `need to have a look at how the defaultValue are set in generic camel-catalog and modify the model we are using in ckc by including them into a default value field.`


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org