You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Ben Mahler <be...@gmail.com> on 2014/10/01 21:20:43 UTC
Review Request 26243: Fixed the flaky SlaveRecoverTest.MultipleSlaves.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26243/
-----------------------------------------------------------
Review request for mesos and Vinod Kone.
Bugs: MESOS-1854
https://issues.apache.org/jira/browse/MESOS-1854
Repository: mesos-git
Description
-------
The issue was that the test did not wait for the executor re-registration messages, so sometimes the slave would shutdown the executors.
I went through and cleaned up the other slave recovery tests in this respect.
Diffs
-----
src/tests/slave_recovery_tests.cpp c7c30d626a431cd2523e68f022bc9bdcc4b18262
Diff: https://reviews.apache.org/r/26243/diff/
Testing
-------
Ran in repetition.
Thanks,
Ben Mahler
Re: Review Request 26243: Fixed the flaky
SlaveRecoverTest.MultipleSlaves.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26243/#review55128
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On Oct. 1, 2014, 7:20 p.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26243/
> -----------------------------------------------------------
>
> (Updated Oct. 1, 2014, 7:20 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-1854
> https://issues.apache.org/jira/browse/MESOS-1854
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> The issue was that the test did not wait for the executor re-registration messages, so sometimes the slave would shutdown the executors.
>
> I went through and cleaned up the other slave recovery tests in this respect.
>
>
> Diffs
> -----
>
> src/tests/slave_recovery_tests.cpp c7c30d626a431cd2523e68f022bc9bdcc4b18262
>
> Diff: https://reviews.apache.org/r/26243/diff/
>
>
> Testing
> -------
>
> Ran in repetition.
>
>
> Thanks,
>
> Ben Mahler
>
>