[jira] [Commented] (KARAF-2347) Performance improvements for ConfigurationSupport class

["Jean-Baptiste Onofré (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KARAF-2347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13685637#comment-13685637 ] 

Jean-Baptiste Onofré commented on KARAF-2347:
---------------------------------------------

Not sure that the changes provides any kind of performance improvements ;)
However, the source seems lighter. I'm making a complete review.
                
> Performance improvements for ConfigurationSupport class 
> --------------------------------------------------------
>
>                 Key: KARAF-2347
>                 URL: https://issues.apache.org/jira/browse/KARAF-2347
>             Project: Karaf
>          Issue Type: Improvement
>          Components: cellar-config
>         Environment: Cellar 3.0.0-SNAPSHOT (As of now, should be based off head)
>            Reporter: Ryan Moquin
>            Assignee: Jean-Baptiste Onofré
>            Priority: Minor
>         Attachments: ConfigurationSupport.java.patch
>
>
> I've been making a lot of improvements to Cellar, but haven't finished what I'm trying to do in order to submit them.  I made a bunch of performance improvements to a class today that is isolated and thought would be worth submitting a patch for (one less class to be out of sync with on my side).  It's the org.apache.karaf.cellar.config.ConfigurationSupport class.  I'm attaching a patch file, in *most* cases I included comments to explain what I changed just to make it clear as to why I am proposing the change as better.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira