You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@hive.apache.org by "Chao (JIRA)" <ji...@apache.org> on 2014/07/31 19:23:39 UTC

[jira] [Commented] (HIVE-7561) StarterProject: Move from assert to Guava Preconditions.* in Hive on Spark

    [ https://issues.apache.org/jira/browse/HIVE-7561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14081150#comment-14081150 ] 

Chao commented on HIVE-7561:
----------------------------

Hi [~brocknoland], can you take a look at this? I'm not sure whether I should post it to review board or trigger precommit tests,
since it just a few simple changes.

> StarterProject: Move from assert to Guava Preconditions.* in Hive on Spark
> --------------------------------------------------------------------------
>
>                 Key: HIVE-7561
>                 URL: https://issues.apache.org/jira/browse/HIVE-7561
>             Project: Hive
>          Issue Type: Sub-task
>          Components: Spark
>    Affects Versions: spark-branch
>            Reporter: Brock Noland
>            Assignee: Chao
>              Labels: StarterProject
>         Attachments: HIVE-7561-spark.patch
>
>
> Hive uses the "assert" keyword all over the place. The problem is that assertions are rarely enabled since they have to be specifically enabled. In the Spark code, e.g. GenSparkUtils, let's use Preconditions.*.



--
This message was sent by Atlassian JIRA
(v6.2#6252)