[GitHub] [pulsar] tuteng edited a comment on pull request #11557: [C++] Fix bugs that were not exposed by broken C++ CI before

[GitBox <gi...@apache.org>]

tuteng edited a comment on pull request #11557:
URL: https://github.com/apache/pulsar/pull/11557#issuecomment-892623460


   The website build ran into the same issue, and I think it's the new syntax of python3  type annotations https://docs.python.org/3/library/typing.html, I think we can remove the type annotation to make sure it works in both python2 and python3
   
   ```
   def encode_dict(self, d):
       obj = {}
       if isinstance(d, dict):
           for k, v in d.items():
               obj[k] = self._get_serialized_value(v)
       return obj
   ```
   
   @gaoran10 Would this work?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org