You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@samza.apache.org by GitBox <gi...@apache.org> on 2019/06/04 22:27:14 UTC

[GitHub] [samza] rmatharu commented on a change in pull request #1065: SAMZA-2233: Allow overriding descriptor generated task.inputs using configs

rmatharu commented on a change in pull request #1065: SAMZA-2233: Allow overriding descriptor generated task.inputs using configs
URL: https://github.com/apache/samza/pull/1065#discussion_r290521246
 
 

 ##########
 File path: samza-core/src/main/java/org/apache/samza/execution/JobPlanner.java
 ##########
 @@ -78,10 +78,8 @@ ExecutionPlan getExecutionPlan(String runId) {
     // TODO: This should all be consolidated with ExecutionPlanner after fixing SAMZA-1811
     // Don't generate any configurations for LegacyTaskApplications
     if (!LegacyTaskApplication.class.isAssignableFrom(appDesc.getAppClass())) {
-      if (userConfig.containsKey(TaskConfig.INPUT_STREAMS())) {
-        LOG.warn("SamzaApplications should not specify task.inputs in configuration. " +
-            "Specify them using InputDescriptors instead. Ignoring configured task.inputs value of " +
-            userConfig.get(TaskConfig.INPUT_STREAMS()));
+      // Don't allow overriding task.inputs to a blank string
+      if (StringUtils.isBlank(userConfig.get(TaskConfig.INPUT_STREAMS()))) {
 
 Review comment:
   Why is this check required?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services