You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Hiroaki Kawai <ka...@stratosphere.co.jp> on 2013/03/06 06:46:09 UTC
Review Request: Remove invalid use of library internal class found in
vmware-base
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9768/
-----------------------------------------------------------
Review request for cloudstack.
Description
-------
com.cloud.hypervisor.vmware.util.VmwareContext is imports com.sun.xml.internal.ws.transport.http.client.CookieJar, but it must not do so, because it is an library internal class.
This addresses bug CLOUDSTACK-1529.
Diffs
-----
vmware-base/src/com/cloud/hypervisor/vmware/util/VmwareClient.java 344fbdd
vmware-base/src/com/cloud/hypervisor/vmware/util/VmwareContext.java 091ce77
Diff: https://reviews.apache.org/r/9768/diff/
Testing
-------
Thanks,
Hiroaki Kawai
Re: Review Request: Remove invalid use of library internal class found in
vmware-base
Posted by Rajesh Battala <ra...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9768/#review17461
-----------------------------------------------------------
Thanks for the patch,
My build is success after applying your patch.
- Rajesh Battala
On March 6, 2013, 5:46 a.m., Hiroaki Kawai wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9768/
> -----------------------------------------------------------
>
> (Updated March 6, 2013, 5:46 a.m.)
>
>
> Review request for cloudstack.
>
>
> Description
> -------
>
> com.cloud.hypervisor.vmware.util.VmwareContext is imports com.sun.xml.internal.ws.transport.http.client.CookieJar, but it must not do so, because it is an library internal class.
>
>
> This addresses bug CLOUDSTACK-1529.
>
>
> Diffs
> -----
>
> vmware-base/src/com/cloud/hypervisor/vmware/util/VmwareClient.java 344fbdd
> vmware-base/src/com/cloud/hypervisor/vmware/util/VmwareContext.java 091ce77
>
> Diff: https://reviews.apache.org/r/9768/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Hiroaki Kawai
>
>
Re: Review Request: Remove invalid use of library internal class found in
vmware-base
Posted by Min Chen <mi...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9768/#review17462
-----------------------------------------------------------
Ship it!
Ship It!
- Min Chen
On March 6, 2013, 6:13 a.m., Hiroaki Kawai wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9768/
> -----------------------------------------------------------
>
> (Updated March 6, 2013, 6:13 a.m.)
>
>
> Review request for cloudstack.
>
>
> Description
> -------
>
> com.cloud.hypervisor.vmware.util.VmwareContext is imports com.sun.xml.internal.ws.transport.http.client.CookieJar, but it must not do so, because it is an library internal class.
>
>
> This addresses bug CLOUDSTACK-1529.
>
>
> Diffs
> -----
>
> vmware-base/src/com/cloud/hypervisor/vmware/util/VmwareClient.java 344fbdd
> vmware-base/src/com/cloud/hypervisor/vmware/util/VmwareContext.java 091ce77
>
> Diff: https://reviews.apache.org/r/9768/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Hiroaki Kawai
>
>
Re: Review Request: Remove invalid use of library internal class found in
vmware-base
Posted by Min Chen <mi...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9768/#review17463
-----------------------------------------------------------
Commit to master branch 0fd30af5f87a0c3f1eb9496a2c0a409d7987028b.
- Min Chen
On March 6, 2013, 6:13 a.m., Hiroaki Kawai wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9768/
> -----------------------------------------------------------
>
> (Updated March 6, 2013, 6:13 a.m.)
>
>
> Review request for cloudstack.
>
>
> Description
> -------
>
> com.cloud.hypervisor.vmware.util.VmwareContext is imports com.sun.xml.internal.ws.transport.http.client.CookieJar, but it must not do so, because it is an library internal class.
>
>
> This addresses bug CLOUDSTACK-1529.
>
>
> Diffs
> -----
>
> vmware-base/src/com/cloud/hypervisor/vmware/util/VmwareClient.java 344fbdd
> vmware-base/src/com/cloud/hypervisor/vmware/util/VmwareContext.java 091ce77
>
> Diff: https://reviews.apache.org/r/9768/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Hiroaki Kawai
>
>
Re: Review Request: Remove invalid use of library internal class found in
vmware-base
Posted by Hiroaki Kawai <ka...@stratosphere.co.jp>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9768/
-----------------------------------------------------------
(Updated March 6, 2013, 6:13 a.m.)
Review request for cloudstack.
Changes
-------
For trailing whitespace, I removed. But for tab indent, what can I do? Current VmwareContext has already mixed tab/space indent.
Description
-------
com.cloud.hypervisor.vmware.util.VmwareContext is imports com.sun.xml.internal.ws.transport.http.client.CookieJar, but it must not do so, because it is an library internal class.
This addresses bug CLOUDSTACK-1529.
Diffs (updated)
-----
vmware-base/src/com/cloud/hypervisor/vmware/util/VmwareClient.java 344fbdd
vmware-base/src/com/cloud/hypervisor/vmware/util/VmwareContext.java 091ce77
Diff: https://reviews.apache.org/r/9768/diff/
Testing
-------
Thanks,
Hiroaki Kawai
Re: Review Request: Remove invalid use of library internal class found in
vmware-base
Posted by Rajesh Battala <ra...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9768/#review17460
-----------------------------------------------------------
I was trying to apply this patch got below errors.
vmwareissue.patch:46: trailing whitespace.
new CookieOrigin(urlUrl.getHost(), urlUrl.getPort(),
vmwareissue.patch:53: trailing whitespace.
vmwareissue.patch:89: tab in indent.
String cookie = _vimClient.getServiceCookie();
vmwareissue.patch:104: tab in indent.
String cookie = _vimClient.getServiceCookie();
vmwareissue.patch:113: tab in indent.
conn.addRequestProperty("Cookie", cookie);
warning: 5 lines add whitespace errors.
- Rajesh Battala
On March 6, 2013, 5:46 a.m., Hiroaki Kawai wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9768/
> -----------------------------------------------------------
>
> (Updated March 6, 2013, 5:46 a.m.)
>
>
> Review request for cloudstack.
>
>
> Description
> -------
>
> com.cloud.hypervisor.vmware.util.VmwareContext is imports com.sun.xml.internal.ws.transport.http.client.CookieJar, but it must not do so, because it is an library internal class.
>
>
> This addresses bug CLOUDSTACK-1529.
>
>
> Diffs
> -----
>
> vmware-base/src/com/cloud/hypervisor/vmware/util/VmwareClient.java 344fbdd
> vmware-base/src/com/cloud/hypervisor/vmware/util/VmwareContext.java 091ce77
>
> Diff: https://reviews.apache.org/r/9768/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Hiroaki Kawai
>
>
Re: Review Request: Remove invalid use of library internal class found in
vmware-base
Posted by Hiroaki Kawai <ka...@stratosphere.co.jp>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9768/
-----------------------------------------------------------
(Updated March 6, 2013, 5:46 a.m.)
Review request for cloudstack.
Description
-------
com.cloud.hypervisor.vmware.util.VmwareContext is imports com.sun.xml.internal.ws.transport.http.client.CookieJar, but it must not do so, because it is an library internal class.
This addresses bug CLOUDSTACK-1529.
Diffs
-----
vmware-base/src/com/cloud/hypervisor/vmware/util/VmwareClient.java 344fbdd
vmware-base/src/com/cloud/hypervisor/vmware/util/VmwareContext.java 091ce77
Diff: https://reviews.apache.org/r/9768/diff/
Testing
-------
Thanks,
Hiroaki Kawai