[GitHub] [incubator-superset] nytai commented on a change in pull request #10416: feat(checkbox): update checkbox to sip-34 design

[GitBox <gi...@apache.org>]

nytai commented on a change in pull request #10416:
URL: https://github.com/apache/incubator-superset/pull/10416#discussion_r459731645



##########
File path: superset-frontend/src/components/Checkbox.jsx
##########
@@ -32,15 +32,17 @@ export default function Checkbox({ checked, onChange, style }) {
         role="button"
         tabIndex={0}
         className={`fa fa-check ${
-          checked ? 'text-primary' : 'text-transparent'
+          checked ? 'text-white' : 'text-transparent'
         }`}
         onClick={() => {
           onChange(!checked);
         }}
         style={{
-          border: '1px solid #aaa',
+          border: `${checked ? '1px solid #20A7C9' : '1px solid #aaa'}`,
           borderRadius: '2px',
           cursor: 'pointer',
+          boxShaddow: 'inset 1px 0px 0px #E0E0E0',
+          backgroundColor: `${checked ? '#20A7C9' : 'transparent'}` 

Review comment:
       I didn't realize this component exists. Thoughts on deprecating this in favor of https://github.com/preset-io/incubator-superset/blob/master/superset-frontend/src/components/IndeterminateCheckbox.tsx which is using the new Icon component and emotion styles?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org