You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/11/27 11:56:46 UTC
[GitHub] [airflow] kaxil opened a new pull request #12652: Add 1.10.13 to CI, Breeze and Docs
kaxil opened a new pull request #12652:
URL: https://github.com/apache/airflow/pull/12652
This commit will allow users to install Airflow 1.10.13 via Breeze. Also updates docs
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] XD-DENG commented on a change in pull request #12652: Add 1.10.13 to CI, Breeze and Docs
Posted by GitBox <gi...@apache.org>.
XD-DENG commented on a change in pull request #12652:
URL: https://github.com/apache/airflow/pull/12652#discussion_r531568262
##########
File path: README.md
##########
@@ -123,15 +123,15 @@ correct Airflow tag/version/branch and python versions in the URL.
1. Installing just Airflow:
```bash
-pip install apache-airflow==1.10.12 \
- --constraint "https://raw.githubusercontent.com/apache/airflow/constraints-1.10.12/constraints-3.7.txt"
+pip install apache-airflow==1.10.13 \
Review comment:
On phone so not adding comments at the exact code lines. Sorry for that
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on a change in pull request #12652: Add 1.10.13 to CI, Breeze and Docs
Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #12652:
URL: https://github.com/apache/airflow/pull/12652#discussion_r531570681
##########
File path: README.md
##########
@@ -123,15 +123,15 @@ correct Airflow tag/version/branch and python versions in the URL.
1. Installing just Airflow:
```bash
-pip install apache-airflow==1.10.12 \
- --constraint "https://raw.githubusercontent.com/apache/airflow/constraints-1.10.12/constraints-3.7.txt"
+pip install apache-airflow==1.10.13 \
Review comment:
L117 says that the change was introduced in 1.10.12 :) hence I have not changed that.
Updated the dockerfiles in `docs/production-deployment.rst` to use 1.10.13 in e6db852
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] XD-DENG commented on a change in pull request #12652: Add 1.10.13 to CI, Breeze and Docs
Posted by GitBox <gi...@apache.org>.
XD-DENG commented on a change in pull request #12652:
URL: https://github.com/apache/airflow/pull/12652#discussion_r531562071
##########
File path: README.md
##########
@@ -123,15 +123,15 @@ correct Airflow tag/version/branch and python versions in the URL.
1. Installing just Airflow:
```bash
-pip install apache-airflow==1.10.12 \
- --constraint "https://raw.githubusercontent.com/apache/airflow/constraints-1.10.12/constraints-3.7.txt"
+pip install apache-airflow==1.10.13 \
Review comment:
shall line 117 in README to be updated as well? Similar to the change done in `docs/installation.rst`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil merged pull request #12652: Add 1.10.13 to CI, Breeze and Docs
Posted by GitBox <gi...@apache.org>.
kaxil merged pull request #12652:
URL: https://github.com/apache/airflow/pull/12652
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] XD-DENG commented on a change in pull request #12652: Add 1.10.13 to CI, Breeze and Docs
Posted by GitBox <gi...@apache.org>.
XD-DENG commented on a change in pull request #12652:
URL: https://github.com/apache/airflow/pull/12652#discussion_r531563556
##########
File path: README.md
##########
@@ -123,15 +123,15 @@ correct Airflow tag/version/branch and python versions in the URL.
1. Installing just Airflow:
```bash
-pip install apache-airflow==1.10.12 \
- --constraint "https://raw.githubusercontent.com/apache/airflow/constraints-1.10.12/constraints-3.7.txt"
+pip install apache-airflow==1.10.13 \
Review comment:
In addition, in `docs/production-deployment.rst`, there are three sample Dockerfiles are using `FROM apache/airflow:1.10.12`. Should they be updated as well?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #12652: Add 1.10.13 to CI, Breeze and Docs
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12652:
URL: https://github.com/apache/airflow/pull/12652#issuecomment-734817291
[The Workflow run](https://github.com/apache/airflow/actions/runs/387060602) is cancelling this PR. Building images for the PR has failed. Follow the the workflow link to check the reason.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #12652: Add 1.10.13 to CI, Breeze and Docs
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12652:
URL: https://github.com/apache/airflow/pull/12652#issuecomment-734801732
The PR needs to run all tests because it modifies core of Airflow! Please rebase it to latest master or ask committer to re-run it!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org