You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hbase.apache.org by Andrew Purtell <ap...@apache.org> on 2017/11/06 18:37:54 UTC
branch-2 build broken?
Lars was having trouble building branch-2. If you wipe
~/.m2/repository/org/apache/hbase and try to build latest head of branch-2,
this is the result:
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-compiler-plugin:3.6.1:compile
(default-compile) on project hbase-mapreduce: Compilation failure
[ERROR]
/Users/apurtell/src/hbase/hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/Import.java:[168,32]
package CellComparatorImpl does not exist
Just us?
--
Best regards,
Andrew
Re: branch-2 build broken?
Posted by Sean Busbey <se...@gmail.com>.
sounds like a dependency error. can you post a full log somewhere for me to see?
On Mon, Nov 6, 2017 at 12:37 PM, Andrew Purtell <ap...@apache.org> wrote:
> Lars was having trouble building branch-2. If you wipe
> ~/.m2/repository/org/apache/hbase and try to build latest head of branch-2,
> this is the result:
>
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-compiler-plugin:3.6.1:compile
> (default-compile) on project hbase-mapreduce: Compilation failure
> [ERROR]
> /Users/apurtell/src/hbase/hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/Import.java:[168,32]
> package CellComparatorImpl does not exist
>
> Just us?
>
>
> --
> Best regards,
> Andrew
--
Sean
Re: branch-2 build broken?
Posted by Andrew Purtell <ap...@apache.org>.
Thanks Ted!
On Mon, Nov 6, 2017 at 11:08 AM, Ted Yu <yu...@gmail.com> wrote:
> I attached addendum to HBASE-19160 which fixes the build.
>
> Let's continue over HBASE-19160.
>
> On Mon, Nov 6, 2017 at 10:57 AM, Mike Drob <md...@apache.org> wrote:
>
> > I will have time to look in about an hour. CellComparatorImpl.COMPARATOR
> > never went away, maybe I screwed up the imports there though?
> >
> > On Mon, Nov 6, 2017 at 12:49 PM, Ted Yu <yu...@gmail.com> wrote:
> >
> > > As of commit cfddfcf23cc38161da70bfe965b8e7b6e0581711 , the reference
> > > to CellComparatorImpl should be replaced.
> > >
> > > - return CellComparatorImpl.COMPARATOR.compare(this.kv,
> > > ((CellWritableComparable)o).kv);
> > > + return CellComparator.getInstance().compare(this.kv, o.kv);
> > >
> > > Looks like Mike forgot to change line 168 over HBASE-19160 for branch
> > > hbase-2
> > >
> >
>
--
Best regards,
Andrew
Words like orphans lost among the crosstalk, meaning torn from truth's
decrepit hands
- A23, Crosstalk
Re: branch-2 build broken?
Posted by Ted Yu <yu...@gmail.com>.
I attached addendum to HBASE-19160 which fixes the build.
Let's continue over HBASE-19160.
On Mon, Nov 6, 2017 at 10:57 AM, Mike Drob <md...@apache.org> wrote:
> I will have time to look in about an hour. CellComparatorImpl.COMPARATOR
> never went away, maybe I screwed up the imports there though?
>
> On Mon, Nov 6, 2017 at 12:49 PM, Ted Yu <yu...@gmail.com> wrote:
>
> > As of commit cfddfcf23cc38161da70bfe965b8e7b6e0581711 , the reference
> > to CellComparatorImpl should be replaced.
> >
> > - return CellComparatorImpl.COMPARATOR.compare(this.kv,
> > ((CellWritableComparable)o).kv);
> > + return CellComparator.getInstance().compare(this.kv, o.kv);
> >
> > Looks like Mike forgot to change line 168 over HBASE-19160 for branch
> > hbase-2
> >
>
Re: branch-2 build broken?
Posted by Mike Drob <md...@apache.org>.
I will have time to look in about an hour. CellComparatorImpl.COMPARATOR
never went away, maybe I screwed up the imports there though?
On Mon, Nov 6, 2017 at 12:49 PM, Ted Yu <yu...@gmail.com> wrote:
> As of commit cfddfcf23cc38161da70bfe965b8e7b6e0581711 , the reference
> to CellComparatorImpl should be replaced.
>
> - return CellComparatorImpl.COMPARATOR.compare(this.kv,
> ((CellWritableComparable)o).kv);
> + return CellComparator.getInstance().compare(this.kv, o.kv);
>
> Looks like Mike forgot to change line 168 over HBASE-19160 for branch
> hbase-2
>
Re: branch-2 build broken?
Posted by Ted Yu <yu...@gmail.com>.
As of commit cfddfcf23cc38161da70bfe965b8e7b6e0581711 , the reference
to CellComparatorImpl should be replaced.
- return CellComparatorImpl.COMPARATOR.compare(this.kv,
((CellWritableComparable)o).kv);
+ return CellComparator.getInstance().compare(this.kv, o.kv);
Looks like Mike forgot to change line 168 over HBASE-19160 for branch
hbase-2