You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by "ntheanh201 (via GitHub)" <gi...@apache.org> on 2023/10/24 03:03:04 UTC
[PR] increase state character limit to 4 [trafficcontrol]
ntheanh201 opened a new pull request, #7846:
URL: https://github.com/apache/trafficcontrol/pull/7846
Closes: #6983
Increase state character limit to 4
<hr/>
## Which Traffic Control components are affected by this PR?
- Traffic Portal
## What is the best way to verify this PR?
<!-- Please include here ALL the steps necessary to test your PR.
If your PR has tests (and most should), provide the steps needed to run the tests.
If not, please provide step-by-step instructions to test the PR manually and explain why your PR does not need tests. -->
- Step 1: Go to Topology/Phys Locations
- Step 2: Create/Update Phys Location
## If this is a bugfix, which Traffic Control versions contained the bug?
<!-- Delete this section if the PR is not a bugfix, or if the bug is only in the master branch.
Examples:
- 5.1.2
- 5.1.3 (RC1)
-->
## PR submission checklist
- [x] This PR has tests <!-- If not, please delete this text and explain why this PR does not need tests. -->
- [x] This PR has documentation <!-- If not, please delete this text and explain why this PR does not need documentation. -->
- [x] This PR has a CHANGELOG.md entry <!-- A fix for a bug from an ATC release, an improvement, or a new feature should have a changelog entry. -->
- [x] This PR **DOES NOT FIX A SERIOUS SECURITY VULNERABILITY** (see [the Apache Software Foundation's security guidelines](https://apache.org/security) for details)
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] increase state character limit to 4 [trafficcontrol]
Posted by "ntheanh201 (via GitHub)" <gi...@apache.org>.
ntheanh201 commented on code in PR #7846:
URL: https://github.com/apache/trafficcontrol/pull/7846#discussion_r1379746734
##########
traffic_portal/app/src/common/modules/form/physLocation/FormPhysLocationController.js:
##########
@@ -42,7 +42,7 @@ var FormPhysLocationController = function(physLocation, $scope, $location, formU
{ name: 'shortName', type: 'text', required: true, maxLength: 100 },
{ name: 'address', type: 'text', required: true, maxLength: 128 },
{ name: 'city', type: 'text', required: true, maxLength: 128 },
- { name: 'state', type: 'text', required: true, maxLength: 2 },
+ { name: 'state', type: 'text', required: true, maxLength: 4 },
Review Comment:
Should we also set the limit in Traffic Ops API?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] increase state character limit to 4 [trafficcontrol]
Posted by "ocket8888 (via GitHub)" <gi...@apache.org>.
ocket8888 commented on code in PR #7846:
URL: https://github.com/apache/trafficcontrol/pull/7846#discussion_r1379097325
##########
traffic_portal/app/src/common/modules/form/physLocation/FormPhysLocationController.js:
##########
@@ -42,7 +42,7 @@ var FormPhysLocationController = function(physLocation, $scope, $location, formU
{ name: 'shortName', type: 'text', required: true, maxLength: 100 },
{ name: 'address', type: 'text', required: true, maxLength: 128 },
{ name: 'city', type: 'text', required: true, maxLength: 128 },
- { name: 'state', type: 'text', required: true, maxLength: 2 },
+ { name: 'state', type: 'text', required: true, maxLength: 4 },
Review Comment:
This should match the limitations set by the API - and currently there is no max length in the API. You might arbitrarily choose something huge like 255 but 5+ characters is actually totally valid and our front-end ought to model that more accurately.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] increase state character limit to 4 [trafficcontrol]
Posted by "mitchell852 (via GitHub)" <gi...@apache.org>.
mitchell852 merged PR #7846:
URL: https://github.com/apache/trafficcontrol/pull/7846
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] increase state character limit to 4 [trafficcontrol]
Posted by "ocket8888 (via GitHub)" <gi...@apache.org>.
ocket8888 commented on code in PR #7846:
URL: https://github.com/apache/trafficcontrol/pull/7846#discussion_r1388802581
##########
traffic_portal/app/src/common/modules/form/physLocation/FormPhysLocationController.js:
##########
@@ -42,7 +42,7 @@ var FormPhysLocationController = function(physLocation, $scope, $location, formU
{ name: 'shortName', type: 'text', required: true, maxLength: 100 },
{ name: 'address', type: 'text', required: true, maxLength: 128 },
{ name: 'city', type: 'text', required: true, maxLength: 128 },
- { name: 'state', type: 'text', required: true, maxLength: 2 },
+ { name: 'state', type: 'text', required: true, maxLength: 4 },
Review Comment:
You could do that, but that would be a breaking API change which would necessitate an APIv6, deprecation strategy, and a plan on how to eventually migrate old data to the new, more restrictive format.
It'd be a lot less work to just eliminate the requirement altogether in the UI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org