You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@gump.apache.org by bs...@apache.org on 2007/06/20 17:00:21 UTC
svn commit: r549123 - /gump/metadata/project/jakarta-commons.xml
Author: bspeakmon
Date: Wed Jun 20 08:00:20 2007
New Revision: 549123
URL: http://svn.apache.org/viewvc?view=rev&rev=549123
Log:
- fixed commons-email jar output name
Modified:
gump/metadata/project/jakarta-commons.xml
Modified: gump/metadata/project/jakarta-commons.xml
URL: http://svn.apache.org/viewvc/gump/metadata/project/jakarta-commons.xml?view=diff&rev=549123&r1=549122&r2=549123
==============================================================================
--- gump/metadata/project/jakarta-commons.xml (original)
+++ gump/metadata/project/jakarta-commons.xml Wed Jun 20 08:00:20 2007
@@ -425,7 +425,6 @@
<description>Commons Email Package</description>
<mvn basedir="email" goal="package">
- <property name="project.build.finalName" value="commons-email-@@DATE@@"/>
<depend project="javamail" property="maven.jar.mail" id="javamail" />
</mvn>
Re: svn commit: r549123 - /gump/metadata/project/jakarta-commons.xml
Posted by Niall Pemberton <ni...@gmail.com>.
On 6/20/07, Niall Pemberton <ni...@gmail.com> wrote:
> On 6/20/07, Ben Speakmon <bs...@apache.org> wrote:
> > I thought I was copying bcel too. I'm confused because bcel has the @@DATE@@
> > tag in its project.build.finalName, but the <jar> points to 5.3-SNAPSHOT.
>
> Good point - looks like that property has no effect - so maybe you're right
...but I think you will need to change the jar config
<jar name="target/commons-email-1.1-SNAPSHOT"/>
...and probably specify an id - I'm guess that would mean downstream
dependencies wouldn't have to change every time the version gets
incremented. Not quite sure about the id but I'll try to look at other
examples to try and work out the affect it has
Niall
> Niall
>
> > I'll back out the change.
> >
> > On 6/20/07, Niall Pemberton <ni...@gmail.com> wrote:
> > >
> > > I believe I had corrected the gump problem by amending the property
> > > for the jar name earlier (by copying what the bcel m2 gump config
> > > had):
> > >
> > > http://svn.apache.org/viewvc?view=rev&revision=549101
> > >
> > > ...and I can't see any reason to completely remove since I believe
> > > gump will fail with the same error as the last run anyway - since the
> > > config has:
> > >
> > > <jar name="commons-email-@@DATE@@.jar"/>
> > >
> > > Niall
> > >
> > > On 6/20/07, bspeakmon@apache.org <bs...@apache.org> wrote:
> > > > Author: bspeakmon
> > > > Date: Wed Jun 20 08:00:20 2007
> > > > New Revision: 549123
> > > >
> > > > URL: http://svn.apache.org/viewvc?view=rev&rev=549123
> > > > Log:
> > > > - fixed commons-email jar output name
> > > >
> > > > Modified:
> > > > gump/metadata/project/jakarta-commons.xml
> > > >
> > > > Modified: gump/metadata/project/jakarta-commons.xml
> > > > URL:
> > > http://svn.apache.org/viewvc/gump/metadata/project/jakarta-commons.xml?view=diff&rev=549123&r1=549122&r2=549123
> > > >
> > > ==============================================================================
> > > > --- gump/metadata/project/jakarta-commons.xml (original)
> > > > +++ gump/metadata/project/jakarta-commons.xml Wed Jun 20 08:00:20 2007
> > > > @@ -425,7 +425,6 @@
> > > > <description>Commons Email Package</description>
> > > >
> > > > <mvn basedir="email" goal="package">
> > > > - <property name="project.build.finalName"
> > > value="commons-email-@@DATE@@"/>
> > > > <depend project="javamail" property="maven.jar.mail"
> > > id="javamail" />
> > > > </mvn>
> > >
> > > ---------------------------------------------------------------------
> > > To unsubscribe, e-mail: general-unsubscribe@gump.apache.org
> > > For additional commands, e-mail: general-help@gump.apache.org
> > >
> > >
> >
>
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@gump.apache.org
For additional commands, e-mail: general-help@gump.apache.org
Re: svn commit: r549123 - /gump/metadata/project/jakarta-commons.xml
Posted by Niall Pemberton <ni...@gmail.com>.
On 6/20/07, Ben Speakmon <bs...@apache.org> wrote:
> I thought I was copying bcel too. I'm confused because bcel has the @@DATE@@
> tag in its project.build.finalName, but the <jar> points to 5.3-SNAPSHOT.
Good point - looks like that property has no effect - so maybe you're right
Niall
> I'll back out the change.
>
> On 6/20/07, Niall Pemberton <ni...@gmail.com> wrote:
> >
> > I believe I had corrected the gump problem by amending the property
> > for the jar name earlier (by copying what the bcel m2 gump config
> > had):
> >
> > http://svn.apache.org/viewvc?view=rev&revision=549101
> >
> > ...and I can't see any reason to completely remove since I believe
> > gump will fail with the same error as the last run anyway - since the
> > config has:
> >
> > <jar name="commons-email-@@DATE@@.jar"/>
> >
> > Niall
> >
> > On 6/20/07, bspeakmon@apache.org <bs...@apache.org> wrote:
> > > Author: bspeakmon
> > > Date: Wed Jun 20 08:00:20 2007
> > > New Revision: 549123
> > >
> > > URL: http://svn.apache.org/viewvc?view=rev&rev=549123
> > > Log:
> > > - fixed commons-email jar output name
> > >
> > > Modified:
> > > gump/metadata/project/jakarta-commons.xml
> > >
> > > Modified: gump/metadata/project/jakarta-commons.xml
> > > URL:
> > http://svn.apache.org/viewvc/gump/metadata/project/jakarta-commons.xml?view=diff&rev=549123&r1=549122&r2=549123
> > >
> > ==============================================================================
> > > --- gump/metadata/project/jakarta-commons.xml (original)
> > > +++ gump/metadata/project/jakarta-commons.xml Wed Jun 20 08:00:20 2007
> > > @@ -425,7 +425,6 @@
> > > <description>Commons Email Package</description>
> > >
> > > <mvn basedir="email" goal="package">
> > > - <property name="project.build.finalName"
> > value="commons-email-@@DATE@@"/>
> > > <depend project="javamail" property="maven.jar.mail"
> > id="javamail" />
> > > </mvn>
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: general-unsubscribe@gump.apache.org
> > For additional commands, e-mail: general-help@gump.apache.org
> >
> >
>
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@gump.apache.org
For additional commands, e-mail: general-help@gump.apache.org
Re: svn commit: r549123 - /gump/metadata/project/jakarta-commons.xml
Posted by Ben Speakmon <bs...@apache.org>.
I thought I was copying bcel too. I'm confused because bcel has the @@DATE@@
tag in its project.build.finalName, but the <jar> points to 5.3-SNAPSHOT.
I'll back out the change.
On 6/20/07, Niall Pemberton <ni...@gmail.com> wrote:
>
> I believe I had corrected the gump problem by amending the property
> for the jar name earlier (by copying what the bcel m2 gump config
> had):
>
> http://svn.apache.org/viewvc?view=rev&revision=549101
>
> ...and I can't see any reason to completely remove since I believe
> gump will fail with the same error as the last run anyway - since the
> config has:
>
> <jar name="commons-email-@@DATE@@.jar"/>
>
> Niall
>
> On 6/20/07, bspeakmon@apache.org <bs...@apache.org> wrote:
> > Author: bspeakmon
> > Date: Wed Jun 20 08:00:20 2007
> > New Revision: 549123
> >
> > URL: http://svn.apache.org/viewvc?view=rev&rev=549123
> > Log:
> > - fixed commons-email jar output name
> >
> > Modified:
> > gump/metadata/project/jakarta-commons.xml
> >
> > Modified: gump/metadata/project/jakarta-commons.xml
> > URL:
> http://svn.apache.org/viewvc/gump/metadata/project/jakarta-commons.xml?view=diff&rev=549123&r1=549122&r2=549123
> >
> ==============================================================================
> > --- gump/metadata/project/jakarta-commons.xml (original)
> > +++ gump/metadata/project/jakarta-commons.xml Wed Jun 20 08:00:20 2007
> > @@ -425,7 +425,6 @@
> > <description>Commons Email Package</description>
> >
> > <mvn basedir="email" goal="package">
> > - <property name="project.build.finalName"
> value="commons-email-@@DATE@@"/>
> > <depend project="javamail" property="maven.jar.mail"
> id="javamail" />
> > </mvn>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: general-unsubscribe@gump.apache.org
> For additional commands, e-mail: general-help@gump.apache.org
>
>
Re: svn commit: r549123 - /gump/metadata/project/jakarta-commons.xml
Posted by Stefan Bodewig <bo...@apache.org>.
On Wed, 20 Jun 2007, Niall Pemberton <ni...@gmail.com>
wrote:
> I believe I had corrected the gump problem by amending the property
> for the jar name earlier (by copying what the bcel m2 gump config
> had):
Yes, but as you later found out, it doesn't work. It was my attempt
to force mvn into using a specific jar name, but it failed.
For bcel I simply adjusted the <jar> line to whatever mvn thinks the
name should be.
We generally prefer to force our name so we don't need to adjust the
descriptor for every change in the version but - like with any other
case where Gump's and mvn's ideas collide - we had to give in for now.
Stefan
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@gump.apache.org
For additional commands, e-mail: general-help@gump.apache.org
Re: svn commit: r549123 - /gump/metadata/project/jakarta-commons.xml
Posted by Niall Pemberton <ni...@gmail.com>.
I believe I had corrected the gump problem by amending the property
for the jar name earlier (by copying what the bcel m2 gump config
had):
http://svn.apache.org/viewvc?view=rev&revision=549101
...and I can't see any reason to completely remove since I believe
gump will fail with the same error as the last run anyway - since the
config has:
<jar name="commons-email-@@DATE@@.jar"/>
Niall
On 6/20/07, bspeakmon@apache.org <bs...@apache.org> wrote:
> Author: bspeakmon
> Date: Wed Jun 20 08:00:20 2007
> New Revision: 549123
>
> URL: http://svn.apache.org/viewvc?view=rev&rev=549123
> Log:
> - fixed commons-email jar output name
>
> Modified:
> gump/metadata/project/jakarta-commons.xml
>
> Modified: gump/metadata/project/jakarta-commons.xml
> URL: http://svn.apache.org/viewvc/gump/metadata/project/jakarta-commons.xml?view=diff&rev=549123&r1=549122&r2=549123
> ==============================================================================
> --- gump/metadata/project/jakarta-commons.xml (original)
> +++ gump/metadata/project/jakarta-commons.xml Wed Jun 20 08:00:20 2007
> @@ -425,7 +425,6 @@
> <description>Commons Email Package</description>
>
> <mvn basedir="email" goal="package">
> - <property name="project.build.finalName" value="commons-email-@@DATE@@"/>
> <depend project="javamail" property="maven.jar.mail" id="javamail" />
> </mvn>
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@gump.apache.org
For additional commands, e-mail: general-help@gump.apache.org