You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Alexander Rukletsov <ru...@gmail.com> on 2015/11/11 11:05:51 UTC
Review Request 40181: Corrected formatting in "hierarchical.cpp".
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40181/
-----------------------------------------------------------
Review request for mesos and Joris Van Remoortere.
Bugs: MESOS-3884
https://issues.apache.org/jira/browse/MESOS-3884
Repository: mesos
Description
-------
See summary.
Diffs
-----
src/master/allocator/mesos/hierarchical.cpp 14fef63714721fcda7cea3c28704766efda6d007
Diff: https://reviews.apache.org/r/40181/diff/
Testing
-------
make check (Mac OS X 10.10.4)
Thanks,
Alexander Rukletsov
Re: Review Request 40181: Corrected formatting in "hierarchical.cpp".
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40181/#review106031
-----------------------------------------------------------
Patch looks great!
Reviews applied: [40179, 40180, 40181]
All tests passed.
- Mesos ReviewBot
On Nov. 11, 2015, 10:05 a.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40181/
> -----------------------------------------------------------
>
> (Updated Nov. 11, 2015, 10:05 a.m.)
>
>
> Review request for mesos and Joris Van Remoortere.
>
>
> Bugs: MESOS-3884
> https://issues.apache.org/jira/browse/MESOS-3884
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/master/allocator/mesos/hierarchical.cpp 14fef63714721fcda7cea3c28704766efda6d007
>
> Diff: https://reviews.apache.org/r/40181/diff/
>
>
> Testing
> -------
>
> make check (Mac OS X 10.10.4)
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 40181: Corrected formatting in "hierarchical.cpp".
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40181/#review106057
-----------------------------------------------------------
Ship it!
Ship It!
- Joris Van Remoortere
On Nov. 11, 2015, 10:05 a.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40181/
> -----------------------------------------------------------
>
> (Updated Nov. 11, 2015, 10:05 a.m.)
>
>
> Review request for mesos and Joris Van Remoortere.
>
>
> Bugs: MESOS-3884
> https://issues.apache.org/jira/browse/MESOS-3884
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/master/allocator/mesos/hierarchical.cpp 14fef63714721fcda7cea3c28704766efda6d007
>
> Diff: https://reviews.apache.org/r/40181/diff/
>
>
> Testing
> -------
>
> make check (Mac OS X 10.10.4)
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 40181: Corrected formatting in "hierarchical.cpp".
Posted by Alexander Rukletsov <ru...@gmail.com>.
> On Nov. 11, 2015, 12:57 p.m., Guangya Liu wrote:
> > src/master/allocator/mesos/hierarchical.cpp, line 166
> > <https://reviews.apache.org/r/40181/diff/1/?file=1123251#file1123251line166>
> >
> > Why moving the check here? This should be at the beginning of the function.
Because everywhere else in the file `CHECK`s form an invariant checking block. In this case, aliasing `role` increases readability of checks, therefore it comes before.
- Alexander
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40181/#review106045
-----------------------------------------------------------
On Nov. 11, 2015, 10:05 a.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40181/
> -----------------------------------------------------------
>
> (Updated Nov. 11, 2015, 10:05 a.m.)
>
>
> Review request for mesos and Joris Van Remoortere.
>
>
> Bugs: MESOS-3884
> https://issues.apache.org/jira/browse/MESOS-3884
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/master/allocator/mesos/hierarchical.cpp 14fef63714721fcda7cea3c28704766efda6d007
>
> Diff: https://reviews.apache.org/r/40181/diff/
>
>
> Testing
> -------
>
> make check (Mac OS X 10.10.4)
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 40181: Corrected formatting in "hierarchical.cpp".
Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40181/#review106045
-----------------------------------------------------------
src/master/allocator/mesos/hierarchical.cpp (line 164)
<https://reviews.apache.org/r/40181/#comment164769>
Why moving the check here? This should be at the beginning of the function.
- Guangya Liu
On 十一月 11, 2015, 10:05 a.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40181/
> -----------------------------------------------------------
>
> (Updated 十一月 11, 2015, 10:05 a.m.)
>
>
> Review request for mesos and Joris Van Remoortere.
>
>
> Bugs: MESOS-3884
> https://issues.apache.org/jira/browse/MESOS-3884
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/master/allocator/mesos/hierarchical.cpp 14fef63714721fcda7cea3c28704766efda6d007
>
> Diff: https://reviews.apache.org/r/40181/diff/
>
>
> Testing
> -------
>
> make check (Mac OS X 10.10.4)
>
>
> Thanks,
>
> Alexander Rukletsov
>
>