You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Geoff Hayman (JIRA)" <ji...@apache.org> on 2012/09/18 19:26:07 UTC
[jira] [Commented] (WICKET-4770) Wicket 6: modal windows in Safari
are always in drag or resize mode
[ https://issues.apache.org/jira/browse/WICKET-4770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13457970#comment-13457970 ]
Geoff Hayman commented on WICKET-4770:
--------------------------------------
The modal dialog tries to set event.ignore=true if the browser is Safari. This Wicket event data structure used to be passed through to Wicket.Drag.mouseDownHandler as the argument e. However, in the switch over to jQuery events the argument (e) passed to mouseDownHandler is no longer Wicket "event". It is now jQuery event data.
There is a test in mouseDownHandler to check for the existence of e.ignore. As this is now jQuery data, it _never_ exists, so Safari is never recognized.
I changed this test to check event.ignore and it appears to work correctly.
> Wicket 6: modal windows in Safari are always in drag or resize mode
> -------------------------------------------------------------------
>
> Key: WICKET-4770
> URL: https://issues.apache.org/jira/browse/WICKET-4770
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 6.0.0
> Environment: Safari - all OS
> Reporter: Geoff Hayman
> Attachments: Fix_to_Wicket_6___Safari_modal_window_drag_issue1.patch
>
>
> In Wicket 6 using Safari, a modal dialog will not allow interactions with form components. The whole dialog always seems to be in "drag" mode. Click anywhere on the panel and the dialog will drag.
> Interaction works fine with all other browsers.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira