You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "crepererum (via GitHub)" <gi...@apache.org> on 2023/11/08 14:44:21 UTC
[PR] refactor: change `object_store` CA handling [arrow-rs]
crepererum opened a new pull request, #5056:
URL: https://github.com/apache/arrow-rs/pull/5056
# Which issue does this PR close?
Closes #4870.
# Rationale for this change
See issue. Alternative to #5030.
# What changes are included in this PR?
Feature switches to opt into webpki.
# Are there any user-facing changes?
**Breaking:** Use system certs by default.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor: change `object_store` CA handling [arrow-rs]
Posted by "crepererum (via GitHub)" <gi...@apache.org>.
crepererum commented on code in PR #5056:
URL: https://github.com/apache/arrow-rs/pull/5056#discussion_r1386763826
##########
object_store/src/lib.rs:
##########
@@ -86,6 +86,17 @@
doc = "* [`http`]: [HTTP/WebDAV Storage](https://datatracker.ietf.org/doc/html/rfc2518). See [`HttpBuilder`](http::HttpBuilder)"
)]
//!
+//! # TLS Certificates
Review Comment:
ups, fat-fingered the merge, will do in a follow-up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor: change `object_store` CA handling [arrow-rs]
Posted by "crepererum (via GitHub)" <gi...@apache.org>.
crepererum merged PR #5056:
URL: https://github.com/apache/arrow-rs/pull/5056
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor: change `object_store` CA handling [arrow-rs]
Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold commented on code in PR #5056:
URL: https://github.com/apache/arrow-rs/pull/5056#discussion_r1386754579
##########
object_store/src/lib.rs:
##########
@@ -86,6 +86,17 @@
doc = "* [`http`]: [HTTP/WebDAV Storage](https://datatracker.ietf.org/doc/html/rfc2518). See [`HttpBuilder`](http::HttpBuilder)"
)]
//!
+//! # TLS Certificates
Review Comment:
Could we perhaps move this lower, e.g. after the configuration section. I don't think this should be the first thing users see
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org