You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shenyu.apache.org by GitBox <gi...@apache.org> on 2022/01/10 15:24:59 UTC
[GitHub] [incubator-shenyu] QinHaiqi opened a new pull request #2746: about ldapconfiguration
QinHaiqi opened a new pull request #2746:
URL: https://github.com/apache/incubator-shenyu/pull/2746
// Describe your PR here; eg. Fixes #issueNo
<!--
Thank you for proposing a pull request. This template will guide you through the essential steps necessary for a pull request.
-->
Make sure that:
- [ ] You have read the [contribution guidelines](https://shenyu.apache.org/community/contributor).
- [ ] You submit test cases (unit or integration tests) that back your changes.
- [ ] Your local test passed `mvn clean install -Dmaven.javadoc.skip=true`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-shenyu] codecov-commenter edited a comment on pull request #2746: about ldapconfiguration
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #2746:
URL: https://github.com/apache/incubator-shenyu/pull/2746#issuecomment-1009005891
# [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/2746?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#2746](https://codecov.io/gh/apache/incubator-shenyu/pull/2746?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e577b55) into [master](https://codecov.io/gh/apache/incubator-shenyu/commit/fe6f3402888c7f2795c80f7b3ca5b251cab99f6b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (fe6f340) will **decrease** coverage by `0.63%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/incubator-shenyu/pull/2746?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #2746 +/- ##
============================================
- Coverage 60.18% 59.55% -0.64%
+ Complexity 4408 4376 -32
============================================
Files 681 681
Lines 19613 19615 +2
Branches 1743 1743
============================================
- Hits 11805 11681 -124
- Misses 6814 6948 +134
+ Partials 994 986 -8
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-shenyu/pull/2746?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../apache/shenyu/admin/config/LdapConfiguration.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2746/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vY29uZmlnL0xkYXBDb25maWd1cmF0aW9uLmphdmE=) | `100.00% <100.00%> (ø)` | |
| [...n/alibaba/dubbo/cache/AlibabaDubboConfigCache.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2746/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWR1YmJvL3NoZW55dS1wbHVnaW4tYWxpYmFiYS1kdWJiby9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L3BsdWdpbi9hbGliYWJhL2R1YmJvL2NhY2hlL0FsaWJhYmFEdWJib0NvbmZpZ0NhY2hlLmphdmE=) | `43.75% <0.00%> (-31.25%)` | :arrow_down: |
| [...gin/apache/dubbo/cache/ApacheDubboConfigCache.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2746/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWR1YmJvL3NoZW55dS1wbHVnaW4tYXBhY2hlLWR1YmJvL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvcGx1Z2luL2FwYWNoZS9kdWJiby9jYWNoZS9BcGFjaGVEdWJib0NvbmZpZ0NhY2hlLmphdmE=) | `43.03% <0.00%> (-29.12%)` | :arrow_down: |
| [...che/shenyu/sync/data/http/HttpSyncDataService.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2746/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXN5bmMtZGF0YS1jZW50ZXIvc2hlbnl1LXN5bmMtZGF0YS1odHRwL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvc3luYy9kYXRhL2h0dHAvSHR0cFN5bmNEYXRhU2VydmljZS5qYXZh) | `63.23% <0.00%> (-20.59%)` | :arrow_down: |
| [...henyu/plugin/grpc/resolver/ShenyuNameResolver.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2746/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWdycGMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vZ3JwYy9yZXNvbHZlci9TaGVueXVOYW1lUmVzb2x2ZXIuamF2YQ==) | `44.68% <0.00%> (-19.15%)` | :arrow_down: |
| [...yu/sync/data/http/refresh/AbstractDataRefresh.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2746/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXN5bmMtZGF0YS1jZW50ZXIvc2hlbnl1LXN5bmMtZGF0YS1odHRwL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvc3luYy9kYXRhL2h0dHAvcmVmcmVzaC9BYnN0cmFjdERhdGFSZWZyZXNoLmphdmE=) | `70.00% <0.00%> (-13.34%)` | :arrow_down: |
| [...apache/shenyu/admin/utils/ShenyuDictH2Trigger.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2746/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vdXRpbHMvU2hlbnl1RGljdEgyVHJpZ2dlci5qYXZh) | `63.63% <0.00%> (-9.10%)` | :arrow_down: |
| [...ache/shenyu/admin/utils/PluginHandleH2Trigger.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2746/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vdXRpbHMvUGx1Z2luSGFuZGxlSDJUcmlnZ2VyLmphdmE=) | `63.63% <0.00%> (-9.10%)` | :arrow_down: |
| [.../apache/shenyu/admin/model/dto/BatchCommonDTO.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2746/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vbW9kZWwvZHRvL0JhdGNoQ29tbW9uRFRPLmphdmE=) | `50.00% <0.00%> (-7.15%)` | :arrow_down: |
| [...apache/shenyu/admin/model/dto/AuthPathWarpDTO.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2746/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vbW9kZWwvZHRvL0F1dGhQYXRoV2FycERUTy5qYXZh) | `57.14% <0.00%> (-7.15%)` | :arrow_down: |
| ... and [24 more](https://codecov.io/gh/apache/incubator-shenyu/pull/2746/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/2746?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/2746?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [fe6f340...e577b55](https://codecov.io/gh/apache/incubator-shenyu/pull/2746?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-shenyu] QinHaiqi commented on pull request #2746: about ldapconfiguration
Posted by GitBox <gi...@apache.org>.
QinHaiqi commented on pull request #2746:
URL: https://github.com/apache/incubator-shenyu/pull/2746#issuecomment-1010519493
> How about reduce your commit number, and detail your pr?
I'll pay attention.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-shenyu] QinHaiqi commented on a change in pull request #2746: [type: refactor] Add protection when ldapprop is null
Posted by GitBox <gi...@apache.org>.
QinHaiqi commented on a change in pull request #2746:
URL: https://github.com/apache/incubator-shenyu/pull/2746#discussion_r782675547
##########
File path: shenyu-admin/src/main/java/org/apache/shenyu/admin/config/LdapConfiguration.java
##########
@@ -47,17 +48,19 @@
@Bean
@ConditionalOnMissingBean
public LdapContextSource contextSource(final LdapProperties ldapProp) {
- LdapContextSource contextSource = new LdapContextSource();
- contextSource.setUrl(ldapProp.getUrl());
- contextSource.setUserDn(ldapProp.getBindDn());
- contextSource.setPassword(ldapProp.getPassword());
- contextSource.setPooled(true);
- Map<String, Object> config = new HashMap<>();
- config.put("java.naming.ldap.attributes.binary", "objectGUID");
- config.put("com.sun.jndi.ldap.connect.timeout", String.valueOf(ldapProp.getConnectTimeout()));
- config.put("com.sun.jndi.ldap.read.timeout", String.valueOf(ldapProp.getReadTimeout()));
- contextSource.setBaseEnvironmentProperties(config);
- return contextSource;
+ return Optional.ofNullable(ldapProp).map(item -> {
Review comment:
I don't understand the function of this annotation. I've learned it now. Thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-shenyu] KevinClair commented on a change in pull request #2746: [type: refactor] Add protection when ldapprop is null
Posted by GitBox <gi...@apache.org>.
KevinClair commented on a change in pull request #2746:
URL: https://github.com/apache/incubator-shenyu/pull/2746#discussion_r782672952
##########
File path: shenyu-admin/src/main/java/org/apache/shenyu/admin/config/LdapConfiguration.java
##########
@@ -47,17 +48,19 @@
@Bean
@ConditionalOnMissingBean
public LdapContextSource contextSource(final LdapProperties ldapProp) {
- LdapContextSource contextSource = new LdapContextSource();
- contextSource.setUrl(ldapProp.getUrl());
- contextSource.setUserDn(ldapProp.getBindDn());
- contextSource.setPassword(ldapProp.getPassword());
- contextSource.setPooled(true);
- Map<String, Object> config = new HashMap<>();
- config.put("java.naming.ldap.attributes.binary", "objectGUID");
- config.put("com.sun.jndi.ldap.connect.timeout", String.valueOf(ldapProp.getConnectTimeout()));
- config.put("com.sun.jndi.ldap.read.timeout", String.valueOf(ldapProp.getReadTimeout()));
- contextSource.setBaseEnvironmentProperties(config);
- return contextSource;
+ return Optional.ofNullable(ldapProp).map(item -> {
Review comment:
why?It has been registerd by `@EnableConfigurationProperties(LdapProperties.class)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-shenyu] QinHaiqi commented on a change in pull request #2746: about ldapconfiguration
Posted by GitBox <gi...@apache.org>.
QinHaiqi commented on a change in pull request #2746:
URL: https://github.com/apache/incubator-shenyu/pull/2746#discussion_r782631998
##########
File path: shenyu-admin/src/main/java/org/apache/shenyu/admin/config/LdapConfiguration.java
##########
@@ -47,17 +48,19 @@
@Bean
@ConditionalOnMissingBean
public LdapContextSource contextSource(final LdapProperties ldapProp) {
- LdapContextSource contextSource = new LdapContextSource();
- contextSource.setUrl(ldapProp.getUrl());
- contextSource.setUserDn(ldapProp.getBindDn());
- contextSource.setPassword(ldapProp.getPassword());
- contextSource.setPooled(true);
- Map<String, Object> config = new HashMap<>();
- config.put("java.naming.ldap.attributes.binary", "objectGUID");
- config.put("com.sun.jndi.ldap.connect.timeout", String.valueOf(ldapProp.getConnectTimeout()));
- config.put("com.sun.jndi.ldap.read.timeout", String.valueOf(ldapProp.getReadTimeout()));
- contextSource.setBaseEnvironmentProperties(config);
- return contextSource;
+ return Optional.ofNullable(ldapProp).map(item -> {
Review comment:
I think it's possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-shenyu] KevinClair commented on a change in pull request #2746: about ldapconfiguration
Posted by GitBox <gi...@apache.org>.
KevinClair commented on a change in pull request #2746:
URL: https://github.com/apache/incubator-shenyu/pull/2746#discussion_r782251637
##########
File path: shenyu-admin/src/main/java/org/apache/shenyu/admin/config/LdapConfiguration.java
##########
@@ -47,17 +48,19 @@
@Bean
@ConditionalOnMissingBean
public LdapContextSource contextSource(final LdapProperties ldapProp) {
- LdapContextSource contextSource = new LdapContextSource();
- contextSource.setUrl(ldapProp.getUrl());
- contextSource.setUserDn(ldapProp.getBindDn());
- contextSource.setPassword(ldapProp.getPassword());
- contextSource.setPooled(true);
- Map<String, Object> config = new HashMap<>();
- config.put("java.naming.ldap.attributes.binary", "objectGUID");
- config.put("com.sun.jndi.ldap.connect.timeout", String.valueOf(ldapProp.getConnectTimeout()));
- config.put("com.sun.jndi.ldap.read.timeout", String.valueOf(ldapProp.getReadTimeout()));
- contextSource.setBaseEnvironmentProperties(config);
- return contextSource;
+ return Optional.ofNullable(ldapProp).map(item -> {
Review comment:
Parameter `ldapprop` may be null?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-shenyu] AhahaGe commented on pull request #2746: about ldapconfiguration
Posted by GitBox <gi...@apache.org>.
AhahaGe commented on pull request #2746:
URL: https://github.com/apache/incubator-shenyu/pull/2746#issuecomment-1009881710
How about reduce your commit number, and detail your pr?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-shenyu] codecov-commenter edited a comment on pull request #2746: about ldapconfiguration
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #2746:
URL: https://github.com/apache/incubator-shenyu/pull/2746#issuecomment-1009005891
# [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/2746?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#2746](https://codecov.io/gh/apache/incubator-shenyu/pull/2746?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e577b55) into [master](https://codecov.io/gh/apache/incubator-shenyu/commit/fe6f3402888c7f2795c80f7b3ca5b251cab99f6b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (fe6f340) will **decrease** coverage by `0.15%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/incubator-shenyu/pull/2746?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #2746 +/- ##
============================================
- Coverage 60.18% 60.03% -0.16%
+ Complexity 4408 4403 -5
============================================
Files 681 681
Lines 19613 19615 +2
Branches 1743 1743
============================================
- Hits 11805 11776 -29
- Misses 6814 6839 +25
- Partials 994 1000 +6
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-shenyu/pull/2746?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../apache/shenyu/admin/config/LdapConfiguration.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2746/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vY29uZmlnL0xkYXBDb25maWd1cmF0aW9uLmphdmE=) | `100.00% <100.00%> (ø)` | |
| [...yu/sync/data/http/refresh/AbstractDataRefresh.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2746/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXN5bmMtZGF0YS1jZW50ZXIvc2hlbnl1LXN5bmMtZGF0YS1odHRwL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvc3luYy9kYXRhL2h0dHAvcmVmcmVzaC9BYnN0cmFjdERhdGFSZWZyZXNoLmphdmE=) | `70.00% <0.00%> (-13.34%)` | :arrow_down: |
| [...che/shenyu/sync/data/http/HttpSyncDataService.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2746/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXN5bmMtZGF0YS1jZW50ZXIvc2hlbnl1LXN5bmMtZGF0YS1odHRwL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvc3luYy9kYXRhL2h0dHAvSHR0cFN5bmNEYXRhU2VydmljZS5qYXZh) | `72.05% <0.00%> (-11.77%)` | :arrow_down: |
| [...henyu/plugin/grpc/resolver/ShenyuNameResolver.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2746/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWdycGMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vZ3JwYy9yZXNvbHZlci9TaGVueXVOYW1lUmVzb2x2ZXIuamF2YQ==) | `54.25% <0.00%> (-9.58%)` | :arrow_down: |
| [...apache/shenyu/admin/utils/ShenyuDictH2Trigger.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2746/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vdXRpbHMvU2hlbnl1RGljdEgyVHJpZ2dlci5qYXZh) | `63.63% <0.00%> (-9.10%)` | :arrow_down: |
| [...ache/shenyu/admin/utils/PluginHandleH2Trigger.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2746/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vdXRpbHMvUGx1Z2luSGFuZGxlSDJUcmlnZ2VyLmphdmE=) | `63.63% <0.00%> (-9.10%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/2746?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/2746?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [fe6f340...e577b55](https://codecov.io/gh/apache/incubator-shenyu/pull/2746?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-shenyu] QinHaiqi closed pull request #2746: [type: refactor] Add protection when ldapprop is null
Posted by GitBox <gi...@apache.org>.
QinHaiqi closed pull request #2746:
URL: https://github.com/apache/incubator-shenyu/pull/2746
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-shenyu] codecov-commenter commented on pull request #2746: about ldapconfiguration
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #2746:
URL: https://github.com/apache/incubator-shenyu/pull/2746#issuecomment-1009005891
# [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/2746?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#2746](https://codecov.io/gh/apache/incubator-shenyu/pull/2746?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e577b55) into [master](https://codecov.io/gh/apache/incubator-shenyu/commit/fe6f3402888c7f2795c80f7b3ca5b251cab99f6b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (fe6f340) will **decrease** coverage by `0.69%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/incubator-shenyu/pull/2746?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #2746 +/- ##
============================================
- Coverage 60.18% 59.49% -0.70%
+ Complexity 4408 4374 -34
============================================
Files 681 681
Lines 19613 19612 -1
Branches 1743 1742 -1
============================================
- Hits 11805 11669 -136
- Misses 6814 6955 +141
+ Partials 994 988 -6
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-shenyu/pull/2746?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../apache/shenyu/admin/config/LdapConfiguration.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2746/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vY29uZmlnL0xkYXBDb25maWd1cmF0aW9uLmphdmE=) | `100.00% <100.00%> (ø)` | |
| [...ache/shenyu/plugin/grpc/cache/GrpcClientCache.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2746/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWdycGMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vZ3JwYy9jYWNoZS9HcnBjQ2xpZW50Q2FjaGUuamF2YQ==) | `68.75% <0.00%> (-31.25%)` | :arrow_down: |
| [...n/alibaba/dubbo/cache/AlibabaDubboConfigCache.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2746/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWR1YmJvL3NoZW55dS1wbHVnaW4tYWxpYmFiYS1kdWJiby9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L3BsdWdpbi9hbGliYWJhL2R1YmJvL2NhY2hlL0FsaWJhYmFEdWJib0NvbmZpZ0NhY2hlLmphdmE=) | `43.75% <0.00%> (-31.25%)` | :arrow_down: |
| [...gin/apache/dubbo/cache/ApacheDubboConfigCache.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2746/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWR1YmJvL3NoZW55dS1wbHVnaW4tYXBhY2hlLWR1YmJvL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvcGx1Z2luL2FwYWNoZS9kdWJiby9jYWNoZS9BcGFjaGVEdWJib0NvbmZpZ0NhY2hlLmphdmE=) | `43.03% <0.00%> (-29.12%)` | :arrow_down: |
| [...che/shenyu/sync/data/http/HttpSyncDataService.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2746/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXN5bmMtZGF0YS1jZW50ZXIvc2hlbnl1LXN5bmMtZGF0YS1odHRwL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvc3luYy9kYXRhL2h0dHAvSHR0cFN5bmNEYXRhU2VydmljZS5qYXZh) | `63.23% <0.00%> (-20.59%)` | :arrow_down: |
| [...henyu/plugin/grpc/resolver/ShenyuNameResolver.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2746/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWdycGMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vZ3JwYy9yZXNvbHZlci9TaGVueXVOYW1lUmVzb2x2ZXIuamF2YQ==) | `44.68% <0.00%> (-19.15%)` | :arrow_down: |
| [...yu/sync/data/http/refresh/AbstractDataRefresh.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2746/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXN5bmMtZGF0YS1jZW50ZXIvc2hlbnl1LXN5bmMtZGF0YS1odHRwL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvc3luYy9kYXRhL2h0dHAvcmVmcmVzaC9BYnN0cmFjdERhdGFSZWZyZXNoLmphdmE=) | `70.00% <0.00%> (-13.34%)` | :arrow_down: |
| [...a/org/apache/shenyu/common/utils/VersionUtils.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2746/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L2NvbW1vbi91dGlscy9WZXJzaW9uVXRpbHMuamF2YQ==) | `67.85% <0.00%> (-10.72%)` | :arrow_down: |
| [...apache/shenyu/admin/utils/ShenyuDictH2Trigger.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2746/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vdXRpbHMvU2hlbnl1RGljdEgyVHJpZ2dlci5qYXZh) | `63.63% <0.00%> (-9.10%)` | :arrow_down: |
| [...ache/shenyu/admin/utils/PluginHandleH2Trigger.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2746/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vdXRpbHMvUGx1Z2luSGFuZGxlSDJUcmlnZ2VyLmphdmE=) | `63.63% <0.00%> (-9.10%)` | :arrow_down: |
| ... and [30 more](https://codecov.io/gh/apache/incubator-shenyu/pull/2746/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/2746?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/2746?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [fe6f340...e577b55](https://codecov.io/gh/apache/incubator-shenyu/pull/2746?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-shenyu] QinHaiqi commented on pull request #2746: about ldapconfiguration
Posted by GitBox <gi...@apache.org>.
QinHaiqi commented on pull request #2746:
URL: https://github.com/apache/incubator-shenyu/pull/2746#issuecomment-1010518399
> By the way, modify your pr's title.
Thanks for reminding.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-shenyu] KevinClair commented on pull request #2746: about ldapconfiguration
Posted by GitBox <gi...@apache.org>.
KevinClair commented on pull request #2746:
URL: https://github.com/apache/incubator-shenyu/pull/2746#issuecomment-1010070309
By the way, modify your pr's title.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-shenyu] codecov-commenter edited a comment on pull request #2746: about ldapconfiguration
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #2746:
URL: https://github.com/apache/incubator-shenyu/pull/2746#issuecomment-1009005891
# [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/2746?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#2746](https://codecov.io/gh/apache/incubator-shenyu/pull/2746?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e577b55) into [master](https://codecov.io/gh/apache/incubator-shenyu/commit/fe6f3402888c7f2795c80f7b3ca5b251cab99f6b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (fe6f340) will **decrease** coverage by `0.55%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/incubator-shenyu/pull/2746?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #2746 +/- ##
============================================
- Coverage 60.18% 59.63% -0.56%
+ Complexity 4408 4376 -32
============================================
Files 681 681
Lines 19613 19615 +2
Branches 1743 1743
============================================
- Hits 11805 11698 -107
- Misses 6814 6928 +114
+ Partials 994 989 -5
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-shenyu/pull/2746?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../apache/shenyu/admin/config/LdapConfiguration.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2746/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vY29uZmlnL0xkYXBDb25maWd1cmF0aW9uLmphdmE=) | `100.00% <100.00%> (ø)` | |
| [...n/alibaba/dubbo/cache/AlibabaDubboConfigCache.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2746/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWR1YmJvL3NoZW55dS1wbHVnaW4tYWxpYmFiYS1kdWJiby9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L3BsdWdpbi9hbGliYWJhL2R1YmJvL2NhY2hlL0FsaWJhYmFEdWJib0NvbmZpZ0NhY2hlLmphdmE=) | `43.75% <0.00%> (-31.25%)` | :arrow_down: |
| [...gin/apache/dubbo/cache/ApacheDubboConfigCache.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2746/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWR1YmJvL3NoZW55dS1wbHVnaW4tYXBhY2hlLWR1YmJvL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvcGx1Z2luL2FwYWNoZS9kdWJiby9jYWNoZS9BcGFjaGVEdWJib0NvbmZpZ0NhY2hlLmphdmE=) | `43.03% <0.00%> (-29.12%)` | :arrow_down: |
| [...yu/sync/data/http/refresh/AbstractDataRefresh.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2746/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXN5bmMtZGF0YS1jZW50ZXIvc2hlbnl1LXN5bmMtZGF0YS1odHRwL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvc3luYy9kYXRhL2h0dHAvcmVmcmVzaC9BYnN0cmFjdERhdGFSZWZyZXNoLmphdmE=) | `70.00% <0.00%> (-13.34%)` | :arrow_down: |
| [...che/shenyu/sync/data/http/HttpSyncDataService.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2746/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXN5bmMtZGF0YS1jZW50ZXIvc2hlbnl1LXN5bmMtZGF0YS1odHRwL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvc3luYy9kYXRhL2h0dHAvSHR0cFN5bmNEYXRhU2VydmljZS5qYXZh) | `70.58% <0.00%> (-13.24%)` | :arrow_down: |
| [...henyu/plugin/grpc/resolver/ShenyuNameResolver.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2746/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWdycGMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vZ3JwYy9yZXNvbHZlci9TaGVueXVOYW1lUmVzb2x2ZXIuamF2YQ==) | `52.12% <0.00%> (-11.71%)` | :arrow_down: |
| [...apache/shenyu/admin/utils/ShenyuDictH2Trigger.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2746/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vdXRpbHMvU2hlbnl1RGljdEgyVHJpZ2dlci5qYXZh) | `63.63% <0.00%> (-9.10%)` | :arrow_down: |
| [...ache/shenyu/admin/utils/PluginHandleH2Trigger.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2746/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vdXRpbHMvUGx1Z2luSGFuZGxlSDJUcmlnZ2VyLmphdmE=) | `63.63% <0.00%> (-9.10%)` | :arrow_down: |
| [.../apache/shenyu/admin/model/dto/BatchCommonDTO.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2746/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vbW9kZWwvZHRvL0JhdGNoQ29tbW9uRFRPLmphdmE=) | `50.00% <0.00%> (-7.15%)` | :arrow_down: |
| [...apache/shenyu/admin/model/dto/AuthPathWarpDTO.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2746/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vbW9kZWwvZHRvL0F1dGhQYXRoV2FycERUTy5qYXZh) | `57.14% <0.00%> (-7.15%)` | :arrow_down: |
| ... and [24 more](https://codecov.io/gh/apache/incubator-shenyu/pull/2746/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/2746?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/2746?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [fe6f340...e577b55](https://codecov.io/gh/apache/incubator-shenyu/pull/2746?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-shenyu] codecov-commenter edited a comment on pull request #2746: about ldapconfiguration
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #2746:
URL: https://github.com/apache/incubator-shenyu/pull/2746#issuecomment-1009005891
# [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/2746?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#2746](https://codecov.io/gh/apache/incubator-shenyu/pull/2746?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e577b55) into [master](https://codecov.io/gh/apache/incubator-shenyu/commit/fe6f3402888c7f2795c80f7b3ca5b251cab99f6b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (fe6f340) will **decrease** coverage by `0.54%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/incubator-shenyu/pull/2746?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #2746 +/- ##
============================================
- Coverage 60.18% 59.64% -0.55%
+ Complexity 4408 4377 -31
============================================
Files 681 681
Lines 19613 19615 +2
Branches 1743 1743
============================================
- Hits 11805 11699 -106
- Misses 6814 6928 +114
+ Partials 994 988 -6
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-shenyu/pull/2746?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../apache/shenyu/admin/config/LdapConfiguration.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2746/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vY29uZmlnL0xkYXBDb25maWd1cmF0aW9uLmphdmE=) | `100.00% <100.00%> (ø)` | |
| [...n/alibaba/dubbo/cache/AlibabaDubboConfigCache.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2746/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWR1YmJvL3NoZW55dS1wbHVnaW4tYWxpYmFiYS1kdWJiby9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L3BsdWdpbi9hbGliYWJhL2R1YmJvL2NhY2hlL0FsaWJhYmFEdWJib0NvbmZpZ0NhY2hlLmphdmE=) | `43.75% <0.00%> (-31.25%)` | :arrow_down: |
| [...gin/apache/dubbo/cache/ApacheDubboConfigCache.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2746/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWR1YmJvL3NoZW55dS1wbHVnaW4tYXBhY2hlLWR1YmJvL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvcGx1Z2luL2FwYWNoZS9kdWJiby9jYWNoZS9BcGFjaGVEdWJib0NvbmZpZ0NhY2hlLmphdmE=) | `43.03% <0.00%> (-29.12%)` | :arrow_down: |
| [...yu/sync/data/http/refresh/AbstractDataRefresh.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2746/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXN5bmMtZGF0YS1jZW50ZXIvc2hlbnl1LXN5bmMtZGF0YS1odHRwL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvc3luYy9kYXRhL2h0dHAvcmVmcmVzaC9BYnN0cmFjdERhdGFSZWZyZXNoLmphdmE=) | `70.00% <0.00%> (-13.34%)` | :arrow_down: |
| [...che/shenyu/sync/data/http/HttpSyncDataService.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2746/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXN5bmMtZGF0YS1jZW50ZXIvc2hlbnl1LXN5bmMtZGF0YS1odHRwL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvc3luYy9kYXRhL2h0dHAvSHR0cFN5bmNEYXRhU2VydmljZS5qYXZh) | `70.58% <0.00%> (-13.24%)` | :arrow_down: |
| [...henyu/plugin/grpc/resolver/ShenyuNameResolver.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2746/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWdycGMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vZ3JwYy9yZXNvbHZlci9TaGVueXVOYW1lUmVzb2x2ZXIuamF2YQ==) | `52.12% <0.00%> (-11.71%)` | :arrow_down: |
| [...apache/shenyu/admin/utils/ShenyuDictH2Trigger.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2746/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vdXRpbHMvU2hlbnl1RGljdEgyVHJpZ2dlci5qYXZh) | `63.63% <0.00%> (-9.10%)` | :arrow_down: |
| [...ache/shenyu/admin/utils/PluginHandleH2Trigger.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2746/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vdXRpbHMvUGx1Z2luSGFuZGxlSDJUcmlnZ2VyLmphdmE=) | `63.63% <0.00%> (-9.10%)` | :arrow_down: |
| [.../apache/shenyu/admin/model/dto/BatchCommonDTO.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2746/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vbW9kZWwvZHRvL0JhdGNoQ29tbW9uRFRPLmphdmE=) | `50.00% <0.00%> (-7.15%)` | :arrow_down: |
| [...apache/shenyu/admin/model/dto/AuthPathWarpDTO.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2746/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vbW9kZWwvZHRvL0F1dGhQYXRoV2FycERUTy5qYXZh) | `57.14% <0.00%> (-7.15%)` | :arrow_down: |
| ... and [23 more](https://codecov.io/gh/apache/incubator-shenyu/pull/2746/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/2746?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/2746?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [fe6f340...e577b55](https://codecov.io/gh/apache/incubator-shenyu/pull/2746?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-shenyu] codecov-commenter edited a comment on pull request #2746: about ldapconfiguration
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #2746:
URL: https://github.com/apache/incubator-shenyu/pull/2746#issuecomment-1009005891
# [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/2746?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#2746](https://codecov.io/gh/apache/incubator-shenyu/pull/2746?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e577b55) into [master](https://codecov.io/gh/apache/incubator-shenyu/commit/fe6f3402888c7f2795c80f7b3ca5b251cab99f6b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (fe6f340) will **decrease** coverage by `0.58%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/incubator-shenyu/pull/2746?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #2746 +/- ##
============================================
- Coverage 60.18% 59.60% -0.59%
+ Complexity 4408 4376 -32
============================================
Files 681 681
Lines 19613 19615 +2
Branches 1743 1743
============================================
- Hits 11805 11691 -114
- Misses 6814 6936 +122
+ Partials 994 988 -6
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-shenyu/pull/2746?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../apache/shenyu/admin/config/LdapConfiguration.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2746/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vY29uZmlnL0xkYXBDb25maWd1cmF0aW9uLmphdmE=) | `100.00% <100.00%> (ø)` | |
| [...n/alibaba/dubbo/cache/AlibabaDubboConfigCache.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2746/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWR1YmJvL3NoZW55dS1wbHVnaW4tYWxpYmFiYS1kdWJiby9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L3BsdWdpbi9hbGliYWJhL2R1YmJvL2NhY2hlL0FsaWJhYmFEdWJib0NvbmZpZ0NhY2hlLmphdmE=) | `43.75% <0.00%> (-31.25%)` | :arrow_down: |
| [...gin/apache/dubbo/cache/ApacheDubboConfigCache.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2746/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWR1YmJvL3NoZW55dS1wbHVnaW4tYXBhY2hlLWR1YmJvL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvcGx1Z2luL2FwYWNoZS9kdWJiby9jYWNoZS9BcGFjaGVEdWJib0NvbmZpZ0NhY2hlLmphdmE=) | `43.03% <0.00%> (-29.12%)` | :arrow_down: |
| [...henyu/plugin/grpc/resolver/ShenyuNameResolver.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2746/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWdycGMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vZ3JwYy9yZXNvbHZlci9TaGVueXVOYW1lUmVzb2x2ZXIuamF2YQ==) | `44.68% <0.00%> (-19.15%)` | :arrow_down: |
| [...yu/sync/data/http/refresh/AbstractDataRefresh.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2746/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXN5bmMtZGF0YS1jZW50ZXIvc2hlbnl1LXN5bmMtZGF0YS1odHRwL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvc3luYy9kYXRhL2h0dHAvcmVmcmVzaC9BYnN0cmFjdERhdGFSZWZyZXNoLmphdmE=) | `70.00% <0.00%> (-13.34%)` | :arrow_down: |
| [...che/shenyu/sync/data/http/HttpSyncDataService.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2746/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXN5bmMtZGF0YS1jZW50ZXIvc2hlbnl1LXN5bmMtZGF0YS1odHRwL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvc3luYy9kYXRhL2h0dHAvSHR0cFN5bmNEYXRhU2VydmljZS5qYXZh) | `70.58% <0.00%> (-13.24%)` | :arrow_down: |
| [...apache/shenyu/admin/utils/ShenyuDictH2Trigger.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2746/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vdXRpbHMvU2hlbnl1RGljdEgyVHJpZ2dlci5qYXZh) | `63.63% <0.00%> (-9.10%)` | :arrow_down: |
| [...ache/shenyu/admin/utils/PluginHandleH2Trigger.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2746/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vdXRpbHMvUGx1Z2luSGFuZGxlSDJUcmlnZ2VyLmphdmE=) | `63.63% <0.00%> (-9.10%)` | :arrow_down: |
| [.../apache/shenyu/admin/model/dto/BatchCommonDTO.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2746/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vbW9kZWwvZHRvL0JhdGNoQ29tbW9uRFRPLmphdmE=) | `50.00% <0.00%> (-7.15%)` | :arrow_down: |
| [...apache/shenyu/admin/model/dto/AuthPathWarpDTO.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2746/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vbW9kZWwvZHRvL0F1dGhQYXRoV2FycERUTy5qYXZh) | `57.14% <0.00%> (-7.15%)` | :arrow_down: |
| ... and [24 more](https://codecov.io/gh/apache/incubator-shenyu/pull/2746/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/2746?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/2746?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [fe6f340...e577b55](https://codecov.io/gh/apache/incubator-shenyu/pull/2746?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org