You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Diana Arroyo <da...@us.ibm.com> on 2016/02/25 09:22:50 UTC

Re: Review Request 43889: CMAKE: Add leveldb library to 3rdparty external builds.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43889/
-----------------------------------------------------------

(Updated Feb. 25, 2016, 8:22 a.m.)


Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van Remoortere, Joseph Wu, and Till Toenshoff.


Changes
-------

Corrected LEVELDB_LIB definition.


Summary (updated)
-----------------

CMAKE: Add leveldb library to 3rdparty external builds.


Bugs: MESOS-4746
    https://issues.apache.org/jira/browse/MESOS-4746


Repository: mesos


Description (updated)
-------

CMAKE: Add leveldb library to 3rdparty external builds.


Diffs (updated)
-----

  3rdparty/cmake/Mesos3rdpartyConfigure.cmake 0c80fb8d799ea1252492cd98ac0780f1228aadcd 
  3rdparty/libprocess/cmake/Process3rdpartyConfigure.cmake d36fa2fbe903fb278e6c00b47bfa4b81cf8f4673 
  3rdparty/libprocess/cmake/ProcessTestsConfigure.cmake 3a2e0999722007475c023ade75719093e35cfc80 
  3rdparty/libprocess/cmake/macros/External.cmake e3901b67048f1c028216ae8323ee1c318a46f3cc 

Diff: https://reviews.apache.org/r/43889/diff/


Testing
-------

Tested on Ubuntu.


Thanks,

Diana Arroyo


Re: Review Request 43889: CMake: Add leveldb library to 3rdparty external builds.

Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43889/#review121598
-----------------------------------------------------------


Ship it!




Ship It!

- Joris Van Remoortere


On March 2, 2016, 6:15 a.m., Diana Arroyo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43889/
> -----------------------------------------------------------
> 
> (Updated March 2, 2016, 6:15 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van Remoortere, Joseph Wu, and Till Toenshoff.
> 
> 
> Bugs: MESOS-4746
>     https://issues.apache.org/jira/browse/MESOS-4746
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> CMake: Add leveldb library to 3rdparty external builds.
> 
> 
> Diffs
> -----
> 
>   3rdparty/CMakeLists.txt 68020dca6a4ea9790c9a54e5e33aa47674581a58 
>   3rdparty/Makefile.am 3782583b7683d9d3bb61e7e8a1953bc3f61055f0 
>   3rdparty/cmake/Mesos3rdpartyConfigure.cmake aaf1651e155b27a4f2cb72b4586d0d3d94a95b11 
>   3rdparty/cmake/Versions.cmake 932f2f66b04e5ca3d2ed04da1e7019d2ff7488e4 
>   3rdparty/leveldb-1.4.tar.gz PRE-CREATION 
>   3rdparty/leveldb.patch  
>   3rdparty/leveldb.tar.gz b6ea2c7df8f0eef687f9ad90af70f35f81743cbc 
>   3rdparty/versions.am 3f4513d960901bc0c014cc7ca148bf5bd43f5995 
>   LICENSE c3aaa437af10533132698df3348114195d338965 
>   src/Makefile.am 5d8fe8bf33acb352589b2b3e0341987f9a41bc17 
>   src/python/native/ext_modules.py.in 4682e5eed0f7be23fb48ef628e1bebc7741431d7 
>   src/slave/cmake/SlaveConfigure.cmake 5697a0bfa52e8ea15563bc0668ec63aadbb01ed3 
> 
> Diff: https://reviews.apache.org/r/43889/diff/
> 
> 
> Testing
> -------
> 
> Tested on Ubuntu.
> 
> 
> Thanks,
> 
> Diana Arroyo
> 
>


Re: Review Request 43889: CMake: Add leveldb library to 3rdparty external builds.

Posted by Alex Clemmer <cl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43889/#review121596
-----------------------------------------------------------


Ship it!




I'm voting ship it, but I do want to call out that I know almost nothing about the autotools build, so I'm not exactly qualified to vote on that.

- Alex Clemmer


On March 2, 2016, 6:15 a.m., Diana Arroyo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43889/
> -----------------------------------------------------------
> 
> (Updated March 2, 2016, 6:15 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van Remoortere, Joseph Wu, and Till Toenshoff.
> 
> 
> Bugs: MESOS-4746
>     https://issues.apache.org/jira/browse/MESOS-4746
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> CMake: Add leveldb library to 3rdparty external builds.
> 
> 
> Diffs
> -----
> 
>   3rdparty/CMakeLists.txt 68020dca6a4ea9790c9a54e5e33aa47674581a58 
>   3rdparty/Makefile.am 3782583b7683d9d3bb61e7e8a1953bc3f61055f0 
>   3rdparty/cmake/Mesos3rdpartyConfigure.cmake aaf1651e155b27a4f2cb72b4586d0d3d94a95b11 
>   3rdparty/cmake/Versions.cmake 932f2f66b04e5ca3d2ed04da1e7019d2ff7488e4 
>   3rdparty/leveldb-1.4.tar.gz PRE-CREATION 
>   3rdparty/leveldb.patch  
>   3rdparty/leveldb.tar.gz b6ea2c7df8f0eef687f9ad90af70f35f81743cbc 
>   3rdparty/versions.am 3f4513d960901bc0c014cc7ca148bf5bd43f5995 
>   LICENSE c3aaa437af10533132698df3348114195d338965 
>   src/Makefile.am 5d8fe8bf33acb352589b2b3e0341987f9a41bc17 
>   src/python/native/ext_modules.py.in 4682e5eed0f7be23fb48ef628e1bebc7741431d7 
>   src/slave/cmake/SlaveConfigure.cmake 5697a0bfa52e8ea15563bc0668ec63aadbb01ed3 
> 
> Diff: https://reviews.apache.org/r/43889/diff/
> 
> 
> Testing
> -------
> 
> Tested on Ubuntu.
> 
> 
> Thanks,
> 
> Diana Arroyo
> 
>


Re: Review Request 43889: CMake: Add leveldb library to 3rdparty external builds.

Posted by Diana Arroyo <da...@us.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43889/
-----------------------------------------------------------

(Updated March 2, 2016, 6:15 a.m.)


Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van Remoortere, Joseph Wu, and Till Toenshoff.


Changes
-------

More changes to handle rename in automake of leveldb to leveldb-1.4.


Bugs: MESOS-4746
    https://issues.apache.org/jira/browse/MESOS-4746


Repository: mesos


Description
-------

CMake: Add leveldb library to 3rdparty external builds.


Diffs (updated)
-----

  3rdparty/CMakeLists.txt 68020dca6a4ea9790c9a54e5e33aa47674581a58 
  3rdparty/Makefile.am 3782583b7683d9d3bb61e7e8a1953bc3f61055f0 
  3rdparty/cmake/Mesos3rdpartyConfigure.cmake aaf1651e155b27a4f2cb72b4586d0d3d94a95b11 
  3rdparty/cmake/Versions.cmake 932f2f66b04e5ca3d2ed04da1e7019d2ff7488e4 
  3rdparty/leveldb-1.4.tar.gz PRE-CREATION 
  3rdparty/leveldb.patch  
  3rdparty/leveldb.tar.gz b6ea2c7df8f0eef687f9ad90af70f35f81743cbc 
  3rdparty/versions.am 3f4513d960901bc0c014cc7ca148bf5bd43f5995 
  LICENSE c3aaa437af10533132698df3348114195d338965 
  src/Makefile.am 5d8fe8bf33acb352589b2b3e0341987f9a41bc17 
  src/python/native/ext_modules.py.in 4682e5eed0f7be23fb48ef628e1bebc7741431d7 
  src/slave/cmake/SlaveConfigure.cmake 5697a0bfa52e8ea15563bc0668ec63aadbb01ed3 

Diff: https://reviews.apache.org/r/43889/diff/


Testing
-------

Tested on Ubuntu.


Thanks,

Diana Arroyo


Re: Review Request 43889: CMake: Add leveldb library to 3rdparty external builds.

Posted by Alex Clemmer <cl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43889/#review121560
-----------------------------------------------------------


Ship it!




- Alex Clemmer


On March 2, 2016, 12:52 a.m., Diana Arroyo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43889/
> -----------------------------------------------------------
> 
> (Updated March 2, 2016, 12:52 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van Remoortere, Joseph Wu, and Till Toenshoff.
> 
> 
> Bugs: MESOS-4746
>     https://issues.apache.org/jira/browse/MESOS-4746
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> CMake: Add leveldb library to 3rdparty external builds.
> 
> 
> Diffs
> -----
> 
>   3rdparty/CMakeLists.txt 68020dca6a4ea9790c9a54e5e33aa47674581a58 
>   3rdparty/cmake/Mesos3rdpartyConfigure.cmake aaf1651e155b27a4f2cb72b4586d0d3d94a95b11 
>   3rdparty/cmake/Versions.cmake 932f2f66b04e5ca3d2ed04da1e7019d2ff7488e4 
>   3rdparty/leveldb-1.4.tar.gz PRE-CREATION 
>   3rdparty/leveldb.tar.gz b6ea2c7df8f0eef687f9ad90af70f35f81743cbc 
>   src/slave/cmake/SlaveConfigure.cmake 5697a0bfa52e8ea15563bc0668ec63aadbb01ed3 
> 
> Diff: https://reviews.apache.org/r/43889/diff/
> 
> 
> Testing
> -------
> 
> Tested on Ubuntu.
> 
> 
> Thanks,
> 
> Diana Arroyo
> 
>


Re: Review Request 43889: CMake: Add leveldb library to 3rdparty external builds.

Posted by Alex Clemmer <cl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43889/#review121561
-----------------------------------------------------------




3rdparty/CMakeLists.txt (line 30)
<https://reviews.apache.org/r/43889/#comment183301>

    Oh wait. Sorry, I marked this as ship it, but you forgot to update the Makefile.am (my build just failed as a result).
    
    As soon as you update that and test the build, you should push this up, and then I think it's ready to go.


- Alex Clemmer


On March 2, 2016, 12:52 a.m., Diana Arroyo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43889/
> -----------------------------------------------------------
> 
> (Updated March 2, 2016, 12:52 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van Remoortere, Joseph Wu, and Till Toenshoff.
> 
> 
> Bugs: MESOS-4746
>     https://issues.apache.org/jira/browse/MESOS-4746
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> CMake: Add leveldb library to 3rdparty external builds.
> 
> 
> Diffs
> -----
> 
>   3rdparty/CMakeLists.txt 68020dca6a4ea9790c9a54e5e33aa47674581a58 
>   3rdparty/cmake/Mesos3rdpartyConfigure.cmake aaf1651e155b27a4f2cb72b4586d0d3d94a95b11 
>   3rdparty/cmake/Versions.cmake 932f2f66b04e5ca3d2ed04da1e7019d2ff7488e4 
>   3rdparty/leveldb-1.4.tar.gz PRE-CREATION 
>   3rdparty/leveldb.tar.gz b6ea2c7df8f0eef687f9ad90af70f35f81743cbc 
>   src/slave/cmake/SlaveConfigure.cmake 5697a0bfa52e8ea15563bc0668ec63aadbb01ed3 
> 
> Diff: https://reviews.apache.org/r/43889/diff/
> 
> 
> Testing
> -------
> 
> Tested on Ubuntu.
> 
> 
> Thanks,
> 
> Diana Arroyo
> 
>


Re: Review Request 43889: CMake: Add leveldb library to 3rdparty external builds.

Posted by Diana Arroyo <da...@us.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43889/
-----------------------------------------------------------

(Updated March 2, 2016, 12:52 a.m.)


Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van Remoortere, Joseph Wu, and Till Toenshoff.


Summary (updated)
-----------------

CMake: Add leveldb library to 3rdparty external builds.


Bugs: MESOS-4746
    https://issues.apache.org/jira/browse/MESOS-4746


Repository: mesos


Description (updated)
-------

CMake: Add leveldb library to 3rdparty external builds.


Diffs (updated)
-----

  3rdparty/CMakeLists.txt 68020dca6a4ea9790c9a54e5e33aa47674581a58 
  3rdparty/cmake/Mesos3rdpartyConfigure.cmake aaf1651e155b27a4f2cb72b4586d0d3d94a95b11 
  3rdparty/cmake/Versions.cmake 932f2f66b04e5ca3d2ed04da1e7019d2ff7488e4 
  3rdparty/leveldb-1.4.tar.gz PRE-CREATION 
  3rdparty/leveldb.tar.gz b6ea2c7df8f0eef687f9ad90af70f35f81743cbc 
  src/slave/cmake/SlaveConfigure.cmake 5697a0bfa52e8ea15563bc0668ec63aadbb01ed3 

Diff: https://reviews.apache.org/r/43889/diff/


Testing
-------

Tested on Ubuntu.


Thanks,

Diana Arroyo


Re: Review Request 43889: CMAKE: Add leveldb library to 3rdparty external builds.

Posted by Diana Arroyo <da...@us.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43889/
-----------------------------------------------------------

(Updated Feb. 25, 2016, 7:42 p.m.)


Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van Remoortere, Joseph Wu, and Till Toenshoff.


Changes
-------

Corrected LEVELDB_LIB to point to leveldb library.


Bugs: MESOS-4746
    https://issues.apache.org/jira/browse/MESOS-4746


Repository: mesos


Description
-------

CMAKE: Add leveldb library to 3rdparty external builds.


Diffs (updated)
-----

  3rdparty/cmake/Mesos3rdpartyConfigure.cmake 0c80fb8d799ea1252492cd98ac0780f1228aadcd 
  3rdparty/libprocess/cmake/Process3rdpartyConfigure.cmake d36fa2fbe903fb278e6c00b47bfa4b81cf8f4673 
  3rdparty/libprocess/cmake/ProcessTestsConfigure.cmake 3a2e0999722007475c023ade75719093e35cfc80 
  3rdparty/libprocess/cmake/macros/External.cmake e3901b67048f1c028216ae8323ee1c318a46f3cc 

Diff: https://reviews.apache.org/r/43889/diff/


Testing
-------

Tested on Ubuntu.


Thanks,

Diana Arroyo