You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2020/07/08 07:43:25 UTC
[GitHub] [incubator-echarts-doc] wf123537200 opened a new pull request #123: add(option.series.graph):add auto curveness doc
wf123537200 opened a new pull request #123:
URL: https://github.com/apache/incubator-echarts-doc/pull/123
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts-doc] Ovilia commented on pull request #123: add(option.series.graph):add auto curveness doc
Posted by GitBox <gi...@apache.org>.
Ovilia commented on pull request #123:
URL: https://github.com/apache/incubator-echarts-doc/pull/123#issuecomment-655423685
Please link the PR of ECharts changes to this.
Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts-doc] wf123537200 commented on pull request #123: add(option.series.graph):add auto curveness doc
Posted by GitBox <gi...@apache.org>.
wf123537200 commented on pull request #123:
URL: https://github.com/apache/incubator-echarts-doc/pull/123#issuecomment-655410791
@plainheart thank you for review，the changes requested has been fixed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts-doc] plainheart commented on a change in pull request #123: add(option.series.graph):add auto curveness doc
Posted by GitBox <gi...@apache.org>.
plainheart commented on a change in pull request #123:
URL: https://github.com/apache/incubator-echarts-doc/pull/123#discussion_r451389594
##########
File path: en/option/series/graph.md
##########
@@ -213,6 +213,15 @@ The label style of node in this category.
#### label(Object)
{{ use:partial-label(prefix="####") }}
+## autoCurveness(number|Array) = 20
+
+For the situation where there are multiple links between nodes, the curveness of each links is automatically calculated.
Review comment:
`each links` should be `each link`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts-doc] plainheart commented on a change in pull request #123: add(option.series.graph):add auto curveness doc
Posted by GitBox <gi...@apache.org>.
plainheart commented on a change in pull request #123:
URL: https://github.com/apache/incubator-echarts-doc/pull/123#discussion_r451405073
##########
File path: zh/option/series/graph.md
##########
@@ -261,6 +261,16 @@ edgeSymbol: ['circle', 'arrow']
{{ use:partial-label(prefix="####") }}
+## autoCurveness(number|Array) = 20
+
+针对点之间存在多边的情况，自动计算各边曲率。
+
+设置为 `Number` 时，表示两点间边曲率数组的长度，由内部算法给出计算结果。
+
+设置为 `Array` 时, 表示直接指定曲率数组，多边曲率会从数组中直接按顺序选取。
Review comment:
`,` should be `，`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts-doc] Ovilia commented on a change in pull request #123: add(option.series.graph):add auto curveness doc
Posted by GitBox <gi...@apache.org>.
Ovilia commented on a change in pull request #123:
URL: https://github.com/apache/incubator-echarts-doc/pull/123#discussion_r451500887
##########
File path: en/option/series/graph.md
##########
@@ -213,6 +213,15 @@ The label style of node in this category.
#### label(Object)
{{ use:partial-label(prefix="####") }}
+## autoCurveness(number|Array) = 20
+
+For the situation where there are multiple links between nodes, the curveness of each link is automatically calculated.
+
+When set to `Number`, it indicates the length of the edge curveness array between two nodes, and the calculation result is given by the internal algorithm.
Review comment:
`Number` should be `number` since it's primitive.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts-doc] Ovilia commented on a change in pull request #123: add(option.series.graph):add auto curveness doc
Posted by GitBox <gi...@apache.org>.
Ovilia commented on a change in pull request #123:
URL: https://github.com/apache/incubator-echarts-doc/pull/123#discussion_r451429956
##########
File path: zh/option/series/graph.md
##########
@@ -261,6 +261,16 @@ edgeSymbol: ['circle', 'arrow']
{{ use:partial-label(prefix="####") }}
+## autoCurveness(number|Array) = 20
+
+针对节点之间存在多边的情况，自动计算各边曲率。
+
+设置为 `Number` 时，表示两点间边曲率数组的长度，由内部算法给出计算结果。
+
+设置为 `Array` 时，表示直接指定曲率数组，多边曲率会从数组中直接按顺序选取。
+
+**注意：** 如果设置[lineStyle.curveness](~series-graph.lineStyle.curveness)则此属性失效。
Review comment:
中文混排需要加入空格，这里“设置”后，“则”前应该加个空格
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts-doc] plainheart commented on a change in pull request #123: add(option.series.graph):add auto curveness doc
Posted by GitBox <gi...@apache.org>.
plainheart commented on a change in pull request #123:
URL: https://github.com/apache/incubator-echarts-doc/pull/123#discussion_r451380094
##########
File path: zh/option/series/graph.md
##########
@@ -261,6 +261,16 @@ edgeSymbol: ['circle', 'arrow']
{{ use:partial-label(prefix="####") }}
+## autoCurveness(number|Array) = 20
+
+针对点之间存在多边的情况，自动计算各边曲率。
Review comment:
Hereafter, it's better to change `点` to `节点`.
##########
File path: en/option/series/graph.md
##########
@@ -213,6 +213,15 @@ The label style of node in this category.
#### label(Object)
{{ use:partial-label(prefix="####") }}
+## autoCurveness(number|Array) = 20
+
+For the situation where there are multiple links between nodes, the curveness of each links is automatically calculated.
+
+When set to `Number`, it indicates the length of the edge curveness array between two points, and the calculation result is given by the internal algorithm.
+
+When set to `Array`, it means that the curveness array is directly specified, and the multilateral curvature is directly selected from the array.
Review comment:
Is `curveness` the same as `curvature`?
##########
File path: en/option/series/graph.md
##########
@@ -213,6 +213,15 @@ The label style of node in this category.
#### label(Object)
{{ use:partial-label(prefix="####") }}
+## autoCurveness(number|Array) = 20
+
+For the situation where there are multiple links between nodes, the curveness of each links is automatically calculated.
Review comment:
`links` should be `link`.
##########
File path: en/option/series/graph.md
##########
@@ -213,6 +213,15 @@ The label style of node in this category.
#### label(Object)
{{ use:partial-label(prefix="####") }}
+## autoCurveness(number|Array) = 20
+
+For the situation where there are multiple links between nodes, the curveness of each links is automatically calculated.
+
+When set to `Number`, it indicates the length of the edge curveness array between two points, and the calculation result is given by the internal algorithm.
+
+When set to `Array`, it means that the curveness array is directly specified, and the multilateral curvature is directly selected from the array.
+
+**Notice：** if [lineStyle.curveness](~series-graph.lineStyle.curveness) has been setted, this property is invalid.
Review comment:
I'm afraid there is no such usage of `setted`, the past participle of `set` is still `set`.
##########
File path: en/option/series/graph.md
##########
@@ -213,6 +213,15 @@ The label style of node in this category.
#### label(Object)
{{ use:partial-label(prefix="####") }}
+## autoCurveness(number|Array) = 20
+
+For the situation where there are multiple links between nodes, the curveness of each links is automatically calculated.
+
+When set to `Number`, it indicates the length of the edge curveness array between two points, and the calculation result is given by the internal algorithm.
Review comment:
The same as Chinese, `points` might be `nodes`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts-doc] Ovilia merged pull request #123: add(option.series.graph):add auto curveness doc
Posted by GitBox <gi...@apache.org>.
Ovilia merged pull request #123:
URL: https://github.com/apache/incubator-echarts-doc/pull/123
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts-doc] susiwen8 commented on a change in pull request #123: add(option.series.graph):add auto curveness doc
Posted by GitBox <gi...@apache.org>.
susiwen8 commented on a change in pull request #123:
URL: https://github.com/apache/incubator-echarts-doc/pull/123#discussion_r451356192
##########
File path: en/option/series/graph.md
##########
@@ -213,6 +213,15 @@ The label style of node in this category.
#### label(Object)
{{ use:partial-label(prefix="####") }}
+## autoCurveness(number|Array) = 20
+
+For the situation where there are multiple links between nodes, the curveness of each links is automatically calculated.
+
+When set to Number, it indicates the length of the edge curveness array between two points, and the calculation result is given by the internal algorithm.
Review comment:
Change Number to `Number`
##########
File path: zh/option/series/graph.md
##########
@@ -261,6 +261,16 @@ edgeSymbol: ['circle', 'arrow']
{{ use:partial-label(prefix="####") }}
+## autoCurveness(number|Array) = 20
+
+针对点之间存在多边的情况，自动计算各边曲率。
+
+设置为 Number时，表示两点间边曲率数组的长度，由内部算法给出计算结果。
+
+设置为 Array时, 表示直接指定曲率数组，多边曲率会从数组中直接按顺序选取。
Review comment:
Same here
##########
File path: en/option/series/graph.md
##########
@@ -213,6 +213,15 @@ The label style of node in this category.
#### label(Object)
{{ use:partial-label(prefix="####") }}
+## autoCurveness(number|Array) = 20
+
+For the situation where there are multiple links between nodes, the curveness of each links is automatically calculated.
+
+When set to Number, it indicates the length of the edge curveness array between two points, and the calculation result is given by the internal algorithm.
+
+When set to Array, it means that the curveness array is directly specified, and the multilateral curvature is directly selected from the array.
Review comment:
Change Array to `Array`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org