You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mesos.apache.org by bb...@apache.org on 2019/01/02 11:31:32 UTC

[mesos] branch master updated: Improved wording in comments for `AgentAdded` event.

This is an automated email from the ASF dual-hosted git repository.

bbannier pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/mesos.git


The following commit(s) were added to refs/heads/master by this push:
     new 7a37859  Improved wording in comments for `AgentAdded` event.
7a37859 is described below

commit 7a378597d6a4359de0b1eabb563d4c12cdb4290e
Author: Benno Evers <be...@mesosphere.com>
AuthorDate: Wed Jan 2 12:28:29 2019 +0100

    Improved wording in comments for `AgentAdded` event.
    
    The comment mentioned that `AgentAdded` events can be
    sent when an agent reregisters after a master failover.
    This is technically correct, but neglects to mention
    that the event can also be sent when the agent reregisters
    at any other point in time.
    
    Review: https://reviews.apache.org/r/69447/
---
 include/mesos/master/master.proto    | 2 +-
 include/mesos/v1/master/master.proto | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/include/mesos/master/master.proto b/include/mesos/master/master.proto
index 80bd7c4..0dc2d68 100644
--- a/include/mesos/master/master.proto
+++ b/include/mesos/master/master.proto
@@ -658,7 +658,7 @@ message Event {
 
   // Forwarded by the master when an agent becomes known to it.
   // This can happen when an agent registered for the first
-  // time, or reregistered after a master failover.
+  // time, or reregistered with the master.
   message AgentAdded {
     required Response.GetAgents.Agent agent = 1;
   }
diff --git a/include/mesos/v1/master/master.proto b/include/mesos/v1/master/master.proto
index cd41a7e..3816ab4 100644
--- a/include/mesos/v1/master/master.proto
+++ b/include/mesos/v1/master/master.proto
@@ -655,7 +655,7 @@ message Event {
 
   // Forwarded by the master when an agent becomes known to it.
   // This can happen when an agent registered for the first
-  // time, or reregistered after a master failover.
+  // time, or reregistered with the master.
   message AgentAdded {
     required Response.GetAgents.Agent agent = 1;
   }