You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by GitBox <gi...@apache.org> on 2021/07/22 19:18:22 UTC
[GitHub] [accumulo] DomGarguilo opened a new pull request #2211: Sanity check table properties prior to creation of fate operation
DomGarguilo opened a new pull request #2211:
URL: https://github.com/apache/accumulo/pull/2211
Fixes #2196.
A check has been added to `FateServiceHandler` to check the properties before the create table operation is kicked off. This check makes use of the return value of the already-in-place `TablePropUtil.setTableProperty`
A redundant check is added to `PopulateZookeeper`.
These two additions essentially do the same thing, so it has been mentioned that a single static method could be added and used in these two places. I wanted to get some feedback on the trade off between these changes which make use of the existing code, and the possibility of using a single method here instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] milleruntime commented on pull request #2211: Sanity check table properties prior to creation of fate operation
Posted by GitBox <gi...@apache.org>.
milleruntime commented on pull request #2211:
URL: https://github.com/apache/accumulo/pull/2211#issuecomment-885683174
@EdColeman is this an OK time to merge this PR? I know it touches some code you are working on.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] EdColeman merged pull request #2211: Sanity check table properties prior to creation of fate operation
Posted by GitBox <gi...@apache.org>.
EdColeman merged pull request #2211:
URL: https://github.com/apache/accumulo/pull/2211
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org