[jira] [Comment Edited] (HBASE-13431) Move splitStoreFile to SplitTransaction interface to allow creating both reference files in case required

["Anoop Sam John (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-13431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14517141#comment-14517141 ] 

Anoop Sam John edited comment on HBASE-13431 at 4/28/15 2:58 PM:
-----------------------------------------------------------------

Can't we just use the default RegionSplitPolicy for non index cfs and extended (Phoenix own) one for index cf?
Why I say is, passing the policy looks cleaner than a boolean. This will be forward compatible also.


was (Author: anoop.hbase):
Can't we just use the default RegionSplitPolicy for non index cfs and extended (Phoenix own) one for index cf?

> Move splitStoreFile to SplitTransaction interface to allow creating both reference files in case required
> ---------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-13431
>                 URL: https://issues.apache.org/jira/browse/HBASE-13431
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Rajeshbabu Chintaguntla
>            Assignee: Rajeshbabu Chintaguntla
>             Fix For: 2.0.0, 1.1.0
>
>         Attachments: HBASE-13431.patch, HBASE-13431_v2.patch
>
>
>  APPROACH #3 at PHOENIX-1734 helps to implement local indexing without much changes in HBase. For split we need one kernel change to allow creating both top and bottom reference files for index column family store files even when the split key not in the storefile key range. 
> The changes helps in this case are  
> 1) pass boolean to HRegionFileSystem#splitStoreFile to allow to skip the storefile key range check.
> 2) move the splitStoreFile with extra boolean parameter  to the new interface introduced at HBASE-12975. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)