You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/08/19 12:46:33 UTC
[GitHub] [skywalking] wu-sheng opened a new issue #5355: Forward the alarm message to slack
wu-sheng opened a new issue #5355:
URL: https://github.com/apache/skywalking/issues/5355
As Slack provides HTTP based integration, we hope our alarm message could forward to it out of the box.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] kezhenxu94 commented on issue #5355: Forward the alarm message to slack
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on issue #5355:
URL: https://github.com/apache/skywalking/issues/5355#issuecomment-676302717
Do we want to couple a specific implementation of alarm? What's the idea to loosely achieve this
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng closed issue #5355: Forward the alarm message to slack
Posted by GitBox <gi...@apache.org>.
wu-sheng closed issue #5355:
URL: https://github.com/apache/skywalking/issues/5355
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #5355: Forward the alarm message to slack
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #5355:
URL: https://github.com/apache/skywalking/issues/5355#issuecomment-676305696
Because it is light-weight enough, nothing special. Slack just asked a specific format HTTP request. Do you have any concern about this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #5355: Forward the alarm message to slack
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #5355:
URL: https://github.com/apache/skywalking/issues/5355#issuecomment-676351116
Nothing special for the Slack, this is just a start. Anything with the HTTP/gRPC format could be added in the upstream, including wechat/dingtalk, unless they requires private/source-closed API/SDKs
> A possible concern is that this is not testable, unless we don't want to test that part
Yes, I think this is hard to test. That is why I asked @JaredTan95 as a PMC member to do this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] kezhenxu94 edited a comment on issue #5355: Forward the alarm message to slack
Posted by GitBox <gi...@apache.org>.
kezhenxu94 edited a comment on issue #5355:
URL: https://github.com/apache/skywalking/issues/5355#issuecomment-676302717
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] kezhenxu94 edited a comment on issue #5355: Forward the alarm message to slack
Posted by GitBox <gi...@apache.org>.
kezhenxu94 edited a comment on issue #5355:
URL: https://github.com/apache/skywalking/issues/5355#issuecomment-676343759
> Because it is light-weight enough, nothing special. Slack just asked a specific format HTTP request. Do you have any concern about this?
I'm totally agree to forward alarm message to Slack channel, but I'm also wondering what makes Slack special, compared with any other IM tools that also just ask a "special format of HTTP request" (light-weight in your words), something like WeChat, Dingtalk, etc. if we have Slack implementation, users will ask for Dingtalk's, WeChat's, do we also accept contributions of that?
A possible concern is that this is not testable, unless we don't want to test that part
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] kezhenxu94 commented on issue #5355: Forward the alarm message to slack
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on issue #5355:
URL: https://github.com/apache/skywalking/issues/5355#issuecomment-676343759
> Because it is light-weight enough, nothing special. Slack just asked a specific format HTTP request. Do you have any concern about this?
I'm totally agree to forward alarm message to Slack channel, but I'm also wondering what makes Slack special, compared with any other IM tools that also just ask a "special format of HTTP request", something like WeChat, Dingtalk, etc. if we have Slack implementation, users will ask for Dingtalk's, WeChat's, do we also accept contributions of that?
A possible concern is that this is not testable, unless we don't want to test that part
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org