You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/02/15 16:13:07 UTC
[GitHub] [airflow] enniomorricone123 opened a new pull request #21322: fixed K8S connection creation issue when kubeconfig or kubeconfig_path is empty string
enniomorricone123 opened a new pull request #21322:
URL: https://github.com/apache/airflow/pull/21322
When connection is defined from web UI all "extra" values get empty string for un-set values.
But in k8s hook we make decisions based on `is not None`.
These two ways of handling the values are incompatible. So we change to truthy evaluation here.
closes: #20626
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #21322: fixed K8S connection issue when kubeconfig is empty string
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #21322:
URL: https://github.com/apache/airflow/pull/21322#issuecomment-1029924068
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (flake8, mypy and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/main/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/docs/apache-airflow/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/BREEZE.rst) for testing locally, itโs a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#coding-style-and-best-practices).
Apache Airflow is a community-driven project and together we are making it better ๐.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] enniomorricone123 commented on pull request #21322: fixed K8S connection creation issue when kubeconfig or kubeconfig_path is empty string
Posted by GitBox <gi...@apache.org>.
enniomorricone123 commented on pull request #21322:
URL: https://github.com/apache/airflow/pull/21322#issuecomment-1030255251
> I think there are some test cases covering already - could you please add a test case covering this case? sounds like an easy one
yes, will do
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #21322: fixed K8S connection creation issue when kubeconfig or kubeconfig_path is empty string
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #21322:
URL: https://github.com/apache/airflow/pull/21322#issuecomment-1030099690
I think there are some test cases covering already - could you please add a test case covering this case? sounds like an easy one
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] dstandish commented on pull request #21322: fixed K8S connection creation issue when kubeconfig or kubeconfig_path is empty string
Posted by GitBox <gi...@apache.org>.
dstandish commented on pull request #21322:
URL: https://github.com/apache/airflow/pull/21322#issuecomment-1040496839
this was resolved by https://github.com/apache/airflow/pull/19695
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] dstandish closed pull request #21322: fixed K8S connection creation issue when kubeconfig or kubeconfig_path is empty string
Posted by GitBox <gi...@apache.org>.
dstandish closed pull request #21322:
URL: https://github.com/apache/airflow/pull/21322
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal commented on pull request #21322: fixed K8S connection creation issue when kubeconfig or kubeconfig_path is empty string
Posted by GitBox <gi...@apache.org>.
eladkal commented on pull request #21322:
URL: https://github.com/apache/airflow/pull/21322#issuecomment-1037951899
@enniomorricone123 Why did you close the PR? was it by mistake?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] dstandish closed pull request #21322: fixed K8S connection creation issue when kubeconfig or kubeconfig_path is empty string
Posted by GitBox <gi...@apache.org>.
dstandish closed pull request #21322:
URL: https://github.com/apache/airflow/pull/21322
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal commented on pull request #21322: fixed K8S connection creation issue when kubeconfig or kubeconfig_path is empty string
Posted by GitBox <gi...@apache.org>.
eladkal commented on pull request #21322:
URL: https://github.com/apache/airflow/pull/21322#issuecomment-1037951899
@enniomorricone123 Why did you close the PR? was it by mistake?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] dstandish commented on pull request #21322: fixed K8S connection creation issue when kubeconfig or kubeconfig_path is empty string
Posted by GitBox <gi...@apache.org>.
dstandish commented on pull request #21322:
URL: https://github.com/apache/airflow/pull/21322#issuecomment-1040496839
this was resolved by https://github.com/apache/airflow/pull/19695
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] enniomorricone123 closed pull request #21322: fixed K8S connection creation issue when kubeconfig or kubeconfig_path is empty string
Posted by GitBox <gi...@apache.org>.
enniomorricone123 closed pull request #21322:
URL: https://github.com/apache/airflow/pull/21322
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org