You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2020/06/27 01:08:43 UTC

[GitHub] [geode] dschneider-pivotal commented on a change in pull request #5316: GEODE-8312: Improve Redis pub/sub capabilities

dschneider-pivotal commented on a change in pull request #5316:
URL: https://github.com/apache/geode/pull/5316#discussion_r446465548



##########
File path: geode-redis/src/main/java/org/apache/geode/redis/internal/netty/ExecutionHandlerContext.java
##########
@@ -188,6 +188,13 @@ private void executeCommand(ChannelHandlerContext ctx, Command command) throws E
       return;
     }
 
+    if (command.isOfType(RedisCommandType.SELECT)

Review comment:
       I don't understand why this code was added. These commands are on our unimplemented list. Was this added to this PR by accident?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org