You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hbase.apache.org by gi...@apache.org on 2018/01/27 15:13:47 UTC

[03/24] hbase-site git commit: Published site at .

http://git-wip-us.apache.org/repos/asf/hbase-site/blob/48b00154/testdevapidocs/src-html/org/apache/hadoop/hbase/master/balancer/TestStochasticLoadBalancer.MockCluster.html
----------------------------------------------------------------------
diff --git a/testdevapidocs/src-html/org/apache/hadoop/hbase/master/balancer/TestStochasticLoadBalancer.MockCluster.html b/testdevapidocs/src-html/org/apache/hadoop/hbase/master/balancer/TestStochasticLoadBalancer.MockCluster.html
index 635cf6d..7a50ac9 100644
--- a/testdevapidocs/src-html/org/apache/hadoop/hbase/master/balancer/TestStochasticLoadBalancer.MockCluster.html
+++ b/testdevapidocs/src-html/org/apache/hadoop/hbase/master/balancer/TestStochasticLoadBalancer.MockCluster.html
@@ -33,690 +33,376 @@
 <span class="sourceLineNo">025</span>import static org.mockito.Mockito.when;<a name="line.25"></a>
 <span class="sourceLineNo">026</span><a name="line.26"></a>
 <span class="sourceLineNo">027</span>import java.util.ArrayList;<a name="line.27"></a>
-<span class="sourceLineNo">028</span>import java.util.HashMap;<a name="line.28"></a>
-<span class="sourceLineNo">029</span>import java.util.Iterator;<a name="line.29"></a>
-<span class="sourceLineNo">030</span>import java.util.List;<a name="line.30"></a>
-<span class="sourceLineNo">031</span>import java.util.Map;<a name="line.31"></a>
-<span class="sourceLineNo">032</span>import java.util.Map.Entry;<a name="line.32"></a>
-<span class="sourceLineNo">033</span>import java.util.Queue;<a name="line.33"></a>
-<span class="sourceLineNo">034</span>import java.util.TreeMap;<a name="line.34"></a>
-<span class="sourceLineNo">035</span>import org.apache.hadoop.conf.Configuration;<a name="line.35"></a>
-<span class="sourceLineNo">036</span>import org.apache.hadoop.hbase.ClusterMetrics;<a name="line.36"></a>
-<span class="sourceLineNo">037</span>import org.apache.hadoop.hbase.HBaseConfiguration;<a name="line.37"></a>
-<span class="sourceLineNo">038</span>import org.apache.hadoop.hbase.RegionMetrics;<a name="line.38"></a>
-<span class="sourceLineNo">039</span>import org.apache.hadoop.hbase.ServerMetrics;<a name="line.39"></a>
-<span class="sourceLineNo">040</span>import org.apache.hadoop.hbase.ServerName;<a name="line.40"></a>
-<span class="sourceLineNo">041</span>import org.apache.hadoop.hbase.Size;<a name="line.41"></a>
-<span class="sourceLineNo">042</span>import org.apache.hadoop.hbase.client.RegionInfo;<a name="line.42"></a>
-<span class="sourceLineNo">043</span>import org.apache.hadoop.hbase.client.RegionReplicaUtil;<a name="line.43"></a>
-<span class="sourceLineNo">044</span>import org.apache.hadoop.hbase.master.MockNoopMasterServices;<a name="line.44"></a>
-<span class="sourceLineNo">045</span>import org.apache.hadoop.hbase.master.RackManager;<a name="line.45"></a>
-<span class="sourceLineNo">046</span>import org.apache.hadoop.hbase.master.RegionPlan;<a name="line.46"></a>
-<span class="sourceLineNo">047</span>import org.apache.hadoop.hbase.master.balancer.BaseLoadBalancer.Cluster;<a name="line.47"></a>
-<span class="sourceLineNo">048</span>import org.apache.hadoop.hbase.master.balancer.StochasticLoadBalancer.ServerLocalityCostFunction;<a name="line.48"></a>
-<span class="sourceLineNo">049</span>import org.apache.hadoop.hbase.testclassification.FlakeyTests;<a name="line.49"></a>
-<span class="sourceLineNo">050</span>import org.apache.hadoop.hbase.testclassification.MediumTests;<a name="line.50"></a>
-<span class="sourceLineNo">051</span>import org.apache.hadoop.hbase.util.Bytes;<a name="line.51"></a>
-<span class="sourceLineNo">052</span>import org.junit.Ignore;<a name="line.52"></a>
-<span class="sourceLineNo">053</span>import org.junit.Test;<a name="line.53"></a>
-<span class="sourceLineNo">054</span>import org.junit.experimental.categories.Category;<a name="line.54"></a>
-<span class="sourceLineNo">055</span>import org.slf4j.Logger;<a name="line.55"></a>
-<span class="sourceLineNo">056</span>import org.slf4j.LoggerFactory;<a name="line.56"></a>
-<span class="sourceLineNo">057</span><a name="line.57"></a>
-<span class="sourceLineNo">058</span>@Category({FlakeyTests.class, MediumTests.class})<a name="line.58"></a>
-<span class="sourceLineNo">059</span>public class TestStochasticLoadBalancer extends BalancerTestBase {<a name="line.59"></a>
-<span class="sourceLineNo">060</span>  public static final String REGION_KEY = "testRegion";<a name="line.60"></a>
-<span class="sourceLineNo">061</span>  private static final Logger LOG = LoggerFactory.getLogger(TestStochasticLoadBalancer.class);<a name="line.61"></a>
-<span class="sourceLineNo">062</span><a name="line.62"></a>
-<span class="sourceLineNo">063</span>  // Mapping of locality test -&gt; expected locality<a name="line.63"></a>
-<span class="sourceLineNo">064</span>  private float[] expectedLocalities = {1.0f, 0.0f, 0.50f, 0.25f, 1.0f};<a name="line.64"></a>
+<span class="sourceLineNo">028</span>import java.util.List;<a name="line.28"></a>
+<span class="sourceLineNo">029</span>import java.util.Map;<a name="line.29"></a>
+<span class="sourceLineNo">030</span>import java.util.Queue;<a name="line.30"></a>
+<span class="sourceLineNo">031</span>import java.util.TreeMap;<a name="line.31"></a>
+<span class="sourceLineNo">032</span>import org.apache.hadoop.conf.Configuration;<a name="line.32"></a>
+<span class="sourceLineNo">033</span>import org.apache.hadoop.hbase.ClusterMetrics;<a name="line.33"></a>
+<span class="sourceLineNo">034</span>import org.apache.hadoop.hbase.HBaseConfiguration;<a name="line.34"></a>
+<span class="sourceLineNo">035</span>import org.apache.hadoop.hbase.RegionMetrics;<a name="line.35"></a>
+<span class="sourceLineNo">036</span>import org.apache.hadoop.hbase.ServerMetrics;<a name="line.36"></a>
+<span class="sourceLineNo">037</span>import org.apache.hadoop.hbase.ServerName;<a name="line.37"></a>
+<span class="sourceLineNo">038</span>import org.apache.hadoop.hbase.Size;<a name="line.38"></a>
+<span class="sourceLineNo">039</span>import org.apache.hadoop.hbase.client.RegionInfo;<a name="line.39"></a>
+<span class="sourceLineNo">040</span>import org.apache.hadoop.hbase.master.MockNoopMasterServices;<a name="line.40"></a>
+<span class="sourceLineNo">041</span>import org.apache.hadoop.hbase.master.RegionPlan;<a name="line.41"></a>
+<span class="sourceLineNo">042</span>import org.apache.hadoop.hbase.master.balancer.BaseLoadBalancer.Cluster;<a name="line.42"></a>
+<span class="sourceLineNo">043</span>import org.apache.hadoop.hbase.master.balancer.StochasticLoadBalancer.ServerLocalityCostFunction;<a name="line.43"></a>
+<span class="sourceLineNo">044</span>import org.apache.hadoop.hbase.testclassification.MasterTests;<a name="line.44"></a>
+<span class="sourceLineNo">045</span>import org.apache.hadoop.hbase.testclassification.MediumTests;<a name="line.45"></a>
+<span class="sourceLineNo">046</span>import org.apache.hadoop.hbase.util.Bytes;<a name="line.46"></a>
+<span class="sourceLineNo">047</span>import org.junit.Test;<a name="line.47"></a>
+<span class="sourceLineNo">048</span>import org.junit.experimental.categories.Category;<a name="line.48"></a>
+<span class="sourceLineNo">049</span><a name="line.49"></a>
+<span class="sourceLineNo">050</span>@Category({ MasterTests.class, MediumTests.class })<a name="line.50"></a>
+<span class="sourceLineNo">051</span>public class TestStochasticLoadBalancer extends BalancerTestBase {<a name="line.51"></a>
+<span class="sourceLineNo">052</span>  private static final String REGION_KEY = "testRegion";<a name="line.52"></a>
+<span class="sourceLineNo">053</span><a name="line.53"></a>
+<span class="sourceLineNo">054</span>  // Mapping of locality test -&gt; expected locality<a name="line.54"></a>
+<span class="sourceLineNo">055</span>  private float[] expectedLocalities = {1.0f, 0.0f, 0.50f, 0.25f, 1.0f};<a name="line.55"></a>
+<span class="sourceLineNo">056</span><a name="line.56"></a>
+<span class="sourceLineNo">057</span>  /**<a name="line.57"></a>
+<span class="sourceLineNo">058</span>   * Data set for testLocalityCost:<a name="line.58"></a>
+<span class="sourceLineNo">059</span>   * [test][0][0] = mapping of server to number of regions it hosts<a name="line.59"></a>
+<span class="sourceLineNo">060</span>   * [test][region + 1][0] = server that region is hosted on<a name="line.60"></a>
+<span class="sourceLineNo">061</span>   * [test][region + 1][server + 1] = locality for region on server<a name="line.61"></a>
+<span class="sourceLineNo">062</span>   */<a name="line.62"></a>
+<span class="sourceLineNo">063</span><a name="line.63"></a>
+<span class="sourceLineNo">064</span>  private int[][][] clusterRegionLocationMocks = new int[][][]{<a name="line.64"></a>
 <span class="sourceLineNo">065</span><a name="line.65"></a>
-<span class="sourceLineNo">066</span>  /**<a name="line.66"></a>
-<span class="sourceLineNo">067</span>   * Data set for testLocalityCost:<a name="line.67"></a>
-<span class="sourceLineNo">068</span>   * [test][0][0] = mapping of server to number of regions it hosts<a name="line.68"></a>
-<span class="sourceLineNo">069</span>   * [test][region + 1][0] = server that region is hosted on<a name="line.69"></a>
-<span class="sourceLineNo">070</span>   * [test][region + 1][server + 1] = locality for region on server<a name="line.70"></a>
-<span class="sourceLineNo">071</span>   */<a name="line.71"></a>
-<span class="sourceLineNo">072</span><a name="line.72"></a>
-<span class="sourceLineNo">073</span>  private int[][][] clusterRegionLocationMocks = new int[][][]{<a name="line.73"></a>
+<span class="sourceLineNo">066</span>      // Test 1: each region is entirely on server that hosts it<a name="line.66"></a>
+<span class="sourceLineNo">067</span>      new int[][]{<a name="line.67"></a>
+<span class="sourceLineNo">068</span>          new int[]{2, 1, 1},<a name="line.68"></a>
+<span class="sourceLineNo">069</span>          new int[]{2, 0, 0, 100},   // region 0 is hosted and entirely local on server 2<a name="line.69"></a>
+<span class="sourceLineNo">070</span>          new int[]{0, 100, 0, 0},   // region 1 is hosted and entirely on server 0<a name="line.70"></a>
+<span class="sourceLineNo">071</span>          new int[]{0, 100, 0, 0},   // region 2 is hosted and entirely on server 0<a name="line.71"></a>
+<span class="sourceLineNo">072</span>          new int[]{1, 0, 100, 0},   // region 1 is hosted and entirely on server 1<a name="line.72"></a>
+<span class="sourceLineNo">073</span>      },<a name="line.73"></a>
 <span class="sourceLineNo">074</span><a name="line.74"></a>
-<span class="sourceLineNo">075</span>      // Test 1: each region is entirely on server that hosts it<a name="line.75"></a>
+<span class="sourceLineNo">075</span>      // Test 2: each region is 0% local on the server that hosts it<a name="line.75"></a>
 <span class="sourceLineNo">076</span>      new int[][]{<a name="line.76"></a>
-<span class="sourceLineNo">077</span>          new int[]{2, 1, 1},<a name="line.77"></a>
-<span class="sourceLineNo">078</span>          new int[]{2, 0, 0, 100},   // region 0 is hosted and entirely local on server 2<a name="line.78"></a>
-<span class="sourceLineNo">079</span>          new int[]{0, 100, 0, 0},   // region 1 is hosted and entirely on server 0<a name="line.79"></a>
-<span class="sourceLineNo">080</span>          new int[]{0, 100, 0, 0},   // region 2 is hosted and entirely on server 0<a name="line.80"></a>
-<span class="sourceLineNo">081</span>          new int[]{1, 0, 100, 0},   // region 1 is hosted and entirely on server 1<a name="line.81"></a>
+<span class="sourceLineNo">077</span>          new int[]{1, 2, 1},<a name="line.77"></a>
+<span class="sourceLineNo">078</span>          new int[]{0, 0, 0, 100},   // region 0 is hosted and entirely local on server 2<a name="line.78"></a>
+<span class="sourceLineNo">079</span>          new int[]{1, 100, 0, 0},   // region 1 is hosted and entirely on server 0<a name="line.79"></a>
+<span class="sourceLineNo">080</span>          new int[]{1, 100, 0, 0},   // region 2 is hosted and entirely on server 0<a name="line.80"></a>
+<span class="sourceLineNo">081</span>          new int[]{2, 0, 100, 0},   // region 1 is hosted and entirely on server 1<a name="line.81"></a>
 <span class="sourceLineNo">082</span>      },<a name="line.82"></a>
 <span class="sourceLineNo">083</span><a name="line.83"></a>
-<span class="sourceLineNo">084</span>      // Test 2: each region is 0% local on the server that hosts it<a name="line.84"></a>
+<span class="sourceLineNo">084</span>      // Test 3: each region is 25% local on the server that hosts it (and 50% locality is possible)<a name="line.84"></a>
 <span class="sourceLineNo">085</span>      new int[][]{<a name="line.85"></a>
 <span class="sourceLineNo">086</span>          new int[]{1, 2, 1},<a name="line.86"></a>
-<span class="sourceLineNo">087</span>          new int[]{0, 0, 0, 100},   // region 0 is hosted and entirely local on server 2<a name="line.87"></a>
-<span class="sourceLineNo">088</span>          new int[]{1, 100, 0, 0},   // region 1 is hosted and entirely on server 0<a name="line.88"></a>
-<span class="sourceLineNo">089</span>          new int[]{1, 100, 0, 0},   // region 2 is hosted and entirely on server 0<a name="line.89"></a>
-<span class="sourceLineNo">090</span>          new int[]{2, 0, 100, 0},   // region 1 is hosted and entirely on server 1<a name="line.90"></a>
+<span class="sourceLineNo">087</span>          new int[]{0, 25, 0, 50},   // region 0 is hosted and entirely local on server 2<a name="line.87"></a>
+<span class="sourceLineNo">088</span>          new int[]{1, 50, 25, 0},   // region 1 is hosted and entirely on server 0<a name="line.88"></a>
+<span class="sourceLineNo">089</span>          new int[]{1, 50, 25, 0},   // region 2 is hosted and entirely on server 0<a name="line.89"></a>
+<span class="sourceLineNo">090</span>          new int[]{2, 0, 50, 25},   // region 1 is hosted and entirely on server 1<a name="line.90"></a>
 <span class="sourceLineNo">091</span>      },<a name="line.91"></a>
 <span class="sourceLineNo">092</span><a name="line.92"></a>
-<span class="sourceLineNo">093</span>      // Test 3: each region is 25% local on the server that hosts it (and 50% locality is possible)<a name="line.93"></a>
+<span class="sourceLineNo">093</span>      // Test 4: each region is 25% local on the server that hosts it (and 100% locality is possible)<a name="line.93"></a>
 <span class="sourceLineNo">094</span>      new int[][]{<a name="line.94"></a>
 <span class="sourceLineNo">095</span>          new int[]{1, 2, 1},<a name="line.95"></a>
-<span class="sourceLineNo">096</span>          new int[]{0, 25, 0, 50},   // region 0 is hosted and entirely local on server 2<a name="line.96"></a>
-<span class="sourceLineNo">097</span>          new int[]{1, 50, 25, 0},   // region 1 is hosted and entirely on server 0<a name="line.97"></a>
-<span class="sourceLineNo">098</span>          new int[]{1, 50, 25, 0},   // region 2 is hosted and entirely on server 0<a name="line.98"></a>
-<span class="sourceLineNo">099</span>          new int[]{2, 0, 50, 25},   // region 1 is hosted and entirely on server 1<a name="line.99"></a>
+<span class="sourceLineNo">096</span>          new int[]{0, 25, 0, 100},   // region 0 is hosted and entirely local on server 2<a name="line.96"></a>
+<span class="sourceLineNo">097</span>          new int[]{1, 100, 25, 0},   // region 1 is hosted and entirely on server 0<a name="line.97"></a>
+<span class="sourceLineNo">098</span>          new int[]{1, 100, 25, 0},   // region 2 is hosted and entirely on server 0<a name="line.98"></a>
+<span class="sourceLineNo">099</span>          new int[]{2, 0, 100, 25},   // region 1 is hosted and entirely on server 1<a name="line.99"></a>
 <span class="sourceLineNo">100</span>      },<a name="line.100"></a>
 <span class="sourceLineNo">101</span><a name="line.101"></a>
-<span class="sourceLineNo">102</span>      // Test 4: each region is 25% local on the server that hosts it (and 100% locality is possible)<a name="line.102"></a>
+<span class="sourceLineNo">102</span>      // Test 5: each region is 75% local on the server that hosts it (and 75% locality is possible everywhere)<a name="line.102"></a>
 <span class="sourceLineNo">103</span>      new int[][]{<a name="line.103"></a>
 <span class="sourceLineNo">104</span>          new int[]{1, 2, 1},<a name="line.104"></a>
-<span class="sourceLineNo">105</span>          new int[]{0, 25, 0, 100},   // region 0 is hosted and entirely local on server 2<a name="line.105"></a>
-<span class="sourceLineNo">106</span>          new int[]{1, 100, 25, 0},   // region 1 is hosted and entirely on server 0<a name="line.106"></a>
-<span class="sourceLineNo">107</span>          new int[]{1, 100, 25, 0},   // region 2 is hosted and entirely on server 0<a name="line.107"></a>
-<span class="sourceLineNo">108</span>          new int[]{2, 0, 100, 25},   // region 1 is hosted and entirely on server 1<a name="line.108"></a>
+<span class="sourceLineNo">105</span>          new int[]{0, 75, 75, 75},   // region 0 is hosted and entirely local on server 2<a name="line.105"></a>
+<span class="sourceLineNo">106</span>          new int[]{1, 75, 75, 75},   // region 1 is hosted and entirely on server 0<a name="line.106"></a>
+<span class="sourceLineNo">107</span>          new int[]{1, 75, 75, 75},   // region 2 is hosted and entirely on server 0<a name="line.107"></a>
+<span class="sourceLineNo">108</span>          new int[]{2, 75, 75, 75},   // region 1 is hosted and entirely on server 1<a name="line.108"></a>
 <span class="sourceLineNo">109</span>      },<a name="line.109"></a>
-<span class="sourceLineNo">110</span><a name="line.110"></a>
-<span class="sourceLineNo">111</span>      // Test 5: each region is 75% local on the server that hosts it (and 75% locality is possible everywhere)<a name="line.111"></a>
-<span class="sourceLineNo">112</span>      new int[][]{<a name="line.112"></a>
-<span class="sourceLineNo">113</span>          new int[]{1, 2, 1},<a name="line.113"></a>
-<span class="sourceLineNo">114</span>          new int[]{0, 75, 75, 75},   // region 0 is hosted and entirely local on server 2<a name="line.114"></a>
-<span class="sourceLineNo">115</span>          new int[]{1, 75, 75, 75},   // region 1 is hosted and entirely on server 0<a name="line.115"></a>
-<span class="sourceLineNo">116</span>          new int[]{1, 75, 75, 75},   // region 2 is hosted and entirely on server 0<a name="line.116"></a>
-<span class="sourceLineNo">117</span>          new int[]{2, 75, 75, 75},   // region 1 is hosted and entirely on server 1<a name="line.117"></a>
-<span class="sourceLineNo">118</span>      },<a name="line.118"></a>
-<span class="sourceLineNo">119</span>  };<a name="line.119"></a>
-<span class="sourceLineNo">120</span><a name="line.120"></a>
-<span class="sourceLineNo">121</span><a name="line.121"></a>
-<span class="sourceLineNo">122</span>  @Test<a name="line.122"></a>
-<span class="sourceLineNo">123</span>  public void testKeepRegionLoad() throws Exception {<a name="line.123"></a>
-<span class="sourceLineNo">124</span><a name="line.124"></a>
-<span class="sourceLineNo">125</span>    ServerName sn = ServerName.valueOf("test:8080", 100);<a name="line.125"></a>
-<span class="sourceLineNo">126</span>    int numClusterStatusToAdd = 20000;<a name="line.126"></a>
-<span class="sourceLineNo">127</span>    for (int i = 0; i &lt; numClusterStatusToAdd; i++) {<a name="line.127"></a>
-<span class="sourceLineNo">128</span>      ServerMetrics sl = mock(ServerMetrics.class);<a name="line.128"></a>
+<span class="sourceLineNo">110</span>  };<a name="line.110"></a>
+<span class="sourceLineNo">111</span><a name="line.111"></a>
+<span class="sourceLineNo">112</span>  @Test<a name="line.112"></a>
+<span class="sourceLineNo">113</span>  public void testKeepRegionLoad() throws Exception {<a name="line.113"></a>
+<span class="sourceLineNo">114</span><a name="line.114"></a>
+<span class="sourceLineNo">115</span>    ServerName sn = ServerName.valueOf("test:8080", 100);<a name="line.115"></a>
+<span class="sourceLineNo">116</span>    int numClusterStatusToAdd = 20000;<a name="line.116"></a>
+<span class="sourceLineNo">117</span>    for (int i = 0; i &lt; numClusterStatusToAdd; i++) {<a name="line.117"></a>
+<span class="sourceLineNo">118</span>      ServerMetrics sl = mock(ServerMetrics.class);<a name="line.118"></a>
+<span class="sourceLineNo">119</span><a name="line.119"></a>
+<span class="sourceLineNo">120</span>      RegionMetrics rl = mock(RegionMetrics.class);<a name="line.120"></a>
+<span class="sourceLineNo">121</span>      when(rl.getReadRequestCount()).thenReturn(0L);<a name="line.121"></a>
+<span class="sourceLineNo">122</span>      when(rl.getWriteRequestCount()).thenReturn(0L);<a name="line.122"></a>
+<span class="sourceLineNo">123</span>      when(rl.getMemStoreSize()).thenReturn(Size.ZERO);<a name="line.123"></a>
+<span class="sourceLineNo">124</span>      when(rl.getStoreFileSize()).thenReturn(new Size(i, Size.Unit.MEGABYTE));<a name="line.124"></a>
+<span class="sourceLineNo">125</span><a name="line.125"></a>
+<span class="sourceLineNo">126</span>      Map&lt;byte[], RegionMetrics&gt; regionLoadMap = new TreeMap&lt;&gt;(Bytes.BYTES_COMPARATOR);<a name="line.126"></a>
+<span class="sourceLineNo">127</span>      regionLoadMap.put(Bytes.toBytes(REGION_KEY), rl);<a name="line.127"></a>
+<span class="sourceLineNo">128</span>      when(sl.getRegionMetrics()).thenReturn(regionLoadMap);<a name="line.128"></a>
 <span class="sourceLineNo">129</span><a name="line.129"></a>
-<span class="sourceLineNo">130</span>      RegionMetrics rl = mock(RegionMetrics.class);<a name="line.130"></a>
-<span class="sourceLineNo">131</span>      when(rl.getReadRequestCount()).thenReturn(0L);<a name="line.131"></a>
-<span class="sourceLineNo">132</span>      when(rl.getWriteRequestCount()).thenReturn(0L);<a name="line.132"></a>
-<span class="sourceLineNo">133</span>      when(rl.getMemStoreSize()).thenReturn(Size.ZERO);<a name="line.133"></a>
-<span class="sourceLineNo">134</span>      when(rl.getStoreFileSize()).thenReturn(new Size(i, Size.Unit.MEGABYTE));<a name="line.134"></a>
+<span class="sourceLineNo">130</span>      ClusterMetrics clusterStatus = mock(ClusterMetrics.class);<a name="line.130"></a>
+<span class="sourceLineNo">131</span>      Map&lt;ServerName, ServerMetrics&gt; serverMetricsMap = new TreeMap&lt;&gt;();<a name="line.131"></a>
+<span class="sourceLineNo">132</span>      serverMetricsMap.put(sn, sl);<a name="line.132"></a>
+<span class="sourceLineNo">133</span>      when(clusterStatus.getLiveServerMetrics()).thenReturn(serverMetricsMap);<a name="line.133"></a>
+<span class="sourceLineNo">134</span>//      when(clusterStatus.getLoad(sn)).thenReturn(sl);<a name="line.134"></a>
 <span class="sourceLineNo">135</span><a name="line.135"></a>
-<span class="sourceLineNo">136</span>      Map&lt;byte[], RegionMetrics&gt; regionLoadMap = new TreeMap&lt;&gt;(Bytes.BYTES_COMPARATOR);<a name="line.136"></a>
-<span class="sourceLineNo">137</span>      regionLoadMap.put(Bytes.toBytes(REGION_KEY), rl);<a name="line.137"></a>
-<span class="sourceLineNo">138</span>      when(sl.getRegionMetrics()).thenReturn(regionLoadMap);<a name="line.138"></a>
-<span class="sourceLineNo">139</span><a name="line.139"></a>
-<span class="sourceLineNo">140</span>      ClusterMetrics clusterStatus = mock(ClusterMetrics.class);<a name="line.140"></a>
-<span class="sourceLineNo">141</span>      Map&lt;ServerName, ServerMetrics&gt; serverMetricsMap = new TreeMap&lt;&gt;();<a name="line.141"></a>
-<span class="sourceLineNo">142</span>      serverMetricsMap.put(sn, sl);<a name="line.142"></a>
-<span class="sourceLineNo">143</span>      when(clusterStatus.getLiveServerMetrics()).thenReturn(serverMetricsMap);<a name="line.143"></a>
-<span class="sourceLineNo">144</span>//      when(clusterStatus.getLoad(sn)).thenReturn(sl);<a name="line.144"></a>
-<span class="sourceLineNo">145</span><a name="line.145"></a>
-<span class="sourceLineNo">146</span>      loadBalancer.setClusterMetrics(clusterStatus);<a name="line.146"></a>
+<span class="sourceLineNo">136</span>      loadBalancer.setClusterMetrics(clusterStatus);<a name="line.136"></a>
+<span class="sourceLineNo">137</span>    }<a name="line.137"></a>
+<span class="sourceLineNo">138</span>    assertTrue(loadBalancer.loads.get(REGION_KEY) != null);<a name="line.138"></a>
+<span class="sourceLineNo">139</span>    assertTrue(loadBalancer.loads.get(REGION_KEY).size() == 15);<a name="line.139"></a>
+<span class="sourceLineNo">140</span><a name="line.140"></a>
+<span class="sourceLineNo">141</span>    Queue&lt;BalancerRegionLoad&gt; loads = loadBalancer.loads.get(REGION_KEY);<a name="line.141"></a>
+<span class="sourceLineNo">142</span>    int i = 0;<a name="line.142"></a>
+<span class="sourceLineNo">143</span>    while(loads.size() &gt; 0) {<a name="line.143"></a>
+<span class="sourceLineNo">144</span>      BalancerRegionLoad rl = loads.remove();<a name="line.144"></a>
+<span class="sourceLineNo">145</span>      assertEquals(i + (numClusterStatusToAdd - 15), rl.getStorefileSizeMB());<a name="line.145"></a>
+<span class="sourceLineNo">146</span>      i ++;<a name="line.146"></a>
 <span class="sourceLineNo">147</span>    }<a name="line.147"></a>
-<span class="sourceLineNo">148</span>    assertTrue(loadBalancer.loads.get(REGION_KEY) != null);<a name="line.148"></a>
-<span class="sourceLineNo">149</span>    assertTrue(loadBalancer.loads.get(REGION_KEY).size() == 15);<a name="line.149"></a>
-<span class="sourceLineNo">150</span><a name="line.150"></a>
-<span class="sourceLineNo">151</span>    Queue&lt;BalancerRegionLoad&gt; loads = loadBalancer.loads.get(REGION_KEY);<a name="line.151"></a>
-<span class="sourceLineNo">152</span>    int i = 0;<a name="line.152"></a>
-<span class="sourceLineNo">153</span>    while(loads.size() &gt; 0) {<a name="line.153"></a>
-<span class="sourceLineNo">154</span>      BalancerRegionLoad rl = loads.remove();<a name="line.154"></a>
-<span class="sourceLineNo">155</span>      assertEquals(i + (numClusterStatusToAdd - 15), rl.getStorefileSizeMB());<a name="line.155"></a>
-<span class="sourceLineNo">156</span>      i ++;<a name="line.156"></a>
-<span class="sourceLineNo">157</span>    }<a name="line.157"></a>
-<span class="sourceLineNo">158</span>  }<a name="line.158"></a>
-<span class="sourceLineNo">159</span><a name="line.159"></a>
-<span class="sourceLineNo">160</span>  @Test<a name="line.160"></a>
-<span class="sourceLineNo">161</span>  public void testNeedBalance() {<a name="line.161"></a>
-<span class="sourceLineNo">162</span>    float minCost = conf.getFloat("hbase.master.balancer.stochastic.minCostNeedBalance", 0.05f);<a name="line.162"></a>
-<span class="sourceLineNo">163</span>    conf.setFloat("hbase.master.balancer.stochastic.minCostNeedBalance", 1.0f);<a name="line.163"></a>
-<span class="sourceLineNo">164</span>    loadBalancer.setConf(conf);<a name="line.164"></a>
-<span class="sourceLineNo">165</span>    for (int[] mockCluster : clusterStateMocks) {<a name="line.165"></a>
-<span class="sourceLineNo">166</span>      Map&lt;ServerName, List&lt;RegionInfo&gt;&gt; servers = mockClusterServers(mockCluster);<a name="line.166"></a>
-<span class="sourceLineNo">167</span>      List&lt;RegionPlan&gt; plans = loadBalancer.balanceCluster(servers);<a name="line.167"></a>
-<span class="sourceLineNo">168</span>      assertNull(plans);<a name="line.168"></a>
-<span class="sourceLineNo">169</span>    }<a name="line.169"></a>
-<span class="sourceLineNo">170</span>    // reset config<a name="line.170"></a>
-<span class="sourceLineNo">171</span>    conf.setFloat("hbase.master.balancer.stochastic.minCostNeedBalance", minCost);<a name="line.171"></a>
-<span class="sourceLineNo">172</span>    loadBalancer.setConf(conf);<a name="line.172"></a>
-<span class="sourceLineNo">173</span>  }<a name="line.173"></a>
-<span class="sourceLineNo">174</span><a name="line.174"></a>
-<span class="sourceLineNo">175</span>  /**<a name="line.175"></a>
-<span class="sourceLineNo">176</span>   * Test the load balancing algorithm.<a name="line.176"></a>
-<span class="sourceLineNo">177</span>   *<a name="line.177"></a>
-<span class="sourceLineNo">178</span>   * Invariant is that all servers should be hosting either floor(average) or<a name="line.178"></a>
-<span class="sourceLineNo">179</span>   * ceiling(average)<a name="line.179"></a>
-<span class="sourceLineNo">180</span>   *<a name="line.180"></a>
-<span class="sourceLineNo">181</span>   * @throws Exception<a name="line.181"></a>
-<span class="sourceLineNo">182</span>   */<a name="line.182"></a>
-<span class="sourceLineNo">183</span>  @Test<a name="line.183"></a>
-<span class="sourceLineNo">184</span>  public void testBalanceCluster() throws Exception {<a name="line.184"></a>
-<span class="sourceLineNo">185</span>    conf.setLong(StochasticLoadBalancer.MAX_STEPS_KEY, 2000000L);<a name="line.185"></a>
-<span class="sourceLineNo">186</span>    conf.setLong("hbase.master.balancer.stochastic.maxRunningTime", 90 * 1000); // 90 sec<a name="line.186"></a>
-<span class="sourceLineNo">187</span>    conf.setFloat("hbase.master.balancer.stochastic.maxMovePercent", 1.0f);<a name="line.187"></a>
-<span class="sourceLineNo">188</span>    loadBalancer.setConf(conf);<a name="line.188"></a>
-<span class="sourceLineNo">189</span>    for (int[] mockCluster : clusterStateMocks) {<a name="line.189"></a>
-<span class="sourceLineNo">190</span>      Map&lt;ServerName, List&lt;RegionInfo&gt;&gt; servers = mockClusterServers(mockCluster);<a name="line.190"></a>
-<span class="sourceLineNo">191</span>      List&lt;ServerAndLoad&gt; list = convertToList(servers);<a name="line.191"></a>
-<span class="sourceLineNo">192</span>      LOG.info("Mock Cluster : " + printMock(list) + " " + printStats(list));<a name="line.192"></a>
-<span class="sourceLineNo">193</span>      List&lt;RegionPlan&gt; plans = loadBalancer.balanceCluster(servers);<a name="line.193"></a>
-<span class="sourceLineNo">194</span>      List&lt;ServerAndLoad&gt; balancedCluster = reconcile(list, plans, servers);<a name="line.194"></a>
-<span class="sourceLineNo">195</span>      LOG.info("Mock Balance : " + printMock(balancedCluster));<a name="line.195"></a>
-<span class="sourceLineNo">196</span>      assertClusterAsBalanced(balancedCluster);<a name="line.196"></a>
-<span class="sourceLineNo">197</span>      List&lt;RegionPlan&gt; secondPlans =  loadBalancer.balanceCluster(servers);<a name="line.197"></a>
-<span class="sourceLineNo">198</span>      assertNull(secondPlans);<a name="line.198"></a>
-<span class="sourceLineNo">199</span>      for (Map.Entry&lt;ServerName, List&lt;RegionInfo&gt;&gt; entry : servers.entrySet()) {<a name="line.199"></a>
-<span class="sourceLineNo">200</span>        returnRegions(entry.getValue());<a name="line.200"></a>
-<span class="sourceLineNo">201</span>        returnServer(entry.getKey());<a name="line.201"></a>
-<span class="sourceLineNo">202</span>      }<a name="line.202"></a>
-<span class="sourceLineNo">203</span>    }<a name="line.203"></a>
-<span class="sourceLineNo">204</span>  }<a name="line.204"></a>
+<span class="sourceLineNo">148</span>  }<a name="line.148"></a>
+<span class="sourceLineNo">149</span><a name="line.149"></a>
+<span class="sourceLineNo">150</span>  @Test<a name="line.150"></a>
+<span class="sourceLineNo">151</span>  public void testNeedBalance() {<a name="line.151"></a>
+<span class="sourceLineNo">152</span>    float minCost = conf.getFloat("hbase.master.balancer.stochastic.minCostNeedBalance", 0.05f);<a name="line.152"></a>
+<span class="sourceLineNo">153</span>    conf.setFloat("hbase.master.balancer.stochastic.minCostNeedBalance", 1.0f);<a name="line.153"></a>
+<span class="sourceLineNo">154</span>    loadBalancer.setConf(conf);<a name="line.154"></a>
+<span class="sourceLineNo">155</span>    for (int[] mockCluster : clusterStateMocks) {<a name="line.155"></a>
+<span class="sourceLineNo">156</span>      Map&lt;ServerName, List&lt;RegionInfo&gt;&gt; servers = mockClusterServers(mockCluster);<a name="line.156"></a>
+<span class="sourceLineNo">157</span>      List&lt;RegionPlan&gt; plans = loadBalancer.balanceCluster(servers);<a name="line.157"></a>
+<span class="sourceLineNo">158</span>      assertNull(plans);<a name="line.158"></a>
+<span class="sourceLineNo">159</span>    }<a name="line.159"></a>
+<span class="sourceLineNo">160</span>    // reset config<a name="line.160"></a>
+<span class="sourceLineNo">161</span>    conf.setFloat("hbase.master.balancer.stochastic.minCostNeedBalance", minCost);<a name="line.161"></a>
+<span class="sourceLineNo">162</span>    loadBalancer.setConf(conf);<a name="line.162"></a>
+<span class="sourceLineNo">163</span>  }<a name="line.163"></a>
+<span class="sourceLineNo">164</span><a name="line.164"></a>
+<span class="sourceLineNo">165</span>  @Test<a name="line.165"></a>
+<span class="sourceLineNo">166</span>  public void testLocalityCost() throws Exception {<a name="line.166"></a>
+<span class="sourceLineNo">167</span>    Configuration conf = HBaseConfiguration.create();<a name="line.167"></a>
+<span class="sourceLineNo">168</span>    MockNoopMasterServices master = new MockNoopMasterServices();<a name="line.168"></a>
+<span class="sourceLineNo">169</span>    StochasticLoadBalancer.CostFunction<a name="line.169"></a>
+<span class="sourceLineNo">170</span>        costFunction = new ServerLocalityCostFunction(conf, master);<a name="line.170"></a>
+<span class="sourceLineNo">171</span><a name="line.171"></a>
+<span class="sourceLineNo">172</span>    for (int test = 0; test &lt; clusterRegionLocationMocks.length; test++) {<a name="line.172"></a>
+<span class="sourceLineNo">173</span>      int[][] clusterRegionLocations = clusterRegionLocationMocks[test];<a name="line.173"></a>
+<span class="sourceLineNo">174</span>      MockCluster cluster = new MockCluster(clusterRegionLocations);<a name="line.174"></a>
+<span class="sourceLineNo">175</span>      costFunction.init(cluster);<a name="line.175"></a>
+<span class="sourceLineNo">176</span>      double cost = costFunction.cost();<a name="line.176"></a>
+<span class="sourceLineNo">177</span>      double expected = 1 - expectedLocalities[test];<a name="line.177"></a>
+<span class="sourceLineNo">178</span>      assertEquals(expected, cost, 0.001);<a name="line.178"></a>
+<span class="sourceLineNo">179</span>    }<a name="line.179"></a>
+<span class="sourceLineNo">180</span>  }<a name="line.180"></a>
+<span class="sourceLineNo">181</span><a name="line.181"></a>
+<span class="sourceLineNo">182</span>  @Test<a name="line.182"></a>
+<span class="sourceLineNo">183</span>  public void testMoveCost() throws Exception {<a name="line.183"></a>
+<span class="sourceLineNo">184</span>    Configuration conf = HBaseConfiguration.create();<a name="line.184"></a>
+<span class="sourceLineNo">185</span>    StochasticLoadBalancer.CostFunction<a name="line.185"></a>
+<span class="sourceLineNo">186</span>        costFunction = new StochasticLoadBalancer.MoveCostFunction(conf);<a name="line.186"></a>
+<span class="sourceLineNo">187</span>    for (int[] mockCluster : clusterStateMocks) {<a name="line.187"></a>
+<span class="sourceLineNo">188</span>      BaseLoadBalancer.Cluster cluster = mockCluster(mockCluster);<a name="line.188"></a>
+<span class="sourceLineNo">189</span>      costFunction.init(cluster);<a name="line.189"></a>
+<span class="sourceLineNo">190</span>      double cost = costFunction.cost();<a name="line.190"></a>
+<span class="sourceLineNo">191</span>      assertEquals(0.0f, cost, 0.001);<a name="line.191"></a>
+<span class="sourceLineNo">192</span><a name="line.192"></a>
+<span class="sourceLineNo">193</span>      // cluster region number is smaller than maxMoves=600<a name="line.193"></a>
+<span class="sourceLineNo">194</span>      cluster.setNumRegions(200);<a name="line.194"></a>
+<span class="sourceLineNo">195</span>      cluster.setNumMovedRegions(10);<a name="line.195"></a>
+<span class="sourceLineNo">196</span>      cost = costFunction.cost();<a name="line.196"></a>
+<span class="sourceLineNo">197</span>      assertEquals(0.05f, cost, 0.001);<a name="line.197"></a>
+<span class="sourceLineNo">198</span>      cluster.setNumMovedRegions(100);<a name="line.198"></a>
+<span class="sourceLineNo">199</span>      cost = costFunction.cost();<a name="line.199"></a>
+<span class="sourceLineNo">200</span>      assertEquals(0.5f, cost, 0.001);<a name="line.200"></a>
+<span class="sourceLineNo">201</span>      cluster.setNumMovedRegions(200);<a name="line.201"></a>
+<span class="sourceLineNo">202</span>      cost = costFunction.cost();<a name="line.202"></a>
+<span class="sourceLineNo">203</span>      assertEquals(1.0f, cost, 0.001);<a name="line.203"></a>
+<span class="sourceLineNo">204</span><a name="line.204"></a>
 <span class="sourceLineNo">205</span><a name="line.205"></a>
-<span class="sourceLineNo">206</span>  @Test<a name="line.206"></a>
-<span class="sourceLineNo">207</span>  public void testLocalityCost() throws Exception {<a name="line.207"></a>
-<span class="sourceLineNo">208</span>    Configuration conf = HBaseConfiguration.create();<a name="line.208"></a>
-<span class="sourceLineNo">209</span>    MockNoopMasterServices master = new MockNoopMasterServices();<a name="line.209"></a>
-<span class="sourceLineNo">210</span>    StochasticLoadBalancer.CostFunction<a name="line.210"></a>
-<span class="sourceLineNo">211</span>        costFunction = new ServerLocalityCostFunction(conf, master);<a name="line.211"></a>
-<span class="sourceLineNo">212</span><a name="line.212"></a>
-<span class="sourceLineNo">213</span>    for (int test = 0; test &lt; clusterRegionLocationMocks.length; test++) {<a name="line.213"></a>
-<span class="sourceLineNo">214</span>      int[][] clusterRegionLocations = clusterRegionLocationMocks[test];<a name="line.214"></a>
-<span class="sourceLineNo">215</span>      MockCluster cluster = new MockCluster(clusterRegionLocations);<a name="line.215"></a>
-<span class="sourceLineNo">216</span>      costFunction.init(cluster);<a name="line.216"></a>
-<span class="sourceLineNo">217</span>      double cost = costFunction.cost();<a name="line.217"></a>
-<span class="sourceLineNo">218</span>      double expected = 1 - expectedLocalities[test];<a name="line.218"></a>
-<span class="sourceLineNo">219</span>      assertEquals(expected, cost, 0.001);<a name="line.219"></a>
-<span class="sourceLineNo">220</span>    }<a name="line.220"></a>
-<span class="sourceLineNo">221</span>  }<a name="line.221"></a>
-<span class="sourceLineNo">222</span><a name="line.222"></a>
-<span class="sourceLineNo">223</span>  @Test<a name="line.223"></a>
-<span class="sourceLineNo">224</span>  public void testMoveCost() throws Exception {<a name="line.224"></a>
-<span class="sourceLineNo">225</span>    Configuration conf = HBaseConfiguration.create();<a name="line.225"></a>
-<span class="sourceLineNo">226</span>    StochasticLoadBalancer.CostFunction<a name="line.226"></a>
-<span class="sourceLineNo">227</span>        costFunction = new StochasticLoadBalancer.MoveCostFunction(conf);<a name="line.227"></a>
-<span class="sourceLineNo">228</span>    for (int[] mockCluster : clusterStateMocks) {<a name="line.228"></a>
-<span class="sourceLineNo">229</span>      BaseLoadBalancer.Cluster cluster = mockCluster(mockCluster);<a name="line.229"></a>
-<span class="sourceLineNo">230</span>      costFunction.init(cluster);<a name="line.230"></a>
-<span class="sourceLineNo">231</span>      double cost = costFunction.cost();<a name="line.231"></a>
-<span class="sourceLineNo">232</span>      assertEquals(0.0f, cost, 0.001);<a name="line.232"></a>
-<span class="sourceLineNo">233</span><a name="line.233"></a>
-<span class="sourceLineNo">234</span>      // cluster region number is smaller than maxMoves=600<a name="line.234"></a>
-<span class="sourceLineNo">235</span>      cluster.setNumRegions(200);<a name="line.235"></a>
-<span class="sourceLineNo">236</span>      cluster.setNumMovedRegions(10);<a name="line.236"></a>
-<span class="sourceLineNo">237</span>      cost = costFunction.cost();<a name="line.237"></a>
-<span class="sourceLineNo">238</span>      assertEquals(0.05f, cost, 0.001);<a name="line.238"></a>
-<span class="sourceLineNo">239</span>      cluster.setNumMovedRegions(100);<a name="line.239"></a>
-<span class="sourceLineNo">240</span>      cost = costFunction.cost();<a name="line.240"></a>
-<span class="sourceLineNo">241</span>      assertEquals(0.5f, cost, 0.001);<a name="line.241"></a>
-<span class="sourceLineNo">242</span>      cluster.setNumMovedRegions(200);<a name="line.242"></a>
-<span class="sourceLineNo">243</span>      cost = costFunction.cost();<a name="line.243"></a>
-<span class="sourceLineNo">244</span>      assertEquals(1.0f, cost, 0.001);<a name="line.244"></a>
+<span class="sourceLineNo">206</span>      // cluster region number is bigger than maxMoves=2500<a name="line.206"></a>
+<span class="sourceLineNo">207</span>      cluster.setNumRegions(10000);<a name="line.207"></a>
+<span class="sourceLineNo">208</span>      cluster.setNumMovedRegions(250);<a name="line.208"></a>
+<span class="sourceLineNo">209</span>      cost = costFunction.cost();<a name="line.209"></a>
+<span class="sourceLineNo">210</span>      assertEquals(0.1f, cost, 0.001);<a name="line.210"></a>
+<span class="sourceLineNo">211</span>      cluster.setNumMovedRegions(1250);<a name="line.211"></a>
+<span class="sourceLineNo">212</span>      cost = costFunction.cost();<a name="line.212"></a>
+<span class="sourceLineNo">213</span>      assertEquals(0.5f, cost, 0.001);<a name="line.213"></a>
+<span class="sourceLineNo">214</span>      cluster.setNumMovedRegions(2500);<a name="line.214"></a>
+<span class="sourceLineNo">215</span>      cost = costFunction.cost();<a name="line.215"></a>
+<span class="sourceLineNo">216</span>      assertEquals(1.0f, cost, 0.01);<a name="line.216"></a>
+<span class="sourceLineNo">217</span>    }<a name="line.217"></a>
+<span class="sourceLineNo">218</span>  }<a name="line.218"></a>
+<span class="sourceLineNo">219</span><a name="line.219"></a>
+<span class="sourceLineNo">220</span>  @Test<a name="line.220"></a>
+<span class="sourceLineNo">221</span>  public void testSkewCost() {<a name="line.221"></a>
+<span class="sourceLineNo">222</span>    Configuration conf = HBaseConfiguration.create();<a name="line.222"></a>
+<span class="sourceLineNo">223</span>    StochasticLoadBalancer.CostFunction<a name="line.223"></a>
+<span class="sourceLineNo">224</span>        costFunction = new StochasticLoadBalancer.RegionCountSkewCostFunction(conf);<a name="line.224"></a>
+<span class="sourceLineNo">225</span>    for (int[] mockCluster : clusterStateMocks) {<a name="line.225"></a>
+<span class="sourceLineNo">226</span>      costFunction.init(mockCluster(mockCluster));<a name="line.226"></a>
+<span class="sourceLineNo">227</span>      double cost = costFunction.cost();<a name="line.227"></a>
+<span class="sourceLineNo">228</span>      assertTrue(cost &gt;= 0);<a name="line.228"></a>
+<span class="sourceLineNo">229</span>      assertTrue(cost &lt;= 1.01);<a name="line.229"></a>
+<span class="sourceLineNo">230</span>    }<a name="line.230"></a>
+<span class="sourceLineNo">231</span><a name="line.231"></a>
+<span class="sourceLineNo">232</span>    costFunction.init(mockCluster(new int[]{0, 0, 0, 0, 1}));<a name="line.232"></a>
+<span class="sourceLineNo">233</span>    assertEquals(0,costFunction.cost(), 0.01);<a name="line.233"></a>
+<span class="sourceLineNo">234</span>    costFunction.init(mockCluster(new int[]{0, 0, 0, 1, 1}));<a name="line.234"></a>
+<span class="sourceLineNo">235</span>    assertEquals(0, costFunction.cost(), 0.01);<a name="line.235"></a>
+<span class="sourceLineNo">236</span>    costFunction.init(mockCluster(new int[]{0, 0, 1, 1, 1}));<a name="line.236"></a>
+<span class="sourceLineNo">237</span>    assertEquals(0, costFunction.cost(), 0.01);<a name="line.237"></a>
+<span class="sourceLineNo">238</span>    costFunction.init(mockCluster(new int[]{0, 1, 1, 1, 1}));<a name="line.238"></a>
+<span class="sourceLineNo">239</span>    assertEquals(0, costFunction.cost(), 0.01);<a name="line.239"></a>
+<span class="sourceLineNo">240</span>    costFunction.init(mockCluster(new int[]{1, 1, 1, 1, 1}));<a name="line.240"></a>
+<span class="sourceLineNo">241</span>    assertEquals(0, costFunction.cost(), 0.01);<a name="line.241"></a>
+<span class="sourceLineNo">242</span>    costFunction.init(mockCluster(new int[]{10000, 0, 0, 0, 0}));<a name="line.242"></a>
+<span class="sourceLineNo">243</span>    assertEquals(1, costFunction.cost(), 0.01);<a name="line.243"></a>
+<span class="sourceLineNo">244</span>  }<a name="line.244"></a>
 <span class="sourceLineNo">245</span><a name="line.245"></a>
-<span class="sourceLineNo">246</span><a name="line.246"></a>
-<span class="sourceLineNo">247</span>      // cluster region number is bigger than maxMoves=2500<a name="line.247"></a>
-<span class="sourceLineNo">248</span>      cluster.setNumRegions(10000);<a name="line.248"></a>
-<span class="sourceLineNo">249</span>      cluster.setNumMovedRegions(250);<a name="line.249"></a>
-<span class="sourceLineNo">250</span>      cost = costFunction.cost();<a name="line.250"></a>
-<span class="sourceLineNo">251</span>      assertEquals(0.1f, cost, 0.001);<a name="line.251"></a>
-<span class="sourceLineNo">252</span>      cluster.setNumMovedRegions(1250);<a name="line.252"></a>
-<span class="sourceLineNo">253</span>      cost = costFunction.cost();<a name="line.253"></a>
-<span class="sourceLineNo">254</span>      assertEquals(0.5f, cost, 0.001);<a name="line.254"></a>
-<span class="sourceLineNo">255</span>      cluster.setNumMovedRegions(2500);<a name="line.255"></a>
-<span class="sourceLineNo">256</span>      cost = costFunction.cost();<a name="line.256"></a>
-<span class="sourceLineNo">257</span>      assertEquals(1.0f, cost, 0.01);<a name="line.257"></a>
-<span class="sourceLineNo">258</span>    }<a name="line.258"></a>
-<span class="sourceLineNo">259</span>  }<a name="line.259"></a>
-<span class="sourceLineNo">260</span><a name="line.260"></a>
-<span class="sourceLineNo">261</span>  @Test<a name="line.261"></a>
-<span class="sourceLineNo">262</span>  public void testSkewCost() {<a name="line.262"></a>
-<span class="sourceLineNo">263</span>    Configuration conf = HBaseConfiguration.create();<a name="line.263"></a>
-<span class="sourceLineNo">264</span>    StochasticLoadBalancer.CostFunction<a name="line.264"></a>
-<span class="sourceLineNo">265</span>        costFunction = new StochasticLoadBalancer.RegionCountSkewCostFunction(conf);<a name="line.265"></a>
-<span class="sourceLineNo">266</span>    for (int[] mockCluster : clusterStateMocks) {<a name="line.266"></a>
-<span class="sourceLineNo">267</span>      costFunction.init(mockCluster(mockCluster));<a name="line.267"></a>
-<span class="sourceLineNo">268</span>      double cost = costFunction.cost();<a name="line.268"></a>
-<span class="sourceLineNo">269</span>      assertTrue(cost &gt;= 0);<a name="line.269"></a>
-<span class="sourceLineNo">270</span>      assertTrue(cost &lt;= 1.01);<a name="line.270"></a>
-<span class="sourceLineNo">271</span>    }<a name="line.271"></a>
-<span class="sourceLineNo">272</span><a name="line.272"></a>
-<span class="sourceLineNo">273</span>    costFunction.init(mockCluster(new int[]{0, 0, 0, 0, 1}));<a name="line.273"></a>
-<span class="sourceLineNo">274</span>    assertEquals(0,costFunction.cost(), 0.01);<a name="line.274"></a>
-<span class="sourceLineNo">275</span>    costFunction.init(mockCluster(new int[]{0, 0, 0, 1, 1}));<a name="line.275"></a>
-<span class="sourceLineNo">276</span>    assertEquals(0, costFunction.cost(), 0.01);<a name="line.276"></a>
-<span class="sourceLineNo">277</span>    costFunction.init(mockCluster(new int[]{0, 0, 1, 1, 1}));<a name="line.277"></a>
-<span class="sourceLineNo">278</span>    assertEquals(0, costFunction.cost(), 0.01);<a name="line.278"></a>
-<span class="sourceLineNo">279</span>    costFunction.init(mockCluster(new int[]{0, 1, 1, 1, 1}));<a name="line.279"></a>
-<span class="sourceLineNo">280</span>    assertEquals(0, costFunction.cost(), 0.01);<a name="line.280"></a>
-<span class="sourceLineNo">281</span>    costFunction.init(mockCluster(new int[]{1, 1, 1, 1, 1}));<a name="line.281"></a>
-<span class="sourceLineNo">282</span>    assertEquals(0, costFunction.cost(), 0.01);<a name="line.282"></a>
-<span class="sourceLineNo">283</span>    costFunction.init(mockCluster(new int[]{10000, 0, 0, 0, 0}));<a name="line.283"></a>
-<span class="sourceLineNo">284</span>    assertEquals(1, costFunction.cost(), 0.01);<a name="line.284"></a>
-<span class="sourceLineNo">285</span>  }<a name="line.285"></a>
-<span class="sourceLineNo">286</span><a name="line.286"></a>
-<span class="sourceLineNo">287</span>  @Test<a name="line.287"></a>
-<span class="sourceLineNo">288</span>  public void testCostAfterUndoAction() {<a name="line.288"></a>
-<span class="sourceLineNo">289</span>    final int runs = 10;<a name="line.289"></a>
-<span class="sourceLineNo">290</span>    loadBalancer.setConf(conf);<a name="line.290"></a>
-<span class="sourceLineNo">291</span>    for (int[] mockCluster : clusterStateMocks) {<a name="line.291"></a>
-<span class="sourceLineNo">292</span>      BaseLoadBalancer.Cluster cluster = mockCluster(mockCluster);<a name="line.292"></a>
-<span class="sourceLineNo">293</span>      loadBalancer.initCosts(cluster);<a name="line.293"></a>
-<span class="sourceLineNo">294</span>      for (int i = 0; i != runs; ++i) {<a name="line.294"></a>
-<span class="sourceLineNo">295</span>        final double expectedCost = loadBalancer.computeCost(cluster, Double.MAX_VALUE);<a name="line.295"></a>
-<span class="sourceLineNo">296</span>        Cluster.Action action = loadBalancer.nextAction(cluster);<a name="line.296"></a>
-<span class="sourceLineNo">297</span>        cluster.doAction(action);<a name="line.297"></a>
-<span class="sourceLineNo">298</span>        loadBalancer.updateCostsWithAction(cluster, action);<a name="line.298"></a>
-<span class="sourceLineNo">299</span>        Cluster.Action undoAction = action.undoAction();<a name="line.299"></a>
-<span class="sourceLineNo">300</span>        cluster.doAction(undoAction);<a name="line.300"></a>
-<span class="sourceLineNo">301</span>        loadBalancer.updateCostsWithAction(cluster, undoAction);<a name="line.301"></a>
-<span class="sourceLineNo">302</span>        final double actualCost = loadBalancer.computeCost(cluster, Double.MAX_VALUE);<a name="line.302"></a>
-<span class="sourceLineNo">303</span>        assertEquals(expectedCost, actualCost, 0);<a name="line.303"></a>
-<span class="sourceLineNo">304</span>      }<a name="line.304"></a>
-<span class="sourceLineNo">305</span>    }<a name="line.305"></a>
-<span class="sourceLineNo">306</span>  }<a name="line.306"></a>
-<span class="sourceLineNo">307</span><a name="line.307"></a>
-<span class="sourceLineNo">308</span>  @Test<a name="line.308"></a>
-<span class="sourceLineNo">309</span>  public void testTableSkewCost() {<a name="line.309"></a>
-<span class="sourceLineNo">310</span>    Configuration conf = HBaseConfiguration.create();<a name="line.310"></a>
-<span class="sourceLineNo">311</span>    StochasticLoadBalancer.CostFunction<a name="line.311"></a>
-<span class="sourceLineNo">312</span>        costFunction = new StochasticLoadBalancer.TableSkewCostFunction(conf);<a name="line.312"></a>
-<span class="sourceLineNo">313</span>    for (int[] mockCluster : clusterStateMocks) {<a name="line.313"></a>
-<span class="sourceLineNo">314</span>      BaseLoadBalancer.Cluster cluster = mockCluster(mockCluster);<a name="line.314"></a>
-<span class="sourceLineNo">315</span>      costFunction.init(cluster);<a name="line.315"></a>
-<span class="sourceLineNo">316</span>      double cost = costFunction.cost();<a name="line.316"></a>
-<span class="sourceLineNo">317</span>      assertTrue(cost &gt;= 0);<a name="line.317"></a>
-<span class="sourceLineNo">318</span>      assertTrue(cost &lt;= 1.01);<a name="line.318"></a>
-<span class="sourceLineNo">319</span>    }<a name="line.319"></a>
-<span class="sourceLineNo">320</span>  }<a name="line.320"></a>
-<span class="sourceLineNo">321</span><a name="line.321"></a>
-<span class="sourceLineNo">322</span>  @Test<a name="line.322"></a>
-<span class="sourceLineNo">323</span>  public void testRegionLoadCost() {<a name="line.323"></a>
-<span class="sourceLineNo">324</span>    List&lt;BalancerRegionLoad&gt; regionLoads = new ArrayList&lt;&gt;();<a name="line.324"></a>
-<span class="sourceLineNo">325</span>    for (int i = 1; i &lt; 5; i++) {<a name="line.325"></a>
-<span class="sourceLineNo">326</span>      BalancerRegionLoad regionLoad = mock(BalancerRegionLoad.class);<a name="line.326"></a>
-<span class="sourceLineNo">327</span>      when(regionLoad.getReadRequestsCount()).thenReturn(new Long(i));<a name="line.327"></a>
-<span class="sourceLineNo">328</span>      when(regionLoad.getStorefileSizeMB()).thenReturn(i);<a name="line.328"></a>
-<span class="sourceLineNo">329</span>      regionLoads.add(regionLoad);<a name="line.329"></a>
-<span class="sourceLineNo">330</span>    }<a name="line.330"></a>
-<span class="sourceLineNo">331</span><a name="line.331"></a>
-<span class="sourceLineNo">332</span>    Configuration conf = HBaseConfiguration.create();<a name="line.332"></a>
-<span class="sourceLineNo">333</span>    StochasticLoadBalancer.ReadRequestCostFunction readCostFunction =<a name="line.333"></a>
-<span class="sourceLineNo">334</span>        new StochasticLoadBalancer.ReadRequestCostFunction(conf);<a name="line.334"></a>
-<span class="sourceLineNo">335</span>    double rateResult = readCostFunction.getRegionLoadCost(regionLoads);<a name="line.335"></a>
-<span class="sourceLineNo">336</span>    // read requests are treated as a rate so the average rate here is simply 1<a name="line.336"></a>
-<span class="sourceLineNo">337</span>    assertEquals(1, rateResult, 0.01);<a name="line.337"></a>
-<span class="sourceLineNo">338</span><a name="line.338"></a>
-<span class="sourceLineNo">339</span>    StochasticLoadBalancer.StoreFileCostFunction storeFileCostFunction =<a name="line.339"></a>
-<span class="sourceLineNo">340</span>        new StochasticLoadBalancer.StoreFileCostFunction(conf);<a name="line.340"></a>
-<span class="sourceLineNo">341</span>    double result = storeFileCostFunction.getRegionLoadCost(regionLoads);<a name="line.341"></a>
-<span class="sourceLineNo">342</span>    // storefile size cost is simply an average of it's value over time<a name="line.342"></a>
-<span class="sourceLineNo">343</span>    assertEquals(2.5, result, 0.01);<a name="line.343"></a>
-<span class="sourceLineNo">344</span>  }<a name="line.344"></a>
+<span class="sourceLineNo">246</span>  @Test<a name="line.246"></a>
+<span class="sourceLineNo">247</span>  public void testCostAfterUndoAction() {<a name="line.247"></a>
+<span class="sourceLineNo">248</span>    final int runs = 10;<a name="line.248"></a>
+<span class="sourceLineNo">249</span>    loadBalancer.setConf(conf);<a name="line.249"></a>
+<span class="sourceLineNo">250</span>    for (int[] mockCluster : clusterStateMocks) {<a name="line.250"></a>
+<span class="sourceLineNo">251</span>      BaseLoadBalancer.Cluster cluster = mockCluster(mockCluster);<a name="line.251"></a>
+<span class="sourceLineNo">252</span>      loadBalancer.initCosts(cluster);<a name="line.252"></a>
+<span class="sourceLineNo">253</span>      for (int i = 0; i != runs; ++i) {<a name="line.253"></a>
+<span class="sourceLineNo">254</span>        final double expectedCost = loadBalancer.computeCost(cluster, Double.MAX_VALUE);<a name="line.254"></a>
+<span class="sourceLineNo">255</span>        Cluster.Action action = loadBalancer.nextAction(cluster);<a name="line.255"></a>
+<span class="sourceLineNo">256</span>        cluster.doAction(action);<a name="line.256"></a>
+<span class="sourceLineNo">257</span>        loadBalancer.updateCostsWithAction(cluster, action);<a name="line.257"></a>
+<span class="sourceLineNo">258</span>        Cluster.Action undoAction = action.undoAction();<a name="line.258"></a>
+<span class="sourceLineNo">259</span>        cluster.doAction(undoAction);<a name="line.259"></a>
+<span class="sourceLineNo">260</span>        loadBalancer.updateCostsWithAction(cluster, undoAction);<a name="line.260"></a>
+<span class="sourceLineNo">261</span>        final double actualCost = loadBalancer.computeCost(cluster, Double.MAX_VALUE);<a name="line.261"></a>
+<span class="sourceLineNo">262</span>        assertEquals(expectedCost, actualCost, 0);<a name="line.262"></a>
+<span class="sourceLineNo">263</span>      }<a name="line.263"></a>
+<span class="sourceLineNo">264</span>    }<a name="line.264"></a>
+<span class="sourceLineNo">265</span>  }<a name="line.265"></a>
+<span class="sourceLineNo">266</span><a name="line.266"></a>
+<span class="sourceLineNo">267</span>  @Test<a name="line.267"></a>
+<span class="sourceLineNo">268</span>  public void testTableSkewCost() {<a name="line.268"></a>
+<span class="sourceLineNo">269</span>    Configuration conf = HBaseConfiguration.create();<a name="line.269"></a>
+<span class="sourceLineNo">270</span>    StochasticLoadBalancer.CostFunction<a name="line.270"></a>
+<span class="sourceLineNo">271</span>        costFunction = new StochasticLoadBalancer.TableSkewCostFunction(conf);<a name="line.271"></a>
+<span class="sourceLineNo">272</span>    for (int[] mockCluster : clusterStateMocks) {<a name="line.272"></a>
+<span class="sourceLineNo">273</span>      BaseLoadBalancer.Cluster cluster = mockCluster(mockCluster);<a name="line.273"></a>
+<span class="sourceLineNo">274</span>      costFunction.init(cluster);<a name="line.274"></a>
+<span class="sourceLineNo">275</span>      double cost = costFunction.cost();<a name="line.275"></a>
+<span class="sourceLineNo">276</span>      assertTrue(cost &gt;= 0);<a name="line.276"></a>
+<span class="sourceLineNo">277</span>      assertTrue(cost &lt;= 1.01);<a name="line.277"></a>
+<span class="sourceLineNo">278</span>    }<a name="line.278"></a>
+<span class="sourceLineNo">279</span>  }<a name="line.279"></a>
+<span class="sourceLineNo">280</span><a name="line.280"></a>
+<span class="sourceLineNo">281</span>  @Test<a name="line.281"></a>
+<span class="sourceLineNo">282</span>  public void testRegionLoadCost() {<a name="line.282"></a>
+<span class="sourceLineNo">283</span>    List&lt;BalancerRegionLoad&gt; regionLoads = new ArrayList&lt;&gt;();<a name="line.283"></a>
+<span class="sourceLineNo">284</span>    for (int i = 1; i &lt; 5; i++) {<a name="line.284"></a>
+<span class="sourceLineNo">285</span>      BalancerRegionLoad regionLoad = mock(BalancerRegionLoad.class);<a name="line.285"></a>
+<span class="sourceLineNo">286</span>      when(regionLoad.getReadRequestsCount()).thenReturn(new Long(i));<a name="line.286"></a>
+<span class="sourceLineNo">287</span>      when(regionLoad.getStorefileSizeMB()).thenReturn(i);<a name="line.287"></a>
+<span class="sourceLineNo">288</span>      regionLoads.add(regionLoad);<a name="line.288"></a>
+<span class="sourceLineNo">289</span>    }<a name="line.289"></a>
+<span class="sourceLineNo">290</span><a name="line.290"></a>
+<span class="sourceLineNo">291</span>    Configuration conf = HBaseConfiguration.create();<a name="line.291"></a>
+<span class="sourceLineNo">292</span>    StochasticLoadBalancer.ReadRequestCostFunction readCostFunction =<a name="line.292"></a>
+<span class="sourceLineNo">293</span>        new StochasticLoadBalancer.ReadRequestCostFunction(conf);<a name="line.293"></a>
+<span class="sourceLineNo">294</span>    double rateResult = readCostFunction.getRegionLoadCost(regionLoads);<a name="line.294"></a>
+<span class="sourceLineNo">295</span>    // read requests are treated as a rate so the average rate here is simply 1<a name="line.295"></a>
+<span class="sourceLineNo">296</span>    assertEquals(1, rateResult, 0.01);<a name="line.296"></a>
+<span class="sourceLineNo">297</span><a name="line.297"></a>
+<span class="sourceLineNo">298</span>    StochasticLoadBalancer.StoreFileCostFunction storeFileCostFunction =<a name="line.298"></a>
+<span class="sourceLineNo">299</span>        new StochasticLoadBalancer.StoreFileCostFunction(conf);<a name="line.299"></a>
+<span class="sourceLineNo">300</span>    double result = storeFileCostFunction.getRegionLoadCost(regionLoads);<a name="line.300"></a>
+<span class="sourceLineNo">301</span>    // storefile size cost is simply an average of it's value over time<a name="line.301"></a>
+<span class="sourceLineNo">302</span>    assertEquals(2.5, result, 0.01);<a name="line.302"></a>
+<span class="sourceLineNo">303</span>  }<a name="line.303"></a>
+<span class="sourceLineNo">304</span><a name="line.304"></a>
+<span class="sourceLineNo">305</span>  @Test<a name="line.305"></a>
+<span class="sourceLineNo">306</span>  public void testCostFromArray() {<a name="line.306"></a>
+<span class="sourceLineNo">307</span>    Configuration conf = HBaseConfiguration.create();<a name="line.307"></a>
+<span class="sourceLineNo">308</span>    StochasticLoadBalancer.CostFromRegionLoadFunction<a name="line.308"></a>
+<span class="sourceLineNo">309</span>        costFunction = new StochasticLoadBalancer.MemStoreSizeCostFunction(conf);<a name="line.309"></a>
+<span class="sourceLineNo">310</span>    costFunction.init(mockCluster(new int[]{0, 0, 0, 0, 1}));<a name="line.310"></a>
+<span class="sourceLineNo">311</span><a name="line.311"></a>
+<span class="sourceLineNo">312</span>    double[] statOne = new double[100];<a name="line.312"></a>
+<span class="sourceLineNo">313</span>    for (int i =0; i &lt; 100; i++) {<a name="line.313"></a>
+<span class="sourceLineNo">314</span>      statOne[i] = 10;<a name="line.314"></a>
+<span class="sourceLineNo">315</span>    }<a name="line.315"></a>
+<span class="sourceLineNo">316</span>    assertEquals(0, costFunction.costFromArray(statOne), 0.01);<a name="line.316"></a>
+<span class="sourceLineNo">317</span><a name="line.317"></a>
+<span class="sourceLineNo">318</span>    double[] statTwo= new double[101];<a name="line.318"></a>
+<span class="sourceLineNo">319</span>    for (int i =0; i &lt; 100; i++) {<a name="line.319"></a>
+<span class="sourceLineNo">320</span>      statTwo[i] = 0;<a name="line.320"></a>
+<span class="sourceLineNo">321</span>    }<a name="line.321"></a>
+<span class="sourceLineNo">322</span>    statTwo[100] = 100;<a name="line.322"></a>
+<span class="sourceLineNo">323</span>    assertEquals(1, costFunction.costFromArray(statTwo), 0.01);<a name="line.323"></a>
+<span class="sourceLineNo">324</span><a name="line.324"></a>
+<span class="sourceLineNo">325</span>    double[] statThree = new double[200];<a name="line.325"></a>
+<span class="sourceLineNo">326</span>    for (int i =0; i &lt; 100; i++) {<a name="line.326"></a>
+<span class="sourceLineNo">327</span>      statThree[i] = (0);<a name="line.327"></a>
+<span class="sourceLineNo">328</span>      statThree[i+100] = 100;<a name="line.328"></a>
+<span class="sourceLineNo">329</span>    }<a name="line.329"></a>
+<span class="sourceLineNo">330</span>    assertEquals(0.5, costFunction.costFromArray(statThree), 0.01);<a name="line.330"></a>
+<span class="sourceLineNo">331</span>  }<a name="line.331"></a>
+<span class="sourceLineNo">332</span><a name="line.332"></a>
+<span class="sourceLineNo">333</span>  @Test<a name="line.333"></a>
+<span class="sourceLineNo">334</span>  public void testLosingRs() throws Exception {<a name="line.334"></a>
+<span class="sourceLineNo">335</span>    int numNodes = 3;<a name="line.335"></a>
+<span class="sourceLineNo">336</span>    int numRegions = 20;<a name="line.336"></a>
+<span class="sourceLineNo">337</span>    int numRegionsPerServer = 3; //all servers except one<a name="line.337"></a>
+<span class="sourceLineNo">338</span>    int replication = 1;<a name="line.338"></a>
+<span class="sourceLineNo">339</span>    int numTables = 2;<a name="line.339"></a>
+<span class="sourceLineNo">340</span><a name="line.340"></a>
+<span class="sourceLineNo">341</span>    Map&lt;ServerName, List&lt;RegionInfo&gt;&gt; serverMap =<a name="line.341"></a>
+<span class="sourceLineNo">342</span>        createServerMap(numNodes, numRegions, numRegionsPerServer, replication, numTables);<a name="line.342"></a>
+<span class="sourceLineNo">343</span>    List&lt;ServerAndLoad&gt; list = convertToList(serverMap);<a name="line.343"></a>
+<span class="sourceLineNo">344</span><a name="line.344"></a>
 <span class="sourceLineNo">345</span><a name="line.345"></a>
-<span class="sourceLineNo">346</span>  @Test<a name="line.346"></a>
-<span class="sourceLineNo">347</span>  public void testCostFromArray() {<a name="line.347"></a>
-<span class="sourceLineNo">348</span>    Configuration conf = HBaseConfiguration.create();<a name="line.348"></a>
-<span class="sourceLineNo">349</span>    StochasticLoadBalancer.CostFromRegionLoadFunction<a name="line.349"></a>
-<span class="sourceLineNo">350</span>        costFunction = new StochasticLoadBalancer.MemStoreSizeCostFunction(conf);<a name="line.350"></a>
-<span class="sourceLineNo">351</span>    costFunction.init(mockCluster(new int[]{0, 0, 0, 0, 1}));<a name="line.351"></a>
-<span class="sourceLineNo">352</span><a name="line.352"></a>
-<span class="sourceLineNo">353</span>    double[] statOne = new double[100];<a name="line.353"></a>
-<span class="sourceLineNo">354</span>    for (int i =0; i &lt; 100; i++) {<a name="line.354"></a>
-<span class="sourceLineNo">355</span>      statOne[i] = 10;<a name="line.355"></a>
-<span class="sourceLineNo">356</span>    }<a name="line.356"></a>
-<span class="sourceLineNo">357</span>    assertEquals(0, costFunction.costFromArray(statOne), 0.01);<a name="line.357"></a>
-<span class="sourceLineNo">358</span><a name="line.358"></a>
-<span class="sourceLineNo">359</span>    double[] statTwo= new double[101];<a name="line.359"></a>
-<span class="sourceLineNo">360</span>    for (int i =0; i &lt; 100; i++) {<a name="line.360"></a>
-<span class="sourceLineNo">361</span>      statTwo[i] = 0;<a name="line.361"></a>
-<span class="sourceLineNo">362</span>    }<a name="line.362"></a>
-<span class="sourceLineNo">363</span>    statTwo[100] = 100;<a name="line.363"></a>
-<span class="sourceLineNo">364</span>    assertEquals(1, costFunction.costFromArray(statTwo), 0.01);<a name="line.364"></a>
-<span class="sourceLineNo">365</span><a name="line.365"></a>
-<span class="sourceLineNo">366</span>    double[] statThree = new double[200];<a name="line.366"></a>
-<span class="sourceLineNo">367</span>    for (int i =0; i &lt; 100; i++) {<a name="line.367"></a>
-<span class="sourceLineNo">368</span>      statThree[i] = (0);<a name="line.368"></a>
-<span class="sourceLineNo">369</span>      statThree[i+100] = 100;<a name="line.369"></a>
-<span class="sourceLineNo">370</span>    }<a name="line.370"></a>
-<span class="sourceLineNo">371</span>    assertEquals(0.5, costFunction.costFromArray(statThree), 0.01);<a name="line.371"></a>
-<span class="sourceLineNo">372</span>  }<a name="line.372"></a>
+<span class="sourceLineNo">346</span>    List&lt;RegionPlan&gt; plans = loadBalancer.balanceCluster(serverMap);<a name="line.346"></a>
+<span class="sourceLineNo">347</span>    assertNotNull(plans);<a name="line.347"></a>
+<span class="sourceLineNo">348</span><a name="line.348"></a>
+<span class="sourceLineNo">349</span>    // Apply the plan to the mock cluster.<a name="line.349"></a>
+<span class="sourceLineNo">350</span>    List&lt;ServerAndLoad&gt; balancedCluster = reconcile(list, plans, serverMap);<a name="line.350"></a>
+<span class="sourceLineNo">351</span><a name="line.351"></a>
+<span class="sourceLineNo">352</span>    assertClusterAsBalanced(balancedCluster);<a name="line.352"></a>
+<span class="sourceLineNo">353</span><a name="line.353"></a>
+<span class="sourceLineNo">354</span>    ServerName sn = serverMap.keySet().toArray(new ServerName[serverMap.size()])[0];<a name="line.354"></a>
+<span class="sourceLineNo">355</span><a name="line.355"></a>
+<span class="sourceLineNo">356</span>    ServerName deadSn = ServerName.valueOf(sn.getHostname(), sn.getPort(), sn.getStartcode() - 100);<a name="line.356"></a>
+<span class="sourceLineNo">357</span><a name="line.357"></a>
+<span class="sourceLineNo">358</span>    serverMap.put(deadSn, new ArrayList&lt;&gt;(0));<a name="line.358"></a>
+<span class="sourceLineNo">359</span><a name="line.359"></a>
+<span class="sourceLineNo">360</span>    plans = loadBalancer.balanceCluster(serverMap);<a name="line.360"></a>
+<span class="sourceLineNo">361</span>    assertNull(plans);<a name="line.361"></a>
+<span class="sourceLineNo">362</span>  }<a name="line.362"></a>
+<span class="sourceLineNo">363</span><a name="line.363"></a>
+<span class="sourceLineNo">364</span>  // This mock allows us to test the LocalityCostFunction<a name="line.364"></a>
+<span class="sourceLineNo">365</span>  private class MockCluster extends BaseLoadBalancer.Cluster {<a name="line.365"></a>
+<span class="sourceLineNo">366</span><a name="line.366"></a>
+<span class="sourceLineNo">367</span>    private int[][] localities = null;   // [region][server] = percent of blocks<a name="line.367"></a>
+<span class="sourceLineNo">368</span><a name="line.368"></a>
+<span class="sourceLineNo">369</span>    public MockCluster(int[][] regions) {<a name="line.369"></a>
+<span class="sourceLineNo">370</span><a name="line.370"></a>
+<span class="sourceLineNo">371</span>      // regions[0] is an array where index = serverIndex an value = number of regions<a name="line.371"></a>
+<span class="sourceLineNo">372</span>      super(mockClusterServers(regions[0], 1), null, null, null);<a name="line.372"></a>
 <span class="sourceLineNo">373</span><a name="line.373"></a>
-<span class="sourceLineNo">374</span>  @Test(timeout =  60000)<a name="line.374"></a>
-<span class="sourceLineNo">375</span>  public void testLosingRs() throws Exception {<a name="line.375"></a>
-<span class="sourceLineNo">376</span>    int numNodes = 3;<a name="line.376"></a>
-<span class="sourceLineNo">377</span>    int numRegions = 20;<a name="line.377"></a>
-<span class="sourceLineNo">378</span>    int numRegionsPerServer = 3; //all servers except one<a name="line.378"></a>
-<span class="sourceLineNo">379</span>    int replication = 1;<a name="line.379"></a>
-<span class="sourceLineNo">380</span>    int numTables = 2;<a name="line.380"></a>
-<span class="sourceLineNo">381</span><a name="line.381"></a>
-<span class="sourceLineNo">382</span>    Map&lt;ServerName, List&lt;RegionInfo&gt;&gt; serverMap =<a name="line.382"></a>
-<span class="sourceLineNo">383</span>        createServerMap(numNodes, numRegions, numRegionsPerServer, replication, numTables);<a name="line.383"></a>
-<span class="sourceLineNo">384</span>    List&lt;ServerAndLoad&gt; list = convertToList(serverMap);<a name="line.384"></a>
+<span class="sourceLineNo">374</span>      localities = new int[regions.length - 1][];<a name="line.374"></a>
+<span class="sourceLineNo">375</span>      for (int i = 1; i &lt; regions.length; i++) {<a name="line.375"></a>
+<span class="sourceLineNo">376</span>        int regionIndex = i - 1;<a name="line.376"></a>
+<span class="sourceLineNo">377</span>        localities[regionIndex] = new int[regions[i].length - 1];<a name="line.377"></a>
+<span class="sourceLineNo">378</span>        regionIndexToServerIndex[regionIndex] = regions[i][0];<a name="line.378"></a>
+<span class="sourceLineNo">379</span>        for (int j = 1; j &lt; regions[i].length; j++) {<a name="line.379"></a>
+<span class="sourceLineNo">380</span>          int serverIndex = j - 1;<a name="line.380"></a>
+<span class="sourceLineNo">381</span>          localities[regionIndex][serverIndex] = regions[i][j] &gt; 100 ? regions[i][j] % 100 : regions[i][j];<a name="line.381"></a>
+<span class="sourceLineNo">382</span>        }<a name="line.382"></a>
+<span class="sourceLineNo">383</span>      }<a name="line.383"></a>
+<span class="sourceLineNo">384</span>    }<a name="line.384"></a>
 <span class="sourceLineNo">385</span><a name="line.385"></a>
-<span class="sourceLineNo">386</span><a name="line.386"></a>
-<span class="sourceLineNo">387</span>    List&lt;RegionPlan&gt; plans = loadBalancer.balanceCluster(serverMap);<a name="line.387"></a>
-<span class="sourceLineNo">388</span>    assertNotNull(plans);<a name="line.388"></a>
-<span class="sourceLineNo">389</span><a name="line.389"></a>
-<span class="sourceLineNo">390</span>    // Apply the plan to the mock cluster.<a name="line.390"></a>
-<span class="sourceLineNo">391</span>    List&lt;ServerAndLoad&gt; balancedCluster = reconcile(list, plans, serverMap);<a name="line.391"></a>
-<span class="sourceLineNo">392</span><a name="line.392"></a>
-<span class="sourceLineNo">393</span>    assertClusterAsBalanced(balancedCluster);<a name="line.393"></a>
-<span class="sourceLineNo">394</span><a name="line.394"></a>
-<span class="sourceLineNo">395</span>    ServerName sn = serverMap.keySet().toArray(new ServerName[serverMap.size()])[0];<a name="line.395"></a>
-<span class="sourceLineNo">396</span><a name="line.396"></a>
-<span class="sourceLineNo">397</span>    ServerName deadSn = ServerName.valueOf(sn.getHostname(), sn.getPort(), sn.getStartcode() - 100);<a name="line.397"></a>
-<span class="sourceLineNo">398</span><a name="line.398"></a>
-<span class="sourceLineNo">399</span>    serverMap.put(deadSn, new ArrayList&lt;&gt;(0));<a name="line.399"></a>
-<span class="sourceLineNo">400</span><a name="line.400"></a>
-<span class="sourceLineNo">401</span>    plans = loadBalancer.balanceCluster(serverMap);<a name="line.401"></a>
-<span class="sourceLineNo">402</span>    assertNull(plans);<a name="line.402"></a>
-<span class="sourceLineNo">403</span>  }<a name="line.403"></a>
-<span class="sourceLineNo">404</span><a name="line.404"></a>
-<span class="sourceLineNo">405</span>  @Test<a name="line.405"></a>
-<span class="sourceLineNo">406</span>  public void testReplicaCost() {<a name="line.406"></a>
-<span class="sourceLineNo">407</span>    Configuration conf = HBaseConfiguration.create();<a name="line.407"></a>
-<span class="sourceLineNo">408</span>    StochasticLoadBalancer.CostFunction<a name="line.408"></a>
-<span class="sourceLineNo">409</span>        costFunction = new StochasticLoadBalancer.RegionReplicaHostCostFunction(conf);<a name="line.409"></a>
-<span class="sourceLineNo">410</span>    for (int[] mockCluster : clusterStateMocks) {<a name="line.410"></a>
-<span class="sourceLineNo">411</span>      BaseLoadBalancer.Cluster cluster = mockCluster(mockCluster);<a name="line.411"></a>
-<span class="sourceLineNo">412</span>      costFunction.init(cluster);<a name="line.412"></a>
-<span class="sourceLineNo">413</span>      double cost = costFunction.cost();<a name="line.413"></a>
-<span class="sourceLineNo">414</span>      assertTrue(cost &gt;= 0);<a name="line.414"></a>
-<span class="sourceLineNo">415</span>      assertTrue(cost &lt;= 1.01);<a name="line.415"></a>
-<span class="sourceLineNo">416</span>    }<a name="line.416"></a>
-<span class="sourceLineNo">417</span>  }<a name="line.417"></a>
-<span class="sourceLineNo">418</span><a name="line.418"></a>
-<span class="sourceLineNo">419</span>  @Test<a name="line.419"></a>
-<span class="sourceLineNo">420</span>  public void testReplicaCostForReplicas() {<a name="line.420"></a>
-<span class="sourceLineNo">421</span>    Configuration conf = HBaseConfiguration.create();<a name="line.421"></a>
-<span class="sourceLineNo">422</span>    StochasticLoadBalancer.CostFunction<a name="line.422"></a>
-<span class="sourceLineNo">423</span>        costFunction = new StochasticLoadBalancer.RegionReplicaHostCostFunction(conf);<a name="line.423"></a>
-<span class="sourceLineNo">424</span><a name="line.424"></a>
-<span class="sourceLineNo">425</span>    int [] servers = new int[] {3,3,3,3,3};<a name="line.425"></a>
-<span class="sourceLineNo">426</span>    TreeMap&lt;ServerName, List&lt;RegionInfo&gt;&gt; clusterState = mockClusterServers(servers);<a name="line.426"></a>
-<span class="sourceLineNo">427</span><a name="line.427"></a>
-<span class="sourceLineNo">428</span>    BaseLoadBalancer.Cluster cluster;<a name="line.428"></a>
-<span class="sourceLineNo">429</span><a name="line.429"></a>
-<span class="sourceLineNo">430</span>    cluster = new BaseLoadBalancer.Cluster(clusterState, null, null, null);<a name="line.430"></a>
-<span class="sourceLineNo">431</span>    costFunction.init(cluster);<a name="line.431"></a>
-<span class="sourceLineNo">432</span>    double costWithoutReplicas = costFunction.cost();<a name="line.432"></a>
-<span class="sourceLineNo">433</span>    assertEquals(0, costWithoutReplicas, 0);<a name="line.433"></a>
-<span class="sourceLineNo">434</span><a name="line.434"></a>
-<span class="sourceLineNo">435</span>    // replicate the region from first server to the last server<a name="line.435"></a>
-<span class="sourceLineNo">436</span>    RegionInfo replica1 = RegionReplicaUtil.getRegionInfoForReplica(<a name="line.436"></a>
-<span class="sourceLineNo">437</span>      clusterState.firstEntry().getValue().get(0),1);<a name="line.437"></a>
-<span class="sourceLineNo">438</span>    clusterState.lastEntry().getValue().add(replica1);<a name="line.438"></a>
-<span class="sourceLineNo">439</span><a name="line.439"></a>
-<span class="sourceLineNo">440</span>    cluster = new BaseLoadBalancer.Cluster(clusterState, null, null, null);<a name="line.440"></a>
-<span class="sourceLineNo">441</span>    costFunction.init(cluster);<a name="line.441"></a>
-<span class="sourceLineNo">442</span>    double costWith1ReplicaDifferentServer = costFunction.cost();<a name="line.442"></a>
-<span class="sourceLineNo">443</span><a name="line.443"></a>
-<span class="sourceLineNo">444</span>    assertEquals(0, costWith1ReplicaDifferentServer, 0);<a name="line.444"></a>
-<span class="sourceLineNo">445</span><a name="line.445"></a>
-<span class="sourceLineNo">446</span>    // add a third replica to the last server<a name="line.446"></a>
-<span class="sourceLineNo">447</span>    RegionInfo replica2 = RegionReplicaUtil.getRegionInfoForReplica(replica1, 2);<a name="line.447"></a>
-<span class="sourceLineNo">448</span>    clusterState.lastEntry().getValue().add(replica2);<a name="line.448"></a>
-<span class="sourceLineNo">449</span><a name="line.449"></a>
-<span class="sourceLineNo">450</span>    cluster = new BaseLoadBalancer.Cluster(clusterState, null, null, null);<a name="line.450"></a>
-<span class="sourceLineNo">451</span>    costFunction.init(cluster);<a name="line.451"></a>
-<span class="sourceLineNo">452</span>    double costWith1ReplicaSameServer = costFunction.cost();<a name="line.452"></a>
-<span class="sourceLineNo">453</span><a name="line.453"></a>
-<span class="sourceLineNo">454</span>    assertTrue(costWith1ReplicaDifferentServer &lt; costWith1ReplicaSameServer);<a name="line.454"></a>
-<span class="sourceLineNo">455</span><a name="line.455"></a>
-<span class="sourceLineNo">456</span>    // test with replication = 4 for following:<a name="line.456"></a>
-<span class="sourceLineNo">457</span><a name="line.457"></a>
-<span class="sourceLineNo">458</span>    RegionInfo replica3;<a name="line.458"></a>
-<span class="sourceLineNo">459</span>    Iterator&lt;Entry&lt;ServerName, List&lt;RegionInfo&gt;&gt;&gt; it;<a name="line.459"></a>
-<span class="sourceLineNo">460</span>    Entry&lt;ServerName, List&lt;RegionInfo&gt;&gt; entry;<a name="line.460"></a>
-<span class="sourceLineNo">461</span><a name="line.461"></a>
-<span class="sourceLineNo">462</span>    clusterState = mockClusterServers(servers);<a name="line.462"></a>
-<span class="sourceLineNo">463</span>    it = clusterState.entrySet().iterator();<a name="line.463"></a>
-<span class="sourceLineNo">464</span>    entry = it.next(); //first server<a name="line.464"></a>
-<span class="sourceLineNo">465</span>    RegionInfo hri = entry.getValue().get(0);<a name="line.465"></a>
-<span class="sourceLineNo">466</span>    replica1 = RegionReplicaUtil.getRegionInfoForReplica(hri, 1);<a name="line.466"></a>
-<span class="sourceLineNo">467</span>    replica2 = RegionReplicaUtil.getRegionInfoForReplica(hri, 2);<a name="line.467"></a>
-<span class="sourceLineNo">468</span>    replica3 = RegionReplicaUtil.getRegionInfoForReplica(hri, 3);<a name="line.468"></a>
-<span class="sourceLineNo">469</span>    entry.getValue().add(replica1);<a name="line.469"></a>
-<span class="sourceLineNo">470</span>    entry.getValue().add(replica2);<a name="line.470"></a>
-<span class="sourceLineNo">471</span>    it.next().getValue().add(replica3); //2nd server<a name="line.471"></a>
-<span class="sourceLineNo">472</span><a name="line.472"></a>
-<span class="sourceLineNo">473</span>    cluster = new BaseLoadBalancer.Cluster(clusterState, null, null, null);<a name="line.473"></a>
-<span class="sourceLineNo">474</span>    costFunction.init(cluster);<a name="line.474"></a>
-<span class="sourceLineNo">475</span>    double costWith3ReplicasSameServer = costFunction.cost();<a name="line.475"></a>
-<span class="sourceLineNo">476</span><a name="line.476"></a>
-<span class="sourceLineNo">477</span>    clusterState = mockClusterServers(servers);<a name="line.477"></a>
-<span class="sourceLineNo">478</span>    hri = clusterState.firstEntry().getValue().get(0);<a name="line.478"></a>
-<span class="sourceLineNo">479</span>    replica1 = RegionReplicaUtil.getRegionInfoForReplica(hri, 1);<a name="line.479"></a>
-<span class="sourceLineNo">480</span>    replica2 = RegionReplicaUtil.getRegionInfoForReplica(hri, 2);<a name="line.480"></a>
-<span class="sourceLineNo">481</span>    replica3 = RegionReplicaUtil.getRegionInfoForReplica(hri, 3);<a name="line.481"></a>
-<span class="sourceLineNo">482</span><a name="line.482"></a>
-<span class="sourceLineNo">483</span>    clusterState.firstEntry().getValue().add(replica1);<a name="line.483"></a>
-<span class="sourceLineNo">484</span>    clusterState.lastEntry().getValue().add(replica2);<a name="line.484"></a>
-<span class="sourceLineNo">485</span>    clusterState.lastEntry().getValue().add(replica3);<a name="line.485"></a>
-<span class="sourceLineNo">486</span><a name="line.486"></a>
-<span class="sourceLineNo">487</span>    cluster = new BaseLoadBalancer.Cluster(clusterState, null, null, null);<a name="line.487"></a>
-<span class="sourceLineNo">488</span>    costFunction.init(cluster);<a name="line.488"></a>
-<span class="sourceLineNo">489</span>    double costWith2ReplicasOnTwoServers = costFunction.cost();<a name="line.489"></a>
-<span class="sourceLineNo">490</span><a name="line.490"></a>
-<span class="sourceLineNo">491</span>    assertTrue(costWith2ReplicasOnTwoServers &lt; costWith3ReplicasSameServer);<a name="line.491"></a>
-<span class="sourceLineNo">492</span>  }<a name="line.492"></a>
-<span class="sourceLineNo">493</span><a name="line.493"></a>
-<span class="sourceLineNo">494</span>  @Test<a name="line.494"></a>
-<span class="sourceLineNo">495</span>  public void testNeedsBalanceForColocatedReplicas() {<a name="line.495"></a>
-<span class="sourceLineNo">496</span>    // check for the case where there are two hosts and with one rack, and where<a name="line.496"></a>
-<span class="sourceLineNo">497</span>    // both the replicas are hosted on the same server<a name="line.497"></a>
-<span class="sourceLineNo">498</span>    List&lt;RegionInfo&gt; regions = randomRegions(1);<a name="line.498"></a>
-<span class="sourceLineNo">499</span>    ServerName s1 = ServerName.valueOf("host1", 1000, 11111);<a name="line.499"></a>
-<span class="sourceLineNo">500</span>    ServerName s2 = ServerName.valueOf("host11", 1000, 11111);<a name="line.500"></a>
-<span class="sourceLineNo">501</span>    Map&lt;ServerName, List&lt;RegionInfo&gt;&gt; map = new HashMap&lt;&gt;();<a name="line.501"></a>
-<span class="sourceLineNo">502</span>    map.put(s1, regions);<a name="line.502"></a>
-<span class="sourceLineNo">503</span>    regions.add(RegionReplicaUtil.getRegionInfoForReplica(regions.get(0), 1));<a name="line.503"></a>
-<span class="sourceLineNo">504</span>    // until the step above s1 holds two replicas of a region<a name="line.504"></a>
-<span class="sourceLineNo">505</span>    regions = randomRegions(1);<a name="line.505"></a>
-<span class="sourceLineNo">506</span>    map.put(s2, regions);<a name="line.506"></a>
-<span class="sourceLineNo">507</span>    assertTrue(loadBalancer.needsBalance(new Cluster(map, null, null, null)));<a name="line.507"></a>
-<span class="sourceLineNo">508</span>    // check for the case where there are two hosts on the same rack and there are two racks<a name="line.508"></a>
-<span class="sourceLineNo">509</span>    // and both the replicas are on the same rack<a name="line.509"></a>
-<span class="sourceLineNo">510</span>    map.clear();<a name="line.510"></a>
-<span class="sourceLineNo">511</span>    regions = randomRegions(1);<a name="line.511"></a>
-<span class="sourceLineNo">512</span>    List&lt;RegionInfo&gt; regionsOnS2 = new ArrayList&lt;&gt;(1);<a name="line.512"></a>
-<span class="sourceLineNo">513</span>    regionsOnS2.add(RegionReplicaUtil.getRegionInfoForReplica(regions.get(0), 1));<a name="line.513"></a>
-<span class="sourceLineNo">514</span>    map.put(s1, regions);<a name="line.514"></a>
-<span class="sourceLineNo">515</span>    map.put(s2, regionsOnS2);<a name="line.515"></a>
-<span class="sourceLineNo">516</span>    // add another server so that the cluster has some host on another rack<a name="line.516"></a>
-<span class="sourceLineNo">517</span>    map.put(ServerName.valueOf("host2", 1000, 11111), randomRegions(1));<a name="line.517"></a>
-<span class="sourceLineNo">518</span>    assertTrue(loadBalancer.needsBalance(new Cluster(map, null, null,<a name="line.518"></a>
-<span class="sourceLineNo">519</span>        new ForTestRackManagerOne())));<a name="line.519"></a>
-<span class="sourceLineNo">520</span>  }<a name="line.520"></a>
-<span class="sourceLineNo">521</span><a name="line.521"></a>
-<span class="sourceLineNo">522</span>  @Test (timeout = 60000)<a name="line.522"></a>
-<span class="sourceLineNo">523</span>  public void testSmallCluster() {<a name="line.523"></a>
-<span class="sourceLineNo">524</span>    int numNodes = 10;<a name="line.524"></a>
-<span class="sourceLineNo">525</span>    int numRegions = 1000;<a name="line.525"></a>
-<span class="sourceLineNo">526</span>    int numRegionsPerServer = 40; //all servers except one<a name="line.526"></a>
-<span class="sourceLineNo">527</span>    int replication = 1;<a name="line.527"></a>
-<span class="sourceLineNo">528</span>    int numTables = 10;<a name="line.528"></a>
-<span class="sourceLineNo">529</span>    testWithCluster(numNodes, numRegions, numRegionsPerServer, replication, numTables, true, true);<a name="line.529"></a>
-<span class="sourceLineNo">530</span>  }<a name="line.530"></a>
-<span class="sourceLineNo">531</span><a name="line.531"></a>
-<span class="sourceLineNo">532</span>  @Test (timeout = 60000)<a name="line.532"></a>
-<span class="sourceLineNo">533</span>  public void testSmallCluster2() {<a name="line.533"></a>
-<span class="sourceLineNo">534</span>    int numNodes = 20;<a name="line.534"></a>
-<span class="sourceLineNo">535</span>    int numRegions = 2000;<a name="line.535"></a>
-<span class="sourceLineNo">536</span>    int numRegionsPerServer = 40; //all servers except one<a name="line.536"></a>
-<span class="sourceLineNo">537</span>    int replication = 1;<a name="line.537"></a>
-<span class="sourceLineNo">538</span>    int numTables = 10;<a name="line.538"></a>
-<span class="sourceLineNo">539</span>    testWithCluster(numNodes, numRegions, numRegionsPerServer, replication, numTables, true, true);<a name="line.539"></a>
-<span class="sourceLineNo">540</span>  }<a name="line.540"></a>
-<span class="sourceLineNo">541</span><a name="line.541"></a>
-<span class="sourceLineNo">542</span>  @Test (timeout = 60000)<a name="line.542"></a>
-<span class="sourceLineNo">543</span>  public void testSmallCluster3() {<a name="line.543"></a>
-<span class="sourceLineNo">544</span>    int numNodes = 20;<a name="line.544"></a>
-<span class="sourceLineNo">545</span>    int numRegions = 2000;<a name="line.545"></a>
-<span class="sourceLineNo">546</span>    int numRegionsPerServer = 1; // all servers except one<a name="line.546"></a>
-<span class="sourceLineNo">547</span>    int replication = 1;<a name="line.547"></a>
-<span class="sourceLineNo">548</span>    int numTables = 10;<a name="line.548"></a>
-<span class="sourceLineNo">549</span>    /* fails because of max moves */<a name="line.549"></a>
-<span class="sourceLineNo">550</span>    testWithCluster(numNodes, numRegions, numRegionsPerServer, replication, numTables, false, false);<a name="line.550"></a>
-<span class="sourceLineNo">551</span>  }<a name="line.551"></a>
-<span class="sourceLineNo">552</span><a name="line.552"></a>
-<span class="sourceLineNo">553</span>  @Test (timeout = 800000)<a name="line.553"></a>
-<span class="sourceLineNo">554</span>  public void testMidCluster() {<a name="line.55

<TRUNCATED>