You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "dirrao (via GitHub)" <gi...@apache.org> on 2024/05/21 02:48:22 UTC
[PR] Resolving mysql deprecated operator warnings [airflow]
dirrao opened a new pull request, #39725:
URL: https://github.com/apache/airflow/pull/39725
Resolving mysql deprecated operator warnings
related: #39485
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Resolving mysql deprecated operator warnings [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk merged PR #39725:
URL: https://github.com/apache/airflow/pull/39725
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Resolving mysql deprecated operator warnings [airflow]
Posted by "dirrao (via GitHub)" <gi...@apache.org>.
dirrao commented on code in PR #39725:
URL: https://github.com/apache/airflow/pull/39725#discussion_r1609910401
##########
airflow/providers/mysql/operators/mysql.py:
##########
@@ -42,7 +42,7 @@ class MySqlOperator(SQLExecuteQueryOperator):
.. seealso::
For more information on how to use this operator, take a look at the guide:
- :ref:`howto/operator:MySqlOperator`
+ :ref:`howto/operator:mysql`
Review Comment:
Yes. The doc checks are failing as this reference is not available.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Resolving mysql deprecated operator warnings [airflow]
Posted by "dirrao (via GitHub)" <gi...@apache.org>.
dirrao commented on PR #39725:
URL: https://github.com/apache/airflow/pull/39725#issuecomment-2130657466
@eladkal / @potiuk
Can someone check and merge this pull request?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Resolving mysql deprecated operator warnings [airflow]
Posted by "Bowrna (via GitHub)" <gi...@apache.org>.
Bowrna commented on PR #39725:
URL: https://github.com/apache/airflow/pull/39725#issuecomment-2121815950
@dirrao you may need to edit the documentation part too
airflow/docs/apache-airflow-providers-mysql/operators.rst
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Resolving mysql deprecated operator warnings [airflow]
Posted by "Taragolis (via GitHub)" <gi...@apache.org>.
Taragolis commented on code in PR #39725:
URL: https://github.com/apache/airflow/pull/39725#discussion_r1609665479
##########
airflow/providers/mysql/operators/mysql.py:
##########
@@ -42,7 +42,7 @@ class MySqlOperator(SQLExecuteQueryOperator):
.. seealso::
For more information on how to use this operator, take a look at the guide:
- :ref:`howto/operator:MySqlOperator`
+ :ref:`howto/operator:mysql`
Review Comment:
Do we really need to change target from `MySqlOperator` to generic `mysql` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org