You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by David Reid <da...@jetnet.co.uk> on 2000/06/20 00:14:08 UTC
[PATCH] mpm_common.c
Folks,
I'd liekt o commit this, but when I checked I found that not all the
mpm's have the ap_get_max_daemons() function. Any objections to the
patch and me adding the function/you adding the function as required?
This came up as I wanted to use a different variable name in my new MPM
and so the function helps give me that ability whilst not breaking
anything. Also I liek that it removes one of the variables being more
widely than needed.
david
RCS file: /home/cvs/apache-2.0/src/main/mpm_common.c,v
retrieving revision 1.13
diff -u -u -r1.13 mpm_common.c
--- mpm_common.c 2000/06/19 21:11:49 1.13
+++ mpm_common.c 2000/06/19 21:12:41
@@ -99,6 +99,7 @@
ap_status_t waitret;
int tries;
int not_dead_yet;
+ int max_daemons = ap_get_max_daemons();
#ifdef SCOREBOARD
ap_sync_scoreboard_image();
@@ -116,7 +117,7 @@
/* now see who is done */
not_dead_yet = 0;
- for (i = 0; i < ap_max_daemons_limit; ++i) {
+ for (i = 0; i < max_daemons; ++i) {
pid_t pid = CHILD_INFO_TABLE[i].pid;
ap_proc_t proc;
Re: [PATCH] mpm_common.c
Posted by Jeff Trawick <tr...@ibm.net>.
> From: "David Reid" <da...@jetnet.co.uk>
> Date: Mon, 19 Jun 2000 22:14:08 +0000
>
> Folks,
>
> I'd liekt o commit this, but when I checked I found that not all the
> mpm's have the ap_get_max_daemons() function. Any objections to the
> patch and me adding the function/you adding the function as
> required?
no objections here as long as you ship the trivial required changes to
the other mpms at about the same time that you ship the code that
needs it...
--
Jeff Trawick | trawick@ibm.net | PGP public key at web site:
http://www.geocities.com/SiliconValley/Park/9289/
Born in Roswell... married an alien...