You are viewing a plain text version of this content. The canonical link for it is here.
Posted to solr-dev@lucene.apache.org by "Gunnar Wagenknecht (JIRA)" <ji...@apache.org> on 2008/11/12 20:09:44 UTC

[jira] Created: (SOLR-851) Remove dependency on StAX Utils or make it optional

Remove dependency on StAX Utils or make it optional
---------------------------------------------------

                 Key: SOLR-851
                 URL: https://issues.apache.org/jira/browse/SOLR-851
             Project: Solr
          Issue Type: Wish
    Affects Versions: 1.3
            Reporter: Gunnar Wagenknecht


I found out that the dependency on https://stax-utils.dev.java.net/ comes down to two places where BaseXMLInputFactory.newInstance() is called.

Is that intentionally or can those be replaced with XMLInputFactory.newInstance()?

The method newInstance is not defined in BaseXMLInputFactory but in XMLInputFactory which comes from the JDK in Java 6. I don't know about Java 5, though.

If it's because of Java 5 can I prepare a patch for using reflection to make the dependency on StAX Utils optional? The reason I'm asking is because I'm about to submit Solr 1.3 for IP review to the Eclipse Foundation because I want to use it in our Eclipse project. Lesser dependencies would make it easier.  

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (SOLR-851) Remove dependency on StAX Utils or make it optional

Posted by "Gunnar Wagenknecht (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SOLR-851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12647004#action_12647004 ] 

Gunnar Wagenknecht commented on SOLR-851:
-----------------------------------------

{blockquote}
-------- Original-Nachricht --------
Betreff: Re: Dependency on StAX Utils
Datum: Mon, 10 Nov 2008 13:42:04 +0530
Von: Shalin Shekhar Mangar <...>
Antwort an: solr-dev@lucene.apache.org
An: solr-dev@lucene.apache.org
Referenzen: <49...@wagenknecht.org>

Thanks for pointing this out.

I just removed stax-utils from my local trunk, changed all instances of
BaseXMLInputFactory.newInstance() to XMLInputFactory.newInstance() and ran
test. All tests pass so I think we should be able to remove this jar from
our list of dependencies.

[...]

Please raise an issue in jira for this.
{blockquote}


> Remove dependency on StAX Utils or make it optional
> ---------------------------------------------------
>
>                 Key: SOLR-851
>                 URL: https://issues.apache.org/jira/browse/SOLR-851
>             Project: Solr
>          Issue Type: Wish
>    Affects Versions: 1.3
>            Reporter: Gunnar Wagenknecht
>
> I found out that the dependency on https://stax-utils.dev.java.net/ comes down to two places where BaseXMLInputFactory.newInstance() is called.
> Is that intentionally or can those be replaced with XMLInputFactory.newInstance()?
> The method newInstance is not defined in BaseXMLInputFactory but in XMLInputFactory which comes from the JDK in Java 6. I don't know about Java 5, though.
> If it's because of Java 5 can I prepare a patch for using reflection to make the dependency on StAX Utils optional? The reason I'm asking is because I'm about to submit Solr 1.3 for IP review to the Eclipse Foundation because I want to use it in our Eclipse project. Lesser dependencies would make it easier.  

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (SOLR-851) Remove dependency on StAX Utils or make it optional

Posted by "Ryan McKinley (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SOLR-851?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ryan McKinley resolved SOLR-851.
--------------------------------

       Resolution: Fixed
    Fix Version/s: 1.4

> Remove dependency on StAX Utils or make it optional
> ---------------------------------------------------
>
>                 Key: SOLR-851
>                 URL: https://issues.apache.org/jira/browse/SOLR-851
>             Project: Solr
>          Issue Type: Wish
>    Affects Versions: 1.3
>            Reporter: Gunnar Wagenknecht
>             Fix For: 1.4
>
>
> I found out that the dependency on https://stax-utils.dev.java.net/ comes down to two places where BaseXMLInputFactory.newInstance() is called.
> Is that intentionally or can those be replaced with XMLInputFactory.newInstance()?
> The method newInstance is not defined in BaseXMLInputFactory but in XMLInputFactory which comes from the JDK in Java 6. I don't know about Java 5, though.
> If it's because of Java 5 can I prepare a patch for using reflection to make the dependency on StAX Utils optional? The reason I'm asking is because I'm about to submit Solr 1.3 for IP review to the Eclipse Foundation because I want to use it in our Eclipse project. Lesser dependencies would make it easier.  

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Issue Comment Edited: (SOLR-851) Remove dependency on StAX Utils or make it optional

Posted by "Gunnar Wagenknecht (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SOLR-851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12647004#action_12647004 ] 

gunnar edited comment on SOLR-851 at 11/12/08 11:12 AM:
--------------------------------------------------------------------

{quote}
-------- Original-Nachricht --------
Betreff: Re: Dependency on StAX Utils
Datum: Mon, 10 Nov 2008 13:42:04 +0530
Von: Shalin Shekhar Mangar <...>
Antwort an: solr-dev@lucene.apache.org
An: solr-dev@lucene.apache.org
Referenzen: <49...@wagenknecht.org>

Thanks for pointing this out.

I just removed stax-utils from my local trunk, changed all instances of
BaseXMLInputFactory.newInstance() to XMLInputFactory.newInstance() and ran
test. All tests pass so I think we should be able to remove this jar from
our list of dependencies.

[...]

Please raise an issue in jira for this.
{quote}


      was (Author: gunnar):
    {blockquote}
-------- Original-Nachricht --------
Betreff: Re: Dependency on StAX Utils
Datum: Mon, 10 Nov 2008 13:42:04 +0530
Von: Shalin Shekhar Mangar <...>
Antwort an: solr-dev@lucene.apache.org
An: solr-dev@lucene.apache.org
Referenzen: <49...@wagenknecht.org>

Thanks for pointing this out.

I just removed stax-utils from my local trunk, changed all instances of
BaseXMLInputFactory.newInstance() to XMLInputFactory.newInstance() and ran
test. All tests pass so I think we should be able to remove this jar from
our list of dependencies.

[...]

Please raise an issue in jira for this.
{blockquote}

  
> Remove dependency on StAX Utils or make it optional
> ---------------------------------------------------
>
>                 Key: SOLR-851
>                 URL: https://issues.apache.org/jira/browse/SOLR-851
>             Project: Solr
>          Issue Type: Wish
>    Affects Versions: 1.3
>            Reporter: Gunnar Wagenknecht
>
> I found out that the dependency on https://stax-utils.dev.java.net/ comes down to two places where BaseXMLInputFactory.newInstance() is called.
> Is that intentionally or can those be replaced with XMLInputFactory.newInstance()?
> The method newInstance is not defined in BaseXMLInputFactory but in XMLInputFactory which comes from the JDK in Java 6. I don't know about Java 5, though.
> If it's because of Java 5 can I prepare a patch for using reflection to make the dependency on StAX Utils optional? The reason I'm asking is because I'm about to submit Solr 1.3 for IP review to the Eclipse Foundation because I want to use it in our Eclipse project. Lesser dependencies would make it easier.  

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (SOLR-851) Remove dependency on StAX Utils or make it optional

Posted by "Gunnar Wagenknecht (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SOLR-851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12661615#action_12661615 ] 

Gunnar Wagenknecht commented on SOLR-851:
-----------------------------------------

Cool. So this issue can be marked resolved then, can't it? 

> Remove dependency on StAX Utils or make it optional
> ---------------------------------------------------
>
>                 Key: SOLR-851
>                 URL: https://issues.apache.org/jira/browse/SOLR-851
>             Project: Solr
>          Issue Type: Wish
>    Affects Versions: 1.3
>            Reporter: Gunnar Wagenknecht
>
> I found out that the dependency on https://stax-utils.dev.java.net/ comes down to two places where BaseXMLInputFactory.newInstance() is called.
> Is that intentionally or can those be replaced with XMLInputFactory.newInstance()?
> The method newInstance is not defined in BaseXMLInputFactory but in XMLInputFactory which comes from the JDK in Java 6. I don't know about Java 5, though.
> If it's because of Java 5 can I prepare a patch for using reflection to make the dependency on StAX Utils optional? The reason I'm asking is because I'm about to submit Solr 1.3 for IP review to the Eclipse Foundation because I want to use it in our Eclipse project. Lesser dependencies would make it easier.  

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (SOLR-851) Remove dependency on StAX Utils or make it optional

Posted by "Ryan McKinley (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SOLR-851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12661614#action_12661614 ] 

Ryan McKinley commented on SOLR-851:
------------------------------------

stax utils is removed from trunk...  but the stax libs are required unless you have java 6.

if anything else would be helpful, patches are always welcome....

> Remove dependency on StAX Utils or make it optional
> ---------------------------------------------------
>
>                 Key: SOLR-851
>                 URL: https://issues.apache.org/jira/browse/SOLR-851
>             Project: Solr
>          Issue Type: Wish
>    Affects Versions: 1.3
>            Reporter: Gunnar Wagenknecht
>
> I found out that the dependency on https://stax-utils.dev.java.net/ comes down to two places where BaseXMLInputFactory.newInstance() is called.
> Is that intentionally or can those be replaced with XMLInputFactory.newInstance()?
> The method newInstance is not defined in BaseXMLInputFactory but in XMLInputFactory which comes from the JDK in Java 6. I don't know about Java 5, though.
> If it's because of Java 5 can I prepare a patch for using reflection to make the dependency on StAX Utils optional? The reason I'm asking is because I'm about to submit Solr 1.3 for IP review to the Eclipse Foundation because I want to use it in our Eclipse project. Lesser dependencies would make it easier.  

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (SOLR-851) Remove dependency on StAX Utils or make it optional

Posted by "Gunnar Wagenknecht (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SOLR-851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12661517#action_12661517 ] 

Gunnar Wagenknecht commented on SOLR-851:
-----------------------------------------

Any chance this can be included in a 1.4 release? Do you need a patch for this?

> Remove dependency on StAX Utils or make it optional
> ---------------------------------------------------
>
>                 Key: SOLR-851
>                 URL: https://issues.apache.org/jira/browse/SOLR-851
>             Project: Solr
>          Issue Type: Wish
>    Affects Versions: 1.3
>            Reporter: Gunnar Wagenknecht
>
> I found out that the dependency on https://stax-utils.dev.java.net/ comes down to two places where BaseXMLInputFactory.newInstance() is called.
> Is that intentionally or can those be replaced with XMLInputFactory.newInstance()?
> The method newInstance is not defined in BaseXMLInputFactory but in XMLInputFactory which comes from the JDK in Java 6. I don't know about Java 5, though.
> If it's because of Java 5 can I prepare a patch for using reflection to make the dependency on StAX Utils optional? The reason I'm asking is because I'm about to submit Solr 1.3 for IP review to the Eclipse Foundation because I want to use it in our Eclipse project. Lesser dependencies would make it easier.  

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Issue Comment Edited: (SOLR-851) Remove dependency on StAX Utils or make it optional

Posted by "Gunnar Wagenknecht (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SOLR-851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12661615#action_12661615 ] 

gunnar edited comment on SOLR-851 at 1/7/09 7:56 AM:
-----------------------------------------------------------------

Cool. So this issue can be marked resolved then, can't it? I'm just checking, because I don't know the actual procedure. As long as the initial request is concerned, IMHO the issues is addressed. :) Thanks!

      was (Author: gunnar):
    Cool. So this issue can be marked resolved then, can't it? 
  
> Remove dependency on StAX Utils or make it optional
> ---------------------------------------------------
>
>                 Key: SOLR-851
>                 URL: https://issues.apache.org/jira/browse/SOLR-851
>             Project: Solr
>          Issue Type: Wish
>    Affects Versions: 1.3
>            Reporter: Gunnar Wagenknecht
>
> I found out that the dependency on https://stax-utils.dev.java.net/ comes down to two places where BaseXMLInputFactory.newInstance() is called.
> Is that intentionally or can those be replaced with XMLInputFactory.newInstance()?
> The method newInstance is not defined in BaseXMLInputFactory but in XMLInputFactory which comes from the JDK in Java 6. I don't know about Java 5, though.
> If it's because of Java 5 can I prepare a patch for using reflection to make the dependency on StAX Utils optional? The reason I'm asking is because I'm about to submit Solr 1.3 for IP review to the Eclipse Foundation because I want to use it in our Eclipse project. Lesser dependencies would make it easier.  

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.