You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Klaus Ma <kl...@gmail.com> on 2016/03/20 15:05:42 UTC
Review Request 45081: Excluded reserved resources when got
nonRevocable resources in stage 1.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45081/
-----------------------------------------------------------
Review request for mesos and Alexander Rukletsov.
Repository: mesos
Description
-------
Allocator will only allocate non-revocable resources to satify quota. As the reserved resources can not be revocable, it's not necessary to call `nonRevocable()` for reserved resources.
Diffs
-----
src/master/allocator/mesos/hierarchical.cpp 70291075c00a9a557529c2562dedcfc6c6c3ec32
Diff: https://reviews.apache.org/r/45081/diff/
Testing
-------
make
make check
Thanks,
Klaus Ma
Re: Review Request 45081: Excluded reserved resources when got
nonRevocable resources in stage 1.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45081/#review124449
-----------------------------------------------------------
Patch looks great!
Reviews applied: [45081]
Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh
- Mesos ReviewBot
On March 20, 2016, 2:06 p.m., Klaus Ma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45081/
> -----------------------------------------------------------
>
> (Updated March 20, 2016, 2:06 p.m.)
>
>
> Review request for mesos and Alexander Rukletsov.
>
>
> Bugs: MESOS-4988
> https://issues.apache.org/jira/browse/MESOS-4988
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Allocator will only allocate non-revocable resources to satify quota. As the reserved resources can not be revocable, it's not necessary to call `nonRevocable()` for reserved resources.
>
>
> Diffs
> -----
>
> src/master/allocator/mesos/hierarchical.cpp 70291075c00a9a557529c2562dedcfc6c6c3ec32
>
> Diff: https://reviews.apache.org/r/45081/diff/
>
>
> Testing
> -------
>
> make
> make check
>
>
> Thanks,
>
> Klaus Ma
>
>
Re: Review Request 45081: Excluded reserved resources when got
nonRevocable resources in stage 1.
Posted by Klaus Ma <kl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45081/
-----------------------------------------------------------
(Updated March 20, 2016, 10:06 p.m.)
Review request for mesos and Alexander Rukletsov.
Changes
-------
Update the bugs
Bugs: MESOS-4988
https://issues.apache.org/jira/browse/MESOS-4988
Repository: mesos
Description
-------
Allocator will only allocate non-revocable resources to satify quota. As the reserved resources can not be revocable, it's not necessary to call `nonRevocable()` for reserved resources.
Diffs
-----
src/master/allocator/mesos/hierarchical.cpp 70291075c00a9a557529c2562dedcfc6c6c3ec32
Diff: https://reviews.apache.org/r/45081/diff/
Testing
-------
make
make check
Thanks,
Klaus Ma