You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@myfaces.apache.org by lu...@apache.org on 2008/04/12 01:10:44 UTC

svn commit: r647347 - /myfaces/shared/trunk_3.0.x/core/src/main/java/org/apache/myfaces/shared/renderkit/html/HtmlRendererUtils.java

Author: lu4242
Date: Fri Apr 11 16:10:41 2008
New Revision: 647347

URL: http://svn.apache.org/viewvc?rev=647347&view=rev
Log:
fix MYFACES-1691 beforeUnload event handler breaks form submission

Modified:
    myfaces/shared/trunk_3.0.x/core/src/main/java/org/apache/myfaces/shared/renderkit/html/HtmlRendererUtils.java

Modified: myfaces/shared/trunk_3.0.x/core/src/main/java/org/apache/myfaces/shared/renderkit/html/HtmlRendererUtils.java
URL: http://svn.apache.org/viewvc/myfaces/shared/trunk_3.0.x/core/src/main/java/org/apache/myfaces/shared/renderkit/html/HtmlRendererUtils.java?rev=647347&r1=647346&r2=647347&view=diff
==============================================================================
--- myfaces/shared/trunk_3.0.x/core/src/main/java/org/apache/myfaces/shared/renderkit/html/HtmlRendererUtils.java (original)
+++ myfaces/shared/trunk_3.0.x/core/src/main/java/org/apache/myfaces/shared/renderkit/html/HtmlRendererUtils.java Fri Apr 11 16:10:41 2008
@@ -1024,8 +1024,8 @@
         context.append(CLEAR_HIDDEN_INPUT_FN_NAME).append("(formname, name, value)");
         context.append("{");
         context.append("var form = document.forms[formname];");
-        context.append("var hInput = form.elements[name];");
         context.prettyLine();
+        context.append("var hInput = form.elements[name];");        
         context.append("if(typeof hInput !='undefined')");
         context.append("{");
         //context.append("form.elements[name].value=null;");
@@ -1093,12 +1093,20 @@
         context.prettyLine();
         context.append("if((typeof result=='undefined')||result)");
         context.append("{");
+        context.append("try");
+        context.append("{");
         context.append("form.submit();");
         context.append("}");
+        context.append("catch(e){}");
+        context.append("}");
         context.append("}");
         context.append("else ");
         context.append("{");
+        context.append("try");
+        context.append("{");        
         context.append("form.submit();");
+        context.append("}");
+        context.append("catch(e){}");        
         context.append("}");
 
         //reset the target