You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2018/03/29 11:42:57 UTC

[GitHub] rafaelweingartner commented on a change in pull request #2505: CLOUDSTACK-10333: Secure Live VM Migration for KVM

rafaelweingartner commented on a change in pull request #2505: CLOUDSTACK-10333: Secure Live VM Migration for KVM
URL: https://github.com/apache/cloudstack/pull/2505#discussion_r178028132
 
 

 ##########
 File path: agent/src/com/cloud/agent/Agent.java
 ##########
 @@ -274,6 +279,19 @@ public void start() {
             }
         }
         _shell.updateConnectedHost();
+
+        // In case of software based restart, GC to remove old instances
+        _executor.submit(new Runnable() {
 
 Review comment:
   Can you explaining the goal of this code here?
   Remove old instance of Java objects? 
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services