[GitHub] [nifi-minifi-cpp] fgerlits commented on a diff in pull request #1394: MINIFICPP-1910 - Rename main directory to avoid name clashes with main branch

[GitBox <gi...@apache.org>]

fgerlits commented on code in PR #1394:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1394#discussion_r951133671


##########
win_build_vs.bat:
##########
@@ -108,9 +108,9 @@ mkdir %builddir%
 pushd %builddir%\
 
 if [%generator%] EQU ["Ninja"] (
-    set "buildcmd=ninja && copy bin\minifi.exe main\"
+    set "buildcmd=ninja && copy bin\minifi.exe minifi_main\"
 ) else (
-    set "buildcmd=msbuild /m nifi-minifi-cpp.sln /property:Configuration=%cmake_build_type% /property:Platform=%build_platform% && copy bin\%cmake_build_type%\minifi.exe main\"
+    set "buildcmd=msbuild /m nifi-minifi-cpp.sln /property:Configuration=%cmake_build_type% /property:Platform=%build_platform% && copy bin\%cmake_build_type%\minifi.exe minifi_main\"

Review Comment:
   It is required by `cpack`, when creating the `msi` installer.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org