[jira] [Created] (DIRKRB-353) Fix findbugs Problem for lib module

["Xu Yaning (JIRA)" <ji...@apache.org>]

Xu Yaning created DIRKRB-353:
--------------------------------

             Summary: Fix findbugs Problem for lib module
                 Key: DIRKRB-353
                 URL: https://issues.apache.org/jira/browse/DIRKRB-353
             Project: Directory Kerberos
          Issue Type: Sub-task
            Reporter: Xu Yaning


For lib module, findbugs reports 6 problems to fix: 

1. Found reliance on default encoding in org.apache.kerby.config.IniConfigLoader.loadConfig(ConfigImpl, Resource): new java.io.InputStreamReader(InputStream);
2. org.apache.kerby.config.IniConfigLoader.loadConfig(ConfigImpl, Resource) may fail to close stream;
3. org.apache.kerby.config.MapConfigLoader.loadConfig(ConfigImpl, Resource) makes inefficient use of keySet iterator instead of entrySet iterator;
4. instanceof will always return true for all non-null values in org.apache.kerby.config.PropertiesConfigLoader.loadConfig(ConfigImpl, Properties), since all String are instances of String;
5. new org.apache.kerby.config.Resource(String, File, Resource$Format) may fail to clean up java.io.InputStream;
6. Redundant nullcheck of name, which is known to be non-null in org.apache.kerby.config.XmlConfigLoader.loadConfig(ConfigImpl, Element).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)