You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@apr.apache.org by Justin Erenkrantz <ju...@erenkrantz.com> on 2007/02/28 19:31:28 UTC

Re: svn commit: r512882 - in /apr/apr/trunk: file_io/os2/readwrite.c file_io/unix/readwrite.c test/testfile.c

On 2/28/07, pquerna@apache.org <pq...@apache.org> wrote:
> Author: pquerna
> Date: Wed Feb 28 10:05:37 2007
> New Revision: 512882
>
> URL: http://svn.apache.org/viewvc?view=rev&rev=512882
> Log:
> Fix apr_file_writev when buffering is enabled by forcing a flush, rather than writing underneath the write buffer.

How about conditionally flushing if we have buffering enabled?  -- justin

Re: svn commit: r512882 - in /apr/apr/trunk: file_io/os2/readwrite.c file_io/unix/readwrite.c test/testfile.c

Posted by Justin Erenkrantz <ju...@erenkrantz.com>.

On 2/28/07, Davi Arnaut <da...@haxent.com.br> wrote:
> apr_file_flush does that.

Ugh, we're not doing an fsync()?  We should be if the user calls
flush.  -- justin

Re: svn commit: r512882 - in /apr/apr/trunk: file_io/os2/readwrite.c file_io/unix/readwrite.c test/testfile.c

Posted by Davi Arnaut <da...@haxent.com.br>.

On 28/02/2007, at 15:31, Justin Erenkrantz wrote:

> On 2/28/07, pquerna@apache.org <pq...@apache.org> wrote:
>> Author: pquerna
>> Date: Wed Feb 28 10:05:37 2007
>> New Revision: 512882
>>
>> URL: http://svn.apache.org/viewvc?view=rev&rev=512882
>> Log:
>> Fix apr_file_writev when buffering is enabled by forcing a flush,  
>> rather than writing underneath the write buffer.
>
> How about conditionally flushing if we have buffering enabled?  --  
> justin

apr_file_flush does that.

--
Davi Arnaut