You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@helix.apache.org by Hang Qi <ha...@gmail.com> on 2015/05/18 09:54:39 UTC
Review Request 34345: [HELIX-596] fix throttled messages still take
constraints' quota
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34345/
-----------------------------------------------------------
Review request for helix.
Bugs: HELIX-596
Repository: helix-git
Description
-------
commit 9ddbefcacff6b8e229e6413299d53d89f1cbcd43
Author: Hang Qi <ha...@gmail.com>
Date: Sun May 17 23:06:20 2015 -0700
[HELIX-596] fix throttled messages still take constraints' quota
:100644 100644 39bb228... 635ac17... M helix-core/src/main/java/org/apache/helix/controller/stages/MessageThrottleStage.java
:100644 100644 29228e4... 40823a8... M helix-core/src/test/java/org/apache/helix/controller/stages/TestMessageThrottleStage.java
:100644 100644 32106e1... edab4c4... M helix-core/src/test/java/org/apache/helix/testutil/HelixTestUtil.java
Diffs
-----
helix-core/src/main/java/org/apache/helix/controller/stages/MessageThrottleStage.java 39bb228
helix-core/src/test/java/org/apache/helix/controller/stages/TestMessageThrottleStage.java 29228e4
helix-core/src/test/java/org/apache/helix/testutil/HelixTestUtil.java 32106e1
Diff: https://reviews.apache.org/r/34345/diff/
Testing
-------
Add One UT TestMessageThrottleStage#testMsgThrottleConstraintsQuota
This UT fails prior to the patch, and passed after the fix.
Thanks,
Hang Qi
Re: Review Request 34345: [HELIX-596] fix throttled messages still
take constraints' quota
Posted by Hang Qi <ha...@gmail.com>.
> On May 20, 2015, 8:38 p.m., Zhen Zhang wrote:
> > LGTM. Thanks for the fix! You can probably send a pull request on github instead, so the fix can be easily merged under your name.
>
> Hang Qi wrote:
> Thanks very much for reviewing it.
>
> Yes, that would be much eaiser for me as well, I am just trying to follow the steps described in https://cwiki.apache.org/confluence/display/HELIX/Contributor+Workflow
>
> Which repo should I send pull request to?
>
> Thanks
> Hang Qi
>
> Zhen Zhang wrote:
> use this repo.
>
> https://github.com/apache/helix
Thx, pull request https://github.com/apache/helix/pull/28
- Hang
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34345/#review84576
-----------------------------------------------------------
On May 18, 2015, 7:54 a.m., Hang Qi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34345/
> -----------------------------------------------------------
>
> (Updated May 18, 2015, 7:54 a.m.)
>
>
> Review request for helix.
>
>
> Bugs: HELIX-596
>
>
> Repository: helix-git
>
>
> Description
> -------
>
> commit 9ddbefcacff6b8e229e6413299d53d89f1cbcd43
> Author: Hang Qi <ha...@gmail.com>
> Date: Sun May 17 23:06:20 2015 -0700
>
> [HELIX-596] fix throttled messages still take constraints' quota
>
> :100644 100644 39bb228... 635ac17... M helix-core/src/main/java/org/apache/helix/controller/stages/MessageThrottleStage.java
> :100644 100644 29228e4... 40823a8... M helix-core/src/test/java/org/apache/helix/controller/stages/TestMessageThrottleStage.java
> :100644 100644 32106e1... edab4c4... M helix-core/src/test/java/org/apache/helix/testutil/HelixTestUtil.java
>
>
> Diffs
> -----
>
> helix-core/src/main/java/org/apache/helix/controller/stages/MessageThrottleStage.java 39bb228
> helix-core/src/test/java/org/apache/helix/controller/stages/TestMessageThrottleStage.java 29228e4
> helix-core/src/test/java/org/apache/helix/testutil/HelixTestUtil.java 32106e1
>
> Diff: https://reviews.apache.org/r/34345/diff/
>
>
> Testing
> -------
>
> Add One UT TestMessageThrottleStage#testMsgThrottleConstraintsQuota
>
> This UT fails prior to the patch, and passed after the fix.
>
>
> Thanks,
>
> Hang Qi
>
>
Re: Review Request 34345: [HELIX-596] fix throttled messages still
take constraints' quota
Posted by Hang Qi <ha...@gmail.com>.
> On May 20, 2015, 8:38 p.m., Zhen Zhang wrote:
> > LGTM. Thanks for the fix! You can probably send a pull request on github instead, so the fix can be easily merged under your name.
Thanks very much for reviewing it.
Yes, that would be much eaiser for me as well, I am just trying to follow the steps described in https://cwiki.apache.org/confluence/display/HELIX/Contributor+Workflow
Which repo should I send pull request to?
Thanks
Hang Qi
- Hang
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34345/#review84576
-----------------------------------------------------------
On May 18, 2015, 7:54 a.m., Hang Qi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34345/
> -----------------------------------------------------------
>
> (Updated May 18, 2015, 7:54 a.m.)
>
>
> Review request for helix.
>
>
> Bugs: HELIX-596
>
>
> Repository: helix-git
>
>
> Description
> -------
>
> commit 9ddbefcacff6b8e229e6413299d53d89f1cbcd43
> Author: Hang Qi <ha...@gmail.com>
> Date: Sun May 17 23:06:20 2015 -0700
>
> [HELIX-596] fix throttled messages still take constraints' quota
>
> :100644 100644 39bb228... 635ac17... M helix-core/src/main/java/org/apache/helix/controller/stages/MessageThrottleStage.java
> :100644 100644 29228e4... 40823a8... M helix-core/src/test/java/org/apache/helix/controller/stages/TestMessageThrottleStage.java
> :100644 100644 32106e1... edab4c4... M helix-core/src/test/java/org/apache/helix/testutil/HelixTestUtil.java
>
>
> Diffs
> -----
>
> helix-core/src/main/java/org/apache/helix/controller/stages/MessageThrottleStage.java 39bb228
> helix-core/src/test/java/org/apache/helix/controller/stages/TestMessageThrottleStage.java 29228e4
> helix-core/src/test/java/org/apache/helix/testutil/HelixTestUtil.java 32106e1
>
> Diff: https://reviews.apache.org/r/34345/diff/
>
>
> Testing
> -------
>
> Add One UT TestMessageThrottleStage#testMsgThrottleConstraintsQuota
>
> This UT fails prior to the patch, and passed after the fix.
>
>
> Thanks,
>
> Hang Qi
>
>
Re: Review Request 34345: [HELIX-596] fix throttled messages still
take constraints' quota
Posted by Zhen Zhang <ne...@gmail.com>.
> On May 20, 2015, 8:38 p.m., Zhen Zhang wrote:
> > LGTM. Thanks for the fix! You can probably send a pull request on github instead, so the fix can be easily merged under your name.
>
> Hang Qi wrote:
> Thanks very much for reviewing it.
>
> Yes, that would be much eaiser for me as well, I am just trying to follow the steps described in https://cwiki.apache.org/confluence/display/HELIX/Contributor+Workflow
>
> Which repo should I send pull request to?
>
> Thanks
> Hang Qi
use this repo.
https://github.com/apache/helix
- Zhen
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34345/#review84576
-----------------------------------------------------------
On May 18, 2015, 7:54 a.m., Hang Qi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34345/
> -----------------------------------------------------------
>
> (Updated May 18, 2015, 7:54 a.m.)
>
>
> Review request for helix.
>
>
> Bugs: HELIX-596
>
>
> Repository: helix-git
>
>
> Description
> -------
>
> commit 9ddbefcacff6b8e229e6413299d53d89f1cbcd43
> Author: Hang Qi <ha...@gmail.com>
> Date: Sun May 17 23:06:20 2015 -0700
>
> [HELIX-596] fix throttled messages still take constraints' quota
>
> :100644 100644 39bb228... 635ac17... M helix-core/src/main/java/org/apache/helix/controller/stages/MessageThrottleStage.java
> :100644 100644 29228e4... 40823a8... M helix-core/src/test/java/org/apache/helix/controller/stages/TestMessageThrottleStage.java
> :100644 100644 32106e1... edab4c4... M helix-core/src/test/java/org/apache/helix/testutil/HelixTestUtil.java
>
>
> Diffs
> -----
>
> helix-core/src/main/java/org/apache/helix/controller/stages/MessageThrottleStage.java 39bb228
> helix-core/src/test/java/org/apache/helix/controller/stages/TestMessageThrottleStage.java 29228e4
> helix-core/src/test/java/org/apache/helix/testutil/HelixTestUtil.java 32106e1
>
> Diff: https://reviews.apache.org/r/34345/diff/
>
>
> Testing
> -------
>
> Add One UT TestMessageThrottleStage#testMsgThrottleConstraintsQuota
>
> This UT fails prior to the patch, and passed after the fix.
>
>
> Thanks,
>
> Hang Qi
>
>
Re: Review Request 34345: [HELIX-596] fix throttled messages still
take constraints' quota
Posted by Zhen Zhang <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34345/#review84576
-----------------------------------------------------------
Ship it!
LGTM. Thanks for the fix! You can probably send a pull request on github instead, so the fix can be easily merged under your name.
- Zhen Zhang
On May 18, 2015, 7:54 a.m., Hang Qi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34345/
> -----------------------------------------------------------
>
> (Updated May 18, 2015, 7:54 a.m.)
>
>
> Review request for helix.
>
>
> Bugs: HELIX-596
>
>
> Repository: helix-git
>
>
> Description
> -------
>
> commit 9ddbefcacff6b8e229e6413299d53d89f1cbcd43
> Author: Hang Qi <ha...@gmail.com>
> Date: Sun May 17 23:06:20 2015 -0700
>
> [HELIX-596] fix throttled messages still take constraints' quota
>
> :100644 100644 39bb228... 635ac17... M helix-core/src/main/java/org/apache/helix/controller/stages/MessageThrottleStage.java
> :100644 100644 29228e4... 40823a8... M helix-core/src/test/java/org/apache/helix/controller/stages/TestMessageThrottleStage.java
> :100644 100644 32106e1... edab4c4... M helix-core/src/test/java/org/apache/helix/testutil/HelixTestUtil.java
>
>
> Diffs
> -----
>
> helix-core/src/main/java/org/apache/helix/controller/stages/MessageThrottleStage.java 39bb228
> helix-core/src/test/java/org/apache/helix/controller/stages/TestMessageThrottleStage.java 29228e4
> helix-core/src/test/java/org/apache/helix/testutil/HelixTestUtil.java 32106e1
>
> Diff: https://reviews.apache.org/r/34345/diff/
>
>
> Testing
> -------
>
> Add One UT TestMessageThrottleStage#testMsgThrottleConstraintsQuota
>
> This UT fails prior to the patch, and passed after the fix.
>
>
> Thanks,
>
> Hang Qi
>
>