[jira] [Commented] (AVRO-1522) SortedKeyValueFile Writer should support compression codecs

["Steven Willis (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AVRO-1522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14014286#comment-14014286 ] 

Steven Willis commented on AVRO-1522:
-------------------------------------

Can I get a code review on this patch? Also, how does one get Jenkins to automatically test this?

> SortedKeyValueFile Writer should support compression codecs
> -----------------------------------------------------------
>
>                 Key: AVRO-1522
>                 URL: https://issues.apache.org/jira/browse/AVRO-1522
>             Project: Avro
>          Issue Type: Bug
>    Affects Versions: 1.7.6
>            Reporter: Steven Willis
>         Attachments: AVRO-1522.patch
>
>
> There's no option to set the compression codec on a {{SortedKeyValueFile.Writer}}. And since the {{Writer}} creates the output file in the constructor and it provides no public access to the underlying {{DataFileWriter}} anyway, the user can't set a codec themselves.
> I have a patch that will add this functionality through the {{SortedKeyValueFile.Writer.Options}} class. But we might want to consider if it also makes sense to delay creating the data and index {{DataFileWriters}} until a {{create()}} method is called, and allow public access to these writers so a consumer of the API can modify settings of the underlying writers themselves.



--
This message was sent by Atlassian JIRA
(v6.2#6252)