Re: [PR] [conf][stats] Fix default configuration 'statsProviderClass' [bookkeeper]

["zwOvO (via GitHub)" <gi...@apache.org>]

zwOvO commented on PR #4156:
URL: https://github.com/apache/bookkeeper/pull/4156#issuecomment-1854137313

   > > > Why do we need this change?
   > > > @hangc0276 The default value of StatsProviderClass is NullStatsProvier.class
   > > 
   > > 
   > > ```java
   > >     public Class<? extends StatsProvider> getStatsProviderClass()
   > >         throws ConfigurationException {
   > >         return ReflectionUtils.getClass(this, STATS_PROVIDER_CLASS,
   > >                                         NullStatsProvider.class, StatsProvider.class,
   > >                                         DEFAULT_LOADER);
   > >     }
   > > ```
   > 
   > @zwOvO Ok, I see. We should only change the wrong value configuration without modifying others. `statsProviderClass=org.apache.bookkeeper.stats.prometheus.PrometheusMetricsProvider`
   
   OK
   
   > > > Why do we need this change?
   > > > @hangc0276 The default value of StatsProviderClass is NullStatsProvier.class
   > > 
   > > 
   > > ```java
   > >     public Class<? extends StatsProvider> getStatsProviderClass()
   > >         throws ConfigurationException {
   > >         return ReflectionUtils.getClass(this, STATS_PROVIDER_CLASS,
   > >                                         NullStatsProvider.class, StatsProvider.class,
   > >                                         DEFAULT_LOADER);
   > >     }
   > > ```
   > 
   > @zwOvO Ok, I see. We should only change the wrong value configuration without modifying others. `statsProviderClass=org.apache.bookkeeper.stats.prometheus.PrometheusMetricsProvider`
   
   OK


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org