You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/10/20 14:52:23 UTC

[GitHub] [arrow] rdettai edited a comment on pull request #8300: ARROW-10135: [Rust] [Parquet] Refactor file module to help adding sources

rdettai edited a comment on pull request #8300:
URL: https://github.com/apache/arrow/pull/8300#issuecomment-712910596


   > @rdettai are there still more changes that you intend on making, and @alamb are all your queries and concerns addressed? Thanks for the detailed review.
   
   @nevi-me Depends on whether we want `ParquetReader` to remain public or not. If not, I think the PR is fine, otherwise, I can bring it back into `parquet::file::reader`.
   
   @sunchao I tried to restrain myself on this PR 😄. Honestly, I had to move quite a lot of things around because this touches a core API and things were very "monolithic". There are two points were I'm getting a little bit out of the main concern:
   - I added a `Seek` implem to the `FileSource` that ended up not being useful. I am removing it right now.
   - The typo fix in `array_reader`, but I'm sure you can forgive me that one :-)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org