[GitHub] [dubbo] AlbumenJ commented on a change in pull request #5913: windows platform unittest adapt

[GitBox <gi...@apache.org>]

AlbumenJ commented on a change in pull request #5913:
URL: https://github.com/apache/dubbo/pull/5913#discussion_r398321161



##########
File path: dubbo-rpc/dubbo-rpc-dubbo/pom.xml
##########
@@ -91,4 +91,15 @@
             <scope>test</scope>
         </dependency>
     </dependencies>
+    <build>
+        <plugins>
+            <plugin>
+                <groupId>org.apache.maven.plugins</groupId>
+                <artifactId>maven-surefire-plugin</artifactId>
+                <configuration>
+                    <runOrder>alphabetical</runOrder>

Review comment:
       This will make ArgumentCallbackTest be the first one in the test suit.
   Running ArgumentCallbackTest after other unit test will fail owing to NPE in arugument callback.
   If remove this one, in Linux platform ArgumentCallbackTest still the first one to run, but in Windows platform it would be the last one.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org