[jira] [Commented] (PDFBOX-4373) Add additional unit tests

["Tilman Hausherr (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PDFBOX-4373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16681787#comment-16681787 ] 

Tilman Hausherr commented on PDFBOX-4373:
-----------------------------------------

Sure! Please attach them here. Important: try to respect the coding conventions,

[https://pdfbox.apache.org/codingconventions.html]

and don't reformat existing code.

> Add additional unit tests
> -------------------------
>
>                 Key: PDFBOX-4373
>                 URL: https://issues.apache.org/jira/browse/PDFBOX-4373
>             Project: PDFBox
>          Issue Type: Test
>          Components: PDModel, Rendering, Writing
>            Reporter: John Bergqvist
>            Priority: Minor
>
> I've ran JaCoCo over the {{pdfbox}} module, and found some functions that were missing unit test coverage.
> I've written some unit tests for these functions and I would like to submit them.
> The functions I've written tests for are:
>  * org.apache.pdfbox.cos.COSObjectKey.compareToInput
>  * org.apache.pdfbox.pdfwriter.COSWriterXRefEntry.compareToInput
>  * org.apache.pdfbox.pdmodel.PageLayout.fromString
>  * org.apache.pdfbox.pdmodel.PageMode.fromString
>  * org.apache.pdfbox.pdmodel.PageMode.stringValue
>  * org.apache.pdfbox.pdmodel.graphics.state.RenderingIntent.fromString
>  * org.apache.pdfbox.pdmodel.graphics.state.RenderingIntent.stringValue
>  * org.apache.pdfbox.pdmodel.graphics.state.RenderingMode.intValue



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pdfbox.apache.org
For additional commands, e-mail: dev-help@pdfbox.apache.org