You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by Jens-G <gi...@git.apache.org> on 2015/10/18 18:59:18 UTC
[GitHub] thrift pull request: THRIFT-3393 Introducing i8 to provide consist...
GitHub user Jens-G opened a pull request:
https://github.com/apache/thrift/pull/656
THRIFT-3393 Introducing i8 to provide consistent set of Thrift integers
THRIFT-3393 Introducing i8 to provide consistent set of Thrift integers
Client: Compiler (general)
Patch: Jens Geyer
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Jens-G/thrift THRIFT-3393
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/656.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #656
----
commit debe89e99a2be191bcc5d70a886bdb12153af293
Author: Jens Geyer <je...@apache.org>
Date: 2015-10-16T18:21:54Z
THRIFT-3393 Introducing i8 to provide consistent set of Thrift integers
Client: Compiler (general)
Patch: Jens Geyer
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: THRIFT-3393 Introducing i8 to provide consist...
Posted by hcorg <gi...@git.apache.org>.
Github user hcorg commented on a diff in the pull request:
https://github.com/apache/thrift/pull/656#discussion_r42542836
--- Diff: test/ThriftTest.thrift ---
@@ -86,7 +86,7 @@ struct Xtruct
struct Xtruct2
{
- 1: byte byte_thing,
+ 1: i8 byte_thing, // used to be byte, hence the name
--- End diff --
I'd go with full rename ;) (just my normal hate for comments :D)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: THRIFT-3393 Introducing i8 to provide consist...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/thrift/pull/656
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: THRIFT-3393 Introducing i8 to provide consist...
Posted by hcorg <gi...@git.apache.org>.
Github user hcorg commented on a diff in the pull request:
https://github.com/apache/thrift/pull/656#discussion_r42542828
--- Diff: compiler/cpp/src/thriftl.ll ---
@@ -155,7 +155,8 @@ literal_begin (['\"])
"include" { return tok_include; }
"void" { return tok_void; }
"bool" { return tok_bool; }
-"byte" { return tok_byte; }
+"byte" { return tok_i8; }
--- End diff --
could we somehow generate warning here? "using byte type is deprecated as it might lead to misunderstanding in signess" or something
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: THRIFT-3393 Introducing i8 to provide consist...
Posted by Jens-G <gi...@git.apache.org>.
Github user Jens-G commented on a diff in the pull request:
https://github.com/apache/thrift/pull/656#discussion_r42545542
--- Diff: test/ThriftTest.thrift ---
@@ -86,7 +86,7 @@ struct Xtruct
struct Xtruct2
{
- 1: byte byte_thing,
+ 1: i8 byte_thing, // used to be byte, hence the name
--- End diff --
Agree, but one of my goals was to break it down into small changes to prevent us from ending up with a monster patch. This could be one of the next steps.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---