You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@lens.apache.org by Sushil Mohanty <su...@gmail.com> on 2015/07/27 17:54:22 UTC

Review Request 36850: Lens-187 : Move cube specific error message codes from InMobi's Hive code to Lens

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36850/
-----------------------------------------------------------

Review request for lens, Amareshwari Sriramadasu and Himanshu Gahlaut.


Bugs: LENS-187
    https://issues.apache.org/jira/browse/LENS-187


Repository: lens


Description
-------

Moved all cube related error messages from (InMobi) Hive to Lens.


Diffs
-----

  lens-api/src/main/resources/lens-errors.conf 6130ad7 
  lens-cube/src/main/java/org/apache/lens/cube/error/LensCubeErrorCode.java 0006b22 
  lens-cube/src/main/java/org/apache/lens/cube/parse/AbridgedTimeRangeWriter.java d5276e0 
  lens-cube/src/main/java/org/apache/lens/cube/parse/AggregateResolver.java f880495 
  lens-cube/src/main/java/org/apache/lens/cube/parse/AliasReplacer.java 9309307 
  lens-cube/src/main/java/org/apache/lens/cube/parse/BetweenTimeRangeWriter.java 6c85c2d 
  lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateFact.java 6c88fb3 
  lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTableResolver.java 50a4d53 
  lens-cube/src/main/java/org/apache/lens/cube/parse/ColumnResolver.java 2ff5959 
  lens-cube/src/main/java/org/apache/lens/cube/parse/ContextRewriter.java feb26d7 
  lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java 65c240a 
  lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryRewriter.java 72dc64b 
  lens-cube/src/main/java/org/apache/lens/cube/parse/CubeSemanticAnalyzer.java 68bffed 
  lens-cube/src/main/java/org/apache/lens/cube/parse/DateUtil.java 9e295d3 
  lens-cube/src/main/java/org/apache/lens/cube/parse/DenormalizationResolver.java 4a95d5a 
  lens-cube/src/main/java/org/apache/lens/cube/parse/DimHQLContext.java 3814cf6 
  lens-cube/src/main/java/org/apache/lens/cube/parse/DimOnlyHQLContext.java 922501d 
  lens-cube/src/main/java/org/apache/lens/cube/parse/ExpressionResolver.java 895cb06 
  lens-cube/src/main/java/org/apache/lens/cube/parse/FactHQLContext.java 623c58b 
  lens-cube/src/main/java/org/apache/lens/cube/parse/FieldValidator.java 03377dd 
  lens-cube/src/main/java/org/apache/lens/cube/parse/HQLContextInterface.java 35011e8 
  lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java 7b99310 
  lens-cube/src/main/java/org/apache/lens/cube/parse/JoinResolver.java 7d04d19 
  lens-cube/src/main/java/org/apache/lens/cube/parse/MultiFactHQLContext.java b5f5adc 
  lens-cube/src/main/java/org/apache/lens/cube/parse/SimpleHQLContext.java f3f3f78 
  lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactHQLContext.java b63111b 
  lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactMultiStorageHQLContext.java 4ad2f1f 
  lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java 7bfbd86 
  lens-cube/src/main/java/org/apache/lens/cube/parse/TimeRange.java 03732cb 
  lens-cube/src/main/java/org/apache/lens/cube/parse/TimeRangeWriter.java 12acf98 
  lens-cube/src/main/java/org/apache/lens/cube/parse/TimerangeResolver.java 820d77d 
  lens-cube/src/main/java/org/apache/lens/cube/parse/UnionHQLContext.java e6ed86b 
  lens-cube/src/test/java/org/apache/lens/cube/metadata/timeline/TestPartitionTimelines.java 0268bbf 
  lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java e0338f5 
  lens-cube/src/test/java/org/apache/lens/cube/parse/FieldsCannotBeQueriedTogetherTest.java 501a4b0 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestAggregateResolver.java 13058e2 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java f65bd28 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java e04d04c 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestDateUtil.java 6717b5b 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestDenormalizationResolver.java 901b95e 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestExpressionResolver.java 7f872e9 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java ed08605 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestQueryRewrite.java d16f6a5 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestRewriterPlan.java 0805fb5 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeExtractor.java 26836fe 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeResolver.java f2d7990 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeWriter.java 453a102 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeWriterWithQuery.java 0e22ce2 
  lens-server-api/src/main/java/org/apache/lens/server/api/error/LensException.java 123b6ee 
  lens-server/src/main/java/org/apache/lens/server/error/UnSupportedQuerySubmitOpException.java 4ab26ec 
  lens-server/src/test/java/org/apache/lens/server/rewrite/TestRewriting.java 9628865 

Diff: https://reviews.apache.org/r/36850/diff/


Testing
-------

All unit tests are running fine.
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [18.289s]
[INFO] Lens .............................................. SUCCESS [0.371s]
[INFO] Lens API .......................................... SUCCESS [26.254s]
[INFO] Lens API for server and extensions ................ SUCCESS [26.354s]
[INFO] Lens Cube ......................................... SUCCESS [5:24.863s]
[INFO] Lens DB storage ................................... SUCCESS [20.037s]
[INFO] Lens Query Library ................................ SUCCESS [10.167s]
[INFO] Lens Hive Driver .................................. SUCCESS [3:34.907s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [34.493s]
[INFO] Lens Server ....................................... SUCCESS [19:37.403s]
[INFO] Lens client ....................................... SUCCESS [55.363s]
[INFO] Lens CLI .......................................... SUCCESS [4:31.293s]
[INFO] Lens Examples ..................................... SUCCESS [7.305s]
[INFO] Lens Distribution ................................. SUCCESS [2.314s]
[INFO] Lens ML Lib ....................................... SUCCESS [13:28.783s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [13.554s]
[INFO] Lens Regression ................................... SUCCESS [3.790s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 50:17.722s
[INFO] Finished at: Mon Jul 27 21:05:04 IST 2015
[INFO] Final Memory: 173M/1864M
[INFO] ------------------------------------------------------------------------


Thanks,

Sushil Mohanty

Re: Review Request 36850: Lens-187 : Move cube specific error message codes from InMobi's Hive code to Lens

Posted by Rajat Khandelwal <ra...@gmail.com>.


> On July 28, 2015, 11:49 a.m., Rajat Khandelwal wrote:
> > lens-cube/src/main/java/org/apache/lens/cube/parse/ContextRewriter.java, line 34
> > <https://reviews.apache.org/r/36850/diff/1/?file=1022465#file1022465line34>
> >
> >     I believe all the semantic exceptions should have been gone. If not, can you elaborate on why?

Also, let's do a `git grep` and make sure they are not used anymore.


- Rajat


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36850/#review93241
-----------------------------------------------------------


On July 27, 2015, 9:24 p.m., Sushil Mohanty wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36850/
> -----------------------------------------------------------
> 
> (Updated July 27, 2015, 9:24 p.m.)
> 
> 
> Review request for lens, Amareshwari Sriramadasu and Himanshu Gahlaut.
> 
> 
> Bugs: LENS-187
>     https://issues.apache.org/jira/browse/LENS-187
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> Moved all cube related error messages from (InMobi) Hive to Lens.
> 
> 
> Diffs
> -----
> 
>   lens-api/src/main/resources/lens-errors.conf 6130ad7 
>   lens-cube/src/main/java/org/apache/lens/cube/error/LensCubeErrorCode.java 0006b22 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/AbridgedTimeRangeWriter.java d5276e0 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/AggregateResolver.java f880495 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/AliasReplacer.java 9309307 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/BetweenTimeRangeWriter.java 6c85c2d 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateFact.java 6c88fb3 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTableResolver.java 50a4d53 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/ColumnResolver.java 2ff5959 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/ContextRewriter.java feb26d7 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java 65c240a 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryRewriter.java 72dc64b 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CubeSemanticAnalyzer.java 68bffed 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/DateUtil.java 9e295d3 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/DenormalizationResolver.java 4a95d5a 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/DimHQLContext.java 3814cf6 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/DimOnlyHQLContext.java 922501d 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/ExpressionResolver.java 895cb06 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/FactHQLContext.java 623c58b 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/FieldValidator.java 03377dd 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/HQLContextInterface.java 35011e8 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java 7b99310 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/JoinResolver.java 7d04d19 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/MultiFactHQLContext.java b5f5adc 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/SimpleHQLContext.java f3f3f78 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactHQLContext.java b63111b 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactMultiStorageHQLContext.java 4ad2f1f 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java 7bfbd86 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/TimeRange.java 03732cb 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/TimeRangeWriter.java 12acf98 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/TimerangeResolver.java 820d77d 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/UnionHQLContext.java e6ed86b 
>   lens-cube/src/test/java/org/apache/lens/cube/metadata/timeline/TestPartitionTimelines.java 0268bbf 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java e0338f5 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/FieldsCannotBeQueriedTogetherTest.java 501a4b0 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestAggregateResolver.java 13058e2 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java f65bd28 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java e04d04c 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestDateUtil.java 6717b5b 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestDenormalizationResolver.java 901b95e 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestExpressionResolver.java 7f872e9 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java ed08605 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestQueryRewrite.java d16f6a5 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestRewriterPlan.java 0805fb5 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeExtractor.java 26836fe 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeResolver.java f2d7990 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeWriter.java 453a102 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeWriterWithQuery.java 0e22ce2 
>   lens-server-api/src/main/java/org/apache/lens/server/api/error/LensException.java 123b6ee 
>   lens-server/src/main/java/org/apache/lens/server/error/UnSupportedQuerySubmitOpException.java 4ab26ec 
>   lens-server/src/test/java/org/apache/lens/server/rewrite/TestRewriting.java 9628865 
> 
> Diff: https://reviews.apache.org/r/36850/diff/
> 
> 
> Testing
> -------
> 
> All unit tests are running fine.
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [18.289s]
> [INFO] Lens .............................................. SUCCESS [0.371s]
> [INFO] Lens API .......................................... SUCCESS [26.254s]
> [INFO] Lens API for server and extensions ................ SUCCESS [26.354s]
> [INFO] Lens Cube ......................................... SUCCESS [5:24.863s]
> [INFO] Lens DB storage ................................... SUCCESS [20.037s]
> [INFO] Lens Query Library ................................ SUCCESS [10.167s]
> [INFO] Lens Hive Driver .................................. SUCCESS [3:34.907s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [34.493s]
> [INFO] Lens Server ....................................... SUCCESS [19:37.403s]
> [INFO] Lens client ....................................... SUCCESS [55.363s]
> [INFO] Lens CLI .......................................... SUCCESS [4:31.293s]
> [INFO] Lens Examples ..................................... SUCCESS [7.305s]
> [INFO] Lens Distribution ................................. SUCCESS [2.314s]
> [INFO] Lens ML Lib ....................................... SUCCESS [13:28.783s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [13.554s]
> [INFO] Lens Regression ................................... SUCCESS [3.790s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 50:17.722s
> [INFO] Finished at: Mon Jul 27 21:05:04 IST 2015
> [INFO] Final Memory: 173M/1864M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Sushil Mohanty
> 
>

Re: Review Request 36850: Lens-187 : Move cube specific error message codes from InMobi's Hive code to Lens

Posted by Amareshwari Sriramadasu <am...@apache.org>.


> On July 28, 2015, 6:19 a.m., Rajat Khandelwal wrote:
> > lens-cube/src/main/java/org/apache/lens/cube/parse/JoinResolver.java, line 851
> > <https://reviews.apache.org/r/36850/diff/1/?file=1022478#file1022478line851>
> >
> >     I believe it would be more explicit if we make sub classes of LensException just like 
> >     
> >     ```
> >     public class FieldsCannotBeQueriedTogetherException extends LensException {
> >     ```
> >     
> >     Then the javadoc of most of the methods would become clear. The `@throws` field can be explicit as to why it throws an exception.
> 
> Himanshu Gahlaut wrote:
>     Just be careful that subclassing should not result in one exception sub class per error code. Otherwise it might become unmaintainable. A subclass is only required if getFormattedErrorMessage is complex (e.g. created using some logic on error payload) OR a error payload has to be transferred. The problem of enhanced documentation can be solved with @throws LensException with {@link org.apache.lens.cube.error.LensCubeErrorCode.NO_JOIN_PATH}

Yes, I agree with Himanshu.
I feel current changes are good for us to move from SemanticException to LensException. Reviewing each exception - whether they should be subclassed or not is lots of work again. And can be done whenever the need comes.


- Amareshwari


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36850/#review93241
-----------------------------------------------------------


On July 27, 2015, 3:54 p.m., Sushil Mohanty wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36850/
> -----------------------------------------------------------
> 
> (Updated July 27, 2015, 3:54 p.m.)
> 
> 
> Review request for lens, Amareshwari Sriramadasu and Himanshu Gahlaut.
> 
> 
> Bugs: LENS-187
>     https://issues.apache.org/jira/browse/LENS-187
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> Moved all cube related error messages from (InMobi) Hive to Lens.
> 
> 
> Diffs
> -----
> 
>   lens-api/src/main/resources/lens-errors.conf 6130ad7 
>   lens-cube/src/main/java/org/apache/lens/cube/error/LensCubeErrorCode.java 0006b22 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/AbridgedTimeRangeWriter.java d5276e0 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/AggregateResolver.java f880495 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/AliasReplacer.java 9309307 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/BetweenTimeRangeWriter.java 6c85c2d 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateFact.java 6c88fb3 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTableResolver.java 50a4d53 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/ColumnResolver.java 2ff5959 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/ContextRewriter.java feb26d7 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java 65c240a 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryRewriter.java 72dc64b 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CubeSemanticAnalyzer.java 68bffed 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/DateUtil.java 9e295d3 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/DenormalizationResolver.java 4a95d5a 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/DimHQLContext.java 3814cf6 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/DimOnlyHQLContext.java 922501d 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/ExpressionResolver.java 895cb06 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/FactHQLContext.java 623c58b 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/FieldValidator.java 03377dd 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/HQLContextInterface.java 35011e8 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java 7b99310 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/JoinResolver.java 7d04d19 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/MultiFactHQLContext.java b5f5adc 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/SimpleHQLContext.java f3f3f78 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactHQLContext.java b63111b 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactMultiStorageHQLContext.java 4ad2f1f 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java 7bfbd86 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/TimeRange.java 03732cb 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/TimeRangeWriter.java 12acf98 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/TimerangeResolver.java 820d77d 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/UnionHQLContext.java e6ed86b 
>   lens-cube/src/test/java/org/apache/lens/cube/metadata/timeline/TestPartitionTimelines.java 0268bbf 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java e0338f5 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/FieldsCannotBeQueriedTogetherTest.java 501a4b0 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestAggregateResolver.java 13058e2 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java f65bd28 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java e04d04c 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestDateUtil.java 6717b5b 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestDenormalizationResolver.java 901b95e 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestExpressionResolver.java 7f872e9 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java ed08605 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestQueryRewrite.java d16f6a5 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestRewriterPlan.java 0805fb5 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeExtractor.java 26836fe 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeResolver.java f2d7990 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeWriter.java 453a102 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeWriterWithQuery.java 0e22ce2 
>   lens-server-api/src/main/java/org/apache/lens/server/api/error/LensException.java 123b6ee 
>   lens-server/src/main/java/org/apache/lens/server/error/UnSupportedQuerySubmitOpException.java 4ab26ec 
>   lens-server/src/test/java/org/apache/lens/server/rewrite/TestRewriting.java 9628865 
> 
> Diff: https://reviews.apache.org/r/36850/diff/
> 
> 
> Testing
> -------
> 
> All unit tests are running fine.
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [18.289s]
> [INFO] Lens .............................................. SUCCESS [0.371s]
> [INFO] Lens API .......................................... SUCCESS [26.254s]
> [INFO] Lens API for server and extensions ................ SUCCESS [26.354s]
> [INFO] Lens Cube ......................................... SUCCESS [5:24.863s]
> [INFO] Lens DB storage ................................... SUCCESS [20.037s]
> [INFO] Lens Query Library ................................ SUCCESS [10.167s]
> [INFO] Lens Hive Driver .................................. SUCCESS [3:34.907s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [34.493s]
> [INFO] Lens Server ....................................... SUCCESS [19:37.403s]
> [INFO] Lens client ....................................... SUCCESS [55.363s]
> [INFO] Lens CLI .......................................... SUCCESS [4:31.293s]
> [INFO] Lens Examples ..................................... SUCCESS [7.305s]
> [INFO] Lens Distribution ................................. SUCCESS [2.314s]
> [INFO] Lens ML Lib ....................................... SUCCESS [13:28.783s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [13.554s]
> [INFO] Lens Regression ................................... SUCCESS [3.790s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 50:17.722s
> [INFO] Finished at: Mon Jul 27 21:05:04 IST 2015
> [INFO] Final Memory: 173M/1864M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Sushil Mohanty
> 
>

Re: Review Request 36850: Lens-187 : Move cube specific error message codes from InMobi's Hive code to Lens

Posted by Sushil Mohanty <su...@gmail.com>.


> On July 28, 2015, 6:19 a.m., Rajat Khandelwal wrote:
> > lens-cube/src/main/java/org/apache/lens/cube/parse/ContextRewriter.java, line 34
> > <https://reviews.apache.org/r/36850/diff/1/?file=1022465#file1022465line34>
> >
> >     I believe all the semantic exceptions should have been gone. If not, can you elaborate on why?
> 
> Rajat Khandelwal wrote:
>     Also, let's do a `git grep` and make sure they are not used anymore.

Classes which extends Hive SemanticAnalyzer will continue throwing SematicException.


> On July 28, 2015, 6:19 a.m., Rajat Khandelwal wrote:
> > lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryRewriter.java, line 197
> > <https://reviews.apache.org/r/36850/diff/1/?file=1022467#file1022467line197>
> >
> >     why hive exception?

Fixed to throw only LensExceotion.


> On July 28, 2015, 6:19 a.m., Rajat Khandelwal wrote:
> > lens-cube/src/main/java/org/apache/lens/cube/parse/JoinResolver.java, line 980
> > <https://reviews.apache.org/r/36850/diff/1/?file=1022478#file1022478line980>
> >
> >     is it throwing `HiveException` anymore?

No, chnaged accordingly.


- Sushil


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36850/#review93241
-----------------------------------------------------------


On Aug. 17, 2015, 9:19 a.m., Sushil Mohanty wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36850/
> -----------------------------------------------------------
> 
> (Updated Aug. 17, 2015, 9:19 a.m.)
> 
> 
> Review request for lens, Amareshwari Sriramadasu and Himanshu Gahlaut.
> 
> 
> Bugs: LENS-187
>     https://issues.apache.org/jira/browse/LENS-187
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> Moved all cube related error messages from (InMobi) Hive to Lens.
> 
> 
> Diffs
> -----
> 
>   lens-api/src/main/resources/lens-errors.conf e6715b6 
>   lens-cube/src/main/java/org/apache/lens/cube/error/LensCubeErrorCode.java 0006b22 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/AbridgedTimeRangeWriter.java d5276e0 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/AggregateResolver.java f880495 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/AliasReplacer.java 9309307 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/BetweenTimeRangeWriter.java 6c85c2d 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateFact.java 6c88fb3 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTableResolver.java 3e73d02 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CheckColumnMapping.java 59e4fd3 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CheckTableNames.java fce1a04 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/ColumnResolver.java 2ff5959 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/ContextRewriter.java feb26d7 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java d753e3f 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryRewriter.java 72dc64b 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CubeSemanticAnalyzer.java 68bffed 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/DateUtil.java 5c77548 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/DenormalizationResolver.java 517e8fc 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/DimHQLContext.java 3814cf6 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/DimOnlyHQLContext.java 922501d 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/ExpressionResolver.java 5bdb412 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/FactHQLContext.java 623c58b 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/FieldValidator.java 1a1232b 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/GroupbyResolver.java 4d2692b 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/HQLContextInterface.java 35011e8 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java 7b99310 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/JoinResolver.java a6e9340 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/LeastPartitionResolver.java 7f02ae8 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/LightestDimensionResolver.java 4ae6226 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/LightestFactResolver.java fba682d 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/MaxCoveringFactResolver.java 4d8cbf3 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/MultiFactHQLContext.java b5f5adc 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/SimpleHQLContext.java f3f3f78 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactHQLContext.java b63111b 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactMultiStorageHQLContext.java 4ad2f1f 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java aa76c0c 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/TimeRange.java 03732cb 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/TimeRangeWriter.java 12acf98 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/TimerangeResolver.java 91c0c75 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/UnionHQLContext.java e6ed86b 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/ValidationRule.java 9567845 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java ae8984f 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/FieldsCannotBeQueriedTogetherTest.java 501a4b0 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestAggregateResolver.java 13058e2 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java 0d0b927 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java fb8f61a 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestDateUtil.java 6717b5b 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestDenormalizationResolver.java 1bf1a5c 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestExpressionResolver.java 7f872e9 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java ed08605 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestQueryRewrite.java d16f6a5 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestRewriterPlan.java 0805fb5 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeExtractor.java 26836fe 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeResolver.java a30a114 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeWriter.java 453a102 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeWriterWithQuery.java 8da740b 
>   lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java 9222d87 
>   lens-server-api/src/main/java/org/apache/lens/server/api/error/LensException.java 123b6ee 
>   lens-server/src/main/java/org/apache/lens/server/error/UnSupportedQuerySubmitOpException.java 4ab26ec 
>   lens-server/src/main/java/org/apache/lens/server/rewrite/RewriteUtil.java 5844010 
>   lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 131f008 
>   lens-server/src/test/java/org/apache/lens/server/rewrite/TestRewriting.java affefe1 
> 
> Diff: https://reviews.apache.org/r/36850/diff/
> 
> 
> Testing
> -------
> 
> All unit tests are running fine.
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [18.289s]
> [INFO] Lens .............................................. SUCCESS [0.371s]
> [INFO] Lens API .......................................... SUCCESS [26.254s]
> [INFO] Lens API for server and extensions ................ SUCCESS [26.354s]
> [INFO] Lens Cube ......................................... SUCCESS [5:24.863s]
> [INFO] Lens DB storage ................................... SUCCESS [20.037s]
> [INFO] Lens Query Library ................................ SUCCESS [10.167s]
> [INFO] Lens Hive Driver .................................. SUCCESS [3:34.907s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [34.493s]
> [INFO] Lens Server ....................................... SUCCESS [19:37.403s]
> [INFO] Lens client ....................................... SUCCESS [55.363s]
> [INFO] Lens CLI .......................................... SUCCESS [4:31.293s]
> [INFO] Lens Examples ..................................... SUCCESS [7.305s]
> [INFO] Lens Distribution ................................. SUCCESS [2.314s]
> [INFO] Lens ML Lib ....................................... SUCCESS [13:28.783s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [13.554s]
> [INFO] Lens Regression ................................... SUCCESS [3.790s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 50:17.722s
> [INFO] Finished at: Mon Jul 27 21:05:04 IST 2015
> [INFO] Final Memory: 173M/1864M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Sushil Mohanty
> 
>

Re: Review Request 36850: Lens-187 : Move cube specific error message codes from InMobi's Hive code to Lens

Posted by Himanshu Gahlaut <ga...@gmail.com>.


> On July 28, 2015, 6:19 a.m., Rajat Khandelwal wrote:
> > lens-cube/src/main/java/org/apache/lens/cube/parse/JoinResolver.java, line 851
> > <https://reviews.apache.org/r/36850/diff/1/?file=1022478#file1022478line851>
> >
> >     I believe it would be more explicit if we make sub classes of LensException just like 
> >     
> >     ```
> >     public class FieldsCannotBeQueriedTogetherException extends LensException {
> >     ```
> >     
> >     Then the javadoc of most of the methods would become clear. The `@throws` field can be explicit as to why it throws an exception.

Just be careful that subclassing should not result in one exception sub class per error code. Otherwise it might become unmaintainable. A subclass is only required if getFormattedErrorMessage is complex (e.g. created using some logic on error payload) OR a error payload has to be transferred. The problem of enhanced documentation can be solved with @throws LensException with {@link org.apache.lens.cube.error.LensCubeErrorCode.NO_JOIN_PATH}


- Himanshu


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36850/#review93241
-----------------------------------------------------------


On July 27, 2015, 3:54 p.m., Sushil Mohanty wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36850/
> -----------------------------------------------------------
> 
> (Updated July 27, 2015, 3:54 p.m.)
> 
> 
> Review request for lens, Amareshwari Sriramadasu and Himanshu Gahlaut.
> 
> 
> Bugs: LENS-187
>     https://issues.apache.org/jira/browse/LENS-187
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> Moved all cube related error messages from (InMobi) Hive to Lens.
> 
> 
> Diffs
> -----
> 
>   lens-api/src/main/resources/lens-errors.conf 6130ad7 
>   lens-cube/src/main/java/org/apache/lens/cube/error/LensCubeErrorCode.java 0006b22 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/AbridgedTimeRangeWriter.java d5276e0 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/AggregateResolver.java f880495 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/AliasReplacer.java 9309307 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/BetweenTimeRangeWriter.java 6c85c2d 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateFact.java 6c88fb3 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTableResolver.java 50a4d53 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/ColumnResolver.java 2ff5959 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/ContextRewriter.java feb26d7 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java 65c240a 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryRewriter.java 72dc64b 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CubeSemanticAnalyzer.java 68bffed 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/DateUtil.java 9e295d3 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/DenormalizationResolver.java 4a95d5a 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/DimHQLContext.java 3814cf6 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/DimOnlyHQLContext.java 922501d 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/ExpressionResolver.java 895cb06 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/FactHQLContext.java 623c58b 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/FieldValidator.java 03377dd 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/HQLContextInterface.java 35011e8 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java 7b99310 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/JoinResolver.java 7d04d19 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/MultiFactHQLContext.java b5f5adc 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/SimpleHQLContext.java f3f3f78 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactHQLContext.java b63111b 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactMultiStorageHQLContext.java 4ad2f1f 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java 7bfbd86 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/TimeRange.java 03732cb 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/TimeRangeWriter.java 12acf98 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/TimerangeResolver.java 820d77d 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/UnionHQLContext.java e6ed86b 
>   lens-cube/src/test/java/org/apache/lens/cube/metadata/timeline/TestPartitionTimelines.java 0268bbf 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java e0338f5 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/FieldsCannotBeQueriedTogetherTest.java 501a4b0 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestAggregateResolver.java 13058e2 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java f65bd28 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java e04d04c 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestDateUtil.java 6717b5b 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestDenormalizationResolver.java 901b95e 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestExpressionResolver.java 7f872e9 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java ed08605 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestQueryRewrite.java d16f6a5 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestRewriterPlan.java 0805fb5 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeExtractor.java 26836fe 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeResolver.java f2d7990 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeWriter.java 453a102 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeWriterWithQuery.java 0e22ce2 
>   lens-server-api/src/main/java/org/apache/lens/server/api/error/LensException.java 123b6ee 
>   lens-server/src/main/java/org/apache/lens/server/error/UnSupportedQuerySubmitOpException.java 4ab26ec 
>   lens-server/src/test/java/org/apache/lens/server/rewrite/TestRewriting.java 9628865 
> 
> Diff: https://reviews.apache.org/r/36850/diff/
> 
> 
> Testing
> -------
> 
> All unit tests are running fine.
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [18.289s]
> [INFO] Lens .............................................. SUCCESS [0.371s]
> [INFO] Lens API .......................................... SUCCESS [26.254s]
> [INFO] Lens API for server and extensions ................ SUCCESS [26.354s]
> [INFO] Lens Cube ......................................... SUCCESS [5:24.863s]
> [INFO] Lens DB storage ................................... SUCCESS [20.037s]
> [INFO] Lens Query Library ................................ SUCCESS [10.167s]
> [INFO] Lens Hive Driver .................................. SUCCESS [3:34.907s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [34.493s]
> [INFO] Lens Server ....................................... SUCCESS [19:37.403s]
> [INFO] Lens client ....................................... SUCCESS [55.363s]
> [INFO] Lens CLI .......................................... SUCCESS [4:31.293s]
> [INFO] Lens Examples ..................................... SUCCESS [7.305s]
> [INFO] Lens Distribution ................................. SUCCESS [2.314s]
> [INFO] Lens ML Lib ....................................... SUCCESS [13:28.783s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [13.554s]
> [INFO] Lens Regression ................................... SUCCESS [3.790s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 50:17.722s
> [INFO] Finished at: Mon Jul 27 21:05:04 IST 2015
> [INFO] Final Memory: 173M/1864M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Sushil Mohanty
> 
>

Re: Review Request 36850: Lens-187 : Move cube specific error message codes from InMobi's Hive code to Lens

Posted by Rajat Khandelwal <ra...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36850/#review93241
-----------------------------------------------------------



lens-cube/src/main/java/org/apache/lens/cube/parse/ContextRewriter.java (line 34)
<https://reviews.apache.org/r/36850/#comment147565>

    I believe all the semantic exceptions should have been gone. If not, can you elaborate on why?



lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryRewriter.java (line 197)
<https://reviews.apache.org/r/36850/#comment147566>

    why hive exception?



lens-cube/src/main/java/org/apache/lens/cube/parse/CubeSemanticAnalyzer.java (line 75)
<https://reviews.apache.org/r/36850/#comment147567>

    Why are we throwing SemanticException now? I think letting `e` propagate should be good now.



lens-cube/src/main/java/org/apache/lens/cube/parse/ExpressionResolver.java 
<https://reviews.apache.org/r/36850/#comment147568>

    Shoule we wrap it with `LensException` now? Or having `HiveException` propagate is a better idea?



lens-cube/src/main/java/org/apache/lens/cube/parse/FieldValidator.java (line 43)
<https://reviews.apache.org/r/36850/#comment147569>

    `FieldsCannotBeQueriedTogetherException` extends `LensException`



lens-cube/src/main/java/org/apache/lens/cube/parse/FieldValidator.java (line 47)
<https://reviews.apache.org/r/36850/#comment147570>

    Same as above.



lens-cube/src/main/java/org/apache/lens/cube/parse/JoinResolver.java (line 850)
<https://reviews.apache.org/r/36850/#comment147571>

    I believe it would be more explicit if we make sub classes of LensException just like 
    
    ```
    public class FieldsCannotBeQueriedTogetherException extends LensException {
    ```
    
    Then the javadoc of most of the methods would become clear. The `@throws` field can be explicit as to why it throws an exception.



lens-cube/src/main/java/org/apache/lens/cube/parse/JoinResolver.java (line 973)
<https://reviews.apache.org/r/36850/#comment147572>

    is it throwing `HiveException` anymore?



lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java (line 735)
<https://reviews.apache.org/r/36850/#comment147573>

    Can you re-evaluate whether all are required?



lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java (line 894)
<https://reviews.apache.org/r/36850/#comment147574>

    `HiveException` anymore?



lens-cube/src/test/java/org/apache/lens/cube/parse/FieldsCannotBeQueriedTogetherTest.java (line 342)
<https://reviews.apache.org/r/36850/#comment147576>

    All the methods of this class, do they throw `HiveException` anymore? If yes, was it getting wrapped with `SemanticException` earlier? If yes, can we wrap it with `LensException` now since it feels to me that `LensException` is replacing `SemanticException` in our codebase. 
    
    Then `HiveException` should not be thrown anymore



lens-cube/src/test/java/org/apache/lens/cube/parse/TestAggregateResolver.java (line 269)
<https://reviews.apache.org/r/36850/#comment147577>

    please re-evaluate the `throws` clauses, as mentioned in earlier comments.



lens-cube/src/test/java/org/apache/lens/cube/parse/TestDenormalizationResolver.java (line 152)
<https://reviews.apache.org/r/36850/#comment147579>

    rename the function `getSemanticExceptionInRewrite` to `getLensExceptionInRewrite` or something.



lens-cube/src/test/java/org/apache/lens/cube/parse/TestDenormalizationResolver.java (line 282)
<https://reviews.apache.org/r/36850/#comment147578>

    Rename the function `getSemanticExceptionErrorMessageInRewrite` to not include the `SemanticException` substring anymore.


- Rajat Khandelwal


On July 27, 2015, 9:24 p.m., Sushil Mohanty wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36850/
> -----------------------------------------------------------
> 
> (Updated July 27, 2015, 9:24 p.m.)
> 
> 
> Review request for lens, Amareshwari Sriramadasu and Himanshu Gahlaut.
> 
> 
> Bugs: LENS-187
>     https://issues.apache.org/jira/browse/LENS-187
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> Moved all cube related error messages from (InMobi) Hive to Lens.
> 
> 
> Diffs
> -----
> 
>   lens-api/src/main/resources/lens-errors.conf 6130ad7 
>   lens-cube/src/main/java/org/apache/lens/cube/error/LensCubeErrorCode.java 0006b22 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/AbridgedTimeRangeWriter.java d5276e0 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/AggregateResolver.java f880495 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/AliasReplacer.java 9309307 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/BetweenTimeRangeWriter.java 6c85c2d 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateFact.java 6c88fb3 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTableResolver.java 50a4d53 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/ColumnResolver.java 2ff5959 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/ContextRewriter.java feb26d7 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java 65c240a 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryRewriter.java 72dc64b 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CubeSemanticAnalyzer.java 68bffed 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/DateUtil.java 9e295d3 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/DenormalizationResolver.java 4a95d5a 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/DimHQLContext.java 3814cf6 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/DimOnlyHQLContext.java 922501d 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/ExpressionResolver.java 895cb06 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/FactHQLContext.java 623c58b 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/FieldValidator.java 03377dd 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/HQLContextInterface.java 35011e8 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java 7b99310 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/JoinResolver.java 7d04d19 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/MultiFactHQLContext.java b5f5adc 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/SimpleHQLContext.java f3f3f78 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactHQLContext.java b63111b 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactMultiStorageHQLContext.java 4ad2f1f 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java 7bfbd86 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/TimeRange.java 03732cb 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/TimeRangeWriter.java 12acf98 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/TimerangeResolver.java 820d77d 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/UnionHQLContext.java e6ed86b 
>   lens-cube/src/test/java/org/apache/lens/cube/metadata/timeline/TestPartitionTimelines.java 0268bbf 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java e0338f5 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/FieldsCannotBeQueriedTogetherTest.java 501a4b0 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestAggregateResolver.java 13058e2 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java f65bd28 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java e04d04c 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestDateUtil.java 6717b5b 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestDenormalizationResolver.java 901b95e 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestExpressionResolver.java 7f872e9 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java ed08605 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestQueryRewrite.java d16f6a5 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestRewriterPlan.java 0805fb5 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeExtractor.java 26836fe 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeResolver.java f2d7990 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeWriter.java 453a102 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeWriterWithQuery.java 0e22ce2 
>   lens-server-api/src/main/java/org/apache/lens/server/api/error/LensException.java 123b6ee 
>   lens-server/src/main/java/org/apache/lens/server/error/UnSupportedQuerySubmitOpException.java 4ab26ec 
>   lens-server/src/test/java/org/apache/lens/server/rewrite/TestRewriting.java 9628865 
> 
> Diff: https://reviews.apache.org/r/36850/diff/
> 
> 
> Testing
> -------
> 
> All unit tests are running fine.
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [18.289s]
> [INFO] Lens .............................................. SUCCESS [0.371s]
> [INFO] Lens API .......................................... SUCCESS [26.254s]
> [INFO] Lens API for server and extensions ................ SUCCESS [26.354s]
> [INFO] Lens Cube ......................................... SUCCESS [5:24.863s]
> [INFO] Lens DB storage ................................... SUCCESS [20.037s]
> [INFO] Lens Query Library ................................ SUCCESS [10.167s]
> [INFO] Lens Hive Driver .................................. SUCCESS [3:34.907s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [34.493s]
> [INFO] Lens Server ....................................... SUCCESS [19:37.403s]
> [INFO] Lens client ....................................... SUCCESS [55.363s]
> [INFO] Lens CLI .......................................... SUCCESS [4:31.293s]
> [INFO] Lens Examples ..................................... SUCCESS [7.305s]
> [INFO] Lens Distribution ................................. SUCCESS [2.314s]
> [INFO] Lens ML Lib ....................................... SUCCESS [13:28.783s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [13.554s]
> [INFO] Lens Regression ................................... SUCCESS [3.790s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 50:17.722s
> [INFO] Finished at: Mon Jul 27 21:05:04 IST 2015
> [INFO] Final Memory: 173M/1864M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Sushil Mohanty
> 
>

Re: Review Request 36850: Lens-187 : Move cube specific error message codes from InMobi's Hive code to Lens

Posted by Amareshwari Sriramadasu <am...@apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36850/#review95816
-----------------------------------------------------------

Ship it!


Ship It!

- Amareshwari Sriramadasu


On Aug. 18, 2015, 9:18 a.m., Sushil Mohanty wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36850/
> -----------------------------------------------------------
> 
> (Updated Aug. 18, 2015, 9:18 a.m.)
> 
> 
> Review request for lens, Amareshwari Sriramadasu and Himanshu Gahlaut.
> 
> 
> Bugs: LENS-187
>     https://issues.apache.org/jira/browse/LENS-187
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> Moved all cube related error messages from (InMobi) Hive to Lens.
> 
> 
> Diffs
> -----
> 
>   lens-api/src/main/resources/lens-errors.conf e6715b6 
>   lens-cube/src/main/java/org/apache/lens/cube/error/LensCubeErrorCode.java 0006b22 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/AbridgedTimeRangeWriter.java d5276e0 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/AggregateResolver.java f880495 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/AliasReplacer.java 9309307 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/BetweenTimeRangeWriter.java 6c85c2d 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateFact.java 6c88fb3 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTableResolver.java 3e73d02 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CheckColumnMapping.java 59e4fd3 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CheckTableNames.java fce1a04 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/ColumnResolver.java 2ff5959 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/ContextRewriter.java feb26d7 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java d753e3f 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryRewriter.java 72dc64b 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CubeSemanticAnalyzer.java 68bffed 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/DateUtil.java 5c77548 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/DenormalizationResolver.java 517e8fc 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/DimHQLContext.java 3814cf6 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/DimOnlyHQLContext.java 922501d 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/ExpressionResolver.java 5bdb412 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/FactHQLContext.java 623c58b 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/FieldValidator.java 1a1232b 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/GroupbyResolver.java 4d2692b 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/HQLContextInterface.java 35011e8 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java 7b99310 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/JoinResolver.java a6e9340 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/LeastPartitionResolver.java 7f02ae8 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/LightestDimensionResolver.java 4ae6226 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/LightestFactResolver.java fba682d 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/MaxCoveringFactResolver.java 4d8cbf3 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/MultiFactHQLContext.java b5f5adc 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/SimpleHQLContext.java f3f3f78 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactHQLContext.java b63111b 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactMultiStorageHQLContext.java 4ad2f1f 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java aa76c0c 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/TimeRange.java 03732cb 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/TimeRangeWriter.java 12acf98 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/TimerangeResolver.java 91c0c75 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/UnionHQLContext.java e6ed86b 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/ValidationRule.java 9567845 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java ae8984f 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/FieldsCannotBeQueriedTogetherTest.java 501a4b0 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestAggregateResolver.java 13058e2 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java 0d0b927 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java fb8f61a 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestDateUtil.java 6717b5b 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestDenormalizationResolver.java 1bf1a5c 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestExpressionResolver.java 7f872e9 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java ed08605 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestQueryRewrite.java d16f6a5 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestRewriterPlan.java 0805fb5 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeExtractor.java 26836fe 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeResolver.java a30a114 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeWriter.java 453a102 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeWriterWithQuery.java 8da740b 
>   lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java 9222d87 
>   lens-server-api/src/main/java/org/apache/lens/server/api/error/LensException.java 123b6ee 
>   lens-server/src/main/java/org/apache/lens/server/error/UnSupportedQuerySubmitOpException.java 4ab26ec 
>   lens-server/src/main/java/org/apache/lens/server/rewrite/RewriteUtil.java 5844010 
>   lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 131f008 
>   lens-server/src/test/java/org/apache/lens/server/rewrite/TestRewriting.java affefe1 
> 
> Diff: https://reviews.apache.org/r/36850/diff/
> 
> 
> Testing
> -------
> 
> All unit tests are running fine.
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [18.289s]
> [INFO] Lens .............................................. SUCCESS [0.371s]
> [INFO] Lens API .......................................... SUCCESS [26.254s]
> [INFO] Lens API for server and extensions ................ SUCCESS [26.354s]
> [INFO] Lens Cube ......................................... SUCCESS [5:24.863s]
> [INFO] Lens DB storage ................................... SUCCESS [20.037s]
> [INFO] Lens Query Library ................................ SUCCESS [10.167s]
> [INFO] Lens Hive Driver .................................. SUCCESS [3:34.907s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [34.493s]
> [INFO] Lens Server ....................................... SUCCESS [19:37.403s]
> [INFO] Lens client ....................................... SUCCESS [55.363s]
> [INFO] Lens CLI .......................................... SUCCESS [4:31.293s]
> [INFO] Lens Examples ..................................... SUCCESS [7.305s]
> [INFO] Lens Distribution ................................. SUCCESS [2.314s]
> [INFO] Lens ML Lib ....................................... SUCCESS [13:28.783s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [13.554s]
> [INFO] Lens Regression ................................... SUCCESS [3.790s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 50:17.722s
> [INFO] Finished at: Mon Jul 27 21:05:04 IST 2015
> [INFO] Final Memory: 173M/1864M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Sushil Mohanty
> 
>

Re: Review Request 36850: Lens-187 : Move cube specific error message codes from InMobi's Hive code to Lens

Posted by Sushil Mohanty <su...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36850/
-----------------------------------------------------------

(Updated Aug. 18, 2015, 9:18 a.m.)


Review request for lens, Amareshwari Sriramadasu and Himanshu Gahlaut.


Changes
-------

Addressed review comment.


Bugs: LENS-187
    https://issues.apache.org/jira/browse/LENS-187


Repository: lens


Description
-------

Moved all cube related error messages from (InMobi) Hive to Lens.


Diffs (updated)
-----

  lens-api/src/main/resources/lens-errors.conf e6715b6 
  lens-cube/src/main/java/org/apache/lens/cube/error/LensCubeErrorCode.java 0006b22 
  lens-cube/src/main/java/org/apache/lens/cube/parse/AbridgedTimeRangeWriter.java d5276e0 
  lens-cube/src/main/java/org/apache/lens/cube/parse/AggregateResolver.java f880495 
  lens-cube/src/main/java/org/apache/lens/cube/parse/AliasReplacer.java 9309307 
  lens-cube/src/main/java/org/apache/lens/cube/parse/BetweenTimeRangeWriter.java 6c85c2d 
  lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateFact.java 6c88fb3 
  lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTableResolver.java 3e73d02 
  lens-cube/src/main/java/org/apache/lens/cube/parse/CheckColumnMapping.java 59e4fd3 
  lens-cube/src/main/java/org/apache/lens/cube/parse/CheckTableNames.java fce1a04 
  lens-cube/src/main/java/org/apache/lens/cube/parse/ColumnResolver.java 2ff5959 
  lens-cube/src/main/java/org/apache/lens/cube/parse/ContextRewriter.java feb26d7 
  lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java d753e3f 
  lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryRewriter.java 72dc64b 
  lens-cube/src/main/java/org/apache/lens/cube/parse/CubeSemanticAnalyzer.java 68bffed 
  lens-cube/src/main/java/org/apache/lens/cube/parse/DateUtil.java 5c77548 
  lens-cube/src/main/java/org/apache/lens/cube/parse/DenormalizationResolver.java 517e8fc 
  lens-cube/src/main/java/org/apache/lens/cube/parse/DimHQLContext.java 3814cf6 
  lens-cube/src/main/java/org/apache/lens/cube/parse/DimOnlyHQLContext.java 922501d 
  lens-cube/src/main/java/org/apache/lens/cube/parse/ExpressionResolver.java 5bdb412 
  lens-cube/src/main/java/org/apache/lens/cube/parse/FactHQLContext.java 623c58b 
  lens-cube/src/main/java/org/apache/lens/cube/parse/FieldValidator.java 1a1232b 
  lens-cube/src/main/java/org/apache/lens/cube/parse/GroupbyResolver.java 4d2692b 
  lens-cube/src/main/java/org/apache/lens/cube/parse/HQLContextInterface.java 35011e8 
  lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java 7b99310 
  lens-cube/src/main/java/org/apache/lens/cube/parse/JoinResolver.java a6e9340 
  lens-cube/src/main/java/org/apache/lens/cube/parse/LeastPartitionResolver.java 7f02ae8 
  lens-cube/src/main/java/org/apache/lens/cube/parse/LightestDimensionResolver.java 4ae6226 
  lens-cube/src/main/java/org/apache/lens/cube/parse/LightestFactResolver.java fba682d 
  lens-cube/src/main/java/org/apache/lens/cube/parse/MaxCoveringFactResolver.java 4d8cbf3 
  lens-cube/src/main/java/org/apache/lens/cube/parse/MultiFactHQLContext.java b5f5adc 
  lens-cube/src/main/java/org/apache/lens/cube/parse/SimpleHQLContext.java f3f3f78 
  lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactHQLContext.java b63111b 
  lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactMultiStorageHQLContext.java 4ad2f1f 
  lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java aa76c0c 
  lens-cube/src/main/java/org/apache/lens/cube/parse/TimeRange.java 03732cb 
  lens-cube/src/main/java/org/apache/lens/cube/parse/TimeRangeWriter.java 12acf98 
  lens-cube/src/main/java/org/apache/lens/cube/parse/TimerangeResolver.java 91c0c75 
  lens-cube/src/main/java/org/apache/lens/cube/parse/UnionHQLContext.java e6ed86b 
  lens-cube/src/main/java/org/apache/lens/cube/parse/ValidationRule.java 9567845 
  lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java ae8984f 
  lens-cube/src/test/java/org/apache/lens/cube/parse/FieldsCannotBeQueriedTogetherTest.java 501a4b0 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestAggregateResolver.java 13058e2 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java 0d0b927 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java fb8f61a 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestDateUtil.java 6717b5b 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestDenormalizationResolver.java 1bf1a5c 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestExpressionResolver.java 7f872e9 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java ed08605 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestQueryRewrite.java d16f6a5 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestRewriterPlan.java 0805fb5 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeExtractor.java 26836fe 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeResolver.java a30a114 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeWriter.java 453a102 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeWriterWithQuery.java 8da740b 
  lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java 9222d87 
  lens-server-api/src/main/java/org/apache/lens/server/api/error/LensException.java 123b6ee 
  lens-server/src/main/java/org/apache/lens/server/error/UnSupportedQuerySubmitOpException.java 4ab26ec 
  lens-server/src/main/java/org/apache/lens/server/rewrite/RewriteUtil.java 5844010 
  lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 131f008 
  lens-server/src/test/java/org/apache/lens/server/rewrite/TestRewriting.java affefe1 

Diff: https://reviews.apache.org/r/36850/diff/


Testing
-------

All unit tests are running fine.
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [18.289s]
[INFO] Lens .............................................. SUCCESS [0.371s]
[INFO] Lens API .......................................... SUCCESS [26.254s]
[INFO] Lens API for server and extensions ................ SUCCESS [26.354s]
[INFO] Lens Cube ......................................... SUCCESS [5:24.863s]
[INFO] Lens DB storage ................................... SUCCESS [20.037s]
[INFO] Lens Query Library ................................ SUCCESS [10.167s]
[INFO] Lens Hive Driver .................................. SUCCESS [3:34.907s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [34.493s]
[INFO] Lens Server ....................................... SUCCESS [19:37.403s]
[INFO] Lens client ....................................... SUCCESS [55.363s]
[INFO] Lens CLI .......................................... SUCCESS [4:31.293s]
[INFO] Lens Examples ..................................... SUCCESS [7.305s]
[INFO] Lens Distribution ................................. SUCCESS [2.314s]
[INFO] Lens ML Lib ....................................... SUCCESS [13:28.783s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [13.554s]
[INFO] Lens Regression ................................... SUCCESS [3.790s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 50:17.722s
[INFO] Finished at: Mon Jul 27 21:05:04 IST 2015
[INFO] Final Memory: 173M/1864M
[INFO] ------------------------------------------------------------------------


Thanks,

Sushil Mohanty

Re: Review Request 36850: Lens-187 : Move cube specific error message codes from InMobi's Hive code to Lens

Posted by Sushil Mohanty <su...@gmail.com>.


> On Aug. 18, 2015, 7:43 a.m., Rajat Khandelwal wrote:
> > lens-api/src/main/resources/lens-errors.conf, line 194
> > <https://reviews.apache.org/r/36850/diff/3/?file=1042874#file1042874line194>
> >
> >     3020?

The hole was due to one unused error code deleted. Will Fix it and upload the patch shortly.


- Sushil


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36850/#review95696
-----------------------------------------------------------


On Aug. 18, 2015, 7:01 a.m., Sushil Mohanty wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36850/
> -----------------------------------------------------------
> 
> (Updated Aug. 18, 2015, 7:01 a.m.)
> 
> 
> Review request for lens, Amareshwari Sriramadasu and Himanshu Gahlaut.
> 
> 
> Bugs: LENS-187
>     https://issues.apache.org/jira/browse/LENS-187
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> Moved all cube related error messages from (InMobi) Hive to Lens.
> 
> 
> Diffs
> -----
> 
>   lens-api/src/main/resources/lens-errors.conf e6715b6 
>   lens-cube/src/main/java/org/apache/lens/cube/error/LensCubeErrorCode.java 0006b22 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/AbridgedTimeRangeWriter.java d5276e0 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/AggregateResolver.java f880495 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/AliasReplacer.java 9309307 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/BetweenTimeRangeWriter.java 6c85c2d 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateFact.java 6c88fb3 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTableResolver.java 3e73d02 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CheckColumnMapping.java 59e4fd3 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CheckTableNames.java fce1a04 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/ColumnResolver.java 2ff5959 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/ContextRewriter.java feb26d7 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java d753e3f 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryRewriter.java 72dc64b 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CubeSemanticAnalyzer.java 68bffed 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/DateUtil.java 5c77548 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/DenormalizationResolver.java 517e8fc 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/DimHQLContext.java 3814cf6 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/DimOnlyHQLContext.java 922501d 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/ExpressionResolver.java 5bdb412 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/FactHQLContext.java 623c58b 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/FieldValidator.java 1a1232b 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/GroupbyResolver.java 4d2692b 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/HQLContextInterface.java 35011e8 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java 7b99310 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/JoinResolver.java a6e9340 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/LeastPartitionResolver.java 7f02ae8 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/LightestDimensionResolver.java 4ae6226 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/LightestFactResolver.java fba682d 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/MaxCoveringFactResolver.java 4d8cbf3 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/MultiFactHQLContext.java b5f5adc 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/SimpleHQLContext.java f3f3f78 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactHQLContext.java b63111b 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactMultiStorageHQLContext.java 4ad2f1f 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java aa76c0c 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/TimeRange.java 03732cb 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/TimeRangeWriter.java 12acf98 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/TimerangeResolver.java 91c0c75 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/UnionHQLContext.java e6ed86b 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/ValidationRule.java 9567845 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java ae8984f 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/FieldsCannotBeQueriedTogetherTest.java 501a4b0 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestAggregateResolver.java 13058e2 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java 0d0b927 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java fb8f61a 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestDateUtil.java 6717b5b 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestDenormalizationResolver.java 1bf1a5c 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestExpressionResolver.java 7f872e9 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java ed08605 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestQueryRewrite.java d16f6a5 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestRewriterPlan.java 0805fb5 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeExtractor.java 26836fe 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeResolver.java a30a114 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeWriter.java 453a102 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeWriterWithQuery.java 8da740b 
>   lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java 9222d87 
>   lens-server-api/src/main/java/org/apache/lens/server/api/error/LensException.java 123b6ee 
>   lens-server/src/main/java/org/apache/lens/server/error/UnSupportedQuerySubmitOpException.java 4ab26ec 
>   lens-server/src/main/java/org/apache/lens/server/rewrite/RewriteUtil.java 5844010 
>   lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 131f008 
>   lens-server/src/test/java/org/apache/lens/server/rewrite/TestRewriting.java affefe1 
> 
> Diff: https://reviews.apache.org/r/36850/diff/
> 
> 
> Testing
> -------
> 
> All unit tests are running fine.
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [18.289s]
> [INFO] Lens .............................................. SUCCESS [0.371s]
> [INFO] Lens API .......................................... SUCCESS [26.254s]
> [INFO] Lens API for server and extensions ................ SUCCESS [26.354s]
> [INFO] Lens Cube ......................................... SUCCESS [5:24.863s]
> [INFO] Lens DB storage ................................... SUCCESS [20.037s]
> [INFO] Lens Query Library ................................ SUCCESS [10.167s]
> [INFO] Lens Hive Driver .................................. SUCCESS [3:34.907s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [34.493s]
> [INFO] Lens Server ....................................... SUCCESS [19:37.403s]
> [INFO] Lens client ....................................... SUCCESS [55.363s]
> [INFO] Lens CLI .......................................... SUCCESS [4:31.293s]
> [INFO] Lens Examples ..................................... SUCCESS [7.305s]
> [INFO] Lens Distribution ................................. SUCCESS [2.314s]
> [INFO] Lens ML Lib ....................................... SUCCESS [13:28.783s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [13.554s]
> [INFO] Lens Regression ................................... SUCCESS [3.790s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 50:17.722s
> [INFO] Finished at: Mon Jul 27 21:05:04 IST 2015
> [INFO] Final Memory: 173M/1864M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Sushil Mohanty
> 
>

Re: Review Request 36850: Lens-187 : Move cube specific error message codes from InMobi's Hive code to Lens

Posted by Rajat Khandelwal <ra...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36850/#review95696
-----------------------------------------------------------



lens-api/src/main/resources/lens-errors.conf (line 194)
<https://reviews.apache.org/r/36850/#comment150794>

    3020?



lens-cube/src/main/java/org/apache/lens/cube/error/LensCubeErrorCode.java (line 42)
<https://reviews.apache.org/r/36850/#comment150795>

    The counter can be resumed from 3020.


- Rajat Khandelwal


On Aug. 18, 2015, 12:31 p.m., Sushil Mohanty wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36850/
> -----------------------------------------------------------
> 
> (Updated Aug. 18, 2015, 12:31 p.m.)
> 
> 
> Review request for lens, Amareshwari Sriramadasu and Himanshu Gahlaut.
> 
> 
> Bugs: LENS-187
>     https://issues.apache.org/jira/browse/LENS-187
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> Moved all cube related error messages from (InMobi) Hive to Lens.
> 
> 
> Diffs
> -----
> 
>   lens-api/src/main/resources/lens-errors.conf e6715b6 
>   lens-cube/src/main/java/org/apache/lens/cube/error/LensCubeErrorCode.java 0006b22 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/AbridgedTimeRangeWriter.java d5276e0 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/AggregateResolver.java f880495 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/AliasReplacer.java 9309307 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/BetweenTimeRangeWriter.java 6c85c2d 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateFact.java 6c88fb3 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTableResolver.java 3e73d02 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CheckColumnMapping.java 59e4fd3 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CheckTableNames.java fce1a04 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/ColumnResolver.java 2ff5959 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/ContextRewriter.java feb26d7 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java d753e3f 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryRewriter.java 72dc64b 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CubeSemanticAnalyzer.java 68bffed 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/DateUtil.java 5c77548 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/DenormalizationResolver.java 517e8fc 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/DimHQLContext.java 3814cf6 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/DimOnlyHQLContext.java 922501d 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/ExpressionResolver.java 5bdb412 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/FactHQLContext.java 623c58b 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/FieldValidator.java 1a1232b 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/GroupbyResolver.java 4d2692b 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/HQLContextInterface.java 35011e8 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java 7b99310 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/JoinResolver.java a6e9340 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/LeastPartitionResolver.java 7f02ae8 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/LightestDimensionResolver.java 4ae6226 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/LightestFactResolver.java fba682d 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/MaxCoveringFactResolver.java 4d8cbf3 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/MultiFactHQLContext.java b5f5adc 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/SimpleHQLContext.java f3f3f78 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactHQLContext.java b63111b 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactMultiStorageHQLContext.java 4ad2f1f 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java aa76c0c 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/TimeRange.java 03732cb 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/TimeRangeWriter.java 12acf98 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/TimerangeResolver.java 91c0c75 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/UnionHQLContext.java e6ed86b 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/ValidationRule.java 9567845 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java ae8984f 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/FieldsCannotBeQueriedTogetherTest.java 501a4b0 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestAggregateResolver.java 13058e2 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java 0d0b927 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java fb8f61a 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestDateUtil.java 6717b5b 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestDenormalizationResolver.java 1bf1a5c 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestExpressionResolver.java 7f872e9 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java ed08605 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestQueryRewrite.java d16f6a5 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestRewriterPlan.java 0805fb5 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeExtractor.java 26836fe 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeResolver.java a30a114 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeWriter.java 453a102 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeWriterWithQuery.java 8da740b 
>   lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java 9222d87 
>   lens-server-api/src/main/java/org/apache/lens/server/api/error/LensException.java 123b6ee 
>   lens-server/src/main/java/org/apache/lens/server/error/UnSupportedQuerySubmitOpException.java 4ab26ec 
>   lens-server/src/main/java/org/apache/lens/server/rewrite/RewriteUtil.java 5844010 
>   lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 131f008 
>   lens-server/src/test/java/org/apache/lens/server/rewrite/TestRewriting.java affefe1 
> 
> Diff: https://reviews.apache.org/r/36850/diff/
> 
> 
> Testing
> -------
> 
> All unit tests are running fine.
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [18.289s]
> [INFO] Lens .............................................. SUCCESS [0.371s]
> [INFO] Lens API .......................................... SUCCESS [26.254s]
> [INFO] Lens API for server and extensions ................ SUCCESS [26.354s]
> [INFO] Lens Cube ......................................... SUCCESS [5:24.863s]
> [INFO] Lens DB storage ................................... SUCCESS [20.037s]
> [INFO] Lens Query Library ................................ SUCCESS [10.167s]
> [INFO] Lens Hive Driver .................................. SUCCESS [3:34.907s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [34.493s]
> [INFO] Lens Server ....................................... SUCCESS [19:37.403s]
> [INFO] Lens client ....................................... SUCCESS [55.363s]
> [INFO] Lens CLI .......................................... SUCCESS [4:31.293s]
> [INFO] Lens Examples ..................................... SUCCESS [7.305s]
> [INFO] Lens Distribution ................................. SUCCESS [2.314s]
> [INFO] Lens ML Lib ....................................... SUCCESS [13:28.783s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [13.554s]
> [INFO] Lens Regression ................................... SUCCESS [3.790s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 50:17.722s
> [INFO] Finished at: Mon Jul 27 21:05:04 IST 2015
> [INFO] Final Memory: 173M/1864M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Sushil Mohanty
> 
>

Re: Review Request 36850: Lens-187 : Move cube specific error message codes from InMobi's Hive code to Lens

Posted by Sushil Mohanty <su...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36850/
-----------------------------------------------------------

(Updated Aug. 18, 2015, 7:01 a.m.)


Review request for lens, Amareshwari Sriramadasu and Himanshu Gahlaut.


Changes
-------

Addressed review comment.


Bugs: LENS-187
    https://issues.apache.org/jira/browse/LENS-187


Repository: lens


Description
-------

Moved all cube related error messages from (InMobi) Hive to Lens.


Diffs (updated)
-----

  lens-api/src/main/resources/lens-errors.conf e6715b6 
  lens-cube/src/main/java/org/apache/lens/cube/error/LensCubeErrorCode.java 0006b22 
  lens-cube/src/main/java/org/apache/lens/cube/parse/AbridgedTimeRangeWriter.java d5276e0 
  lens-cube/src/main/java/org/apache/lens/cube/parse/AggregateResolver.java f880495 
  lens-cube/src/main/java/org/apache/lens/cube/parse/AliasReplacer.java 9309307 
  lens-cube/src/main/java/org/apache/lens/cube/parse/BetweenTimeRangeWriter.java 6c85c2d 
  lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateFact.java 6c88fb3 
  lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTableResolver.java 3e73d02 
  lens-cube/src/main/java/org/apache/lens/cube/parse/CheckColumnMapping.java 59e4fd3 
  lens-cube/src/main/java/org/apache/lens/cube/parse/CheckTableNames.java fce1a04 
  lens-cube/src/main/java/org/apache/lens/cube/parse/ColumnResolver.java 2ff5959 
  lens-cube/src/main/java/org/apache/lens/cube/parse/ContextRewriter.java feb26d7 
  lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java d753e3f 
  lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryRewriter.java 72dc64b 
  lens-cube/src/main/java/org/apache/lens/cube/parse/CubeSemanticAnalyzer.java 68bffed 
  lens-cube/src/main/java/org/apache/lens/cube/parse/DateUtil.java 5c77548 
  lens-cube/src/main/java/org/apache/lens/cube/parse/DenormalizationResolver.java 517e8fc 
  lens-cube/src/main/java/org/apache/lens/cube/parse/DimHQLContext.java 3814cf6 
  lens-cube/src/main/java/org/apache/lens/cube/parse/DimOnlyHQLContext.java 922501d 
  lens-cube/src/main/java/org/apache/lens/cube/parse/ExpressionResolver.java 5bdb412 
  lens-cube/src/main/java/org/apache/lens/cube/parse/FactHQLContext.java 623c58b 
  lens-cube/src/main/java/org/apache/lens/cube/parse/FieldValidator.java 1a1232b 
  lens-cube/src/main/java/org/apache/lens/cube/parse/GroupbyResolver.java 4d2692b 
  lens-cube/src/main/java/org/apache/lens/cube/parse/HQLContextInterface.java 35011e8 
  lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java 7b99310 
  lens-cube/src/main/java/org/apache/lens/cube/parse/JoinResolver.java a6e9340 
  lens-cube/src/main/java/org/apache/lens/cube/parse/LeastPartitionResolver.java 7f02ae8 
  lens-cube/src/main/java/org/apache/lens/cube/parse/LightestDimensionResolver.java 4ae6226 
  lens-cube/src/main/java/org/apache/lens/cube/parse/LightestFactResolver.java fba682d 
  lens-cube/src/main/java/org/apache/lens/cube/parse/MaxCoveringFactResolver.java 4d8cbf3 
  lens-cube/src/main/java/org/apache/lens/cube/parse/MultiFactHQLContext.java b5f5adc 
  lens-cube/src/main/java/org/apache/lens/cube/parse/SimpleHQLContext.java f3f3f78 
  lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactHQLContext.java b63111b 
  lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactMultiStorageHQLContext.java 4ad2f1f 
  lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java aa76c0c 
  lens-cube/src/main/java/org/apache/lens/cube/parse/TimeRange.java 03732cb 
  lens-cube/src/main/java/org/apache/lens/cube/parse/TimeRangeWriter.java 12acf98 
  lens-cube/src/main/java/org/apache/lens/cube/parse/TimerangeResolver.java 91c0c75 
  lens-cube/src/main/java/org/apache/lens/cube/parse/UnionHQLContext.java e6ed86b 
  lens-cube/src/main/java/org/apache/lens/cube/parse/ValidationRule.java 9567845 
  lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java ae8984f 
  lens-cube/src/test/java/org/apache/lens/cube/parse/FieldsCannotBeQueriedTogetherTest.java 501a4b0 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestAggregateResolver.java 13058e2 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java 0d0b927 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java fb8f61a 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestDateUtil.java 6717b5b 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestDenormalizationResolver.java 1bf1a5c 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestExpressionResolver.java 7f872e9 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java ed08605 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestQueryRewrite.java d16f6a5 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestRewriterPlan.java 0805fb5 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeExtractor.java 26836fe 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeResolver.java a30a114 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeWriter.java 453a102 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeWriterWithQuery.java 8da740b 
  lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java 9222d87 
  lens-server-api/src/main/java/org/apache/lens/server/api/error/LensException.java 123b6ee 
  lens-server/src/main/java/org/apache/lens/server/error/UnSupportedQuerySubmitOpException.java 4ab26ec 
  lens-server/src/main/java/org/apache/lens/server/rewrite/RewriteUtil.java 5844010 
  lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 131f008 
  lens-server/src/test/java/org/apache/lens/server/rewrite/TestRewriting.java affefe1 

Diff: https://reviews.apache.org/r/36850/diff/


Testing
-------

All unit tests are running fine.
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [18.289s]
[INFO] Lens .............................................. SUCCESS [0.371s]
[INFO] Lens API .......................................... SUCCESS [26.254s]
[INFO] Lens API for server and extensions ................ SUCCESS [26.354s]
[INFO] Lens Cube ......................................... SUCCESS [5:24.863s]
[INFO] Lens DB storage ................................... SUCCESS [20.037s]
[INFO] Lens Query Library ................................ SUCCESS [10.167s]
[INFO] Lens Hive Driver .................................. SUCCESS [3:34.907s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [34.493s]
[INFO] Lens Server ....................................... SUCCESS [19:37.403s]
[INFO] Lens client ....................................... SUCCESS [55.363s]
[INFO] Lens CLI .......................................... SUCCESS [4:31.293s]
[INFO] Lens Examples ..................................... SUCCESS [7.305s]
[INFO] Lens Distribution ................................. SUCCESS [2.314s]
[INFO] Lens ML Lib ....................................... SUCCESS [13:28.783s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [13.554s]
[INFO] Lens Regression ................................... SUCCESS [3.790s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 50:17.722s
[INFO] Finished at: Mon Jul 27 21:05:04 IST 2015
[INFO] Final Memory: 173M/1864M
[INFO] ------------------------------------------------------------------------


Thanks,

Sushil Mohanty

Re: Review Request 36850: Lens-187 : Move cube specific error message codes from InMobi's Hive code to Lens

Posted by Amareshwari Sriramadasu <am...@apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36850/#review95580
-----------------------------------------------------------



lens-cube/src/main/java/org/apache/lens/cube/parse/DenormalizationResolver.java (line 254)
<https://reviews.apache.org/r/36850/#comment150605>

    Can we move the errors to new error codes and move message to errors.conf?


- Amareshwari Sriramadasu


On Aug. 17, 2015, 9:19 a.m., Sushil Mohanty wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36850/
> -----------------------------------------------------------
> 
> (Updated Aug. 17, 2015, 9:19 a.m.)
> 
> 
> Review request for lens, Amareshwari Sriramadasu and Himanshu Gahlaut.
> 
> 
> Bugs: LENS-187
>     https://issues.apache.org/jira/browse/LENS-187
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> Moved all cube related error messages from (InMobi) Hive to Lens.
> 
> 
> Diffs
> -----
> 
>   lens-api/src/main/resources/lens-errors.conf e6715b6 
>   lens-cube/src/main/java/org/apache/lens/cube/error/LensCubeErrorCode.java 0006b22 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/AbridgedTimeRangeWriter.java d5276e0 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/AggregateResolver.java f880495 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/AliasReplacer.java 9309307 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/BetweenTimeRangeWriter.java 6c85c2d 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateFact.java 6c88fb3 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTableResolver.java 3e73d02 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CheckColumnMapping.java 59e4fd3 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CheckTableNames.java fce1a04 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/ColumnResolver.java 2ff5959 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/ContextRewriter.java feb26d7 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java d753e3f 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryRewriter.java 72dc64b 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CubeSemanticAnalyzer.java 68bffed 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/DateUtil.java 5c77548 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/DenormalizationResolver.java 517e8fc 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/DimHQLContext.java 3814cf6 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/DimOnlyHQLContext.java 922501d 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/ExpressionResolver.java 5bdb412 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/FactHQLContext.java 623c58b 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/FieldValidator.java 1a1232b 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/GroupbyResolver.java 4d2692b 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/HQLContextInterface.java 35011e8 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java 7b99310 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/JoinResolver.java a6e9340 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/LeastPartitionResolver.java 7f02ae8 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/LightestDimensionResolver.java 4ae6226 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/LightestFactResolver.java fba682d 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/MaxCoveringFactResolver.java 4d8cbf3 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/MultiFactHQLContext.java b5f5adc 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/SimpleHQLContext.java f3f3f78 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactHQLContext.java b63111b 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactMultiStorageHQLContext.java 4ad2f1f 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java aa76c0c 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/TimeRange.java 03732cb 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/TimeRangeWriter.java 12acf98 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/TimerangeResolver.java 91c0c75 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/UnionHQLContext.java e6ed86b 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/ValidationRule.java 9567845 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java ae8984f 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/FieldsCannotBeQueriedTogetherTest.java 501a4b0 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestAggregateResolver.java 13058e2 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java 0d0b927 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java fb8f61a 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestDateUtil.java 6717b5b 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestDenormalizationResolver.java 1bf1a5c 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestExpressionResolver.java 7f872e9 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java ed08605 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestQueryRewrite.java d16f6a5 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestRewriterPlan.java 0805fb5 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeExtractor.java 26836fe 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeResolver.java a30a114 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeWriter.java 453a102 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeWriterWithQuery.java 8da740b 
>   lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java 9222d87 
>   lens-server-api/src/main/java/org/apache/lens/server/api/error/LensException.java 123b6ee 
>   lens-server/src/main/java/org/apache/lens/server/error/UnSupportedQuerySubmitOpException.java 4ab26ec 
>   lens-server/src/main/java/org/apache/lens/server/rewrite/RewriteUtil.java 5844010 
>   lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 131f008 
>   lens-server/src/test/java/org/apache/lens/server/rewrite/TestRewriting.java affefe1 
> 
> Diff: https://reviews.apache.org/r/36850/diff/
> 
> 
> Testing
> -------
> 
> All unit tests are running fine.
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [18.289s]
> [INFO] Lens .............................................. SUCCESS [0.371s]
> [INFO] Lens API .......................................... SUCCESS [26.254s]
> [INFO] Lens API for server and extensions ................ SUCCESS [26.354s]
> [INFO] Lens Cube ......................................... SUCCESS [5:24.863s]
> [INFO] Lens DB storage ................................... SUCCESS [20.037s]
> [INFO] Lens Query Library ................................ SUCCESS [10.167s]
> [INFO] Lens Hive Driver .................................. SUCCESS [3:34.907s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [34.493s]
> [INFO] Lens Server ....................................... SUCCESS [19:37.403s]
> [INFO] Lens client ....................................... SUCCESS [55.363s]
> [INFO] Lens CLI .......................................... SUCCESS [4:31.293s]
> [INFO] Lens Examples ..................................... SUCCESS [7.305s]
> [INFO] Lens Distribution ................................. SUCCESS [2.314s]
> [INFO] Lens ML Lib ....................................... SUCCESS [13:28.783s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [13.554s]
> [INFO] Lens Regression ................................... SUCCESS [3.790s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 50:17.722s
> [INFO] Finished at: Mon Jul 27 21:05:04 IST 2015
> [INFO] Final Memory: 173M/1864M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Sushil Mohanty
> 
>

Re: Review Request 36850: Lens-187 : Move cube specific error message codes from InMobi's Hive code to Lens

Posted by Sushil Mohanty <su...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36850/
-----------------------------------------------------------

(Updated Aug. 17, 2015, 9:19 a.m.)


Review request for lens, Amareshwari Sriramadasu and Himanshu Gahlaut.


Changes
-------

Addressed review comments. All unit tests are running fine.

[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [5.843s]
[INFO] Lens .............................................. SUCCESS [0.299s]
[INFO] Lens API .......................................... SUCCESS [15.869s]
[INFO] Lens API for server and extensions ................ SUCCESS [16.897s]
[INFO] Lens Cube ......................................... SUCCESS [6:12.475s]
[INFO] Lens DB storage ................................... SUCCESS [23.471s]
[INFO] Lens Query Library ................................ SUCCESS [12.325s]
[INFO] Lens Hive Driver .................................. SUCCESS [4:12.072s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [40.382s]
[INFO] Lens Elastic Search Driver ........................ SUCCESS [14.921s]
[INFO] Lens Server ....................................... SUCCESS [16:12.239s]
[INFO] Lens client ....................................... SUCCESS [42.450s]
[INFO] Lens CLI .......................................... SUCCESS [5:39.587s]
[INFO] Lens Examples ..................................... SUCCESS [4.132s]
[INFO] Lens Distribution ................................. SUCCESS [2.417s]
[INFO] Lens ML Lib ....................................... SUCCESS [2:48.248s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [7.737s]
[INFO] Lens Regression ................................... SUCCESS [5.011s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 38:17.427s
[INFO] Finished at: Mon Aug 17 14:44:55 IST 2015
[INFO] Final Memory: 169M/1778M
[INFO] ------------------------------------------------------------------------


Bugs: LENS-187
    https://issues.apache.org/jira/browse/LENS-187


Repository: lens


Description
-------

Moved all cube related error messages from (InMobi) Hive to Lens.


Diffs (updated)
-----

  lens-api/src/main/resources/lens-errors.conf e6715b6 
  lens-cube/src/main/java/org/apache/lens/cube/error/LensCubeErrorCode.java 0006b22 
  lens-cube/src/main/java/org/apache/lens/cube/parse/AbridgedTimeRangeWriter.java d5276e0 
  lens-cube/src/main/java/org/apache/lens/cube/parse/AggregateResolver.java f880495 
  lens-cube/src/main/java/org/apache/lens/cube/parse/AliasReplacer.java 9309307 
  lens-cube/src/main/java/org/apache/lens/cube/parse/BetweenTimeRangeWriter.java 6c85c2d 
  lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateFact.java 6c88fb3 
  lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTableResolver.java 3e73d02 
  lens-cube/src/main/java/org/apache/lens/cube/parse/CheckColumnMapping.java 59e4fd3 
  lens-cube/src/main/java/org/apache/lens/cube/parse/CheckTableNames.java fce1a04 
  lens-cube/src/main/java/org/apache/lens/cube/parse/ColumnResolver.java 2ff5959 
  lens-cube/src/main/java/org/apache/lens/cube/parse/ContextRewriter.java feb26d7 
  lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java d753e3f 
  lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryRewriter.java 72dc64b 
  lens-cube/src/main/java/org/apache/lens/cube/parse/CubeSemanticAnalyzer.java 68bffed 
  lens-cube/src/main/java/org/apache/lens/cube/parse/DateUtil.java 5c77548 
  lens-cube/src/main/java/org/apache/lens/cube/parse/DenormalizationResolver.java 517e8fc 
  lens-cube/src/main/java/org/apache/lens/cube/parse/DimHQLContext.java 3814cf6 
  lens-cube/src/main/java/org/apache/lens/cube/parse/DimOnlyHQLContext.java 922501d 
  lens-cube/src/main/java/org/apache/lens/cube/parse/ExpressionResolver.java 5bdb412 
  lens-cube/src/main/java/org/apache/lens/cube/parse/FactHQLContext.java 623c58b 
  lens-cube/src/main/java/org/apache/lens/cube/parse/FieldValidator.java 1a1232b 
  lens-cube/src/main/java/org/apache/lens/cube/parse/GroupbyResolver.java 4d2692b 
  lens-cube/src/main/java/org/apache/lens/cube/parse/HQLContextInterface.java 35011e8 
  lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java 7b99310 
  lens-cube/src/main/java/org/apache/lens/cube/parse/JoinResolver.java a6e9340 
  lens-cube/src/main/java/org/apache/lens/cube/parse/LeastPartitionResolver.java 7f02ae8 
  lens-cube/src/main/java/org/apache/lens/cube/parse/LightestDimensionResolver.java 4ae6226 
  lens-cube/src/main/java/org/apache/lens/cube/parse/LightestFactResolver.java fba682d 
  lens-cube/src/main/java/org/apache/lens/cube/parse/MaxCoveringFactResolver.java 4d8cbf3 
  lens-cube/src/main/java/org/apache/lens/cube/parse/MultiFactHQLContext.java b5f5adc 
  lens-cube/src/main/java/org/apache/lens/cube/parse/SimpleHQLContext.java f3f3f78 
  lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactHQLContext.java b63111b 
  lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactMultiStorageHQLContext.java 4ad2f1f 
  lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java aa76c0c 
  lens-cube/src/main/java/org/apache/lens/cube/parse/TimeRange.java 03732cb 
  lens-cube/src/main/java/org/apache/lens/cube/parse/TimeRangeWriter.java 12acf98 
  lens-cube/src/main/java/org/apache/lens/cube/parse/TimerangeResolver.java 91c0c75 
  lens-cube/src/main/java/org/apache/lens/cube/parse/UnionHQLContext.java e6ed86b 
  lens-cube/src/main/java/org/apache/lens/cube/parse/ValidationRule.java 9567845 
  lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java ae8984f 
  lens-cube/src/test/java/org/apache/lens/cube/parse/FieldsCannotBeQueriedTogetherTest.java 501a4b0 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestAggregateResolver.java 13058e2 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java 0d0b927 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java fb8f61a 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestDateUtil.java 6717b5b 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestDenormalizationResolver.java 1bf1a5c 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestExpressionResolver.java 7f872e9 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java ed08605 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestQueryRewrite.java d16f6a5 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestRewriterPlan.java 0805fb5 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeExtractor.java 26836fe 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeResolver.java a30a114 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeWriter.java 453a102 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeWriterWithQuery.java 8da740b 
  lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java 9222d87 
  lens-server-api/src/main/java/org/apache/lens/server/api/error/LensException.java 123b6ee 
  lens-server/src/main/java/org/apache/lens/server/error/UnSupportedQuerySubmitOpException.java 4ab26ec 
  lens-server/src/main/java/org/apache/lens/server/rewrite/RewriteUtil.java 5844010 
  lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 131f008 
  lens-server/src/test/java/org/apache/lens/server/rewrite/TestRewriting.java affefe1 

Diff: https://reviews.apache.org/r/36850/diff/


Testing
-------

All unit tests are running fine.
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [18.289s]
[INFO] Lens .............................................. SUCCESS [0.371s]
[INFO] Lens API .......................................... SUCCESS [26.254s]
[INFO] Lens API for server and extensions ................ SUCCESS [26.354s]
[INFO] Lens Cube ......................................... SUCCESS [5:24.863s]
[INFO] Lens DB storage ................................... SUCCESS [20.037s]
[INFO] Lens Query Library ................................ SUCCESS [10.167s]
[INFO] Lens Hive Driver .................................. SUCCESS [3:34.907s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [34.493s]
[INFO] Lens Server ....................................... SUCCESS [19:37.403s]
[INFO] Lens client ....................................... SUCCESS [55.363s]
[INFO] Lens CLI .......................................... SUCCESS [4:31.293s]
[INFO] Lens Examples ..................................... SUCCESS [7.305s]
[INFO] Lens Distribution ................................. SUCCESS [2.314s]
[INFO] Lens ML Lib ....................................... SUCCESS [13:28.783s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [13.554s]
[INFO] Lens Regression ................................... SUCCESS [3.790s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 50:17.722s
[INFO] Finished at: Mon Jul 27 21:05:04 IST 2015
[INFO] Final Memory: 173M/1864M
[INFO] ------------------------------------------------------------------------


Thanks,

Sushil Mohanty

Re: Review Request 36850: Lens-187 : Move cube specific error message codes from InMobi's Hive code to Lens

Posted by Sushil Mohanty <su...@gmail.com>.


> On July 28, 2015, 5:24 a.m., Amareshwari Sriramadasu wrote:
> > lens-cube/src/main/java/org/apache/lens/cube/error/LensCubeErrorCode.java, line 26
> > <https://reviews.apache.org/r/36850/diff/1/?file=1022457#file1022457line26>
> >
> >     Used any more? If not, can we remove?

Yes removed.


> On July 28, 2015, 5:24 a.m., Amareshwari Sriramadasu wrote:
> > lens-cube/src/main/java/org/apache/lens/cube/error/LensCubeErrorCode.java, line 42
> > <https://reviews.apache.org/r/36850/diff/1/?file=1022457#file1022457line42>
> >
> >     Used any more? If not, can we remove?

Yes removed.


> On July 28, 2015, 5:24 a.m., Amareshwari Sriramadasu wrote:
> > lens-cube/src/main/java/org/apache/lens/cube/parse/ContextRewriter.java, line 34
> > <https://reviews.apache.org/r/36850/diff/1/?file=1022465#file1022465line34>
> >
> >     Is the signature change for HiveException required?

Not required. Fixed it.


- Sushil


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36850/#review93237
-----------------------------------------------------------


On Aug. 17, 2015, 9:19 a.m., Sushil Mohanty wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36850/
> -----------------------------------------------------------
> 
> (Updated Aug. 17, 2015, 9:19 a.m.)
> 
> 
> Review request for lens, Amareshwari Sriramadasu and Himanshu Gahlaut.
> 
> 
> Bugs: LENS-187
>     https://issues.apache.org/jira/browse/LENS-187
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> Moved all cube related error messages from (InMobi) Hive to Lens.
> 
> 
> Diffs
> -----
> 
>   lens-api/src/main/resources/lens-errors.conf e6715b6 
>   lens-cube/src/main/java/org/apache/lens/cube/error/LensCubeErrorCode.java 0006b22 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/AbridgedTimeRangeWriter.java d5276e0 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/AggregateResolver.java f880495 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/AliasReplacer.java 9309307 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/BetweenTimeRangeWriter.java 6c85c2d 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateFact.java 6c88fb3 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTableResolver.java 3e73d02 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CheckColumnMapping.java 59e4fd3 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CheckTableNames.java fce1a04 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/ColumnResolver.java 2ff5959 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/ContextRewriter.java feb26d7 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java d753e3f 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryRewriter.java 72dc64b 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CubeSemanticAnalyzer.java 68bffed 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/DateUtil.java 5c77548 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/DenormalizationResolver.java 517e8fc 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/DimHQLContext.java 3814cf6 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/DimOnlyHQLContext.java 922501d 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/ExpressionResolver.java 5bdb412 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/FactHQLContext.java 623c58b 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/FieldValidator.java 1a1232b 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/GroupbyResolver.java 4d2692b 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/HQLContextInterface.java 35011e8 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java 7b99310 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/JoinResolver.java a6e9340 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/LeastPartitionResolver.java 7f02ae8 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/LightestDimensionResolver.java 4ae6226 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/LightestFactResolver.java fba682d 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/MaxCoveringFactResolver.java 4d8cbf3 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/MultiFactHQLContext.java b5f5adc 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/SimpleHQLContext.java f3f3f78 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactHQLContext.java b63111b 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactMultiStorageHQLContext.java 4ad2f1f 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java aa76c0c 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/TimeRange.java 03732cb 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/TimeRangeWriter.java 12acf98 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/TimerangeResolver.java 91c0c75 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/UnionHQLContext.java e6ed86b 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/ValidationRule.java 9567845 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java ae8984f 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/FieldsCannotBeQueriedTogetherTest.java 501a4b0 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestAggregateResolver.java 13058e2 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java 0d0b927 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java fb8f61a 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestDateUtil.java 6717b5b 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestDenormalizationResolver.java 1bf1a5c 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestExpressionResolver.java 7f872e9 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java ed08605 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestQueryRewrite.java d16f6a5 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestRewriterPlan.java 0805fb5 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeExtractor.java 26836fe 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeResolver.java a30a114 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeWriter.java 453a102 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeWriterWithQuery.java 8da740b 
>   lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java 9222d87 
>   lens-server-api/src/main/java/org/apache/lens/server/api/error/LensException.java 123b6ee 
>   lens-server/src/main/java/org/apache/lens/server/error/UnSupportedQuerySubmitOpException.java 4ab26ec 
>   lens-server/src/main/java/org/apache/lens/server/rewrite/RewriteUtil.java 5844010 
>   lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 131f008 
>   lens-server/src/test/java/org/apache/lens/server/rewrite/TestRewriting.java affefe1 
> 
> Diff: https://reviews.apache.org/r/36850/diff/
> 
> 
> Testing
> -------
> 
> All unit tests are running fine.
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [18.289s]
> [INFO] Lens .............................................. SUCCESS [0.371s]
> [INFO] Lens API .......................................... SUCCESS [26.254s]
> [INFO] Lens API for server and extensions ................ SUCCESS [26.354s]
> [INFO] Lens Cube ......................................... SUCCESS [5:24.863s]
> [INFO] Lens DB storage ................................... SUCCESS [20.037s]
> [INFO] Lens Query Library ................................ SUCCESS [10.167s]
> [INFO] Lens Hive Driver .................................. SUCCESS [3:34.907s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [34.493s]
> [INFO] Lens Server ....................................... SUCCESS [19:37.403s]
> [INFO] Lens client ....................................... SUCCESS [55.363s]
> [INFO] Lens CLI .......................................... SUCCESS [4:31.293s]
> [INFO] Lens Examples ..................................... SUCCESS [7.305s]
> [INFO] Lens Distribution ................................. SUCCESS [2.314s]
> [INFO] Lens ML Lib ....................................... SUCCESS [13:28.783s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [13.554s]
> [INFO] Lens Regression ................................... SUCCESS [3.790s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 50:17.722s
> [INFO] Finished at: Mon Jul 27 21:05:04 IST 2015
> [INFO] Final Memory: 173M/1864M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Sushil Mohanty
> 
>

Re: Review Request 36850: Lens-187 : Move cube specific error message codes from InMobi's Hive code to Lens

Posted by Amareshwari Sriramadasu <am...@apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36850/#review93237
-----------------------------------------------------------



lens-cube/src/main/java/org/apache/lens/cube/error/LensCubeErrorCode.java (line 26)
<https://reviews.apache.org/r/36850/#comment147563>

    Used any more? If not, can we remove?



lens-cube/src/main/java/org/apache/lens/cube/error/LensCubeErrorCode.java (line 42)
<https://reviews.apache.org/r/36850/#comment147564>

    Used any more? If not, can we remove?



lens-cube/src/main/java/org/apache/lens/cube/parse/ContextRewriter.java (line 34)
<https://reviews.apache.org/r/36850/#comment147560>

    Is the signature change for HiveException required?



lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryRewriter.java (line 189)
<https://reviews.apache.org/r/36850/#comment147561>

    Can we create LensException with cause HiveException - instead of signature change and handling HiveException later?



lens-cube/src/test/java/org/apache/lens/cube/metadata/timeline/TestPartitionTimelines.java (line 47)
<https://reviews.apache.org/r/36850/#comment147562>

    commented test?


- Amareshwari Sriramadasu


On July 27, 2015, 3:54 p.m., Sushil Mohanty wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36850/
> -----------------------------------------------------------
> 
> (Updated July 27, 2015, 3:54 p.m.)
> 
> 
> Review request for lens, Amareshwari Sriramadasu and Himanshu Gahlaut.
> 
> 
> Bugs: LENS-187
>     https://issues.apache.org/jira/browse/LENS-187
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> Moved all cube related error messages from (InMobi) Hive to Lens.
> 
> 
> Diffs
> -----
> 
>   lens-api/src/main/resources/lens-errors.conf 6130ad7 
>   lens-cube/src/main/java/org/apache/lens/cube/error/LensCubeErrorCode.java 0006b22 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/AbridgedTimeRangeWriter.java d5276e0 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/AggregateResolver.java f880495 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/AliasReplacer.java 9309307 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/BetweenTimeRangeWriter.java 6c85c2d 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateFact.java 6c88fb3 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTableResolver.java 50a4d53 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/ColumnResolver.java 2ff5959 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/ContextRewriter.java feb26d7 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java 65c240a 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryRewriter.java 72dc64b 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CubeSemanticAnalyzer.java 68bffed 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/DateUtil.java 9e295d3 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/DenormalizationResolver.java 4a95d5a 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/DimHQLContext.java 3814cf6 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/DimOnlyHQLContext.java 922501d 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/ExpressionResolver.java 895cb06 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/FactHQLContext.java 623c58b 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/FieldValidator.java 03377dd 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/HQLContextInterface.java 35011e8 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java 7b99310 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/JoinResolver.java 7d04d19 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/MultiFactHQLContext.java b5f5adc 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/SimpleHQLContext.java f3f3f78 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactHQLContext.java b63111b 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactMultiStorageHQLContext.java 4ad2f1f 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java 7bfbd86 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/TimeRange.java 03732cb 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/TimeRangeWriter.java 12acf98 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/TimerangeResolver.java 820d77d 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/UnionHQLContext.java e6ed86b 
>   lens-cube/src/test/java/org/apache/lens/cube/metadata/timeline/TestPartitionTimelines.java 0268bbf 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java e0338f5 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/FieldsCannotBeQueriedTogetherTest.java 501a4b0 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestAggregateResolver.java 13058e2 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java f65bd28 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java e04d04c 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestDateUtil.java 6717b5b 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestDenormalizationResolver.java 901b95e 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestExpressionResolver.java 7f872e9 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java ed08605 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestQueryRewrite.java d16f6a5 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestRewriterPlan.java 0805fb5 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeExtractor.java 26836fe 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeResolver.java f2d7990 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeWriter.java 453a102 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeWriterWithQuery.java 0e22ce2 
>   lens-server-api/src/main/java/org/apache/lens/server/api/error/LensException.java 123b6ee 
>   lens-server/src/main/java/org/apache/lens/server/error/UnSupportedQuerySubmitOpException.java 4ab26ec 
>   lens-server/src/test/java/org/apache/lens/server/rewrite/TestRewriting.java 9628865 
> 
> Diff: https://reviews.apache.org/r/36850/diff/
> 
> 
> Testing
> -------
> 
> All unit tests are running fine.
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [18.289s]
> [INFO] Lens .............................................. SUCCESS [0.371s]
> [INFO] Lens API .......................................... SUCCESS [26.254s]
> [INFO] Lens API for server and extensions ................ SUCCESS [26.354s]
> [INFO] Lens Cube ......................................... SUCCESS [5:24.863s]
> [INFO] Lens DB storage ................................... SUCCESS [20.037s]
> [INFO] Lens Query Library ................................ SUCCESS [10.167s]
> [INFO] Lens Hive Driver .................................. SUCCESS [3:34.907s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [34.493s]
> [INFO] Lens Server ....................................... SUCCESS [19:37.403s]
> [INFO] Lens client ....................................... SUCCESS [55.363s]
> [INFO] Lens CLI .......................................... SUCCESS [4:31.293s]
> [INFO] Lens Examples ..................................... SUCCESS [7.305s]
> [INFO] Lens Distribution ................................. SUCCESS [2.314s]
> [INFO] Lens ML Lib ....................................... SUCCESS [13:28.783s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [13.554s]
> [INFO] Lens Regression ................................... SUCCESS [3.790s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 50:17.722s
> [INFO] Finished at: Mon Jul 27 21:05:04 IST 2015
> [INFO] Final Memory: 173M/1864M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Sushil Mohanty
> 
>